From e03b6041d42fb9a0f10aac5617b81cfa7b178519 Mon Sep 17 00:00:00 2001
From: Sunil Mohan Adapa <sunil@medhas.org>
Date: Tue, 18 Aug 2020 20:02:23 -0700
Subject: [PATCH] bepasty: Minor fixes

Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: Joseph Nuthalapati <njoseph@riseup.net>
---
 actions/bepasty                               | 8 ++++----
 plinth/modules/bepasty/__init__.py            | 2 +-
 plinth/modules/bepasty/templates/bepasty.html | 3 ++-
 3 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/actions/bepasty b/actions/bepasty
index 88ccba531..1eed93e45 100755
--- a/actions/bepasty
+++ b/actions/bepasty
@@ -87,7 +87,7 @@ def subcommand_setup(arguments):
     except KeyError:
         subprocess.run(['addgroup', '--system', 'bepasty'], check=True)
 
-    # Create bepasty user is needed.
+    # Create bepasty user if needed.
     try:
         pwd.getpwnam('bepasty')
     except KeyError:
@@ -226,15 +226,15 @@ def subcommand_set_default(arguments):
 
 
 def _format_permissions(permissions=None):
-    """Format permissions as comma-separated"""
+    """Format permissions as comma-separated."""
     return ','.join(set(bepasty.PERMISSIONS.keys()).intersection(
         permissions)) if permissions else ''
 
 
 def _generate_password():
-    """Generate a random password"""
+    """Generate a random password."""
     alphabet = string.ascii_letters + string.digits
-    return ''.join(secrets.choice(alphabet) for i in range(PASSWORD_LENGTH))
+    return ''.join(secrets.choice(alphabet) for _ in range(PASSWORD_LENGTH))
 
 
 def main():
diff --git a/plinth/modules/bepasty/__init__.py b/plinth/modules/bepasty/__init__.py
index 6ec57203f..f446137b8 100644
--- a/plinth/modules/bepasty/__init__.py
+++ b/plinth/modules/bepasty/__init__.py
@@ -132,6 +132,6 @@ def get_default_permissions():
 
 
 def set_default_permissions(permissions):
-    """Set default permissions"""
+    """Set default permissions."""
     perm = permissions.split()
     actions.superuser_run('bepasty', ['set-default', '--permissions'] + perm)
diff --git a/plinth/modules/bepasty/templates/bepasty.html b/plinth/modules/bepasty/templates/bepasty.html
index 5f3fd9ffb..28cab6fff 100644
--- a/plinth/modules/bepasty/templates/bepasty.html
+++ b/plinth/modules/bepasty/templates/bepasty.html
@@ -22,7 +22,8 @@
   {% if not passwords %}
     <p>{% trans 'No passwords currently configured.' %}</p>
   {% else %}
-    <table class="table table-bordered table-condensed table-striped" id="passwords-list">
+    <table class="table table-bordered table-condensed table-striped"
+           id="passwords-list">
       <thead>
         <tr>
           <th>{% trans "Password" %}</th>