nik/FreedomBox
1
0
Fork 0
mirror of https://github.com/freedombox/FreedomBox.git synced 2026-03-11 09:04:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

setup: Ensure that force upgrade won't run when app is not installed

Browse Source 
- This keep the initial setup of the app simple and efficient. Setup will be
less prone to any issues in force upgrade code. There are also fewer chances for
immediate regressions.

Tests:

- Tested as part of the patch series.

Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
This commit is contained in:
Sunil Mohan Adapa 2024-02-14 15:47:41 -08:00 committed by James Valleroy
parent 56b58174b3
commit e208bdbbca
No known key found for this signature in database
GPG Key ID: 77C0C75E7B650808
1 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
plinth/setup.py
View File

@ -56,14 +56,15 @@ def _run_setup_on_app(app, current_version):
exception_to_update = None
message = None
try:
force_upgrader = ForceUpgrader.get_instance()
# Check if this app needs force_upgrade. If it is needed, but not yet
# supported for the new version of the package, then an exception will
# be raised, so that we do not run setup.
force_upgrader.attempt_upgrade_for_app(app.app_id)
current_version = app.get_setup_version()
if current_version != 0:
# Check if this app needs force_upgrade. If it is needed, but not
# yet supported for the new version of the package, then an
# exception will be raised, so that we do not run setup.
force_upgrader = ForceUpgrader.get_instance()
force_upgrader.attempt_upgrade_for_app(app.app_id)
app.setup(old_version=current_version)
app.set_setup_version(app.info.version)
post_setup.send_robust(sender=app.__class__, module_name=app.app_id)