From e302fdabaf52384f79f256e980c5618ed48a7223 Mon Sep 17 00:00:00 2001
From: Sunil Mohan Adapa <sunil@medhas.org>
Date: Wed, 13 Nov 2024 16:45:47 -0800
Subject: [PATCH] firewalld: Reduce severity for alert about service on
 internal zone

- When apps are available only on 'internal' zone, a warning message is shown on
the app's page. This is a routine warning that requires no action from the user.
It is quite annoying to see it on a page like Samba where it is even implied.
Hence reduce the severity of the alert to 'info' from 'warning'.

Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: Veiko Aasa <veiko17@disroot.org>
---
 plinth/templates/internal-zone.html | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/plinth/templates/internal-zone.html b/plinth/templates/internal-zone.html
index ee6a809bd..61f59bb0a 100644
--- a/plinth/templates/internal-zone.html
+++ b/plinth/templates/internal-zone.html
@@ -7,17 +7,22 @@
 {% block internal_zone_warning %}
   {% for component in firewall %}
     {% if not component.is_external %}
-      <div class="alert alert-warning" role="alert">
+      <div class="alert alert-info" role="alert">
         {% blocktrans trimmed with service_name=component.name %}
-          <em>{{ service_name }}</em> is available only on internal networks or when the client is connected to {{ box_name }} through VPN.
+          <em>{{ service_name }}</em> is available only on internal networks or
+          when the client is connected to {{ box_name }} through VPN.
         {% endblocktrans %}
         <p>
           {% with interfaces=component.get_internal_interfaces %}
             {% if not interfaces %}
-              {% trans "Currently there are no network interfaces configured as internal." %}
+              {% blocktrans trimmed %}
+                Currently there are no network interfaces configured as
+                internal.
+              {% endblocktrans %}
             {% else %}
               {% blocktrans trimmed with interface_list=interfaces|join:", " %}
-                Currently the following network interfaces are configured as internal: {{ interface_list }}
+                Currently the following network interfaces are configured as
+                internal: {{ interface_list }}
               {% endblocktrans %}
             {% endif %}
           {% endwith %}