nik/FreedomBox
1
0
Fork 0
mirror of https://github.com/freedombox/FreedomBox.git synced 2026-01-21 07:55:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

featherwiki: Don't allow index.html as a file name

Browse Source 
Tests:

- Creating/renaming/uploading wikis with names index[.html] does not work. Doing
so with other names work.

Signed-off-by: Joseph Nuthalapati <njoseph@riseup.net>
[sunil: Use validators= property instead of clean_name()]
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: Sunil Mohan Adapa <sunil@medhas.org>
This commit is contained in:
Joseph Nuthalapati 2025-07-02 12:25:42 +05:30 committed by Sunil Mohan Adapa
parent d89fcd74f1
commit e444b74e93
No known key found for this signature in database
GPG Key ID: 43EA1CFF0AA7C5F2
1 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
plinth/modules/featherwiki/forms.py
View File

@ -6,12 +6,19 @@ from django.core import validators
from django.utils.translation import gettext_lazy as _
def _validate_not_index_file(name):
"""Validate that the normalized file name is not 'index.html'."""
if str(name) in ('index.html', 'index'):
raise forms.ValidationError(
_('Wiki files cannot be named "index.html".'))
class CreateWikiForm(forms.Form):
"""Form to create a new wiki file."""
name = forms.CharField(
label=_('Name of the wiki file, with file extension ".html"'),
strip=True, help_text=_(
strip=True, validators=[_validate_not_index_file], help_text=_(
'Wiki title and description can be set from within the wiki. '
'This file name is independent of the wiki title.'))
@ -21,7 +28,7 @@ class RenameWikiForm(forms.Form):
new_name = forms.CharField(
label=_('New name for the wiki file, with file extension ".html"'),
strip=True, help_text=_(
strip=True, validators=[_validate_not_index_file], help_text=_(
'Renaming the file has no effect on the title of the wiki.'))
@ -32,6 +39,8 @@ class UploadWikiForm(forms.Form):
label=_('A Feather Wiki file with .html file extension'),
required=True, validators=[
validators.FileExtensionValidator(
['html'], _('Feather Wiki files must be in HTML format'))
['html'],
_('Feather Wiki files must be in HTML format'),
), _validate_not_index_file
], help_text=_(
'Upload an existing Feather Wiki file from this computer.'))