nik/FreedomBox
1
0
Fork 0
mirror of https://github.com/freedombox/FreedomBox.git synced 2026-04-29 10:10:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

syncthing: Completely uninstall app

Browse Source 
Remove config file when app is uninstalled

Tests:
1. Install app and add a share
2. Reinstall app and confirm that the share doesn't exist

The order of the functional tests should be modified
since 'test_add_remove_folder' fails

Signed-off-by: nbenedek <contact@nbenedek.me>
[sunil: Update docstrings, make uninstall fail-safe]
[sunil: Remove the entire configuration directory]
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: Sunil Mohan Adapa <sunil@medhas.org>
This commit is contained in:
nbenedek 2023-04-07 03:26:49 +02:00 committed by Sunil Mohan Adapa
parent 77318806c2
commit f1d2139c2d
No known key found for this signature in database
GPG Key ID: 43EA1CFF0AA7C5F2
2 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
plinth/modules/syncthing/__init__.py
View File

@ -143,3 +143,8 @@ class SyncthingApp(app_module.App):
sharing.remove_share(name) sharing.remove_share(name)
sharing.add_share(name, share['path'], new_groups, sharing.add_share(name, share['path'], new_groups,
share['is_public']) share['is_public'])
def uninstall(self):
"""De-configure and uninstall the app."""
super().uninstall()
privileged.uninstall()

7
plinth/modules/syncthing/privileged.py
View File

@ -3,6 +3,7 @@
import grp import grp
import os import os
import pathlib
import pwd import pwd
import shutil import shutil
import subprocess import subprocess
@ -80,3 +81,9 @@ def setup_config():
if conf_changed: if conf_changed:
action_utils.service_try_restart('syncthing@syncthing') action_utils.service_try_restart('syncthing@syncthing')
@privileged
def uninstall():
"""Remove configuration file when app is uninstalled."""
shutil.rmtree(DATA_DIR + '/.config', ignore_errors=True)