- Some changes in the 'New' menu and a new introduction animation broke the
functional tests. Fix this by updating the way elements are searched for in the
interface.
Tests:
- Functional tests for Nextcloud pass.
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
Tests:
- Functional tests run much more reliably. Although there were several failures
still observed due to following reasons:
- Due to FreedomBox service receiving SIGSEGV (presumably during NM DBus
operations).
- Error something like Invalid UTF-8: setting not known during removal of
a client.
- Unknown failures caused by newly added clients not showing up on the page.
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
- This does not effect the existing flow much but is a problem when waiting for
the public key to show up in list of peers.
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
- When no domains are configured, and .local domain is filtered out, an
exception is thrown by the auto-add client page.
- Don't filter out .local domain. It is still a valid endpoint for peers to
connect to.
- Instead of showing just one domain, show all the domains as endpoints to
connect to.
- Don't store private key in the session. It is retained for longer than
necessary and also sessions are stored on the disk.
Tests:
- Remove all configured domains from the system and click 'Add Client
Automatically' button. It throws an exception. With the patch, it works.
- The Add Client Automatically page shows all the domains as endpoints.
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
- When Nextcloud is enabled, /.well-known/{card,cal}dav URLs are taken over by
Nextcloud. So relying on them makes radicale fail. Instead just check for the
web interface to be available.
Tests:
- Enable Nextcloud and run radicale functional tests. Without the patch tests
fail and with the patch, tests succeed.
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
- When Nextcloud is enabled, it takes over the .well-known URLs. We don't want
the redirect result to be cached resulting in wanted behavior.
Tests:
- curl -k https://192.168.122.87/.well-known/caldav and curl -k
https://192.168.122.87/.well-known/carddav results in 302 Found responses
instead of 301 permanent redirects.
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
- Migration files have already been renamed from plinth/migrations/*.py to
freedombox/migrations/*.py. When running these migrations, ensure that database
tables are first created with plinth_* names rather than freedombox_*. This is
because we want the database progression path for fresh installations (with not
tables) as well as the old installation (with plinth_ tables) to be the same. To
achieve this, migrations.CreateModel will be provided with db_table=plinth_*
values.
- Ensure if a migration call (plinth, 0001_initial) ran, then the (freedombox,
0001_initial) is not run again. This is achieved by adding replaces = [] in the
newly renamed migration.
- Create a new migration that renames plinth_* tables to freedombox_*.
- Fix an old migration (0003) to use historic model rather than current model.
This ensure that it uses the plinth_ table during migration rather than
freedombox_ table.
Tests:
- Delete the database and start plinth.service with all the patches. Notice that
the database migration (fresh creation) works well. First setup, first wizard,
bepasty app installation, and notifications work as expected. Notice that
django_migrations table contains entries for (plinth,000[1-6]*) as well
as (freedombox,000[1-7]*).
- Delete the database and start plinth.service without the patches. Run first
setup and wizard. Install bepasty. Then apply the patches and restart
plinth.service. Notice that the database migration (renaming of tables) works
well. First setup is already done. First wizard is not shown. bepasty is shown
as installed. Previously shown notifications are retained . Notice that
django_migrations table contains entries for (plinth,000[1-6]*) as well
as (freedombox,000[1-7]*).
- Delete the database and start plinth.service from trixie version. Run first
setup and wizard. Install bepasty. Then apply the patches and restart
plinth.service. Notice that the database migration (renaming of tables) works
well. First setup is already done. First wizard is not shown. bepasty is shown
as installed. Previously shown notifications are retained . Notice that
django_migrations table contains entries for (plinth,000[1-6]*) as well
as (freedombox,000[1-7]*).
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
