Tests:
- On Coturn app page, clicking on a tag redirects to Add New App page with tag
filter set to clicked tag.
- On Names app page, clicking on a tag redirects to system page with tag filter
set to clicked tag.
- On Operations page such as when installing an app, clicking on a tag redirects
to Add New App page with tag filter set to clicked tag.
- On Index page such when OpenVPN is clicked description for OpenVPN is shown.
Clicking on a tag in the description redirects to Add New App page with tag
filter set to clicked tag.
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
- Instead of the apps page which will be empty on first boot.
Tests:
- On Next Steps page, click on apps link takes users to add apps page and not
apps page.
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
- It avoids confusion with two separate app sections in a single page. The
sections/pages can be better titled.
- In future, we can style the apps page (with more status display) differently
from apps-add page (with more search and featured apps).
- Move page specific parts into individual pages instead of in the common
template cards.html.
- Add special message when there are no apps enabled and when there are no more
apps to enable.
- Drop show_disabled flag in cards template that is not needed anymore.
Tests:
- Unit tests work.
- Functional tests work on bepasty when starting with uninstalled, disabled, or
enabled states.
- Apps page shows special message when there are no apps enabled. It is
centered.
- Apps page shows 'Add new app' button with icon. Clicking it takes us to
apps-add page.
- Apps page does not have disabled apps list (even hidden).
- Disabled and uninstalled apps are not shown on apps page.
- Apps-add page shows special message when there are no more apps to be
installed or enabled (test by altering view code to have empty list of apps).
- Apps-add page shows list of apps that are disabled or uninstalled but not
enabled apps. It shows a title 'Add New App'.
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
- Change the IPv6 checkbox into an option to select from IPv4 only, IPv6 only,
or IPv4 and IPv6. Update functional tests.
- Add type hints everywhere.
- Separate out the generic URL update method to its own module. Add unit tests.
- Migrate old configuration to new configuration on first read.
- Store multiple IP addresses in the status. Support showing old status format
of single IP address as well. Show multiple IP addresses in the status table.
- Handle errors during update using exceptions for clearer code.
- For generic URL based updates, capture return code, stdout and stdin in error
message.
Tests:
- Adding a new GnuDIP domain leads to configuration setting ip_type = ipv4
- When adding a new dynamic domain, when generic option is selected IP Address
Type is shown. When GnuDIP is selected, the field is hidden.
- IP Address Type field is as expected. Options and description are as expected.
- When a new domain is added for generic domain, the value of ip_type is set as
expected. Changing the value to other values works. Configuration is updated
as expected. Option values and description are as expected.
- The column for IP Address is now 'IP Addresses'. When multiple IP addresses
are present in the status, they are shown in multiple lines in the tables as
<pre>. When no IP addresses are present, a '-' is shown in the column.
- When generic domain update fails, subprocess failure code, stderr and stdout
are shown in the error message.
- Unit tests work.
- Functional tests work.
- After 5 minute period, attempts are made to update the domain
- For GnuDIP and generic method:
- IP address lookup works for IPv4 and IPv6.
- IP address updates works for IPv4 (tested) and IPv6 (untested).
- In 'both' configuration, when IPv6 update fails, IPv4 still succeeds.
- Updates are skipped if the record is up-to-date.
- Successful updates are performed otherwise.
- Wrong password leads to proper error being shown.
- When the old status is stored, it is updated during read and proper status is
shown.
- When configuration has old use_ipv6 key, then it is migrated when newer
version of the service is started. True value is converted as 'ipv6', False
value is converted as 'ipv4'. 'null' key is properly removed.
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
All the users of the old ez-ipupdate client must have been migrated long ago as
the migration code was shipped in bookworm.
Tests:
- Service starts as expected.
- Re-running setup for the app works.
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
Explicitly noting down the version of Django helps us keep better track of our
upgrade progress. Due to the nature of changes to Django in recent versions,
FreedomBox does not need any changes to support newer versions. So, work done on
analyzing support for newer versions needs to tracked separate from git log
message.
Tests:
- Building FreedomBox Debian package works.
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
- Trixie has Django 4.2.28.
Tests:
- Unit tests pass on Trixie and Forky.
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
- The last bit code left in the file was a fix applied in 2018 and not used
since we stopped using access.conf file.
Tests:
- Building Debian package works.
- The Debian package still contains a postinst script with code for starting
systemd daemon and for running other debhelper hooks.
- Installing the Debian package on a fresh Debian trixie machine starts the
FreedomBox service. First wizard finished without issues and bepasty app install
succeeds.
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
- This app has been running on my FreedomBox without any problems with every day
usage for more than 6 months.
Tests:
- The app description does not show experimental message anymore. App page shows
up fine.
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
- Generating files in postinst script makes working with image-based systems
harder as postinst scripts are not run when booting from a pristine image. So,
move this to first_boot app's setup() method.
- This means that first wizard secret is no longer displayed during package
installation. This is a loss in usability, but might be acceptable:
- We want to reduce the number of dialog box messages shown to the user during
the installation of FreedomBox as a blend in Debian installer. Along with this
change, if we migrate away from LDAP, then no messages will be shown anymore.
- When users are installing using Debian installer, they don't have access to
console to note down the secret. They can only note down on a physical medium.
This is not the best way. Most of the time when I installed on machines, I
just looked at the secret file later.
- It is not expected that user will loose root access to the machine on which
they installed 'freedombox' package (manually or through Debian installer)
before they can type in the secret into the first wizard. Earlier, we had
restrictions on the type of users who can login to the console and this could
have happened.
- We can eliminate a lintian warning that we are showing messages in a dialog
in the postinst script instead of configure script.
Tests:
- Unit tests work.
- Building Debian package with changes works.
- Lintian warning about debconf has been eliminated.
- On a fresh Debian Trixie machine, installing the newly built Debian package
succeeds. It does not show first wizard secret related message. When web
interface is accessed, secret is asked. Skipping the secret is not possible.
Even before the creation of the secret file.
- Providing incorrect secret leads to error message. Secret file can be read by
root. The file is owned by plinth:plinth. The file has 0400 permissions.
- The secret file contains a newline at the file but entering the secret without
the newline character works.
- The secret contains uppercase and lowercase ASCII characters and digits. The
secret is 16 chars in length.
- Incrementing the version number of first_boot app does not lead to change in
the secret file contents.
- The message in the first wizard secret form is as expected.
- Building a disk image with newly built Debian package works. When the image is
booted, it does not ask for first wizard secret.
- When an existing machine is upgraded, if it is a disk image, first wizard
secret file is not created and first wizard is not shown to the user.
- When an existing machine is upgraded, if it is not a disk image, first wizard
secret file is not changed and first wizard is not shown to the user.
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
[jvalleroy: Correct comment]
Signed-off-by: James Valleroy <jvalleroy@mailbox.org>
Closes: #2575.
Tests:
- 'touch /etc/ssh/ssh_host_dsa_key.pub'. Try to load the SSH app page. It fails.
With the patch, it succeeds. A warning message is printed about failing to read
the key with proper returncode, stdout, and stderr.
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
Tests:
- When watching journal using 'sudo freedombox-logs' command, the syslog
identifier for main service is 'freedombox' and for privileged service is
'freedombox-privileged'.
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
Closes: #2583.
Changes based on fix and workaround suggested by James Duncan (@jaduncan).
See: https://salsa.debian.org/freedombox-team/freedombox/-/work_items/2583
Tests:
- Home page, apps, system, and help icons appears as before.
- James Duncan (@jaduncan) reports that custom shortcut icons appear normal
after this change.
Reviewed-by: Sunil Mohan Adapa <sunil@medhas.org>
Closes#1633.
[sunil: Move the button to the top of the apps page]
[sunil: Drop additional div nesting for 'available for install' section]
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: Sunil Mohan Adapa <sunil@medhas.org>
See:
https://discuss.freedombox.org/t/error-when-uninstalling-tor-and-tor-proxy/4295
sunil: Use pathlib.Path.unlink()
Tests:
- Install Tor and Tor Proxy. Uninstall both. Uninstall is succesful.
- Install Tor and Tor Proxy. Manually delete
/var/run/tor-instances/*.defaults. Uninstall both apps. Uninstall is
successful. A warning is printed in the logs.
Signed-off-by: James Valleroy <jvalleroy@mailbox.org>
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: Sunil Mohan Adapa <sunil@medhas.org>
Sunil:
- Simplify installation of Luanti client into a paragraph. Merge information
about default port into this paragraph.
- Minor formatting and punctuation.
- Drop format_lazy calls where not needed.
Signed-off-by: Frederico Gomes <fredericojfgomes@gmail.com>
Reviewed-by: Sunil Mohan Adapa <sunil@medhas.org>
Test was failing (on Ubuntu) after an unrelated systemd update caused
things to be reordered enough to cause the 30 second time limit to
overrun, meaning apache wouldn't be ready and the test would fail.
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
Fixes: #2556
Should be merged after fix for https://bugs.debian.org/1122841 is in unstable.
- This fixes issue with Matrix Synapse app not being installable from current
unstable.
- matrix-synapse package depends on older version of python3-typing-extensions.
This causes the daemon to fail during startup when older version is installed.
This was reported as https://bugs.debian.org/1122841. After this bug is fixed
and a newer version of matrix-synapse is uploaded, the patch will work as
expected. An alternative was to allow unattended-upgrades to upgrade
python3-typing-extensions from unstable, but has to be done very carefully and
with a lot of testing.
Tests:
- Install Matrix Synapse apps works. This request installation of the latest
version python3-typing-extensions from unstable. The daemon is running properly
after installation.
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
