2850 Commits

Author SHA1 Message Date
Joseph Nuthalapati
b42a54e826
transmission: Update description
Signed-off-by: Joseph Nuthalapati <njoseph@riseup.net>
Reviewed-by: Veiko Aasa <veiko17@disroot.org>
2021-01-11 22:48:25 +02:00
Joseph Nuthalapati
6b2656e8f3
transmission: Show port forwarding information
Using the firewalld service configuration provided by the Debian package.

Fixes #1868

Signed-off-by: Joseph Nuthalapati <njoseph@riseup.net>
Reviewed-by: Veiko Aasa <veiko17@disroot.org>
2021-01-11 22:47:27 +02:00
James Valleroy
2ae60802a9
upgrades: Write dist-upgrade service file in /run
Signed-off-by: James Valleroy <jvalleroy@mailbox.org>
Reviewed-by: Sunil Mohan Adapa <sunil@medhas.org>
2021-01-10 20:43:53 -08:00
James Valleroy
a66520f3ff
upgrades: Don't allow needrestart to restart freedombox-dist-upgrade
Signed-off-by: James Valleroy <jvalleroy@mailbox.org>
Reviewed-by: Sunil Mohan Adapa <sunil@medhas.org>
2021-01-10 20:43:46 -08:00
James Valleroy
8934c22ef3
upgrades: Add service for dist upgrade
Only restart plinth if needed.

Signed-off-by: James Valleroy <jvalleroy@mailbox.org>
Reviewed-by: Sunil Mohan Adapa <sunil@medhas.org>
2021-01-10 20:43:40 -08:00
Veiko Aasa
504d0cdf00
gitweb: Add functional tests for git-access group
Add functional tests:
- User of git-access group can access gitweb site.
- User not of git-access group can't access gitweb site.

Tested that all the gitweb app tests pass.

Signed-off-by: Veiko Aasa <veiko17@disroot.org>
Reviewed-by: Joseph Nuthalapati <njoseph@riseup.net>
2021-01-10 20:16:50 +05:30
Veiko Aasa
9c7b4d7b84
tests: functional: Improve creating users in tests
- Do not require a user password when creating a user. Generate a password
  if not provided.
- Before creating a user, delete previous user with the same name.
- Delete user: Do not skip if the user doesn't exist. It avoids the
  situation that some @when tests may silently skip.
- Update openvpn and deluge functional tests assuming passwords were not
  under the tests.

Tests performed:
- users, openvpn and deluge app functional tests pass.

Signed-off-by: Veiko Aasa <veiko17@disroot.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
2021-01-09 22:03:00 -05:00
James Valleroy
d69a36c25f
users: Avoid test error if ldapsearch is not available
ldapsearch is provided by ldap-utils, which is not a build dependency.

Test: Build package using `gbp buildpackage`.

Signed-off-by: James Valleroy <jvalleroy@mailbox.org>
Reviewed-by: Veiko Aasa <veiko17@disroot.org>
2021-01-06 08:36:18 +02:00
Veiko Aasa
7cf166e558
gitweb: tests: functional: Fix test failures in localized environment
Closes #2005

Signed-off-by: Veiko Aasa <veiko17@disroot.org>
Reviewed-by: Fioddor Superconcentrado <fioddor@gmail.com>
2021-01-05 22:38:55 +01:00
Veiko Aasa
87b2799e3b users: Skip action script tests if LDAP is not set up
- Also, make sure an admin account exists before some tests.

Tests performed:
- The users module test_actions unit tests are skipped if LDAP is not set up.
- The users module unit tests pass if LDAP is set up.

Signed-off-by: Veiko Aasa <veiko17@disroot.org>
2021-01-05 17:31:50 +01:00
Sunil Mohan Adapa
8bcd7f9611
radicale: Fix backup and restore of configuration
Perhaps the configuration was earlier stored under /var and symlinked from /etc/
but currently it is a separate directory and needs to be backed up.

Tests:
- Run functional tests for the radicale.

Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: Veiko Aasa <veiko17@disroot.org>
2021-01-04 13:47:41 +02:00
Sunil Mohan Adapa
6fc9e228a0
app: info: Move client validation to info component
- Each app does not have to call the validator by itself.

Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: Veiko Aasa <veiko17@disroot.org>
2021-01-04 13:47:39 +02:00
Sunil Mohan Adapa
fb1898befc
backups: Use the backup component in all apps
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: Veiko Aasa <veiko17@disroot.org>
2021-01-04 13:47:38 +02:00
Sunil Mohan Adapa
f630fb6059
backups: Add new component for backup and restore
- Component performs the validation instead of each app calling the validator.

- Retain the schema for declaring backup information.

- Suitable for usage directly in the backup/restore operation packets instead of
using BackupApp class.

- Backup/restore hooks can be handled by overriding this component instead of
module level methods.

Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: Veiko Aasa <veiko17@disroot.org>
2021-01-04 13:47:37 +02:00
Sunil Mohan Adapa
d45cc00981
openvpn: Don't show running status on download profile button
The running status prevents the user from downloading the profile a second time.

Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: Veiko Aasa <veiko17@disroot.org>
2021-01-02 13:53:20 +02:00
Sunil Mohan Adapa
cc8c0cb05d
backups: Don't open a new window for downloading backups
Opening a new window is simply unnecessary.

Tests:

- Clicking the link will result in immediate download in Chrome without
navigating away from the page.

- Clicking the link will result in download prompt in Firefox without navigating
away from the page.

Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: Veiko Aasa <veiko17@disroot.org>
2021-01-02 13:53:14 +02:00
ullli
269936ff14
mumble: Updated mumla and removed plumble from clients list
- Added mumla play-store link
- Removed pumble entry and plumble var

Reviewed-by: Sunil Mohan Adapa <sunil@medhas.org>
2020-12-31 17:15:51 -08:00
Veiko Aasa
aa54421216
ejabberd: functional tests: Wait until the jsxc buddy list is loaded
Fixes #1894

Tests performed:
- All the ejabberd tests pass on both Debian testing and stable

Signed-off-by: Veiko Aasa <veiko17@disroot.org>
Reviewed-by: Sunil Mohan Adapa <sunil@medhas.org>
2020-12-31 17:01:52 -08:00
Veiko Aasa
1ea6b0b176
functional tests: Make tests compatible with pytest-bdd v4.0
- In pytest-bdd v4.0, given steps are no longer fixtures. Mark steps
  as fixtures when needed.
- Remove 'test_' prefix from step function names, so that pytest doesn't
  run those twice.

Test performed:
- Run all tests, no more pytest-bdd v4.0 related failures
- All the openvpn, snapshot and users module tests pass

Signed-off-by: Veiko Aasa <veiko17@disroot.org>
Reviewed-by: Sunil Mohan Adapa <sunil@medhas.org>
2020-12-31 15:41:40 -08:00
Veiko Aasa
6665052fe8
security: Fix access denied for user daemon from cron
When 'restrict console logins' is activated, debsecan hourly cron jobs fail
because the 'daemon' user is not allowed to run cron jobs. Add rule to the
login access control file to allow 'daemon' user to run cron jobs.

Fixes #1770

Tested that after I copied the file to /etc/security/access.d/10freedombox-security.conf,
there are no more debsecan cron job errors in the journalctl logs.

Signed-off-by: Veiko Aasa <veiko17@disroot.org>
Reviewed-by: Fioddor Superconcentrado <fioddor@gmail.com>
2020-12-28 15:46:37 +01:00
spectral
79acc9b918
calibre: Fix manual page name
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
2020-12-26 13:47:53 -05:00
Joseph Nuthalapati
8085879643
deluge: Functional tests for bit-torrent group
Add tests to check that usage of Deluge is only permitted to users in
the group 'bit-torrent'.

Signed-off-by: Joseph Nuthalapati <njoseph@riseup.net>
Reviewed-by: Veiko Aasa <veiko17@disroot.org>
2020-12-23 16:47:03 +02:00
Joseph Nuthalapati
c975fb94e3
deluge: Sync apache2 config with Transmission
Use the same reverse proxy configuration as Transmission for Deluge.

Signed-off-by: Joseph Nuthalapati <njoseph@riseup.net>
Reviewed-by: Veiko Aasa <veiko17@disroot.org>
2020-12-23 16:46:47 +02:00
James Valleroy
c986bf8ff5
config: Skip homepage test on buildd (Closes: #977527)
Signed-off-by: James Valleroy <jvalleroy@mailbox.org>
Reviewed-by: Sunil Mohan Adapa <sunil@medhas.org>
2020-12-19 13:50:20 -08:00
James Valleroy
925903e72b
help: Update status log test
Check for either "Logs begin" (stable) or "Journal begins" (testing/unstable).

Signed-off-by: James Valleroy <jvalleroy@mailbox.org>
Reviewed-by: Sunil Mohan Adapa <sunil@medhas.org>
2020-12-19 13:41:26 -08:00
James Valleroy
f5b34704ee
tests: Skip initial update
Signed-off-by: James Valleroy <jvalleroy@mailbox.org>
Reviewed-by: Veiko Aasa <veiko17@disroot.org>
2020-12-19 17:15:16 +02:00
Veiko Aasa
9a6fa83376
gitweb: Make functional tests compatible with pytest-bdd v4.0
In pytest-bdd v4.0, given steps are no longer fixtures.

- Make gitweb_repo_metadata a fixture.
- Remove errorneous fixture usage from the gitweb_repo_should_not_exist
  step (fixture gitweb_repo returned always None).

Tested that gitweb functional tests pass when using pytest v4.0.2

Signed-off-by: Veiko Aasa <veiko17@disroot.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
2020-12-19 09:49:23 -05:00
Sunil Mohan Adapa
83c0adf6cf
ui: Avoid inline styling for setting progress bar width
- attr() CSS function can't used practically on anything but the content
property.

- Introduce a hack for setting any arbitrary percentage width on an element
similar to w-25, w-50, w-75 and w-100 bootstrap utilities. This hack should not
be used widely.

Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: Veiko Aasa <veiko17@disroot.org>
2020-12-19 16:26:54 +02:00
Sunil Mohan Adapa
30aae90030
help: Show version information as an alert
- Move the message to the top as it is important and a likely reason to visit
the about page.

- Turn it into an alert so that it stands out from the rest of the text. Success
when up-to-date, warning otherwise.

- Remove custom inline styling.

Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: Veiko Aasa <veiko17@disroot.org>
2020-12-19 16:26:53 +02:00
Sunil Mohan Adapa
a9ff7a4408
pagekite: Eliminate inline styling
- Use bootstrap utility instead.

Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: Veiko Aasa <veiko17@disroot.org>
2020-12-19 16:26:53 +02:00
Sunil Mohan Adapa
c2cd8f50c2
firstboot: Use bootstrap for logo styling
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: Veiko Aasa <veiko17@disroot.org>
2020-12-19 16:26:53 +02:00
Sunil Mohan Adapa
ae535268b2
ui: Use common styling to hide logo during firstboot
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: Veiko Aasa <veiko17@disroot.org>
2020-12-19 16:26:52 +02:00
Sunil Mohan Adapa
0e09d08d17
help: Split CSS styling into a separate file
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: Veiko Aasa <veiko17@disroot.org>
2020-12-19 16:26:51 +02:00
Sunil Mohan Adapa
ccefd98135
letsencrypt: Split CSS styling into a separate file
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: Veiko Aasa <veiko17@disroot.org>
2020-12-19 16:26:51 +02:00
Sunil Mohan Adapa
9c2d936b33
sharing: Split CSS styling into a separate file
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: Veiko Aasa <veiko17@disroot.org>
2020-12-19 16:26:51 +02:00
Sunil Mohan Adapa
3031d2063d
storage: Split CSS styling into a separate file
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: Veiko Aasa <veiko17@disroot.org>
2020-12-19 16:26:50 +02:00
Sunil Mohan Adapa
001923312b
backups: Split CSS styling into a separate file
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: Veiko Aasa <veiko17@disroot.org>
2020-12-19 16:26:50 +02:00
Sunil Mohan Adapa
b09e252731
upgrades: Split CSS styling into a separate file
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: Veiko Aasa <veiko17@disroot.org>
2020-12-19 16:26:49 +02:00
Sunil Mohan Adapa
cd58957e36
samba: Split CSS styling into separate file
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: Veiko Aasa <veiko17@disroot.org>
2020-12-19 16:26:49 +02:00
Sunil Mohan Adapa
c37bb77ed3
monkeysphere: Split CSS styling into a separate file
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: Veiko Aasa <veiko17@disroot.org>
2020-12-19 16:26:49 +02:00
Sunil Mohan Adapa
4b9b683a16
firewall: Split CSS styling into separate file
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: Veiko Aasa <veiko17@disroot.org>
2020-12-19 16:26:48 +02:00
Sunil Mohan Adapa
eeac81b8c6
networks: Use table for styling network connection list
- Split CSS into a separate file.

Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: Veiko Aasa <veiko17@disroot.org>
2020-12-19 16:26:48 +02:00
Sunil Mohan Adapa
4b10d525bd
networks: Use common styling for Wi-Fi network list
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: Veiko Aasa <veiko17@disroot.org>
2020-12-19 16:26:47 +02:00
Sunil Mohan Adapa
55880e8f0b
networks: Use common styling for showing network connection
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: Veiko Aasa <veiko17@disroot.org>
2020-12-19 16:26:47 +02:00
Sunil Mohan Adapa
9e04782f0d
users: Use common styling for users list
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: Veiko Aasa <veiko17@disroot.org>
2020-12-19 16:26:47 +02:00
Sunil Mohan Adapa
e2aa3c2229
gitweb: Use common styling for repo list
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: Veiko Aasa <veiko17@disroot.org>
2020-12-19 16:26:46 +02:00
Sunil Mohan Adapa
0e78f8f4a8
ikiwiki: Use common styling for wiki/blog list
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: Veiko Aasa <veiko17@disroot.org>
2020-12-19 16:26:46 +02:00
Sunil Mohan Adapa
40e23f209a
pagekite: Use common styling for custom services
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: Veiko Aasa <veiko17@disroot.org>
2020-12-19 16:26:46 +02:00
Sunil Mohan Adapa
7a32b8f638
calibre: Use common styling for libraries list
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: Veiko Aasa <veiko17@disroot.org>
2020-12-19 16:26:45 +02:00
Sunil Mohan Adapa
858d005b87
help, power, index: ui: Drop remaining uses of &raquo;
- Mostly for consistency with the rest of the interface.

- Most of the usages got removed already.

Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: Veiko Aasa <veiko17@disroot.org>
2020-12-19 11:26:39 +02:00