8 Commits

Author SHA1 Message Date
Sunil Mohan Adapa
d44283d9ba
minidlna: cosmetic: isort fixes
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
2020-05-18 08:49:31 -04:00
James Valleroy
3c85846fa2
minidlna: Move sysctl config to /etc/sysctl.d/50-freedombox.conf
/etc/sysctl.conf is owned by procps package.

Test: Run minidlna install on fresh image.
- /etc/sysctl.conf is not modified.
- /etc/sysctl.d/50-freedombox.conf has the expected content.
- /proc/sys/fs/inotify/max_user_watches contains 100000.

- Running with these changes upgrades app version and triggers a setup. Changes
in /etc/sysctl.conf are removed. After undoing the changes /etc/sysctl.conf is
identical to pristine version installed from procps package. This can be
obtained by running; rm -f /etc/sysctl.conf ; apt install --reinstall procps -o
Dpkg::Options::=--force-confmiss

Closes #1802.

Signed-off-by: James Valleroy <jvalleroy@mailbox.org>
[sunil: Undo changes done in /etc/sysctl.conf in older versions]
[sunil: Increment app version to trigger configuration migration]
[sunil: Ensure that app is not re-enabled during migration]
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
2020-05-18 08:49:24 -04:00
Veiko Aasa
4d59713d79
minidlna: Make app installable inside unprivileged container
Use systemd-sysctl to reload sysctl configuration which ignores
fs.inotify.max_user_watches parameter inside unprivileged
container.

Closes #1830

Tests performed:

- Install minidlna using FreedomBox on KVM virtual machine. Installation
succeeds and the max_user_watches parameter
`cat /proc/sys/fs/inotify/max_user_watches` has changed.

- Install minidlna using FreedomBox on unprivileged systemd-nspawn container.
Installation succeeds (and the max_user_watches parameter hasn't changed).

Signed-off-by: Veiko Aasa <veiko17@disroot.org>
Reviewed-by: Sunil Mohan Adapa <sunil@medhas.org>
2020-04-29 21:14:21 -07:00
Sunil Mohan Adapa
eada506b23
actions/*: Use SPDX license identifier
Reviewed-by: Veiko Aasa <veiko17@disroot.org>
2020-02-19 14:39:36 +02:00
James Valleroy
f19a5b746f
minidlna: Use single action to set media dir and restart
Style config path as constant.

Signed-off-by: James Valleroy <jvalleroy@mailbox.org>
2019-12-08 14:50:22 -05:00
Nektarios Katakis
b5fb23e448
run sysctl after installation
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
2019-12-08 14:50:16 -05:00
Nektarios Katakis
3614a977f8
fix: minidlna.conf file permissions after editing
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
2019-12-08 14:50:07 -05:00
Nektarios Katakis
ef5f5a21de
feature: minidlna app
Closes #1679

Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
2019-12-08 14:49:21 -05:00