7 Commits

Author	SHA1	Message	Date
Sunil Mohan Adapa	7f608cd570	*: Collect output for all privileged sub-processes ... - Now that we have a mechanism for properly collecting, transmitting, and display the stdout and stderr. There is no reason not to collect all of the stdin and stderr. - Also, the stdin/stderr=subprocess.PIPE is redundant and prevents the output from getting collected for debugging. So, remove it. Tests: - Ran functional tests on backups, calibre, ejabberd, email, gitweb, ikiwiki, infinoted, kiwix, mediawiki, mumble, nextcloud,, openvpn, samba, wireguard, zoph. 2-3 issues were found but did not seem like new errors. Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org> Reviewed-by: Veiko Aasa <veiko17@disroot.org>	2025-09-29 16:58:57 +03:00
Sunil Mohan Adapa	61ff15a04f	*: Use action_utils.run instead of subprocess.run ... - This is to capture stdout and stderr and transmit that from privileged daemon back to the service to be displayed in HTML. Tests: - Unit tests and code checks pass. - Some of the modified actions work as expected. Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org> Reviewed-by: Veiko Aasa <veiko17@disroot.org>	2025-09-29 16:58:53 +03:00
Sunil Mohan Adapa	382b931cd4	ikiwiki: Mark secret strings in privileged actions ... Tests: - Run affected privileged actions through UI and notice that secret strings are not logged. Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org> Reviewed-by: James Valleroy <jvalleroy@mailbox.org>	2024-08-11 12:57:41 -04:00
Sunil Mohan Adapa	38ece87c6c	*: Utilize newer 3.10 syntax for type hints ... Tests: - mypy does not show any errors. - Installing ejabberd app works. Privileged actions run fine. - Unit tests work. - No additional testing was done as type annotations don't have any effect at runtime. Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org> Reviewed-by: James Valleroy <jvalleroy@mailbox.org>	2023-09-25 20:03:34 -04:00
nbenedek	b2ad4088aa	ikiwiki: Completely uninstall app ... Tests: 1. Create a wiki and a blog 2. Reinstall the app and confirm the sites get deleted Signed-off-by: nbenedek <contact@nbenedek.me> [sunil: Update docstrings, make uninstall fail-safe] Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org> Reviewed-by: Sunil Mohan Adapa <sunil@medhas.org>	2023-04-11 12:52:25 +05:30
James Valleroy	a179dd302e	ikiwiki: Re-run setup for each site after restore ... Closes: #2028. Tests: - Backup and restore with no sites. - Backup and restore with one wiki and one blog. Confirm that login works for both sites. - Backup from one container, and restore in another container. Confirm that login works for both sites. Signed-off-by: James Valleroy <jvalleroy@mailbox.org> Reviewed-by: Sunil Mohan Adapa <sunil@medhas.org>	2023-01-31 13:05:20 -08:00
Sunil Mohan Adapa	486d56e4cb	ikiwiki: Use privileged decorator for actions ... Tests: - Functional tests work. - Initial setup works - /var/www/ikiwiki is created - Shortcuts are created for existing sites after restarting FreedomBox service. - Creating a new wiki works. - The site is listed in the list of blogs/wikis - Creating a new blog works. - The site is listed in the list of blogs/wikis - Deleting a wiki works - Deleting a blog works Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org> Reviewed-by: James Valleroy <jvalleroy@mailbox.org>	2022-10-08 18:52:11 -04:00