- Enable cached results when checking if the user is an admin. Cached results
are only invalid when a user newly get admin permission or when an existing
user loose admin permission. Here the consequence of showing wrong results is
minor.
- Use all small case for variable names.
- When we use a utility method from Plinth, we can trust it to give expected
values. Otherwise, we should fix the method to be more robust.
- Don't recommend the user to go to disks configuration page as there is not
much there to do to free up space. The action might be removing apps, deleting
downloaded content (downloaded via torrents) etc.
- df is unlikely to return '-1' for size of disk.
- Avoid using -1 as error value.
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
- Remove apps and system modules and merge their views into main views.
- Move main_menu from cfg into menu.py.
- Remove dependencies of other modules on apps and system modules.
- Update tests.
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Closes#795. On a Raspberry Pi, the root partition was show as being
mounted from /dev/root. Use information from lsblk to more acurately
indentify the device as /dev/mmcblk0p2.
Reviewed-by: Sunil Mohan Adapa <sunil@medhas.org>
Most tables now occupy the full width of the container row. Some of
them are otherwise squished. Also make sure the new fixed container
layout has not reduced the originally intended width of a table.
- Show free space of currently mounted partitions. Should help with
people running out of free space and ending up with non-working
system. In future, this module could emit more visible messages.
- Show and allow expanding root partition to help people who have
written FreedomBox images to higher capacity SD cards. Very selective
and restrictive checks to minimize problems.
- Automated tests to ensure expansion works in non-trivial senarious.
