- No spaces at the beginning and end of a single line comment. (python code does this)
- Double space after a statement in a multi-line comment. (PEP-8)
- Enforce 79 character limit. (PEP-8)
- Empty line after a block ends make code more readable.
- Empty line at the end of a multi line comment. (python code seems to do this)
- Don't use depricated exception.message. Instead using exception.args
- Pass stdout output along with stderr in exception
- Handle possible exceptions such as ValueError, OSError in all cases
- Log all command executions and their errors
- contract module has not see a release since 2010
- Corresponding PEP has been deferred
- python-contract module in Debian is orphaned
- We are only using contract module in one method of one module
- That can be replaced with one line of check instead of depending on an
entire module
- The code using contract module does not work
- There is already replacement one line code that is actually working
If commands are executed synchronously, they'll return output and
error strings. If commands are executed asynchronously, nothing is
returned. We assume you can communicate with asynchronous processes
out-of-band.
Not every command needs to be executed as root, so there's a new
entry-point, *actions.run*, which executes actions as the current
user.