mirror of
https://github.com/freedombox/FreedomBox.git
synced 2026-01-21 07:55:00 +00:00
7e0156adbe
- Drop all the bash code. - Run the update URL code with same logic as before. Don't need to use action code for it. - Completely new way to handle configuration: using key/value store. Import old configuration once and delete it. - Use a glib scheduler instead of creating a cron job. - Store and show status from key/value store. - Handle multiple domains when getting/setting configuration and status. The UI still shows a single configuration form. To be improved later. - Catch and report all errors during the update process. - Drop all NAT detection code. - Drop selfhost.bz. German only, no free account, no proper TLS on domain, no easy to test. Existing accounts will continue to work with "other" as the service type. - For gnudip update code, add a timeout of 10 seconds, set a buffer size of two powers and fix handling error messages from server. Tests: - GnuDIP: - Upon submission of the form, the IP is updated if app is enabled. IP is not updated if app is disabled. - Every 5 minutes, check is made again and IP is updated. - If IP lookup URL is available, update calls are not made if the DNS is already up-to-date. - If IP lookup URL is not available, update calls are made unconditionally every 5 minutes. - For each of noip.com, freedns.afraid.org and other service: - Upon submission of the form, the IP is updated if app is enabled. IP is not updated if app is disabled. - Every 5 minutes, check is made again and IP is updated. - If IP lookup URL is available, update calls are not made if the DNS is already up-to-date. - If IP lookup URL is not available, update calls are made unconditionally every 5 minutes. - Form validation: - Domain field is always mandatory. - When type is selected as gnudip, the fields server, username, and password are mandatory. - When type is selected other than gnudip, the field update URL is mandatory. The rest are optional. - When the update URL contains a field contains <User>, username is mandatory. For <Pass>, password is mandatory. For <Ip>, ip_lookup_url is mandatory. - When use HTTP basic auth is checked, the fields username and password are mandatory. - Password is optional only if a previous password exists. If configuration is deleted from kvstore, password is mandatory. - Configuration import: Install dynamicdns without the patch. Add configuration with each of the service types. For GnuDIP service type, set two configurations with one with and without IP lookup URL. Update to code with the patch. Setup should run. - All fields in the configuration should be imported properly. - If the previous configuration is disabled, app should be disabled after import. Enabled otherwise. - Updating the IP address should work immediately after import. - Enable/Disable: when enabled, IP URL should be enabled every 5 minutes. When disabled, updates should not happen. - Status: - When status is removed from the DB, it should show that no status is available yet. - When the form is updated or update happens via the timer, the status is shown. It should show success for a proper update. Proper external IP address should be shown. - Set the server to localhost and submit. Status should show 'Server refused connection' message. IP address should be '-'. - Set the server to an unknown domain. Status should show 'Could not find server' message. IP address should be '-'. - Set the server to a known domain. Status should show 'Connection timed out' message. IP address should be '-'. - Last update time should keep increasing as time passes. - Backup/restore: - Functional tests. - Javascript: - When GnuDIP is selected as the type, the fields server, username, password, domain, show password, and IP lookup URL should be shown while other fields should be hidden. Same on page load with GnuDIP as pre-selected type. - When GnuDIP is not selected as the type, the fields update URL, accept all SSL certificates, use basic HTTP auth, domain name, username, password, show password, IP lookup URL and use IPv6 fields should be shown and rest of the fields should be hidden. Same on page load with non-GnuDIP as pre-selected type. - When show password is checked, password should be shown and when it is unchecked, password is masked. - When other service types are selected, the update URL values changes to the respective service's URL. Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org> Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
84 lines
2.7 KiB
Python
84 lines
2.7 KiB
Python
# SPDX-License-Identifier: AGPL-3.0-or-later
|
|
"""
|
|
Views for the dynamicsdns module.
|
|
"""
|
|
|
|
import datetime
|
|
|
|
from django.contrib import messages
|
|
from django.utils.translation import gettext_lazy as _
|
|
|
|
from plinth import views
|
|
from plinth.modules import dynamicdns
|
|
|
|
from .forms import ConfigureForm
|
|
|
|
|
|
class DynamicDNSAppView(views.AppView):
|
|
"""Serve configuration page."""
|
|
app_id = 'dynamicdns'
|
|
template_name = 'dynamicdns.html'
|
|
form_class = ConfigureForm
|
|
|
|
_error_messages = {
|
|
'timeout': _('Connection timed out'),
|
|
'gaierror': _('Could not find server'),
|
|
'TimeoutError': _('Connection timed out'),
|
|
'ConnectionRefusedError': _('Server refused connection'),
|
|
'ValueError': _('Already up-to-date')
|
|
}
|
|
|
|
def get_context_data(self, **kwargs):
|
|
"""Return the context data for rendering the template view."""
|
|
context = super().get_context_data(**kwargs)
|
|
status = dynamicdns.get_status()
|
|
config = dynamicdns.get_config()
|
|
domains_status = {}
|
|
for domain_name, domain in status['domains'].items():
|
|
if domain_name not in config['domains']:
|
|
continue
|
|
|
|
# Create naive datetime object in local timezone
|
|
domain['timestamp'] = datetime.datetime.fromtimestamp(
|
|
domain['timestamp'])
|
|
domains_status[domain_name] = domain
|
|
if domain['error_code'] in self._error_messages:
|
|
domain['error_message'] = self._error_messages[
|
|
domain['error_code']]
|
|
|
|
context['domains_status'] = domains_status
|
|
return context
|
|
|
|
def get_initial(self):
|
|
"""Get the current values for the form."""
|
|
initial = super().get_initial()
|
|
domains = dynamicdns.get_config()['domains']
|
|
domain = list(domains.values())[0] if domains else {}
|
|
initial.update(domain)
|
|
return domain
|
|
|
|
def form_valid(self, form):
|
|
"""Apply the changes submitted in the form."""
|
|
old_status = form.initial
|
|
new_status = form.cleaned_data
|
|
|
|
if old_status != new_status:
|
|
config = dynamicdns.get_config()
|
|
try:
|
|
del config['domains'][old_status['domain']]
|
|
except KeyError:
|
|
pass
|
|
|
|
config['domains'][new_status['domain']] = new_status
|
|
dynamicdns.set_config(config)
|
|
if old_status.get('domain'):
|
|
dynamicdns.notify_domain_removed(old_status['domain'])
|
|
|
|
dynamicdns.notify_domain_added(new_status['domain'])
|
|
messages.success(self.request, _('Configuration updated'))
|
|
|
|
# Perform an immediate update, even when configuration is not changed.
|
|
dynamicdns.update_dns(None)
|
|
|
|
return super().form_valid(form)
|