Sunil Mohan Adapa 1dcbfce713
users: Use privileged decorator for actions
Tests:

- Functional tests work (failing already)
- DONE: Showing front page shortcuts according to user groups works
  - DONE: Only user who is party of syncthing group is shown syncthing
  - DONE: Admin users are always shown all the apps
- DONE: Syncthing:
  - Not tested: When upgrading from version 2 or below, renaming group works
  - DONE: Syncthing is added to freedombox-share group
- DONE: Initial setup of users app works
  - DONE: freedombox-share group is created
- DONE: Retriving last admin user works
  - DONE: Last admin is not allowed to delete account
- DONE: Creating a new user works
  - DONE: Password is set properly (user can login with 'su - user' after)
  - DONE: Incorrect confirmation password leads to error
  - DONE: Adding the user to groups works (edit page shows correct list of groups)
- DONE: Editing a user works
  - DONE: User is renamed properly
  - DONE: Removing user from groups works
  - DONE: Adding user to new groups works
  - DONE: Providing incorrect auth password results in error message
  - DONE: Enabling/disabling account work (confirm with 'su - user'). See #2277.
- DONE: Updating user password works
  - DONE: New password is set (confirm with 'su - user')
  - DONE: Providing incorrect auth password results in error message
- DONE: Initial user account creation works
  - DONE: User account can be used (confirm with 'su - user')
  - DONE: User is added to admin group
- DONE: Exception while getting SSH keys results in showing empty field
- DONE: Removing a user works
  - DONE: Command provided in a message in users_firstboot.html works for
    deleting users.
- DONE: If an admin users exists when running first wizard, list of admin users
  is shown.

Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
2022-10-08 18:53:52 -04:00

249 lines
8.7 KiB
Python

# SPDX-License-Identifier: AGPL-3.0-or-later
"""Django views for user app."""
import django.views.generic
from django.contrib import messages
from django.contrib.auth import update_session_auth_hash
from django.contrib.auth.models import User
from django.contrib.messages.views import SuccessMessageMixin
from django.core.exceptions import PermissionDenied
from django.http import HttpResponseRedirect
from django.urls import reverse, reverse_lazy
from django.utils.translation import gettext as _
from django.utils.translation import gettext_lazy
from django.views.generic.edit import (CreateView, DeleteView, FormView,
UpdateView)
import plinth.modules.ssh.privileged as ssh_privileged
from plinth import translation
from plinth.modules import first_boot
from plinth.utils import is_user_admin
from plinth.views import AppView
from . import get_last_admin_user, privileged
from .forms import (CreateUserForm, FirstBootForm, UserChangePasswordForm,
UserUpdateForm)
class ContextMixin:
"""Mixin to add 'title' to the template context."""
def get_context_data(self, **kwargs):
"""Add self.title to template context."""
context = super().get_context_data(**kwargs)
context['title'] = getattr(self, 'title', '')
return context
class UserCreate(ContextMixin, SuccessMessageMixin, CreateView):
"""View to create a new user."""
form_class = CreateUserForm
template_name = 'users_create.html'
model = User
success_message = gettext_lazy('User %(username)s created.')
success_url = reverse_lazy('users:create')
title = gettext_lazy('Create User')
def get_form_kwargs(self):
"""Make the request object available to the form."""
kwargs = super().get_form_kwargs()
kwargs['request'] = self.request
return kwargs
def get_success_url(self):
"""Return the URL to redirect to in case of successful updation."""
return reverse('users:index')
class UserList(AppView, ContextMixin, django.views.generic.ListView):
"""View to list users."""
model = User
template_name = 'users_list.html'
title = gettext_lazy('Users')
app_id = 'users'
def get_context_data(self, *args, **kwargs):
context = super().get_context_data(*args, **kwargs)
context['last_admin_user'] = get_last_admin_user()
return context
class UserUpdate(ContextMixin, SuccessMessageMixin, UpdateView):
"""View to update a user's details."""
template_name = 'users_update.html'
model = User
form_class = UserUpdateForm
slug_field = 'username'
success_message = gettext_lazy('User %(username)s updated.')
title = gettext_lazy('Edit User')
def dispatch(self, request, *args, **kwargs):
"""Handle a request and return a HTTP response."""
if self.request.user.get_username() != self.kwargs['slug'] \
and not is_user_admin(self.request):
raise PermissionDenied
return super().dispatch(request, *args, **kwargs)
def get_form_kwargs(self):
"""Make the request object available to the form."""
kwargs = super().get_form_kwargs()
kwargs['request'] = self.request
kwargs['username'] = self.object.username
return kwargs
def get_initial(self):
"""Return the data for initial form load."""
initial = super().get_initial()
try:
ssh_keys = ssh_privileged.get_keys(self.object.username)
initial['ssh_keys'] = ssh_keys.strip()
initial['language'] = self.object.userprofile.language
except Exception:
pass
return initial
def get_success_url(self):
"""Return the URL to redirect to in case of successful updation."""
return reverse('users:edit', kwargs={'slug': self.object.username})
def form_valid(self, form):
"""Set the user language if necessary."""
response = super().form_valid(form)
# If user is updating their own profile then set the language for
# current session too.
if self.object.username == self.request.user.username:
translation.set_language(self.request, response,
self.request.user.userprofile.language)
return response
class UserDelete(ContextMixin, DeleteView):
"""Handle deleting users, showing a confirmation dialog first.
On GET, display a confirmation page.
On POST, delete the user.
"""
template_name = 'users_delete.html'
model = User
slug_field = 'username'
success_url = reverse_lazy('users:index')
title = gettext_lazy('Delete User')
def __init__(self, *args, **kwargs):
"""Initialize view, override delete method."""
super().__init__(*args, **kwargs)
# Avoid a warning with Django 4.0 that delete member should not be
# overridden. Remove this line and _delete() after Django 4.0 reaches
# Debian Stable.
self.delete = self._delete
def _delete_from_ldap(self):
"""Remove user from LDAP and show a success/error message."""
message = _('User {user} deleted.').format(user=self.kwargs['slug'])
messages.success(self.request, message)
try:
privileged.remove_user(self.kwargs['slug'])
except Exception:
messages.error(self.request, _('Deleting LDAP user failed.'))
def _delete(self, *args, **kwargs):
"""Set the success message of deleting the user.
The SuccessMessageMixin doesn't work with the DeleteView on Django1.7,
so set the success message manually here.
"""
output = super().delete(*args, **kwargs)
self._delete_from_ldap()
return output
def form_valid(self, form):
"""Perform additional operations after delete.
Since Django 4.0, DeleteView inherits form_view and a call to delete()
is not made.
"""
response = super().form_valid(form) # NOQA, pylint: disable=no-member
self._delete_from_ldap()
return response
class UserChangePassword(ContextMixin, SuccessMessageMixin, FormView):
"""View to change user password."""
template_name = 'users_change_password.html'
form_class = UserChangePasswordForm
title = gettext_lazy('Change Password')
success_message = gettext_lazy('Password changed successfully.')
def dispatch(self, request, *args, **kwargs):
"""Handle a request and return a HTTP response."""
if self.request.user.get_username() != self.kwargs['slug'] \
and not is_user_admin(self.request):
raise PermissionDenied
return super().dispatch(request, *args, **kwargs)
def get_form_kwargs(self):
"""Make the user object available to the form."""
kwargs = super().get_form_kwargs()
kwargs['request'] = self.request
kwargs['user'] = User.objects.get(username=self.kwargs['slug'])
return kwargs
def get_success_url(self):
"""Return the URL to go to on successful sumbission."""
return reverse('users:edit', kwargs={'slug': self.kwargs['slug']})
def form_valid(self, form):
"""Save the form if the submission is valid.
Django user session authentication hashes are based on password to have
the ability to logout all sessions on password change. Update the
session authentications to ensure that the current sessions is not
logged out.
"""
form.save()
update_session_auth_hash(self.request, form.user)
return super().form_valid(form)
class FirstBootView(django.views.generic.CreateView):
"""Create user account and log the user in."""
template_name = 'users_firstboot.html'
form_class = FirstBootForm
def dispatch(self, request, *args, **kwargs):
"""Check if there is no possibility to create a new admin account."""
if request.method == 'POST' and 'skip' in request.POST:
first_boot.mark_step_done('users_firstboot')
return HttpResponseRedirect(reverse(first_boot.next_step()))
return super().dispatch(request, *args, **kwargs)
def get_context_data(self, *args, **kwargs):
"""Add admin users to context data."""
context = super().get_context_data(*args, **kwargs)
context['admin_users'] = privileged.get_group_users('admin')
return context
def get_form_kwargs(self):
"""Make request available to the form (to insert messages)."""
kwargs = super().get_form_kwargs()
kwargs['request'] = self.request
return kwargs
def get_success_url(self):
"""Return the next first boot step after valid form submission."""
return reverse(first_boot.next_step())