mirror of
https://github.com/freedombox/FreedomBox.git
synced 2026-08-19 12:36:06 +00:00
62deda0ec7
- Change the IPv6 checkbox into an option to select from IPv4 only, IPv6 only, or IPv4 and IPv6. Update functional tests. - Add type hints everywhere. - Separate out the generic URL update method to its own module. Add unit tests. - Migrate old configuration to new configuration on first read. - Store multiple IP addresses in the status. Support showing old status format of single IP address as well. Show multiple IP addresses in the status table. - Handle errors during update using exceptions for clearer code. - For generic URL based updates, capture return code, stdout and stdin in error message. Tests: - Adding a new GnuDIP domain leads to configuration setting ip_type = ipv4 - When adding a new dynamic domain, when generic option is selected IP Address Type is shown. When GnuDIP is selected, the field is hidden. - IP Address Type field is as expected. Options and description are as expected. - When a new domain is added for generic domain, the value of ip_type is set as expected. Changing the value to other values works. Configuration is updated as expected. Option values and description are as expected. - The column for IP Address is now 'IP Addresses'. When multiple IP addresses are present in the status, they are shown in multiple lines in the tables as <pre>. When no IP addresses are present, a '-' is shown in the column. - When generic domain update fails, subprocess failure code, stderr and stdout are shown in the error message. - Unit tests work. - Functional tests work. - After 5 minute period, attempts are made to update the domain - For GnuDIP and generic method: - IP address lookup works for IPv4 and IPv6. - IP address updates works for IPv4 (tested) and IPv6 (untested). - In 'both' configuration, when IPv6 update fails, IPv4 still succeeds. - Updates are skipped if the record is up-to-date. - Successful updates are performed otherwise. - Wrong password leads to proper error being shown. - When the old status is stored, it is updated during read and proper status is shown. - When configuration has old use_ipv6 key, then it is migrated when newer version of the service is started. True value is converted as 'ipv6', False value is converted as 'ipv4'. 'null' key is properly removed. Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org> Reviewed-by: James Valleroy <jvalleroy@mailbox.org>