mirror of
https://github.com/freedombox/FreedomBox.git
synced 2026-01-28 08:03:36 +00:00
7a9a4cd861
- Use action helper so that Plinth can run unprivilaged and action script can run as root. - Use Status-Fd feature of apt-get to report progress. Don't report much detail. - Capture all stderr of the apt-get process and present it only in case of failure. - Remove package installation using PackageKit. Remove dependency on PackageKit. - Merge --setup package installation with regular package installation. This should fix the following problems: - PackageKit throws errors when APT encounters an error and later corrects them and proceeds well. This is reported upstream but not fixed. - PackageKit does not install recommends by default and there is no easy way to tell it to do so. - In some rare cases, PackageKit could get stuck for interactive input even though interactive flag is set to false. - PackageKit does not work without network manager connections. (Could have been mitigated by altering packagekit configuration). - PackageKit glib library leaks file descriptors after each operation. This leads to running out of fds during long running refresh operations such as OpenVPN setup. (This should have subsided by not checking package install with the new setup mechanism.)] Known issues: - In development mode, inside action scripts the python modules are always loaded from system path and not development directory. - With PackageKit it is possible to run multiple operations simultaneously. Others would wait while the first is being installed. With new implementation, the others error out unable to obtain lock.
134 lines
4.4 KiB
Python
134 lines
4.4 KiB
Python
#
|
|
# This file is part of Plinth.
|
|
#
|
|
# This program is free software: you can redistribute it and/or modify
|
|
# it under the terms of the GNU Affero General Public License as
|
|
# published by the Free Software Foundation, either version 3 of the
|
|
# License, or (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU Affero General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU Affero General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
#
|
|
|
|
"""
|
|
Framework for installing and updating distribution packages
|
|
"""
|
|
|
|
from django.utils.translation import ugettext as _
|
|
import logging
|
|
import subprocess
|
|
import threading
|
|
|
|
from plinth import actions
|
|
|
|
|
|
logger = logging.getLogger(__name__)
|
|
|
|
|
|
class PackageException(Exception):
|
|
"""A package operation has failed."""
|
|
|
|
def __init__(self, error_string=None, error_details=None, *args, **kwargs):
|
|
"""Store packagekit error string and details."""
|
|
super(PackageException, self).__init__(*args, **kwargs)
|
|
|
|
self.error_string = error_string
|
|
self.error_details = error_details
|
|
|
|
def __str__(self):
|
|
"""Return the strin representation of the exception."""
|
|
return 'PackageException(error_string="{0}", error_details="{1}")' \
|
|
.format(self.error_string, self.error_details)
|
|
|
|
|
|
class Transaction(object):
|
|
"""Information about an ongoing transaction."""
|
|
|
|
def __init__(self, module_name, package_names):
|
|
"""Initialize transaction object.
|
|
|
|
Set most values to None until they are sent as progress update.
|
|
"""
|
|
self.module_name = module_name
|
|
self.package_names = package_names
|
|
|
|
self._reset_status()
|
|
|
|
def get_id(self):
|
|
"""Return a identifier to use as a key in a map of transactions."""
|
|
return frozenset(self.package_names)
|
|
|
|
def _reset_status(self):
|
|
"""Reset the current status progress."""
|
|
self.status_string = ''
|
|
self.percentage = 0
|
|
self.stderr = None
|
|
|
|
def install(self):
|
|
"""Run a PackageKit transaction to install given packages.
|
|
|
|
Plinth needs to be running as root when calling this.
|
|
Currently, this is meant to be only during first time setup
|
|
when --setup is argument is passed.
|
|
"""
|
|
try:
|
|
self._run_apt_command(['update'])
|
|
self._run_apt_command(['install', self.module_name] +
|
|
self.package_names)
|
|
except subprocess.CalledProcessError as exception:
|
|
logger.exception('Error installing package: %s', exception)
|
|
raise
|
|
|
|
def _run_apt_command(self, arguments):
|
|
"""Run apt-get and update progress."""
|
|
self._reset_status()
|
|
|
|
process = actions.superuser_run('packages', arguments, async=True)
|
|
process.stdin.close()
|
|
|
|
stdout_thread = threading.Thread(target=self._read_stdout,
|
|
args=(process,))
|
|
stderr_thread = threading.Thread(target=self._read_stderr,
|
|
args=(process,))
|
|
stdout_thread.start()
|
|
stderr_thread.start()
|
|
stdout_thread.join()
|
|
stderr_thread.join()
|
|
|
|
return_code = process.wait()
|
|
if return_code != 0:
|
|
raise PackageException(_('Error during installation'), self.stderr)
|
|
|
|
def _read_stdout(self, process):
|
|
"""Read the stdout of the process and update progress."""
|
|
for line in process.stdout:
|
|
self._parse_progress(line.decode())
|
|
|
|
def _read_stderr(self, process):
|
|
"""Read the stderr of the process and store in buffer."""
|
|
self.stderr = process.stderr.read().decode()
|
|
|
|
def _parse_progress(self, line):
|
|
"""Parse the apt-get process output line.
|
|
|
|
See README.progress-reporting in apt source code.
|
|
"""
|
|
parts = line.split(':')
|
|
if len(parts) < 4:
|
|
return
|
|
|
|
status_map = {
|
|
'pmstatus': _('installing'),
|
|
'dlstatus': _('downloading'),
|
|
'media-change': _('media change'),
|
|
'pmconffile': _('configuration file: {file}').format(
|
|
file=parts[1]),
|
|
}
|
|
self.status_string = status_map.get(parts[0], '')
|
|
self.percentage = int(float(parts[2]))
|