mirror of
https://github.com/freedombox/FreedomBox.git
synced 2026-01-21 07:55:00 +00:00
As reported in discussion forum[1], when clients connected via 'shared' network connection try to resolve the a static domain name configured in FreedomBox, they resolve to 127.0.1.1. Since this refers to client's own IP address, they fail to connect. In the previous version, this was not a problem because the entry was stored as <hostname>.<domainname>. To resolve this, store domain names in kvstore instead of /etc/hosts. Links: 1) https://discuss.freedombox.org/t/freedombox-resolves-its-own-external-name-as-127-0-1-1/3660 Tests: - Adding/removing static domains from Names app works. The order of added domains is preserved in the stored configuration. When adding a existing domain, a proper error message is shown. - Without the patch, configure multiple domains. They show up in /etc/hosts. Apply the patches and restart the service. Names app setup will run. Entries from /etc/hosts are removed and will be added to kvstore. The list of domains shows properly in Names app. After restarting the services, domains are show properly. - Without the patch on a version of FreedomBox without support for multiple static domains, configure a static domain. Switch to latest version FreedomBox with the patches. Restart the service. Names app setup will run. Entry from /etc/hosts will be removed and will be added to kvstore. The list of domains shows properly in Names app. After restarting the services, domains are show properly. Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
128 lines
5.7 KiB
Python
128 lines
5.7 KiB
Python
# SPDX-License-Identifier: AGPL-3.0-or-later
|
|
"""Forms for the names app."""
|
|
|
|
import re
|
|
|
|
from django import forms
|
|
from django.core import validators
|
|
from django.core.exceptions import ValidationError
|
|
from django.utils.translation import gettext_lazy as _
|
|
|
|
from plinth import cfg
|
|
from plinth.modules import names
|
|
from plinth.utils import format_lazy
|
|
|
|
HOSTNAME_REGEX = r'^[a-zA-Z0-9]([-a-zA-Z0-9]{,61}[a-zA-Z0-9])?$'
|
|
|
|
|
|
class NamesConfigurationForm(forms.Form):
|
|
"""Form to configure names app."""
|
|
|
|
dns_over_tls = forms.ChoiceField(
|
|
label=_('Use DNS-over-TLS for resolving domains (global preference)'),
|
|
widget=forms.RadioSelect, choices=[
|
|
('yes',
|
|
format_lazy(
|
|
'Yes. Encrypt connections to the DNS server. <p '
|
|
'class="help-block">This improves privacy as domain name '
|
|
'queries will not be made as plain text over the network. It '
|
|
'also improves security as responses from the server cannot '
|
|
'be manipulated. If the configured DNS servers do not '
|
|
'support DNS-over-TLS, all name resolutions will fail. If '
|
|
'your DNS provider (likely your ISP) does not support '
|
|
'DNS-over-TLS or blocks some domains, you can configure '
|
|
'well-known public DNS servers in individual network '
|
|
'connection settings.</p>', allow_markup=True)),
|
|
('opportunistic',
|
|
format_lazy(
|
|
'Opportunistic. <p class="help-block">Encrypt connections to '
|
|
'the DNS server if the server supports DNS-over-TLS. '
|
|
'Otherwise, use unencrypted connections. There is no '
|
|
'protection against response manipulation.</p>',
|
|
allow_markup=True)),
|
|
('no',
|
|
format_lazy(
|
|
'No. <p class="help-block">Do not encrypt domain name '
|
|
'resolutions.</p>', allow_markup=True)),
|
|
], initial='no')
|
|
|
|
dnssec = forms.ChoiceField(
|
|
label=_('Use DNSSEC when resolving domains (global preference)'),
|
|
widget=forms.RadioSelect, choices=[
|
|
('yes',
|
|
format_lazy(
|
|
'Yes. Verify authenticity and integrity of domain '
|
|
'resolutions. <p class="help-block">This improves security. '
|
|
'If the configured DNS servers do not support DNSSEC, all '
|
|
'name resolutions will fail. If your DNS provider (likely '
|
|
'your ISP) does not support DNSSEC or is manipulating '
|
|
'responses, you can configure well-known public DNS servers '
|
|
'in individual network connection settings.</p>',
|
|
allow_markup=True)),
|
|
('allow-downgrade',
|
|
format_lazy(
|
|
'Allow downgrade. <p class="help-block">Verify name '
|
|
'resolutions done by the DNS server if the server supports '
|
|
'DNSSEC. Otherwise, allow unverified resolutions. Limited '
|
|
'improvement to security. Detecting whether a DNS server '
|
|
'supports DNSSEC is not very reliable currently.</p>',
|
|
allow_markup=True)),
|
|
('no',
|
|
format_lazy(
|
|
'No. <p class="help-block">Do not verify domain name '
|
|
'resolutions.</p>', allow_markup=True)),
|
|
], initial='no')
|
|
|
|
|
|
class HostnameForm(forms.Form):
|
|
"""Form to update system's hostname."""
|
|
# See:
|
|
# https://tools.ietf.org/html/rfc952
|
|
# https://tools.ietf.org/html/rfc1035#section-2.3.1
|
|
# https://tools.ietf.org/html/rfc1123#section-2
|
|
# https://tools.ietf.org/html/rfc2181#section-11
|
|
hostname = forms.CharField(
|
|
label=_('Hostname'), help_text=format_lazy(
|
|
_('Hostname is the local name by which other devices on the local '
|
|
'network can reach your {box_name}. It must start and end with '
|
|
'an alphabet or a digit and have as interior characters only '
|
|
'alphabets, digits and hyphens. Total length must be 63 '
|
|
'characters or less.'), box_name=_(cfg.box_name)), validators=[
|
|
validators.RegexValidator(HOSTNAME_REGEX,
|
|
_('Invalid hostname'))
|
|
], strip=True)
|
|
|
|
|
|
def _domain_label_validator(domain_name):
|
|
"""Validate domain name labels."""
|
|
for label in domain_name.split('.'):
|
|
if not re.match(HOSTNAME_REGEX, label):
|
|
raise ValidationError(_('Invalid domain name'))
|
|
|
|
|
|
class DomainAddForm(forms.Form):
|
|
"""Form to add a static domain name."""
|
|
|
|
domain_name = forms.CharField(
|
|
label=_('Domain Name'), help_text=format_lazy(
|
|
_('Domain name is the global name by which other devices on the '
|
|
'Internet can reach your {box_name}. It must consist of '
|
|
'labels separated by dots. Each label must start and end '
|
|
'with an alphabet or a digit and have as interior characters '
|
|
'only alphabets, digits and hyphens. Length of each label '
|
|
'must be 63 characters or less. Total length of domain name '
|
|
'must be 253 characters or less.'), box_name=_(cfg.box_name)),
|
|
required=True, validators=[
|
|
validators.RegexValidator(
|
|
r'^[a-zA-Z0-9]([-a-zA-Z0-9.]{,251}[a-zA-Z0-9])?$',
|
|
_('Invalid domain name')), _domain_label_validator
|
|
], strip=True)
|
|
|
|
def clean_domain_name(self):
|
|
"""Check if the name is valid."""
|
|
domain_name = self.cleaned_data['domain_name']
|
|
if domain_name in names.domains_list():
|
|
raise ValidationError(_('Domain already exists.'))
|
|
|
|
return domain_name
|