Sunil Mohan Adapa f7277cf465
snapshot: Fix mounting /.snapshots subvolume and use automounting
Closes: #2085.

- Read the list of snapshots and properly determine the full subvolume name to
be used for mounting the .snapshots subvolume.

- Use systemd .mount units instead of editing fstab. Fstab editing is dangerous
and could result in system not booting properly. systemd units are better suited
for tool based editing while /etc/fstab is recommended for humans.

- Use automount feature provided by systemd using autofs to perform mounting. This
means that the backing filesystem is only accessed and mounted when the mount
point is accessed by a program. Parse errors in the mount/automount file and
incorrect mount parameters are also tolerated well with failure to boot.

Tests:

- On a fresh Debian Bullseye install with btrfs. Install FreedomBox with the
changes, create and delete manual snapshots. Rollback to a snapshot should also
work. /.snapshots should contain all the files inside each of the snapshots.

- After rebooting into a rolled back snapshot, create/delete and restore to a
snapshot should work. /.snapshots should contain all the files inside each of
the snapshots.

- Introduce an error in .mount file such the mount operation will fail. Reboot
the machine. Reboot is successful. /.snapshots is still mounted as autofs.
Trying to access /.snapshots will result in error during mount operation.

- On a vagrant box without changes. Install freedombox and ensure snapshot app
setup has been run. This creates the /etc/fstab entry. Apply the patches.
snapshot app will run and remove the mount line in /etc/fstab and create the
.mount entry. /.snapshots is still mounted but not because of .automount. After
reboot, /.snapshots is mounted with autofs and also with btrfs. Unmounting
/.snapshots and then trying to run 'ls /.snapshots' will perform the mount again.

Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
2023-02-08 21:10:59 -05:00

139 lines
4.5 KiB
Python

# SPDX-License-Identifier: AGPL-3.0-or-later
"""FreedomBox app to manage filesystem snapshots."""
import pathlib
import augeas
from django.utils.translation import gettext_lazy as _
from plinth import app as app_module
from plinth import menu
from plinth.modules import storage
from plinth.modules.backups.components import BackupRestore
from plinth.package import Packages
from . import manifest, privileged
_description = [
_('Snapshots allows creating and managing btrfs file system snapshots. '
'These can be used to roll back the system to a previously known '
'good state in case of unwanted changes to the system.'),
# Translators: xgettext:no-python-format
_('Snapshots are taken periodically (called timeline snapshots) and also '
'before and after a software installation. Older snapshots will be '
'automatically cleaned up according to the settings below.'),
_('Snapshots currently work on btrfs file systems only and on the root '
'partition only. Snapshots are not a replacement for '
'<a href="/plinth/sys/backups">backups</a> since '
'they can only be stored on the same partition. ')
]
DEFAULT_FILE = '/etc/default/snapper'
fs_types_supported = ['btrfs']
class SnapshotApp(app_module.App):
"""FreedomBox app for snapshots."""
app_id = 'snapshot'
_version = 5
can_be_disabled = False
def __init__(self):
"""Create components for the app."""
super().__init__()
info = app_module.Info(app_id=self.app_id, version=self._version,
is_essential=True, name=_('Storage Snapshots'),
icon='fa-film', description=_description,
manual_page='Snapshots')
self.add(info)
menu_item = menu.Menu('menu-snapshot', info.name, None, info.icon,
'snapshot:index', parent_url_name='system')
self.add(menu_item)
packages = Packages('packages-snapshot', ['snapper'])
self.add(packages)
backup_restore = SnapshotBackupRestore('backup-restore-snapshot',
**manifest.backup)
self.add(backup_restore)
def setup(self, old_version):
"""Install and configure the app."""
super().setup(old_version)
if is_supported():
privileged.setup(old_version)
self.enable()
class SnapshotBackupRestore(BackupRestore):
"""Component to backup/restore snapshot module."""
def restore_post(self, packet):
"""Run after restore."""
privileged.kill_daemon()
def is_supported():
"""Return whether snapshots are support on current setup."""
fs_type = storage.get_filesystem_type()
# Check that / is not a bind mounted btrfs filesystem similar to how
# snapper does the check: https://github.com/openSUSE/snapper/blob/
# 77eb6565d3d8df95a06cd52ce31174d98994939c/snapper/BtrfsUtils.cc#L61
root_inode_number = pathlib.Path('/').stat().st_ino
return fs_type in fs_types_supported and root_inode_number == 256
def load_augeas():
"""Initialize Augeas."""
aug = augeas.Augeas(flags=augeas.Augeas.NO_LOAD +
augeas.Augeas.NO_MODL_AUTOLOAD)
# shell-script config file lens
aug.set('/augeas/load/Shellvars/lens', 'Shellvars.lns')
aug.set('/augeas/load/Shellvars/incl[last() + 1]', DEFAULT_FILE)
aug.load()
return aug
def is_apt_snapshots_enabled(aug):
"""Return whether APT snapshots is enabled."""
value = aug.get('/files' + DEFAULT_FILE + '/DISABLE_APT_SNAPSHOT')
return value != 'yes'
def get_configuration():
"""Return snapper configuration."""
aug = load_augeas()
output = privileged.get_config()
def get_boolean_choice(status):
return ('yes', 'Enabled') if status else ('no', 'Disabled')
def get_max_from_range(key):
return output[key].split('-')[-1]
return {
'enable_timeline_snapshots':
get_boolean_choice(output['TIMELINE_CREATE'] == 'yes'),
'enable_software_snapshots':
get_boolean_choice(is_apt_snapshots_enabled(aug)),
'hourly_limit':
get_max_from_range('TIMELINE_LIMIT_HOURLY'),
'daily_limit':
get_max_from_range('TIMELINE_LIMIT_DAILY'),
'weekly_limit':
get_max_from_range('TIMELINE_LIMIT_WEEKLY'),
'monthly_limit':
get_max_from_range('TIMELINE_LIMIT_MONTHLY'),
'yearly_limit':
get_max_from_range('TIMELINE_LIMIT_YEARLY'),
'free_space':
output['FREE_LIMIT'],
}