mirror of
https://github.com/freedombox/FreedomBox.git
synced 2026-01-28 08:03:36 +00:00
59d7721682
Unix paths can contain double quotes. Allow entering paths with double quotes by escaping them in c-style[1] and retrieve them back properly. 1) https://httpd.apache.org/docs/2.4/expr.html Tests: Run tests on with various paths: - /var/a b - /var/c"d - /var/ef" Run the following tests. - Create a directory with the test path and create a sample file inside it. - Add a share with the test path. - Ensure that the share is accessible and the file can be downloaded. - Ensure that the list of the shares shows the path correctly. - Ensure that the share can be edited. Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
65 lines
2.3 KiB
Python
65 lines
2.3 KiB
Python
# SPDX-License-Identifier: AGPL-3.0-or-later
|
|
"""
|
|
Django forms for sharing app.
|
|
"""
|
|
|
|
from django import forms
|
|
from django.core.exceptions import ValidationError
|
|
from django.utils.translation import gettext_lazy as _
|
|
|
|
from plinth.modules import sharing
|
|
from plinth.modules.users.components import UsersAndGroups
|
|
|
|
|
|
class AddShareForm(forms.Form):
|
|
"""Form to add a new share."""
|
|
|
|
name = forms.RegexField(
|
|
label=_('Name of the share'), strip=True, regex=r'^[a-z0-9]+$',
|
|
help_text=_(
|
|
'A lowercase alpha-numeric string that uniquely identifies a '
|
|
'share. Example: <em>media</em>.'))
|
|
|
|
path = forms.CharField(
|
|
label=_('Path to share'), strip=True, help_text=_(
|
|
'Disk path to a folder on this server that you intend to share.'))
|
|
|
|
is_public = forms.BooleanField(
|
|
label=_('Public share'), required=False, help_text=_(
|
|
'Make files in this folder available to anyone with the link.'))
|
|
|
|
groups = forms.MultipleChoiceField(
|
|
choices=UsersAndGroups.get_group_choices,
|
|
widget=forms.CheckboxSelectMultiple, required=False,
|
|
label=_('User groups that can read the files in the share:'),
|
|
help_text=_(
|
|
'Users of the selected user groups will be able to read the '
|
|
'files in the share.'))
|
|
|
|
def __init__(self, *args, **kwargs):
|
|
"""Initialize the form with extra request argument."""
|
|
super().__init__(*args, **kwargs)
|
|
self.fields['name'].widget.attrs.update({'autofocus': 'autofocus'})
|
|
|
|
def clean_name(self):
|
|
"""Check if the name is valid."""
|
|
name = self.cleaned_data['name']
|
|
if 'name' in self.initial and name == self.initial['name']:
|
|
return name
|
|
|
|
if any((share for share in sharing.list_shares()
|
|
if name == share['name'])):
|
|
raise ValidationError(_('A share with this name already exists.'))
|
|
|
|
return name
|
|
|
|
def clean(self):
|
|
"""Check that at least one group is added for non-public shares."""
|
|
super(AddShareForm, self).clean()
|
|
is_public = self.cleaned_data.get('is_public')
|
|
groups = self.cleaned_data.get('groups')
|
|
if not is_public and not groups:
|
|
raise forms.ValidationError(
|
|
_('Shares should be either public or shared with at '
|
|
'least one group'))
|