mirror of
https://github.com/freedombox/FreedomBox.git
synced 2026-02-11 08:23:49 +00:00
0b5b384651
- Introduce new API to mark an app that it can't be disabled. - Mark jsxc, storage, config, upgrade and firewall apps as can't be disabled. - Fixed functional tests - Replaced AppForm with forms.Form in all modules' forms.py. - Remove app.template.js. - Remove unused styles. - Remove app status checks in form_valid of Deluge, Diaspora, Matrix, Ejabberd, MediaWiki, Storage, Transmission, Quassel - Purge unused is_enabled context variables (Ikiwiki) - ejabberd: Minor cleanup in template - jsxc: Cleanup unneeded overrides - tahoe: Cleanup unnecessary overrides Tests performed: - For all apps affected, test enable/disable button works and submitting configuration form works: with changes updates message and without changes 'settings unchanged' message. - avahi - bind - cockpit - SKIP: coquelicot - datetime - deluge - SKIP: diaspora - ejabberd - gitweb - i2p - infinoted - ikiwiki - matrixsynapse - mediawiki - minetest - minidlna - mldonkey - mumble - pagekite - privoxy - quassel - radicale - roundcube - SKIP: samba - searx - SKIP: shaarli - shadowsocks - ssh - tahoe - transmission - FAIL: tt-rss (not installable) - wireguard - Deluge test that configuration changes when app is disabled work - Quassel test that setting the domain works when app is diabled - Transmission test that setting the domain works when app is diabled - Ikiwiki create form works properly - Enable/disable button appears as expected when enabled and when disabled - Enable/disable button works without Javascript - Functional tests work for affected apps, Tor and OpenVPN - AppForm is removed from developer documentation - Forms reference - Customizing tutorial - Test all apps using directory select form - Transmission - Deluge - Visit each template that overrides block configuration and ensure that it is loaded properly and the display is as expected. - All apps that use AppView that are not tested above should not have an enable/disable button. That is JSXC, update, config, firewall, storage, users. Signed-off-by: Alice Kile <buoyantair@protonmail.com> Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org> Reviewed-by: Veiko Aasa <veiko17@disroot.org>
89 lines
2.6 KiB
Python
89 lines
2.6 KiB
Python
# SPDX-License-Identifier: AGPL-3.0-or-later
|
|
"""
|
|
FreedomBox app for upgrades.
|
|
"""
|
|
|
|
from django.contrib import messages
|
|
from django.template.response import TemplateResponse
|
|
from django.urls import reverse_lazy
|
|
from django.utils.translation import ugettext as _
|
|
|
|
from plinth import actions
|
|
from plinth.errors import ActionError
|
|
from plinth.modules import upgrades
|
|
from plinth.views import AppView
|
|
|
|
from .forms import ConfigureForm
|
|
|
|
|
|
class UpgradesConfigurationView(AppView):
|
|
"""Serve configuration page."""
|
|
form_class = ConfigureForm
|
|
success_url = reverse_lazy('upgrades:index')
|
|
template_name = "upgrades_configure.html"
|
|
app_id = 'upgrades'
|
|
|
|
def get_initial(self):
|
|
return {'auto_upgrades_enabled': upgrades.is_enabled()}
|
|
|
|
def form_valid(self, form):
|
|
"""Apply the form changes."""
|
|
old_status = form.initial
|
|
new_status = form.cleaned_data
|
|
|
|
if old_status['auto_upgrades_enabled'] \
|
|
!= new_status['auto_upgrades_enabled']:
|
|
|
|
try:
|
|
if new_status['auto_upgrades_enabled']:
|
|
upgrades.enable()
|
|
else:
|
|
upgrades.disable()
|
|
except ActionError as exception:
|
|
error = exception.args[2]
|
|
messages.error(
|
|
self.request,
|
|
_('Error when configuring unattended-upgrades: {error}').
|
|
format(error=error))
|
|
|
|
if new_status['auto_upgrades_enabled']:
|
|
messages.success(self.request, _('Automatic upgrades enabled'))
|
|
else:
|
|
messages.success(self.request,
|
|
_('Automatic upgrades disabled'))
|
|
|
|
return super().form_valid(form)
|
|
|
|
|
|
def is_package_manager_busy():
|
|
"""Return whether a package manager is running."""
|
|
try:
|
|
actions.superuser_run('packages', ['is-package-manager-busy'])
|
|
return True
|
|
except actions.ActionError:
|
|
return False
|
|
|
|
|
|
def get_log():
|
|
"""Return the current log for unattended upgrades."""
|
|
return actions.superuser_run('upgrades', ['get-log'])
|
|
|
|
|
|
def upgrade(request):
|
|
"""Serve the upgrade page."""
|
|
is_busy = is_package_manager_busy()
|
|
|
|
if request.method == 'POST':
|
|
try:
|
|
actions.superuser_run('upgrades', ['run'])
|
|
messages.success(request, _('Upgrade process started.'))
|
|
is_busy = True
|
|
except ActionError:
|
|
messages.error(request, _('Starting upgrade failed.'))
|
|
|
|
return TemplateResponse(request, 'upgrades.html', {
|
|
'title': _('Manual update'),
|
|
'is_busy': is_busy,
|
|
'log': get_log()
|
|
})
|