mirror of
https://github.com/freedombox/FreedomBox.git
synced 2026-01-21 07:55:00 +00:00
bc9e83e41f
Closes: #707 Helps: #1570 - Network Manager's 'shared' connections use port 53 on those interfaces. Bind by default also listens on them if possible. In some corner cases, this could lead to a clash. This patch fixes to cases by making sure bind does not listen on IP address likely used by Network Manager's 'shared' connections. If user custom configures address, they will need to update the bind configuration accordingly. - App version increment is not necessary because in this release cycle we have already incremented it once. Tests: - Install without patch. Increment the app version number (and the version number in the privileged script). Notice that bind app setup is run again. 'listen-on' line is inserted into the configuration file as expected. - Increment the version numbers again and a second 'listen-on' line is not inserted. - Without patch, on a machine with two network interfaces, start a 'shared' network connection. Start bind. Notice the error that bind could not listen on the shared network IP address. - Without patch, on a machine with two network interface, start bind while 'shared' network connection is configured with just the IP address. Start bind and it will listening on the IP address with shared network IP address. Configure a shared connection and it fails to start. - Apply the patch. Start 'shared' network connection. Start bind and notice that bind does not attempt to listen on that shared network IP address and does not print error message as well. - Apply the patch. Start bind while 'shared' network connection is configured with just the IP address. Bind does not attempt to listen on that shared network IP address. Start the shared network connection. It start without issues. Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org> Reviewed-by: James Valleroy <jvalleroy@mailbox.org>