FreedomBox/plinth/modules/samba/privileged.py
Sunil Mohan Adapa b253166f6d
*: Use action_utils.run instead of subprocess.check_output
- This is to capture stdout and stderr and transmit that from privileged daemon
back to the service to be displayed in HTML.

Tests:

- Unit tests and code checks pass.

- Some of the modified actions work as expected.

Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: Veiko Aasa <veiko17@disroot.org>
2025-09-29 16:58:56 +03:00

309 lines
10 KiB
Python

# SPDX-License-Identifier: AGPL-3.0-or-later
"""Configuration helper for samba."""
import configparser
import os
import pathlib
import shutil
import subprocess
from plinth import action_utils
from plinth.actions import privileged
DEFAULT_FILE = '/etc/default/samba'
CONF_PATH = '/etc/samba/smb-freedombox.conf'
CONF = r'''
#
# This file is managed and overwritten by Plinth. If you wish to manage
# Samba yourself, disable Samba in Plinth, remove this file and remove
# line with --configfile parameter in /etc/default/samba.
#
# Configuration parameters which differ from Debian default configuration
# are commented. To view configured samba shares use command `net conf list`.
#
[global]
workgroup = WORKGROUP
log file = /var/log/samba/log.%m
max log size = 1000
logging = file
panic action = /usr/share/samba/panic-action %d
server role = standalone server
#obey pam restrictions = yes
#unix password sync = yes
#passwd program = /usr/bin/passwd %u
#passwd chat = *Enter\snew\s*\spassword:* %n\n *Retype\snew\s*\spassword:* %n\n *password\supdated\ssuccessfully* .
#pam password change = yes
map to guest = bad user
# connection inactivity timeout in minutes
deadtime = 5
# enable registry based shares
registry shares = yes
# Make sure Samba isn't available over the Internet.
# https://en.wikipedia.org/wiki/localhost
# https://en.wikipedia.org/wiki/Private_network
# https://en.wikipedia.org/wiki/Link-local_address
# https://en.wikipedia.org/wiki/Unique_local_address
hosts allow = 127.0.0.0/8 10.0.0.0/8 172.16.0.0/12 192.168.0.0/16 169.254.0.0/16 ::1
hosts deny = all
''' # noqa: E501
def _close_share(share_name):
"""Disconnect all samba users who are connected to the share."""
action_utils.run(['smbcontrol', 'smbd', 'close-share', share_name],
check=True)
def _conf_command(parameters, **kwargs):
"""Run samba configuration registry command."""
action_utils.run(['net', 'conf'] + parameters, check=True, **kwargs)
def _create_share(mount_point, share_type, windows_filesystem=False):
"""Create samba public, group and private shares."""
if share_type == 'open':
subdir = 'open_share'
elif share_type == 'group':
subdir = 'group_share'
elif share_type == 'home':
subdir = 'homes'
shares_path = _get_shares_path(mount_point)
share_path = os.path.join(mount_point, shares_path, subdir)
os.makedirs(share_path, exist_ok=True)
# FAT and NTFS partitions don't support setting permissions
if not windows_filesystem:
if share_type in ['open', 'group']:
_set_share_permissions(share_path)
else:
shutil.chown(share_path, group='users')
os.chmod(share_path, 0o0775)
share_name = _create_share_name(mount_point)
if share_type == 'open':
_define_open_share(share_name, share_path, windows_filesystem)
elif share_type == 'group':
_define_group_share(share_name + '_group', share_path,
windows_filesystem)
elif share_type == 'home':
_define_homes_share(share_name + '_home', share_path)
def _create_share_name(mount_point):
"""Create a share name."""
share_name = os.path.basename(mount_point)
if not share_name:
share_name = 'disk'
return share_name
def _define_open_share(name, path, windows_filesystem=False):
"""Define an open samba share."""
try:
_conf_command(['delshare', name], stderr=subprocess.DEVNULL)
except subprocess.CalledProcessError:
pass
_conf_command(['addshare', name, path, 'writeable=y', 'guest_ok=y'])
if not windows_filesystem:
_conf_command(['setparm', name, 'force group', 'freedombox-share'])
_conf_command(['setparm', name, 'inherit permissions', 'yes'])
def _define_group_share(name, path, windows_filesystem=False):
"""Define a group samba share."""
try:
_conf_command(['delshare', name], stderr=subprocess.DEVNULL)
except subprocess.CalledProcessError:
pass
_conf_command(['addshare', name, path, 'writeable=y', 'guest_ok=n'])
_conf_command(['setparm', name, 'valid users', '@freedombox-share @admin'])
if not windows_filesystem:
_conf_command(['setparm', name, 'force group', 'freedombox-share'])
_conf_command(['setparm', name, 'inherit permissions', 'yes'])
def _define_homes_share(name, path):
"""Define a samba share for private homes."""
try:
_conf_command(['delshare', name], stderr=subprocess.DEVNULL)
except subprocess.CalledProcessError:
pass
userpath = os.path.join(path, '%u')
_conf_command(['addshare', name, userpath, 'writeable=y', 'guest_ok=n'])
_conf_command(['setparm', name, 'valid users', '@freedombox-share @admin'])
_conf_command(
['setparm', name, 'preexec', 'mkdir -p -m 755 {}'.format(userpath)])
def _get_mount_point(path):
"""Get the mount point where the share is."""
subpath = 'FreedomBox/shares/'
if '/var/lib/freedombox/shares/' in path:
if os.path.ismount(path.split('lib/freedombox/shares/')[0]):
subpath = 'lib/freedombox/shares/'
else:
subpath = 'var/lib/freedombox/shares/'
return path.split(subpath)[0]
def _get_shares() -> list[dict[str, str]]:
"""Get shares."""
shares = []
output = action_utils.run(['net', 'conf', 'list'], check=True).stdout
config = configparser.RawConfigParser()
config.read_string(output.decode())
for name in config.sections():
share_type = 'open'
if name.endswith('_group'):
share_type = 'group'
elif name.endswith('_home'):
share_type = 'home'
share_path = config[name]['path']
mount_point = _get_mount_point(share_path)
mount_point = os.path.normpath(mount_point)
shares.append(
dict(name=name, mount_point=mount_point, path=share_path,
share_type=share_type))
return shares
def _get_shares_path(mount_point):
"""Return base path of the shared directories."""
if mount_point == '/var':
return 'lib/freedombox/shares/'
var_directory = os.path.join(mount_point, 'var')
if os.path.exists(var_directory) and os.stat(
mount_point).st_dev == os.stat(var_directory).st_dev:
return 'var/lib/freedombox/shares/'
return 'FreedomBox/shares/'
def _set_open_share_permissions(directory):
"""Set file and directory permissions for open share."""
shutil.chown(directory, group='freedombox-share')
os.chmod(directory, 0o2775)
for root, dirs, files in os.walk(directory):
for subdir in dirs:
subdir_path = os.path.join(root, subdir)
shutil.chown(subdir_path, group='freedombox-share')
os.chmod(subdir_path, 0o2775)
for file in files:
file_path = os.path.join(root, file)
shutil.chown(file_path, group='freedombox-share')
os.chmod(file_path, 0o0664)
action_utils.run(['setfacl', '-Rm', 'g::rwX', directory], check=True)
action_utils.run(['setfacl', '-Rdm', 'g::rwX', directory], check=True)
def _use_config_file(conf_file):
"""Set samba configuration file location."""
import augeas
aug = augeas.Augeas(flags=augeas.Augeas.NO_LOAD +
augeas.Augeas.NO_MODL_AUTOLOAD)
aug.set('/augeas/load/Shellvars/lens', 'Shellvars.lns')
aug.set('/augeas/load/Shellvars/incl[last() + 1]', DEFAULT_FILE)
aug.load()
aug.set('/files' + DEFAULT_FILE + '/SMBDOPTIONS',
'--configfile={0}'.format(conf_file))
aug.save()
def _set_share_permissions(directory):
"""Set file and directory permissions for a share."""
shutil.chown(directory, group='freedombox-share')
os.chmod(directory, 0o2775)
for root, dirs, files in os.walk(directory):
for subdir in dirs:
subdir_path = os.path.join(root, subdir)
shutil.chown(subdir_path, group='freedombox-share')
os.chmod(subdir_path, 0o2775)
for file in files:
file_path = os.path.join(root, file)
shutil.chown(file_path, group='freedombox-share')
os.chmod(file_path, 0o0664)
action_utils.run(['setfacl', '-Rm', 'g::rwX', directory], check=True)
action_utils.run(['setfacl', '-Rdm', 'g::rwX', directory], check=True)
@privileged
def add_share(mount_point: str, share_type: str, windows_filesystem: bool):
"""Create a samba share."""
if share_type not in ('open', 'group', 'home'):
raise ValueError('Invalid share type')
mount_point = os.path.normpath(mount_point)
if not os.path.ismount(mount_point):
raise RuntimeError(
'Path "{0}" is not a mount point.'.format(mount_point))
_create_share(mount_point, share_type, windows_filesystem)
@privileged
def delete_share(mount_point: str, share_type: str):
"""Delete a samba share configuration."""
if share_type not in ('open', 'group', 'home'):
raise ValueError('Invalid share type')
mount_point = os.path.normpath(mount_point)
shares = _get_shares()
for share in shares:
if share['mount_point'] == mount_point and share[
'share_type'] == share_type:
_close_share(share['name'])
_conf_command(['delshare', share['name']])
@privileged
def get_shares() -> list[dict[str, str]]:
"""Get samba shares."""
return _get_shares()
@privileged
def get_users() -> list[str]:
"""Get users from Samba database."""
output = action_utils.run(['pdbedit', '-L'], check=True).stdout.decode()
samba_users = [line.split(':')[0] for line in output.split()]
return samba_users
@privileged
def setup():
"""Configure samba, use custom samba config file."""
from plinth import action_utils
with open(CONF_PATH, 'w', encoding='utf-8') as file_handle:
file_handle.write(CONF)
_use_config_file(CONF_PATH)
os.makedirs('/var/lib/freedombox', exist_ok=True)
os.chmod('/var/lib/freedombox', 0o0755)
# Disable NetBIOS Service, used with now deprecated SMB1 protocol
if action_utils.service_is_running('nmbd'):
action_utils.service_stop('nmbd')
action_utils.service_disable('nmbd')
action_utils.service_mask('nmbd')
action_utils.service_disable('nmb')
action_utils.service_mask('nmb')
if action_utils.service_is_running('smbd'):
action_utils.service_restart('smbd')
@privileged
def uninstall():
"""Drop all Samba shares."""
_conf_command(['drop'])
for path in [CONF_PATH, DEFAULT_FILE]:
# Both files are typically created on setup()
pathlib.Path(path).unlink(missing_ok=True)