Veiko Aasa e7afa69155
storage: Directory selection form improvements
- Action script:
  - must not be root when validating directory
  - return only first validation error
- Directory selection form, transmission, deluge:
  show the download path as it is in the configuration,
  the path is resolved only on form submit.
- Tests: add relative path checks, refactor parametrize code

Signed-off-by: Veiko Aasa <veiko17@disroot.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
2020-03-02 20:51:41 -05:00

47 lines
1.4 KiB
Python

# SPDX-License-Identifier: AGPL-3.0-or-later
"""
Django views for Deluge.
"""
import json
from django.contrib import messages
from django.utils.translation import ugettext as _
from plinth import actions, views
from .forms import DelugeForm
class DelugeAppView(views.AppView):
"""Serve configuration page."""
diagnostics_module_name = 'deluge'
form_class = DelugeForm
app_id = 'deluge'
def get_initial(self):
"""Get current Deluge server settings."""
status = super().get_initial()
configuration = json.loads(
actions.superuser_run('deluge', ['get-configuration']))
status['storage_path'] = configuration['download_location']
return status
def form_valid(self, form):
"""Apply the changes submitted in the form."""
old_status = form.initial
new_status = form.cleaned_data
# don't change the configuration if the application was disabled
if new_status['is_enabled'] or not old_status['is_enabled']:
if old_status['storage_path'] != new_status['storage_path']:
new_configuration = [
'download_location', new_status['storage_path']
]
actions.superuser_run('deluge', ['set-configuration'] +
new_configuration)
messages.success(self.request, _('Configuration updated'))
return super().form_valid(form)