mirror of
https://github.com/freedombox/FreedomBox.git
synced 2026-01-28 08:03:36 +00:00
- Allow to enter either name or URL when creating repository - Validate a repository URL, allow only http and https schemes - Set autocomplete off on the name/URL field because URL may contain username:password - Check whether the repository actually exists before cloning - Show progress info while cloning - Actions script: new subcommand check-repo-exists and new arguments for the create-repo: --url, --prepare-only and --skip-prepare - Add test for invalid URLs Closes #1670 Signed-off-by: Veiko Aasa <veiko17@disroot.org> [sunil: Fix validating repo name in edit form] [sunil: Don't pipe stdin of clone process, it may lead to a hang] [sunil: Always run clone process with 'C' locale since we are parsing output] [sunil: Cosmetic changes] Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org> Reviewed-by: Sunil Mohan Adapa <sunil@medhas.org>
168 lines
5.5 KiB
Python
168 lines
5.5 KiB
Python
#
|
|
# This file is part of FreedomBox.
|
|
#
|
|
# This program is free software: you can redistribute it and/or modify
|
|
# it under the terms of the GNU Affero General Public License as
|
|
# published by the Free Software Foundation, either version 3 of the
|
|
# License, or (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU Affero General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU Affero General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
#
|
|
"""
|
|
Django views for Gitweb.
|
|
"""
|
|
|
|
from django.contrib import messages
|
|
from django.contrib.messages.views import SuccessMessageMixin
|
|
from django.http import Http404
|
|
from django.shortcuts import redirect
|
|
from django.template.response import TemplateResponse
|
|
from django.urls import reverse_lazy
|
|
from django.utils.translation import ugettext as _
|
|
from django.views.generic import FormView
|
|
|
|
from plinth import actions, views
|
|
from plinth.errors import ActionError
|
|
from plinth.modules import gitweb
|
|
|
|
from .forms import CreateRepoForm, EditRepoForm
|
|
|
|
|
|
class GitwebAppView(views.AppView):
|
|
"""Serve configuration page."""
|
|
|
|
clients = gitweb.clients
|
|
name = gitweb.name
|
|
description = gitweb.description
|
|
diagnostics_module_name = 'gitweb'
|
|
app_id = 'gitweb'
|
|
show_status_block = False
|
|
template_name = 'gitweb_configure.html'
|
|
|
|
def get_context_data(self, *args, **kwargs):
|
|
"""Add repositories to the context data."""
|
|
context = super().get_context_data(*args, **kwargs)
|
|
repos = gitweb.app.get_repo_list()
|
|
context['repos'] = repos
|
|
context['cloning'] = any('clone_progress' in repo for repo in repos)
|
|
return context
|
|
|
|
|
|
class CreateRepoView(SuccessMessageMixin, FormView):
|
|
"""View to create a new repository."""
|
|
|
|
form_class = CreateRepoForm
|
|
prefix = 'gitweb'
|
|
template_name = 'gitweb_create_edit.html'
|
|
success_url = reverse_lazy('gitweb:index')
|
|
success_message = _('Repository created.')
|
|
|
|
def get_context_data(self, **kwargs):
|
|
"""Return additional context for rendering the template."""
|
|
context = super().get_context_data(**kwargs)
|
|
context['title'] = _('Create Repository')
|
|
return context
|
|
|
|
def form_valid(self, form):
|
|
"""Create the repository on valid form submission."""
|
|
form_data = {}
|
|
for key, value in form.cleaned_data.items():
|
|
if value is None:
|
|
form_data[key] = ''
|
|
else:
|
|
form_data[key] = value
|
|
try:
|
|
gitweb.create_repo(form_data['name'], form_data['description'],
|
|
form_data['owner'], form_data['is_private'])
|
|
except ActionError:
|
|
messages.error(
|
|
self.request,
|
|
_('An error occurred while creating the repository.'))
|
|
gitweb.app.update_service_access()
|
|
|
|
return super().form_valid(form)
|
|
|
|
|
|
class EditRepoView(SuccessMessageMixin, FormView):
|
|
"""View to edit an existing repository."""
|
|
|
|
form_class = EditRepoForm
|
|
prefix = 'gitweb'
|
|
template_name = 'gitweb_create_edit.html'
|
|
success_url = reverse_lazy('gitweb:index')
|
|
success_message = _('Repository edited.')
|
|
|
|
def get_context_data(self, **kwargs):
|
|
"""Return additional context for rendering the template."""
|
|
context = super().get_context_data(**kwargs)
|
|
context['title'] = _('Edit repository')
|
|
return context
|
|
|
|
def get_initial(self):
|
|
"""Load information about repository being edited."""
|
|
name = self.kwargs['name']
|
|
for repo in gitweb.app.get_repo_list():
|
|
if repo['name'] == name and 'clone_progress' not in repo:
|
|
break
|
|
else:
|
|
raise Http404
|
|
|
|
return gitweb.repo_info(name)
|
|
|
|
def form_valid(self, form):
|
|
"""Edit the repo on valid form submission."""
|
|
if form.initial != form.cleaned_data:
|
|
form_data = {}
|
|
for key, value in form.cleaned_data.items():
|
|
if value is None:
|
|
form_data[key] = ''
|
|
else:
|
|
form_data[key] = value
|
|
|
|
try:
|
|
gitweb.edit_repo(form.initial, form_data)
|
|
except ActionError:
|
|
messages.error(self.request,
|
|
_('An error occurred during configuration.'))
|
|
gitweb.app.update_service_access()
|
|
|
|
return super().form_valid(form)
|
|
|
|
|
|
def delete(request, name):
|
|
"""Handle deleting repositories, showing a confirmation dialog first.
|
|
|
|
On GET, display a confirmation page.
|
|
On POST, delete the repository.
|
|
"""
|
|
for repo in gitweb.app.get_repo_list():
|
|
if repo['name'] == name and 'clone_progress' not in repo:
|
|
break
|
|
else:
|
|
raise Http404
|
|
|
|
if request.method == 'POST':
|
|
try:
|
|
gitweb.delete_repo(name)
|
|
messages.success(request, _('{name} deleted.').format(name=name))
|
|
except actions.ActionError as error:
|
|
messages.error(
|
|
request,
|
|
_('Could not delete {name}: {error}').format(
|
|
name=name, error=error),
|
|
)
|
|
gitweb.app.update_service_access()
|
|
|
|
return redirect(reverse_lazy('gitweb:index'))
|
|
|
|
return TemplateResponse(request, 'gitweb_delete.html', {
|
|
'title': gitweb.name,
|
|
'name': name
|
|
})
|