Sunil Mohan Adapa d4b21ef1e4
views: Use dedicated view when showing an app with operations
Closes: #2309.

- This prevents processing of AppView when the app is being uninstalled. For at
least two apps, this has failed because the AppView assumes that app and its
dependencies are installed.

- Use a dedicated template as well is simplify app template.

Tests:

- Installing and uninstalling an app works.

- Refreshing the app page during uninstall does not lead to an error for samba
and email apps.

- Unit tests pass.

- Functional tests for samba and email work.

Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
2023-01-30 20:08:11 -05:00

172 lines
5.9 KiB
Python

# SPDX-License-Identifier: AGPL-3.0-or-later
"""
Tests for samba views.
"""
import pathlib
import urllib
from unittest.mock import patch
import pytest
from django import urls
from django.contrib.messages.storage.fallback import FallbackStorage
from plinth import module_loader
from plinth.modules.samba import views
# For all tests, use plinth.urls instead of urls configured for testing
pytestmark = pytest.mark.urls('plinth.urls')
setfacl_path = pathlib.Path('/usr/bin/setfacl')
USERS = {"access_ok": ["testuser"], 'password_re_enter_needed': []}
DISKS = [{
'device': '/dev/sda1',
'label': '',
'filesystem_type': 'ext4',
'mount_point': '/',
'percent_used': 63,
'size_str': '9.5 GiB',
'used_str': '5.7 GiB'
}, {
'device': '/dev/sda2',
'label': '',
'filesystem_type': 'vfat',
'mount_point': '/boot/efi',
'percent_used': 50,
'size_str': '150 MiB',
'used_str': '75 MiB'
}]
SHARES = [
{
"name": "disk",
"mount_point": "/",
"path": "/var/lib/freedombox/shares/open_share",
"share_type": "open"
},
{
"name": "disk_home",
"mount_point": "/",
"path": "/var/lib/freedombox/shares/homes/%u",
"share_type": "home"
},
{
"name": "otherdisk",
"mount_point": "/media/root/otherdisk",
"path": "/media/root/otherdisk/FreedomBox/shares/homes/open_share",
"share_type": "open"
},
]
@pytest.fixture(autouse=True, scope='module')
def fixture_samba_urls():
"""Make sure samba app's URLs are part of plinth.urls."""
with patch('plinth.module_loader._modules_to_load', new=[]) as modules, \
patch('plinth.urls.urlpatterns', new=[]):
modules.append('plinth.modules.samba')
module_loader.include_urls()
yield
@pytest.fixture(autouse=True)
def samba_patch_privileged():
"""Patch privileged scripts runner."""
with patch('plinth.modules.samba.privileged.get_shares') as get_shares, \
patch('plinth.modules.samba.privileged.delete_share'):
get_shares.return_value = SHARES
yield
def make_request(request, view, **kwargs):
"""Make request with a message storage."""
setattr(request, 'session', 'session')
messages = FallbackStorage(request)
setattr(request, '_messages', messages)
response = view(request, **kwargs)
return response, messages
def test_samba_shares_view(rf):
"""Test that a share list has correct view data."""
with (patch('plinth.views.AppView.get_context_data',
return_value={'is_enabled': True}),
patch('plinth.modules.samba.get_users', return_value=USERS),
patch('plinth.modules.storage.get_mounts', return_value=DISKS),
patch('plinth.views.AppView.app', return_value=None)):
view = views.SambaAppView.as_view()
response, _ = make_request(rf.get(''), view)
assert response.context_data['disks'] == [DISKS[0]]
assert response.context_data['shared_mounts'] == {
'/': ['open', 'home'],
'/media/root/otherdisk': ['open']
}
assert response.context_data['unavailable_shares'] == [{
'mount_point': '/media/root/otherdisk',
'name': 'otherdisk',
'path': '/media/root/otherdisk/FreedomBox/shares/homes/open_share',
'share_type': 'open'
}]
assert response.context_data['users'] == USERS
assert response.status_code == 200
@pytest.mark.skipif(not setfacl_path.exists(), reason='setfacl not installed')
def test_enable_samba_share_view(rf):
"""Test that enabling share sends correct success message."""
form_data = {'filesystem_type': 'ext4', 'open_share': 'enable'}
mount_point = urllib.parse.quote('/')
response, messages = make_request(rf.post('', data=form_data), views.share,
mount_point=mount_point)
assert list(messages)[0].message == 'Share enabled.'
assert response.status_code == 302
assert response.url == urls.reverse('samba:index')
def test_enable_samba_share_failed_view(rf):
"""Test that share enabling failure sends correct error message."""
form_data = {'filesystem_type': 'ext4', 'open_share': 'enable'}
mount_point = urllib.parse.quote('/')
error_message = 'Sharing failed'
with patch('plinth.modules.samba.add_share',
side_effect=RuntimeError(error_message)):
response, messages = make_request(rf.post('', data=form_data),
views.share, mount_point=mount_point)
assert list(messages)[0].message == 'Error enabling share: {0}'.format(
error_message)
assert response.status_code == 302
assert response.url == urls.reverse('samba:index')
def test_disable_samba_share(rf):
"""Test that enabling share sends correct success message."""
form_data = {'filesystem_type': 'ext4', 'open_share': 'disable'}
mount_point = urllib.parse.quote('/')
response, messages = make_request(rf.post('', data=form_data), views.share,
mount_point=mount_point)
assert list(messages)[0].message == 'Share disabled.'
assert response.status_code == 302
assert response.url == urls.reverse('samba:index')
def test_disable_samba_share_failed_view(rf):
"""Test that share disabling failure sends correct error message."""
form_data = {'filesystem_type': 'ext4', 'open_share': 'disable'}
mount_point = urllib.parse.quote('/')
error_message = 'Unsharing failed'
with patch('plinth.modules.samba.privileged.delete_share',
side_effect=RuntimeError(error_message)):
response, messages = make_request(rf.post('', data=form_data),
views.share, mount_point=mount_point)
assert list(messages)[
0].message == 'Error disabling share: {0}'.format(error_message)
assert response.status_code == 302
assert response.url == urls.reverse('samba:index')