mirror of
https://github.com/freedombox/FreedomBox.git
synced 2026-02-04 08:13:38 +00:00
83cb305026
- new share types - group and home shares - users: when creating, deleting or changing user password, update also Samba tdbsam backend database - users: new managed packages - samba-common-bin, tdb-tools - module page: show current samba users who are in freedombox-share group - module page: show users who should re-enter their password in the password change page - fix: use os.path.ismount() from Python standard library to validate a mount point - fix: samba share permissions, fixes #1729 - fix: delete a share - do not raise an exception if the share doesn't exist - storage: show samba share type in the directory selection form Closes #1727 Signed-off-by: Veiko Aasa <veiko17@disroot.org> Reviewed-by: James Valleroy <jvalleroy@mailbox.org>
116 lines
3.8 KiB
Python
116 lines
3.8 KiB
Python
#
|
|
# This file is part of FreedomBox.
|
|
#
|
|
# This program is free software: you can redistribute it and/or modify
|
|
# it under the terms of the GNU Affero General Public License as
|
|
# published by the Free Software Foundation, either version 3 of the
|
|
# License, or (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU Affero General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU Affero General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
#
|
|
"""
|
|
Views for samba module.
|
|
"""
|
|
|
|
import logging
|
|
import urllib.parse
|
|
from collections import defaultdict
|
|
|
|
from django.contrib import messages
|
|
from django.shortcuts import redirect
|
|
from django.urls import reverse
|
|
from django.utils.translation import ugettext as _
|
|
from django.views.decorators.http import require_POST
|
|
|
|
from plinth import views
|
|
from plinth.errors import ActionError
|
|
from plinth.modules import samba, storage
|
|
|
|
logger = logging.getLogger(__name__)
|
|
|
|
|
|
class SambaAppView(views.AppView):
|
|
"""Samba sharing basic configuration."""
|
|
name = samba.name
|
|
description = samba.description
|
|
diagnostics_module_name = 'samba'
|
|
app_id = 'samba'
|
|
template_name = 'samba.html'
|
|
icon_filename = samba.icon_filename
|
|
|
|
def get_context_data(self, *args, **kwargs):
|
|
"""Return template context data."""
|
|
context = super().get_context_data(*args, **kwargs)
|
|
disks = storage.get_disks()
|
|
shares = samba.get_shares()
|
|
|
|
for disk in disks:
|
|
disk['name'] = samba.disk_name(disk['mount_point'])
|
|
context['disks'] = disks
|
|
|
|
shared_mounts = defaultdict(list)
|
|
for share in shares:
|
|
shared_mounts[share['mount_point']].append(share['share_type'])
|
|
context['shared_mounts'] = shared_mounts
|
|
|
|
context['share_types'] = [('open', _('Open Share')),
|
|
('group', _('Group Share')),
|
|
('home', _('Home Share'))]
|
|
|
|
unavailable_shares = []
|
|
for share in shares:
|
|
for disk in disks:
|
|
if share['mount_point'] == disk['mount_point']:
|
|
break
|
|
else:
|
|
unavailable_shares.append(share)
|
|
context['unavailable_shares'] = unavailable_shares
|
|
|
|
context['users'] = samba.get_users()
|
|
|
|
return context
|
|
|
|
|
|
@require_POST
|
|
def share(request, mount_point):
|
|
"""Enable sharing, given its root path.
|
|
|
|
mount_point is urlquoted.
|
|
|
|
"""
|
|
mount_point = urllib.parse.unquote(mount_point)
|
|
filesystem = request.POST.get('filesystem_type', '')
|
|
|
|
share_types = ['open', 'group', 'home']
|
|
|
|
for share_type in share_types:
|
|
action = request.POST.get(share_type + '_share', '')
|
|
if action == 'enable':
|
|
try:
|
|
samba.add_share(mount_point, share_type, filesystem)
|
|
messages.success(request, _('Share enabled.'))
|
|
except ActionError as exception:
|
|
logger.exception('Error enabling share')
|
|
messages.error(
|
|
request,
|
|
_('Error enabling share: {error_message}').format(
|
|
error_message=exception))
|
|
elif action == 'disable':
|
|
try:
|
|
samba.delete_share(mount_point, share_type)
|
|
messages.success(request, _('Share disabled.'))
|
|
except ActionError as exception:
|
|
logger.exception('Error disabling share')
|
|
messages.error(
|
|
request,
|
|
_('Error disabling share: {error_message}').format(
|
|
error_message=exception))
|
|
|
|
return redirect(reverse('samba:index'))
|