mirror of
https://github.com/freedombox/FreedomBox.git
synced 2026-01-21 07:55:00 +00:00
f8f7dd22b5
- It is simpler to keep all the configuration in a single file. Any overrides are expected to be done by writing additional configuration files with higher priority. - /etc/apache2/site-available/ is typically reserved for virtual host configurations. Redirections and proxying for all virtual hosts rather belongs in /etc/apache2/conf-available/. - This looses the option of disabling plinth-ssl.conf when needed. In the initial days of enabling TLS, there was a need felt to keep the option of easily disabling redirection to TLS in case there is a need for it. However, TLS certificate setup is mature and the limitations are well understood. There is no longer a need for it. It still may be possible to avoid the redirection with an additional configuration. Tests: - In a fresh container, setup succeeds. Redirecting to https:// for /plinth works. FreedomBox web interface is available. - Without the patch applied created a container. Run setup and access Plinth interface. Apply the patches. Apache setup is run. a2query -s plinth and a2query -s plinth-ssl show that sites are not enabled. Redirecting to https:// for /plinth works. FreedomBox web interface is available. Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org> Reviewed-by: James Valleroy <jvalleroy@mailbox.org>