Joseph Nuthalapati 6dd6f12f5a
kiwix: Use new utility for handling uploads
Earlier, the uploaded ZIM file was being written to disk twice.

Manual Test
-----------
Without the changes in this commit, the English MediaWiki archive of
6.83 GB cannot be uploaded to the dev container of size 12 GB, since two
temporary files are created.

With the changes in this commit, the same file can be uploaded
successfully and accessed using Kiwix reader.

- Uploaded file has expected ownership and permissions.

Signed-off-by: Joseph Nuthalapati <njoseph@riseup.net>
[sunil: Handle error for uploading duplicate content.]
[sunil: Set root:root ownership on the uploaded file.]
[sunil: Use the action utility for checking that the upload file and moving it.]
Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org>
Reviewed-by: Veiko Aasa <veiko17@disroot.org>
2024-10-03 11:45:15 +03:00

109 lines
3.5 KiB
Python

# SPDX-License-Identifier: AGPL-3.0-or-later
"""
Views for the Kiwix module.
"""
import logging
from django.contrib import messages
from django.contrib.messages.views import SuccessMessageMixin
from django.http import Http404
from django.shortcuts import redirect
from django.template.response import TemplateResponse
from django.urls import reverse_lazy
from django.utils.translation import gettext as _
from django.views.generic.edit import FormView
from plinth import app as app_module
from plinth import views
from plinth.errors import PlinthError
from plinth.modules import storage
from plinth.modules.kiwix import privileged
from plinth.views import messages_error
from . import forms
logger = logging.getLogger(__name__)
class KiwixAppView(views.AppView):
"""Serve configuration form."""
app_id = 'kiwix'
template_name = 'kiwix.html'
def get_context_data(self, **kwargs):
"""Return additional context for rendering the template."""
context = super().get_context_data(**kwargs)
context['packages'] = privileged.list_packages()
return context
class AddPackageView(SuccessMessageMixin, FormView):
"""View to add content package in the form of ZIM files."""
form_class = forms.AddPackageForm
prefix = 'kiwix'
template_name = 'kiwix-add-package.html'
success_url = reverse_lazy('kiwix:index')
success_message = _('Content package added.')
def get_context_data(self, **kwargs):
"""Return additional context for rendering the template."""
context = super().get_context_data(**kwargs)
context['title'] = _('Add a new content package')
# TODO The following is almost duplicated in backups/views.py
try:
mount_info = storage.get_mount_info('/')
except PlinthError as exception:
logger.exception(
'Error getting information about root partition: %s',
exception)
else:
context['max_filesize'] = storage.format_bytes(
mount_info['free_bytes'])
return context
def form_valid(self, form):
"""Store the uploaded file."""
try:
uploaded_file = self.request.FILES['kiwix-file']
privileged.add_package(uploaded_file.name,
uploaded_file.temporary_file_path())
except FileExistsError:
messages.error(self.request, _('Content package already exists.'))
return redirect(reverse_lazy('kiwix:index'))
except Exception as exception:
messages_error(self.request, _('Failed to add content package.'),
exception)
return redirect(reverse_lazy('kiwix:index'))
return super().form_valid(form)
def delete_package(request, zim_id):
"""View to delete a library."""
packages = privileged.list_packages()
if zim_id not in packages:
raise Http404
name = packages[zim_id]['title']
if request.method == 'POST':
try:
privileged.delete_package(zim_id)
messages.success(request, _('{name} deleted.').format(name=name))
except Exception as error:
messages.error(
request,
_('Could not delete {name}: {error}').format(
name=name, error=error))
return redirect(reverse_lazy('kiwix:index'))
return TemplateResponse(request, 'kiwix-delete-package.html', {
'title': app_module.App.get('kiwix').info.name,
'name': name
})