mirror of
https://github.com/freedombox/FreedomBox.git
synced 2026-01-28 08:03:36 +00:00
Closes: #1782. This restores the API to the earlier behavior of ignoring errors when firewalld is not running. This may not be the best approach however. - Ignore errors on all operations when firewalld is not running. This include enable/disable service, list interfaces of a zone, get service ports and get enabled service. - Log errors when firewalld is not running. - ALREADY_ENABLE and NOT_ENABLED errors already ignored during enable/disable service operations respectively. Tests successfully executed: - Turn off firewalld and perform following operations. They should all log an error that firewalld is not running. - Visit app page of an app that works only on internal networks such as Privoxy. It should show that there are no internal networks. - Run diagnostics of an app. It should show ports for a service as empty list. - Enable/disable an app, it should enable/disable without failure. - Visit firewall app page. It should show that firewalld is not running. - Perform all the about operations without error message showing up and with expected results. Signed-off-by: Sunil Mohan Adapa <sunil@medhas.org> Reviewed-by: Veiko Aasa <veiko17@disroot.org>