mirror of
https://github.com/permissionlesstech/bitchat-android.git
synced 2026-08-08 06:46:11 +00:00
Merge pull request #852 from permissionlesstech/codex/fix-readme-screenshot-crop-20260801
Fix cropped README screenshot controls
This commit is contained in:
commit
28bd6bdcfd
@ -152,6 +152,10 @@ animations, incomplete placement, or media that has not finished decoding.
|
||||
Crop only Android system chrome. Preserve Bitchat's app header, translucent
|
||||
overlap, content, and composer. Derive the crop from the observed status and
|
||||
navigation insets; do not blindly reuse pixel offsets from a different profile.
|
||||
Because the app renders edge-to-edge, app controls may extend into the reported
|
||||
navigation inset. Place the bottom crop after the final control outline and
|
||||
shadow but before the system gesture affordance; removing the entire inset can
|
||||
clip the app itself.
|
||||
Keep every final README screenshot in a matched portrait size.
|
||||
|
||||
Use image inspection after the crop. File dimensions and a successful ADB
|
||||
|
||||
@ -40,6 +40,20 @@
|
||||
"Uses the PR merge-base and paired before/after capture workflow.",
|
||||
"Publishes only the requested PR comment rather than opening an unrelated screenshot PR."
|
||||
]
|
||||
},
|
||||
{
|
||||
"id": 4,
|
||||
"prompt": "The bottom of one or both README showcase screenshots is cropped. Correct the images without changing their content, update the screenshot skill so this does not recur, and open a new PR.",
|
||||
"expected_output": "The agent inspects both merged assets at full size, identifies every affected screen, recaptures from the real app with the existing deterministic fixtures, and treats the navigation inset as an inspection region rather than an automatic crop. The final crop preserves complete app controls while excluding the system gesture affordance, keeps the pair matched, adds a reusable edge-to-edge guardrail to the skill, validates and visually inspects both images, and opens a sanitized PR.",
|
||||
"files": [],
|
||||
"expectations": [
|
||||
"Inspects both screenshots and corrects every affected asset rather than assuming only one is cropped.",
|
||||
"Recaptures the real app with the established deterministic synthetic content instead of padding or compositing the merged PNGs.",
|
||||
"Uses accessibility bounds and full-size pixel inspection to place the bottom crop after complete app controls and before system gesture chrome.",
|
||||
"Verifies the entire chat composer border and bottom padding plus every globe action-button corner and shadow are visible.",
|
||||
"Keeps paired screenshots at identical dimensions and passes the screenshot validator and clean debug build.",
|
||||
"Updates the skill with a general edge-to-edge crop rule and publishes no device or machine identifiers."
|
||||
]
|
||||
}
|
||||
]
|
||||
}
|
||||
|
||||
@ -222,6 +222,12 @@ Reject the capture when:
|
||||
Capture the full physical screen first. Determine the status-bar and
|
||||
navigation-bar insets from the current profile, then crop those insets only.
|
||||
|
||||
Treat the navigation inset as an inspection region, not an automatic crop
|
||||
amount. Bitchat uses edge-to-edge layout, so the composer's border, globe-button
|
||||
corners, or their shadows may occupy part of that region. Use accessibility
|
||||
bounds plus full-size pixel inspection to place the crop below every app
|
||||
control and above the system gesture affordance.
|
||||
|
||||
Treat previously observed crop offsets as local evidence, not as a universal
|
||||
rule or repository documentation. Re-measure when the profile changes.
|
||||
|
||||
@ -244,6 +250,7 @@ Every paired README image should:
|
||||
- [ ] Waveforms were extracted from real speech audio and look distinct.
|
||||
- [ ] Final reaction is visible above the composer.
|
||||
- [ ] Header peer count and nickname are synthetic and intentional.
|
||||
- [ ] The complete composer border and bottom padding are visible.
|
||||
|
||||
### Globe
|
||||
|
||||
@ -252,6 +259,7 @@ Every paired README image should:
|
||||
- [ ] Whole Earth and grid are visible.
|
||||
- [ ] Selected cell and crosshair are legible.
|
||||
- [ ] Hint and precision controls are unobstructed.
|
||||
- [ ] Every action-button corner and shadow is fully visible.
|
||||
|
||||
### Repository
|
||||
|
||||
|
||||
Binary file not shown.
|
Before Width: | Height: | Size: 910 KiB After Width: | Height: | Size: 919 KiB |
Binary file not shown.
|
Before Width: | Height: | Size: 1.3 MiB After Width: | Height: | Size: 1.3 MiB |
Loading…
x
Reference in New Issue
Block a user