nik/bitchat-android
1
0
Fork 0
mirror of https://github.com/permissionlesstech/bitchat-android.git synced 2026-09-19 04:59:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Reject signed and non-ASCII hexadecimal byte chunks

Browse Source
This commit is contained in:
Taksh 2026-09-12 12:21:04 +05:30
parent 53fdacca83
commit 3754d416d2
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
app/src/main/java/com/bitchat/android/util/BinaryEncodingUtils.kt
View File

@ -27,7 +27,8 @@ fun String.dataFromHexString(): ByteArray? {
if (hex.isEmpty()) {
return ByteArray(0)
}
if (hex.length % 2 != 0) {
// Radix parsing accepts signs and Unicode digits; encoded bytes require ASCII hex.
if (hex.length % 2 != 0 || hex.any { it !in '0'..'9' && it !in 'a'..'f' && it !in 'A'..'F' }) {
return null
}

7
app/src/test/java/com/bitchat/android/util/HexStringTest.kt
View File

@ -48,6 +48,13 @@ class HexStringTest {
assertNull("0xgg".dataFromHexString())
}
@Test
fun `rejects signed byte chunks and non-ascii digits`() {
for (invalid in listOf("0x-1", "0x+1", "-1", "+1", "00-1", "0X+100", "０１")) {
assertNull(invalid.dataFromHexString())
}
}
@Test
fun `round-trips with hexEncodedString`() {
val original = byteArrayOf(0x00, 0x7f, 0xff.toByte())