nik/bitchat
1
0
Fork 0
mirror of https://github.com/permissionlesstech/bitchat.git synced 2026-10-18 07:33:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: drop the swipe gesture during playback instead of ignoring it

Browse Source 
The guard in onEnded prevented the conversation from being left, but the
scrub was still lost: an armed .highPriorityGesture starves its
descendants at recognition time, long before either gesture ends, so the
waveform's seek never saw the drag.

The gesture is now attached with `including: .subviews` while a note is
audible, which yields recognition to the waveform. The onEnded guard
stays as the second line of defence for a drag already in flight when
playback starts.
This commit is contained in:
Taksh 2026-08-17 10:48:29 +05:30
parent ca15f66080
commit 2da25a9d9e
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
bitchat/Views/ContentSheetViews.swift
View File

@ -462,6 +462,9 @@ private extension ContentPeopleListView {
private struct ContentPrivateChatSheetView: View {
@EnvironmentObject private var privateConversationModel: PrivateConversationModel
/// Observed so the swipe gesture can be dropped for the duration of
/// playback rather than merely declining to act when it ends.
@ObservedObject private var playbackCoordinator = VoiceNotePlaybackCoordinator.shared
@Binding var showSidebar: Bool
@Binding var messageText: String
@ -572,7 +575,14 @@ private struct ContentPrivateChatSheetView: View {
// whole sheet it preempted the composer's press-and-hold mic
// gesture (a high-priority ancestor drag cancels child gestures
// within milliseconds — same starvation as the image-reveal bug).
.highPriorityGesture(swipeToLeaveGesture)
// `.subviews` while a note is audible: recognition then belongs to
// the waveform's seek drag. Guarding in `onEnded` is not enough --
// an armed high-priority ancestor drag starves its descendants
// before either gesture ends, so the scrub would still be lost.
.highPriorityGesture(
swipeToLeaveGesture,
including: playbackCoordinator.hasActivePlayback ? .subviews : .all
)
if !theme.usesGlassChrome {
Divider()