diff --git a/bitchat/Utils/MessageDeduplicator.swift b/bitchat/Utils/MessageDeduplicator.swift index d2fc489d..66bab3c7 100644 --- a/bitchat/Utils/MessageDeduplicator.swift +++ b/bitchat/Utils/MessageDeduplicator.swift @@ -16,6 +16,7 @@ final class MessageDeduplicator { private let lock = NSLock() private let maxAge: TimeInterval private let maxCount: Int + private let dateProvider: () -> Date /// Initialize with default config from TransportConfig convenience init() { @@ -26,9 +27,14 @@ final class MessageDeduplicator { } /// Initialize with custom config for content deduplication - init(maxAge: TimeInterval, maxCount: Int) { + init( + maxAge: TimeInterval, + maxCount: Int, + dateProvider: @escaping () -> Date = Date.init + ) { self.maxAge = maxAge self.maxCount = maxCount + self.dateProvider = dateProvider } /// Check if message is duplicate and add if not. @@ -38,7 +44,7 @@ final class MessageDeduplicator { lock.lock() defer { lock.unlock() } - let now = Date() + let now = dateProvider() cleanupOldEntries(before: now.addingTimeInterval(-maxAge)) if lookup[id] != nil { @@ -57,7 +63,7 @@ final class MessageDeduplicator { lock.lock() defer { lock.unlock() } - let now = Date() + let now = dateProvider() cleanupOldEntries(before: now.addingTimeInterval(-maxAge)) if lookup[id] == nil { @@ -109,7 +115,7 @@ final class MessageDeduplicator { lock.lock() defer { lock.unlock() } - cleanupOldEntries(before: Date().addingTimeInterval(-maxAge)) + cleanupOldEntries(before: dateProvider().addingTimeInterval(-maxAge)) // Shrink capacity if significantly oversized if entries.capacity > maxCount * 2 && entries.count < maxCount { diff --git a/bitchatTests/MessageDeduplicatorTests.swift b/bitchatTests/MessageDeduplicatorTests.swift index 6db1117d..af7d29cc 100644 --- a/bitchatTests/MessageDeduplicatorTests.swift +++ b/bitchatTests/MessageDeduplicatorTests.swift @@ -13,7 +13,12 @@ import Testing @Suite("Message Deduplicator") struct MessageDeduplicatorTests { @Test func markProcessed_enforcesMaximumCount() { - let deduplicator = MessageDeduplicator(maxAge: 300, maxCount: 4) + let now = Date(timeIntervalSince1970: 1_000) + let deduplicator = MessageDeduplicator( + maxAge: 300, + maxCount: 4, + dateProvider: { now } + ) for id in ["a", "b", "c", "d", "e"] { deduplicator.markProcessed(id) @@ -26,11 +31,16 @@ struct MessageDeduplicatorTests { #expect(deduplicator.contains("e")) } - @Test func markProcessed_cleansExpiredEntriesBeforeCountTrim() async { - let deduplicator = MessageDeduplicator(maxAge: 0.1, maxCount: 4) + @Test func markProcessed_cleansExpiredEntriesBeforeCountTrim() { + var now = Date(timeIntervalSince1970: 1_000) + let deduplicator = MessageDeduplicator( + maxAge: 300, + maxCount: 4, + dateProvider: { now } + ) deduplicator.markProcessed("expired") - try? await Task.sleep(nanoseconds: 200_000_000) + now.addTimeInterval(301) for id in ["b", "c", "d", "e"] { deduplicator.markProcessed(id)