.github/workflows/fetch_georelays.yml

@@ -1,228 +1,42 @@
-name: Propose GeoRelay Data Update
+name: Fetch GeoRelays Data
 
 on:
   schedule:
-    - cron: "0 6 * * 0"
+    - cron: '0 6 * * 0'
   workflow_dispatch:
 
-# Default to read-only. The publishing job receives only the scopes required
-# to push its branch and publish either a PR or a tracking issue.
 permissions:
-  contents: read
-
-concurrency:
-  group: georelay-data-update
-  cancel-in-progress: false
-
-env:
-  SOURCE_REPOSITORY: https://github.com/permissionlesstech/georelays.git
-  UPDATE_BRANCH: automation/georelay-data
-  TRACKING_ISSUE_TITLE: GeoRelay update awaiting pull request
+  contents: write
+  pull-requests: write
 
 jobs:
-  propose-relay-data:
-    name: Validate and propose relay data
+  update-relay-data:
     runs-on: ubuntu-latest
-    timeout-minutes: 10
-    permissions:
-      contents: write
-      pull-requests: write
-      issues: write
 
     steps:
-      - name: Checkout reviewed base
-        # Pinned actions/checkout v5 so a mutable action tag cannot change the
-        # code that receives this job's write-capable token.
-        uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd
+      - name: Checkout repository
+        uses: actions/checkout@v4
         with:
-          ref: main
+          token: ${{ secrets.GITHUB_TOKEN }}
           fetch-depth: 0
-          # Do not expose the write token to fetch/validation subprocesses.
-          persist-credentials: false
 
-      - name: Test GeoRelay validator
+      - name: Fetch GeoRelays
         run: |
-          set -euo pipefail
-          python3 -m unittest discover -s scripts/tests -p "test_*.py" -v
+          wget -q https://raw.githubusercontent.com/permissionlesstech/georelays/refs/heads/main/nostr_relays.csv
+          mv nostr_relays.csv ./relays/online_relays_gps.csv
 
-      - name: Fetch candidate over pinned HTTPS policy
-        id: upstream
+      - name: Check for changes
+        id: git-check
         run: |
-          set -euo pipefail
-          source_commit=$(git ls-remote --refs "$SOURCE_REPOSITORY" refs/heads/main | awk 'NR == 1 { print $1 }')
-          if [[ ! "$source_commit" =~ ^[0-9a-f]{40}$ ]]; then
-            echo "::error::Could not resolve an immutable upstream commit"
-            exit 1
-          fi
-          source_url="https://raw.githubusercontent.com/permissionlesstech/georelays/$source_commit/nostr_relays.csv"
-          effective_url=$(curl --fail --show-error --silent --location --proto "=https" --proto-redir "=https" --tlsv1.2 --max-time 60 --retry 3 --retry-all-errors --output "$RUNNER_TEMP/georelays-candidate.csv" --write-out "%{url_effective}" "$source_url")
-          if [[ "$effective_url" != "$source_url" ]]; then
-            echo "::error::Unexpected GeoRelay redirect target: $effective_url"
-            exit 1
-          fi
-          echo "source_commit=$source_commit" >> "$GITHUB_OUTPUT"
-          echo "source_url=$source_url" >> "$GITHUB_OUTPUT"
-
-      - name: Validate candidate against reviewed baseline
-        id: validation
+          git diff --exit-code || echo "changes=true" >> $GITHUB_OUTPUT
+    
+      - name: Commit and push changes
+        if: steps.git-check.outputs.changes == 'true'
         run: |
-          set -euo pipefail
-          python3 scripts/validate_georelays.py --input "$RUNNER_TEMP/georelays-candidate.csv" --baseline relays/online_relays_gps.csv --output relays/online_relays_gps.csv --github-output "$GITHUB_OUTPUT"
-
-      - name: Check for a reviewed-file change
-        id: changes
-        run: |
-          set -euo pipefail
-          if git diff --quiet -- relays/online_relays_gps.csv; then
-            echo "changed=false" >> "$GITHUB_OUTPUT"
-            echo "Upstream GeoRelay data already matches main." >> "$GITHUB_STEP_SUMMARY"
-          else
-            echo "changed=true" >> "$GITHUB_OUTPUT"
-            git diff --stat -- relays/online_relays_gps.csv
-          fi
-
-      - name: Push automation branch and publish review request
-        if: steps.changes.outputs.changed == 'true'
+          git config --local user.email "action@github.com"
+          git config --local user.name "GitHub Action"
+          git add relays/online_relays_gps.csv
+          git commit -m "Automated update of relay data - $(date -u)"
+          git push
         env:
-          GH_TOKEN: ${{ github.token }}
-          SOURCE_COMMIT: ${{ steps.upstream.outputs.source_commit }}
-          SOURCE_URL: ${{ steps.upstream.outputs.source_url }}
-          DATA_ROWS: ${{ steps.validation.outputs.data_rows }}
-          UNIQUE_RELAYS: ${{ steps.validation.outputs.unique_relays }}
-          DATA_SHA256: ${{ steps.validation.outputs.sha256 }}
-        run: |
-          set -euo pipefail
-
-          # Scope credential exposure to this final publishing step.
-          gh auth setup-git
-          git config user.name "github-actions[bot]"
-          git config user.email "41898282+github-actions[bot]@users.noreply.github.com"
-
-          git switch -C "$UPDATE_BRANCH"
-          git add -- relays/online_relays_gps.csv
-          git diff --cached --quiet && {
-            echo "::error::Expected a staged GeoRelay data change"
-            exit 1
-          }
-          git commit -m "Update reviewed georelay directory" -m "Upstream-commit: $SOURCE_COMMIT"
-
-          remote_ref="refs/remotes/origin/$UPDATE_BRANCH"
-          if git fetch --no-tags origin "+refs/heads/$UPDATE_BRANCH:$remote_ref" 2>/dev/null; then
-            remote_sha=$(git rev-parse "$remote_ref")
-            git push --force-with-lease="refs/heads/$UPDATE_BRANCH:$remote_sha" origin "HEAD:refs/heads/$UPDATE_BRANCH"
-          else
-            git push origin "HEAD:refs/heads/$UPDATE_BRANCH"
-          fi
-
-          body_file="$RUNNER_TEMP/georelay-pr-body.md"
-          {
-            echo "## Automated GeoRelay data proposal"
-            echo
-            echo "- Source: $SOURCE_URL"
-            echo "- Upstream commit: $SOURCE_COMMIT"
-            echo "- Data rows: $DATA_ROWS"
-            echo "- Unique normalized relays: $UNIQUE_RELAYS"
-            echo "- SHA-256: $DATA_SHA256"
-            echo
-            echo "The candidate passed strict UTF-8, schema, size, row-count, secure-host, coordinate, duplicate-conflict, and baseline-delta validation."
-            echo
-            echo "This PR is intentionally not auto-merged. Review the relay additions/removals before merging."
-          } > "$body_file"
-
-          existing_pr=$(gh pr list --repo "$GITHUB_REPOSITORY" --state open --base main --head "$UPDATE_BRANCH" --json number --jq '.[0].number // empty')
-          pr_error="$RUNNER_TEMP/georelay-pr-error.txt"
-          pr_url=""
-          if [[ -n "$existing_pr" ]]; then
-            if gh pr edit "$existing_pr" --repo "$GITHUB_REPOSITORY" --title "Update reviewed GeoRelay directory" --body-file "$body_file" 2> "$pr_error"; then
-              pr_url=$(gh pr view "$existing_pr" --repo "$GITHUB_REPOSITORY" --json url --jq .url)
-            fi
-          else
-            if created_pr_url=$(gh pr create --repo "$GITHUB_REPOSITORY" --base main --head "$UPDATE_BRANCH" --title "Update reviewed GeoRelay directory" --body-file "$body_file" 2> "$pr_error"); then
-              pr_url="$created_pr_url"
-            fi
-          fi
-
-          tracking_issue_numbers=$(gh issue list --repo "$GITHUB_REPOSITORY" --state open --search "\"$TRACKING_ISSUE_TITLE\" in:title" --limit 100 --json number,title --jq ".[] | select(.title == \"$TRACKING_ISSUE_TITLE\") | .number")
-          tracking_issues=()
-          if [[ -n "$tracking_issue_numbers" ]]; then
-            mapfile -t tracking_issues <<< "$tracking_issue_numbers"
-          fi
-
-          if [[ -n "$pr_url" ]]; then
-            for issue_number in "${tracking_issues[@]}"; do
-              gh issue close "$issue_number" --repo "$GITHUB_REPOSITORY" --comment "A pull request is now available at $pr_url; closing this fallback tracking issue."
-            done
-            echo "Published GeoRelay review PR: $pr_url" >> "$GITHUB_STEP_SUMMARY"
-            exit 0
-          fi
-
-          echo "::warning::GITHUB_TOKEN could not create or update the GeoRelay pull request; publishing the issues-write fallback."
-          if [[ -s "$pr_error" ]]; then
-            cat "$pr_error" >&2
-          fi
-
-          compare_url="https://github.com/${GITHUB_REPOSITORY}/compare/main...${UPDATE_BRANCH}?expand=1"
-          issue_body_file="$RUNNER_TEMP/georelay-tracking-issue-body.md"
-          {
-            echo "## Validated GeoRelay update awaiting review"
-            echo
-            echo "The automation branch was updated, but this workflow token could not create or update the pull request. Use the compare link below to create it manually."
-            echo
-            echo "- Compare and create PR: $compare_url"
-            echo "- Automation branch: $UPDATE_BRANCH"
-            echo "- Source: $SOURCE_URL"
-            echo "- Upstream commit: $SOURCE_COMMIT"
-            echo "- Data rows: $DATA_ROWS"
-            echo "- Unique normalized relays: $UNIQUE_RELAYS"
-            echo "- SHA-256: $DATA_SHA256"
-            echo
-            echo "The snapshot passed the repository's strict validator before the branch was pushed."
-          } > "$issue_body_file"
-
-          if (( ${#tracking_issues[@]} > 0 )); then
-            primary_issue="${tracking_issues[0]}"
-            gh issue edit "$primary_issue" --repo "$GITHUB_REPOSITORY" --title "$TRACKING_ISSUE_TITLE" --body-file "$issue_body_file"
-            issue_url=$(gh issue view "$primary_issue" --repo "$GITHUB_REPOSITORY" --json url --jq .url)
-            for duplicate_issue in "${tracking_issues[@]:1}"; do
-              gh issue close "$duplicate_issue" --repo "$GITHUB_REPOSITORY" --comment "Closing duplicate GeoRelay automation tracking issue; #$primary_issue is canonical."
-            done
-          else
-            issue_url=$(gh issue create --repo "$GITHUB_REPOSITORY" --title "$TRACKING_ISSUE_TITLE" --body-file "$issue_body_file")
-          fi
-
-          # Do not claim success until the fallback issue was confirmed.
-          [[ -n "$issue_url" ]]
-          echo "Published GeoRelay tracking issue fallback: $issue_url" >> "$GITHUB_STEP_SUMMARY"
-
-      - name: Clean obsolete automation review state
-        if: steps.changes.outputs.changed == 'false'
-        env:
-          GH_TOKEN: ${{ github.token }}
-        run: |
-          set -euo pipefail
-          gh auth setup-git
-
-          existing_pr=$(gh pr list --repo "$GITHUB_REPOSITORY" --state open --base main --head "$UPDATE_BRANCH" --json number --jq '.[0].number // empty')
-          if [[ -n "$existing_pr" ]]; then
-            gh pr close "$existing_pr" --repo "$GITHUB_REPOSITORY" --comment "Upstream now matches the reviewed file on main; closing this obsolete automation proposal."
-            echo "Closed obsolete PR #$existing_pr." >> "$GITHUB_STEP_SUMMARY"
-          fi
-
-          tracking_issue_numbers=$(gh issue list --repo "$GITHUB_REPOSITORY" --state open --search "\"$TRACKING_ISSUE_TITLE\" in:title" --limit 100 --json number,title --jq ".[] | select(.title == \"$TRACKING_ISSUE_TITLE\") | .number")
-          if [[ -n "$tracking_issue_numbers" ]]; then
-            while IFS= read -r issue_number; do
-              gh issue close "$issue_number" --repo "$GITHUB_REPOSITORY" --comment "Upstream now matches the reviewed file on main; closing this obsolete automation tracker."
-              echo "Closed obsolete tracking issue #$issue_number." >> "$GITHUB_STEP_SUMMARY"
-            done <<< "$tracking_issue_numbers"
-          fi
-
-          if git ls-remote --exit-code --heads origin "refs/heads/$UPDATE_BRANCH" > /dev/null; then
-            git push origin --delete "$UPDATE_BRANCH"
-            echo "Deleted obsolete automation branch $UPDATE_BRANCH." >> "$GITHUB_STEP_SUMMARY"
-          else
-            ls_remote_status=$?
-            if (( ls_remote_status != 2 )); then
-              echo "::error::Could not inspect the obsolete automation branch"
-              exit "$ls_remote_status"
-            fi
-          fi
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/periphery.yml

@@ -11,11 +11,9 @@ jobs:
     name: Periphery scan
     runs-on: macos-latest
     timeout-minutes: 30
-    # Blocking, like SwiftLint since #1646. The baseline (committed July 8)
-    # has been stable across a month of merges — the "drop continue-on-error
-    # once the baseline proves stable" condition this job shipped with is met.
-    # Known macOS-scan false positives stay suppressed by the baseline; only
-    # NEW dead code fails the job (--strict below).
+    # Advisory, like SwiftLint (#1361): findings annotate the PR but don't
+    # block merges. Drop continue-on-error once the baseline proves stable.
+    continue-on-error: true
 
     steps:
       - name: Checkout code

.github/workflows/source-manifest.yml

@@ -1,112 +0,0 @@
-name: Source manifest
-
-# Publishes a hash manifest for every tagged release so a copy of the source
-# obtained from somewhere other than this repository can be checked against it.
-#
-# This exists because the repository has been the target of takedown demands.
-# When that succeeds, mirrors appear, and without a manifest there is no way to
-# tell a faithful mirror from a modified one. The manifest is attested to this
-# workflow run, so its own provenance is verifiable with `gh attestation verify`.
-#
-# Scope, stated plainly: this verifies SOURCE. It does not verify any compiled
-# app. See docs/VERIFYING-A-BUILD.md.
-
-on:
-  push:
-    tags:
-      - 'v*'
-  workflow_dispatch:
-    inputs:
-      ref:
-        description: 'Tag or commit to produce a manifest for'
-        required: true
-
-permissions:
-  contents: read
-
-jobs:
-  manifest:
-    runs-on: ubuntu-latest
-    permissions:
-      contents: write      # attach the manifest to the release
-      id-token: write      # provenance attestation
-      attestations: write
-    steps:
-      - uses: actions/checkout@v4
-        with:
-          ref: ${{ github.event.inputs.ref || github.ref }}
-          # Full history so the commit the tag names can be recorded exactly.
-          fetch-depth: 0
-
-      - name: Build manifest
-        id: build
-        run: |
-          set -euo pipefail
-          ref_name="${{ github.event.inputs.ref || github.ref_name }}"
-          commit="$(git rev-parse HEAD)"
-          tree="$(git rev-parse HEAD^{tree})"
-
-          # Hash every tracked file, in a stable order, with NUL separation so
-          # paths containing spaces or newlines cannot shift the columns.
-          git ls-files -z \
-            | sort -z \
-            | xargs -0 sha256sum \
-            > files.sha256
-
-          {
-            echo "# bitchat source manifest"
-            echo "#"
-            echo "# ref:    ${ref_name}"
-            echo "# commit: ${commit}"
-            echo "# tree:   ${tree}"
-            echo "# files:  $(wc -l < files.sha256 | tr -d ' ')"
-            echo "#"
-            echo "# Verify a checkout of this ref with:"
-            echo "#   shasum -a 256 -c files.sha256"
-            echo "# Hash checking alone ignores files this manifest does not list, and"
-            echo "# the Xcode project compiles any source file present in the tree. So"
-            echo "# also confirm nothing extra is present:"
-            echo "#   git status --porcelain --ignored   # git checkout: must print nothing"
-            echo "# or, for a tarball, diff this manifest's path list against find(1)."
-            echo "# Full instructions: docs/VERIFYING-A-BUILD.md"
-            echo "# The git tree hash above is the single value covering all tracked content:"
-            echo "#   git rev-parse HEAD^{tree}"
-            echo "#"
-          } > SOURCE-MANIFEST.txt
-          cat files.sha256 >> SOURCE-MANIFEST.txt
-
-          echo "commit=${commit}" >> "$GITHUB_OUTPUT"
-          echo "tree=${tree}" >> "$GITHUB_OUTPUT"
-
-      - name: Self-check the manifest
-        run: |
-          set -euo pipefail
-          # A manifest that does not validate against the tree it was made from
-          # is worse than none, so fail loudly rather than publishing it.
-          grep -v '^#' SOURCE-MANIFEST.txt > check.sha256
-          sha256sum -c check.sha256 > /dev/null
-          echo "manifest validates against this checkout"
-
-      - name: Attest the manifest
-        uses: actions/attest-build-provenance@v1
-        with:
-          subject-path: SOURCE-MANIFEST.txt
-
-      - uses: actions/upload-artifact@v4
-        with:
-          name: source-manifest
-          path: SOURCE-MANIFEST.txt
-
-      - name: Attach to release
-        if: startsWith(github.ref, 'refs/tags/')
-        env:
-          GH_TOKEN: ${{ github.token }}
-        run: |
-          set -euo pipefail
-          # A tag may be pushed before its release exists; only attach when
-          # there is a release to attach to, and never fail the run over it.
-          if gh release view "${{ github.ref_name }}" >/dev/null 2>&1; then
-            gh release upload "${{ github.ref_name }}" SOURCE-MANIFEST.txt --clobber
-          else
-            echo "no release for ${{ github.ref_name }} yet; manifest is available as a workflow artifact"
-          fi

.github/workflows/swift-tests.yml

@@ -94,24 +94,6 @@ jobs:
           kill "$watchdog_pid" 2>/dev/null || true
           exit "$status"
 
-      # Read coverage before the serial benchmark command below rebuilds the
-      # test binary without instrumentation. Reporting against that newer
-      # binary makes llvm-cov reject the profile as out of date.
-      # Informational only: there is deliberately no percentage threshold, but
-      # a broken/missing report is a CI configuration error and must be visible.
-      - name: Coverage summary
-        run: |
-          BIN_PATH=$(swift build --show-bin-path --package-path ${{ matrix.path }})
-          PROF="$BIN_PATH/codecov/default.profdata"
-          XCTEST=$(find "$BIN_PATH" -maxdepth 1 -name '*.xctest' | head -1)
-          BINARY="$XCTEST/Contents/MacOS/$(basename "$XCTEST" .xctest)"
-          if [ ! -f "$PROF" ] || [ ! -f "$BINARY" ]; then
-            echo "::error::Coverage profile or test binary is missing"
-            exit 1
-          fi
-          xcrun llvm-cov report "$BINARY" -instr-profile "$PROF" \
-            -ignore-filename-regex='(Tests|\.build|checkouts|Mocks|_PreviewHelpers)'
-
       # Benchmarks run serially on an otherwise idle runner for stable
       # numbers; BITCHAT_PERF_LOG captures the PERF[...] lines for the gate.
       - name: Run performance benchmarks (serial)
@@ -133,10 +115,26 @@ jobs:
         timeout-minutes: 10
         run: ./scripts/check-perf-floors.sh perf-output.log
 
-  # SPM tests do not link the shipping app targets. This job covers the
-  # iOS-conditional paths and both universal Release link configurations.
+      # Informational only: surfaces per-file and total line coverage in the
+      # job log so coverage trends are visible on every PR. No thresholds —
+      # this must never be the reason a build goes red.
+      - name: Coverage summary
+        run: |
+          BIN_PATH=$(swift build --show-bin-path --package-path ${{ matrix.path }})
+          PROF="$BIN_PATH/codecov/default.profdata"
+          XCTEST=$(find "$BIN_PATH" -maxdepth 1 -name '*.xctest' | head -1)
+          BINARY="$XCTEST/Contents/MacOS/$(basename "$XCTEST" .xctest)"
+          if [ -f "$PROF" ] && [ -f "$BINARY" ]; then
+            xcrun llvm-cov report "$BINARY" -instr-profile "$PROF" \
+              -ignore-filename-regex='(Tests|\.build|checkouts|Mocks|_PreviewHelpers)' || true
+          else
+            echo "No coverage data found; skipping summary."
+          fi
+
+  # SPM tests above only compile the macOS slice; this job covers the
+  # iOS-conditional code paths (UIKit, CoreBluetooth restoration, etc.).
   ios-build:
-    name: Build Release apps (universal)
+    name: Build iOS app (simulator)
     runs-on: macos-latest
     timeout-minutes: 15
 
@@ -144,133 +142,23 @@ jobs:
       - name: Checkout code
         uses: actions/checkout@v5
 
-      - name: Check clean recipe safety
-        run: bash scripts/check-just-clean-safety.sh
-
       - name: Build iOS (simulator, no signing)
-        # Build both simulator architectures so CI validates every vendored
-        # Arti simulator slice and the configuration that ships.
+        # arm64 only: the vendored arti.xcframework has no x86_64 simulator slice.
         run: |
           set -o pipefail
           xcodebuild -project bitchat.xcodeproj \
             -scheme "bitchat (iOS)" \
-            -configuration Release \
             -sdk iphonesimulator \
             -destination 'generic/platform=iOS Simulator' \
-            ARCHS='arm64 x86_64' \
-            ONLY_ACTIVE_ARCH=NO \
+            ARCHS=arm64 \
             CODE_SIGNING_ALLOWED=NO \
             build
 
-      - name: Build macOS (universal, no signing)
-        run: |
-          set -o pipefail
-          xcodebuild -project bitchat.xcodeproj \
-            -scheme "bitchat (macOS)" \
-            -configuration Release \
-            -destination 'generic/platform=macOS' \
-            ARCHS='arm64 x86_64' \
-            ONLY_ACTIVE_ARCH=NO \
-            CODE_SIGNING_ALLOWED=NO \
-            build
-
-  # The SwiftPM matrix runs on macOS and cannot execute UIKit/CoreBluetooth
-  # conditional tests. Build the shared iOS test target and run it on the first
-  # available iPhone simulator from the runner image instead of hard-coding a
-  # model that changes when GitHub updates Xcode. The suite intentionally runs
-  # in one test runner: a number of integration tests exercise process-global
-  # stores and notification centers, so overlapping workers can corrupt each
-  # other's fixtures and turn sub-second tests into multi-minute timeouts.
-  ios-tests:
-    name: Run iOS simulator tests
-    runs-on: macos-latest
-    timeout-minutes: 20
-
-    steps:
-      - name: Checkout code
-        uses: actions/checkout@v5
-
-      # Some runner images list only placeholder destinations (rows carrying
-      # "error:" or "unavailable") or ship the selected Xcode without a
-      # matching iOS simulator runtime, so this walks three paths in order:
-      # a usable xcodebuild destination, an existing simctl device, and
-      # finally creating a device from the newest installed iOS runtime.
-      - name: Select available iPhone simulator
-        id: destination
-        run: |
-          set -uo pipefail
-          destinations=$(xcodebuild -project bitchat.xcodeproj -scheme "bitchat (iOS)" -showdestinations 2>/dev/null || true)
-          destination_id=$(awk -F'id:' '
-            /platform:iOS Simulator/ && /name:iPhone/ \
-              && !/error/ && !/unavailable/ && !found {
-              value=$2
-              sub(/,.*/, "", value)
-              gsub(/^[[:space:]]+|[[:space:]]+$/, "", value)
-              print value
-              found=1
-            }
-          ' <<< "$destinations")
-
-          if [ -n "$destination_id" ]; then
-            echo "Selected destination via xcodebuild -showdestinations: $destination_id"
-          else
-            echo "No usable iPhone destination in -showdestinations output; falling back to simctl"
-            destination_id=$(xcrun simctl list devices available --json | jq -r '
-              [.devices | to_entries[]
-                | select(.key | contains("iOS"))
-                | .value[]
-                | select(.isAvailable and (.name | startswith("iPhone")))]
-              | first.udid // empty')
-            if [ -n "$destination_id" ]; then
-              echo "Selected existing simctl device: $destination_id"
-            else
-              echo "No available iPhone simulator device; creating one"
-              # Newest installed iOS runtime plus an iPhone device type that
-              # runtime itself reports as supported, so the pair always match.
-              create_spec=$(xcrun simctl list runtimes --json | jq -r '
-                [.runtimes[] | select(.platform == "iOS" and .isAvailable)]
-                | sort_by(.version | split(".") | map(tonumber))
-                | last // empty
-                | .identifier as $runtime
-                | ([(.supportedDeviceTypes // [])[]
-                    | select(.productFamily == "iPhone"
-                        or (.name // "" | startswith("iPhone")))]
-                  | first.identifier // empty) as $devicetype
-                | "\($devicetype) \($runtime)"')
-              read -r devicetype runtime <<< "$create_spec" || true
-              if [ -z "${devicetype:-}" ] || [ -z "${runtime:-}" ]; then
-                echo "::error::No iPhone simulator destination found and none creatable (no installed iOS runtime with an iPhone device type)"
-                exit 1
-              fi
-              destination_id=$(xcrun simctl create ci-iphone "$devicetype" "$runtime") || {
-                echo "::error::simctl create failed for $devicetype on $runtime"
-                exit 1
-              }
-              echo "Created simulator $destination_id ($devicetype, $runtime)"
-            fi
-          fi
-
-          echo "Using iPhone simulator destination id: $destination_id"
-          echo "id=$destination_id" >> "$GITHUB_OUTPUT"
-
-      - name: Run iOS tests
-        run: |
-          set -o pipefail
-          xcodebuild -project bitchat.xcodeproj \
-            -scheme "bitchat (iOS)" \
-            -sdk iphonesimulator \
-            -destination "platform=iOS Simulator,id=${{ steps.destination.outputs.id }}" \
-            -parallel-testing-enabled NO \
-            CODE_SIGNING_ALLOWED=NO \
-            test
-
-  # Blocking since the backlog reached zero (all violations fixed; rules the
-  # codebase deliberately breaks are disabled in .swiftlint.yml). --strict
-  # promotes warnings to errors so new violations fail the job. Runs in a
-  # pinned container (no Xcode plugin, no pbxproj changes) so it can never
-  # break the documented xcodebuild path.
+  # Advisory only: SwiftLint reports style violations without ever failing the
+  # build. Runs in a pinned container (no Xcode plugin, no pbxproj changes) so
+  # it can never break the documented xcodebuild path or block a merge.
   lint:
-    name: SwiftLint
+    name: SwiftLint (advisory)
     runs-on: ubuntu-latest
     timeout-minutes: 15
     # This job runs a third-party container image, so give it the least
@@ -282,9 +170,10 @@ jobs:
       # Tag for readability, digest for immutability (tags can be repointed).
       # Bump both together, deliberately — never a floating tag.
       image: ghcr.io/realm/swiftlint:0.65.0@sha256:a482729f4b58741875af1566f23397f3f6db300372756fc31606d0a4527fab9e
+    continue-on-error: true
     steps:
       - uses: actions/checkout@v5
         with:
           persist-credentials: false
       - name: Run SwiftLint
-        run: swiftlint lint --strict --reporter github-actions-logging
+        run: swiftlint lint --reporter github-actions-logging

.gitignore

@@ -80,4 +80,3 @@ build.log
 
 # Local configs
 Local.xcconfig
-*.profraw

.periphery.baseline.json

@@ -1 +1 @@
-{"v1":{"usrs":["param-buf-arti_bootstrap_summary(_:_:)-s:3Tor22arti_bootstrap_summary33_954FD7701B4E47ABB5F166D1CF862DC9LLys5Int32VSpys4Int8VG_AEtF","param-dataDir-arti_start(_:_:)-s:3Tor10arti_start33_954FD7701B4E47ABB5F166D1CF862DC9LLys5Int32VSPys4Int8VG_s6UInt16VtF","param-len-arti_bootstrap_summary(_:_:)-s:3Tor22arti_bootstrap_summary33_954FD7701B4E47ABB5F166D1CF862DC9LLys5Int32VSpys4Int8VG_AEtF","param-socksPort-arti_start(_:_:)-s:3Tor10arti_start33_954FD7701B4E47ABB5F166D1CF862DC9LLys5Int32VSPys4Int8VG_s6UInt16VtF","s:13BitFoundation16PeerCapabilitiesV8wifiBulkACvpZ","s:13BitFoundation18KeychainReadResultO18isRecoverableErrorSbvp","s:13BitFoundation23KeychainManagerProtocolP11secureClearyySSzF","s:18bitchatTests_macOS12MockKeychainC11secureClearyySSzF","s:18bitchatTests_macOS20TrackingMockKeychainC11resetCountsyyF","s:18bitchatTests_macOS20TrackingMockKeychainC11secureClearyySSzF","s:18bitchatTests_macOS20TrackingMockKeychainC25totalSecureClearCallCountSivp","s:18bitchatTests_macOS20TrackingMockKeychainC26secureClearStringCallCountSivp","s:18bitchatTests_macOS20TrackingMockKeychainC27_secureClearStringCallCount06_AB6D1M24FD239F2969C82F4108818260LLSivp","s:18bitchatTests_macOS24FailingCacheSaveKeychain33_22380C7A11A569A0B83FA83F34C498A7LLC11secureClearyySSzF","s:18bitchatTests_macOS24MockGeohashPresenceTimer33_483587EFB96650EE130EFB09BBA2A1AALLC7handleryycvp","s:3Tor0A7ManagerC21goDormantOnBackgroundyyF","s:7bitchat10AppRuntimeC24handleScreenshotCaptured33_C8B369AD8BC1D9963A50CEDA77A4332ALLyyF","s:7bitchat10AppRuntimeC33handleDidBecomeActiveNotificationyyF","s:7bitchat10BLEServiceC18logBluetoothStatus33_69191C53E68500C17D98DBCF2BDA7100LLyySSF","s:7bitchat10BLEServiceC18logBluetoothStatusyySSF","s:7bitchat10BLEServiceC20centralRestorationID33_69191C53E68500C17D98DBCF2BDA7100LLSSvpZ","s:7bitchat10BLEServiceC22captureBluetoothStatus33_69191C53E68500C17D98DBCF2BDA7100LL7contextySS_tF","s:7bitchat10BLEServiceC23peripheralRestorationID33_69191C53E68500C17D98DBCF2BDA7100LLSSvpZ","s:7bitchat10BLEServiceC29scheduleBluetoothStatusSample33_69191C53E68500C17D98DBCF2BDA7100LL5after7contextySd_SStF","s:7bitchat10QRScanViewV8isActiveSbvp","s:7bitchat15BLEPeerRegistryV5countSivp","s:7bitchat15KeychainManagerC11secureClearyySSzF","s:7bitchat15PaymentChipViewV7openURL33_10AC50641B1EBCD52E5092A2E521D236LL7SwiftUI13OpenURLActionVvp","s:7bitchat15TransportConfigO29uiBatchDispatchStaggerSecondsSdvpZ","s:7bitchat15TransportConfigO35uiShareExtensionDismissDelaySecondsSdvpZ","s:7bitchat15TransportConfigO38bleBackgroundPendingConnectSlotReserveSivpZ","s:7bitchat17GossipSyncManagerC10persistNowyyF","s:7bitchat17NostrRelayManagerC15InboundEventKey33_E4160FE8A9A2C9D6308EAAD5A8B5CB07LLV7eventIDSSvp","s:7bitchat18BLERadioControllerC14candidateCountSivp","s:7bitchat25LocationNotesDependenciesV3now10Foundation4DateVycvp","s:7bitchat25NWPathReachabilityMonitorC7monitor33_84633C9DBCAF57538179C1E04DB8E015LL7Network0bD0CSgvp"]}}
+{"v1":{"usrs":["param-buf-arti_bootstrap_summary(_:_:)-s:3Tor22arti_bootstrap_summary33_954FD7701B4E47ABB5F166D1CF862DC9LLys5Int32VSpys4Int8VG_AEtF","param-dataDir-arti_start(_:_:)-s:3Tor10arti_start33_954FD7701B4E47ABB5F166D1CF862DC9LLys5Int32VSPys4Int8VG_s6UInt16VtF","param-len-arti_bootstrap_summary(_:_:)-s:3Tor22arti_bootstrap_summary33_954FD7701B4E47ABB5F166D1CF862DC9LLys5Int32VSpys4Int8VG_AEtF","param-socksPort-arti_start(_:_:)-s:3Tor10arti_start33_954FD7701B4E47ABB5F166D1CF862DC9LLys5Int32VSPys4Int8VG_s6UInt16VtF","s:13BitFoundation16PeerCapabilitiesV8wifiBulkACvpZ","s:13BitFoundation18KeychainReadResultO18isRecoverableErrorSbvp","s:13BitFoundation23KeychainManagerProtocolP11secureClearyySSzF","s:18bitchatTests_macOS12MockKeychainC11secureClearyySSzF","s:18bitchatTests_macOS20TrackingMockKeychainC11resetCountsyyF","s:18bitchatTests_macOS20TrackingMockKeychainC11secureClearyySSzF","s:18bitchatTests_macOS20TrackingMockKeychainC25totalSecureClearCallCountSivp","s:18bitchatTests_macOS20TrackingMockKeychainC26secureClearStringCallCountSivp","s:18bitchatTests_macOS20TrackingMockKeychainC27_secureClearStringCallCount06_AB6D1M24FD239F2969C82F4108818260LLSivp","s:18bitchatTests_macOS24FailingCacheSaveKeychain33_22380C7A11A569A0B83FA83F34C498A7LLC11secureClearyySSzF","s:18bitchatTests_macOS24MockGeohashPresenceTimer33_483587EFB96650EE130EFB09BBA2A1AALLC7handleryycvp","s:3Tor0A7ManagerC21goDormantOnBackgroundyyF","s:7bitchat10AppRuntimeC24handleScreenshotCaptured33_C8B369AD8BC1D9963A50CEDA77A4332ALLyyF","s:7bitchat10AppRuntimeC33handleDidBecomeActiveNotificationyyF","s:7bitchat10BLEServiceC18logBluetoothStatus33_69191C53E68500C17D98DBCF2BDA7100LLyySSF","s:7bitchat10BLEServiceC20centralRestorationID33_69191C53E68500C17D98DBCF2BDA7100LLSSvpZ","s:7bitchat10BLEServiceC22captureBluetoothStatus33_69191C53E68500C17D98DBCF2BDA7100LL7contextySS_tF","s:7bitchat10BLEServiceC23peripheralRestorationID33_69191C53E68500C17D98DBCF2BDA7100LLSSvpZ","s:7bitchat10BLEServiceC29scheduleBluetoothStatusSample33_69191C53E68500C17D98DBCF2BDA7100LL5after7contextySd_SStF","s:7bitchat10QRScanViewV8isActiveSbvp","s:7bitchat15BLEPeerRegistryV5countSivp","s:7bitchat15KeychainManagerC11secureClearyySSzF","s:7bitchat15PaymentChipViewV7openURL33_10AC50641B1EBCD52E5092A2E521D236LL7SwiftUI13OpenURLActionVvp","s:7bitchat15TransportConfigO29uiBatchDispatchStaggerSecondsSdvpZ","s:7bitchat15TransportConfigO35uiShareExtensionDismissDelaySecondsSdvpZ","s:7bitchat15TransportConfigO38bleBackgroundPendingConnectSlotReserveSivpZ","s:7bitchat17GossipSyncManagerC10persistNowyyF","s:7bitchat17NostrRelayManagerC15InboundEventKey33_E4160FE8A9A2C9D6308EAAD5A8B5CB07LLV7eventIDSSvp","s:7bitchat17PrekeyBundleStoreC12StoredBundleV8noiseKey10Foundation4DataVvp","s:7bitchat25LocationNotesDependenciesV3now10Foundation4DateVycvp","s:7bitchat25NWPathReachabilityMonitorC7monitor33_84633C9DBCAF57538179C1E04DB8E015LL7Network0bD0CSgvp"]}}

.periphery.yml

@@ -10,12 +10,5 @@ project: bitchat.xcodeproj
 schemes:
   - bitchat (macOS)
 retain_swift_ui_previews: true
-# Codable properties are (de)serialized via synthesized conformances the
-# indexer doesn't always attribute reads to: PrekeyBundleStore.StoredBundle
-# .noiseKey flaked CI as "assign-only" even while read in loadFromDisk —
-# and slipped past its baselined USR. Retaining Codable properties outright
-# is deterministic; a truly-dead Codable field is a persisted-format change
-# anyway, never a safe mechanical delete.
-retain_codable_properties: true
 relative_results: true
 baseline: .periphery.baseline.json

.swiftlint.yml

@@ -2,8 +2,6 @@
 # (CI checkouts are fresh, so this only matters in a working tree).
 excluded:
   - .build
-  - .claude
-  - .device-lab
   - .swiftpm
   - .DerivedData
   - DerivedData
@@ -22,7 +20,6 @@ disabled_rules:
   - control_statement
   - void_function_in_ternary
   - redundant_discardable_let  # SwiftUI breaks without it
-  - todo  # TODOs that cite a tracked issue are deliberate markers, not lint debt
   # To be enabled as we fix the issues
   - trailing_whitespace
   - cyclomatic_complexity

Configs/Local.xcconfig.example

@@ -3,6 +3,3 @@ DEVELOPMENT_TEAM = ABC123
 
 // Unique bundle id to be able to register and run locally
 PRODUCT_BUNDLE_IDENTIFIER = chat.bitchat.$(DEVELOPMENT_TEAM)
-
-// App and share extension must use an App Group registered to your team.
-APP_GROUP_ID = group.chat.bitchat.$(DEVELOPMENT_TEAM)

Configs/Release.xcconfig

@@ -1,4 +1,4 @@
-MARKETING_VERSION = 1.7.1
+MARKETING_VERSION = 1.7.0
 CURRENT_PROJECT_VERSION = 1
 
 IPHONEOS_DEPLOYMENT_TARGET = 16.0

Justfile

@@ -1,66 +1,107 @@
-# BitChat developer commands
-#
-# Builds use a repository-local, ignored DerivedData directory. No recipe
-# patches, restores, or removes tracked project/configuration files.
-
-project := "bitchat.xcodeproj"
-macos_scheme := "bitchat (macOS)"
-ios_scheme := "bitchat (iOS)"
-derived_data := ".DerivedData"
+# BitChat macOS Build Justfile
+# Handles temporary modifications needed to build and run on macOS
 
+# Default recipe - shows available commands
 default:
-    @echo "BitChat developer commands:"
-    @echo "  just run                Build and run the macOS app"
-    @echo "  just build              Build the macOS app without signing"
-    @echo "  just test               Run the SwiftPM test suite"
-    @echo "  just test-ios           Run tests on the iPhone 17 simulator"
-    @echo "  just clean              Remove repo-local build artifacts only"
-    @echo "  just nuke               Also remove nested package build caches"
-    @echo "  just check              Validate the development environment"
+    @echo "BitChat macOS Build Commands:"
+    @echo "  just run     - Build and run the macOS app"
+    @echo "  just build   - Build the macOS app only"
+    @echo "  just clean   - Clean build artifacts and restore original files"
+    @echo "  just check   - Check prerequisites"
+    @echo ""
+    @echo "Original files are preserved - modifications are temporary for builds only"
 
-# Static guard against reintroducing source-restoring or source-deleting clean
-# behavior. CI runs the same script directly.
-check-clean-safety:
-    @bash scripts/check-just-clean-safety.sh
-
-check: check-clean-safety
+# Check prerequisites
+check:
     @echo "Checking prerequisites..."
-    @command -v xcodebuild >/dev/null 2>&1 || (echo "❌ xcodebuild not found. Install full Xcode." && exit 1)
-    @developer_dir="$(xcode-select -p 2>/dev/null)"; case "$developer_dir" in *.app/Contents/Developer) ;; *) echo "❌ Full Xcode is not selected. Run: sudo xcode-select -s /Applications/Xcode.app/Contents/Developer"; exit 1;; esac
-    @xcodebuild -version
-    @echo "✅ Development environment ready (a signing identity is not required for just build)"
+    @command -v xcodebuild >/dev/null 2>&1 || (echo "❌ xcodebuild not found. Install Xcode from App Store" && exit 1)
+    @xcode-select -p | grep -q "Xcode.app" || (echo "❌ Full Xcode required, not just command line tools. Install from App Store and run:\n   sudo xcode-select -s /Applications/Xcode.app/Contents/Developer" && exit 1)
+    @test -d "/Applications/Xcode.app" || (echo "❌ Xcode.app not found in Applications folder. Install from App Store" && exit 1)
+    @xcodebuild -version >/dev/null 2>&1 || (echo "❌ Xcode not properly configured. Try:\n   sudo xcode-select -s /Applications/Xcode.app/Contents/Developer" && exit 1)
+    @security find-identity -v -p codesigning | grep -q "Apple Development\|Developer ID" || (echo "⚠️  No Developer ID found - code signing may fail" && exit 0)
+    @echo "✅ All prerequisites met"
 
-build: check
+# Backup original files
+backup:
+    @echo "Backing up original project configuration..."
+    @if [ -f bitchat.xcodeproj/project.pbxproj ]; then cp bitchat.xcodeproj/project.pbxproj bitchat.xcodeproj/project.pbxproj.backup; fi
+    @if [ -f bitchat/Info.plist ]; then cp bitchat/Info.plist bitchat/Info.plist.backup; fi
+
+# Restore original files
+restore:
+    @echo "Restoring original project configuration..."
+    @if [ -f project.yml.backup ]; then mv project.yml.backup project.yml; fi
+    @# Restore iOS-specific files
+    @if [ -f bitchat/LaunchScreen.storyboard.ios ]; then mv bitchat/LaunchScreen.storyboard.ios bitchat/LaunchScreen.storyboard; fi
+    @# Use git to restore all modified files except Justfile
+    @git checkout -- project.yml bitchat.xcodeproj/project.pbxproj bitchat/Info.plist 2>/dev/null || echo "⚠️  Could not restore some files with git"
+    @# Remove any backup files
+    @rm -f bitchat.xcodeproj/project.pbxproj.backup bitchat/Info.plist.backup 2>/dev/null || true
+
+# Apply macOS-specific modifications
+patch-for-macos: backup
+    @echo "Temporarily hiding iOS-specific files for macOS build..."
+    @# Move iOS-specific files out of the way temporarily
+    @if [ -f bitchat/LaunchScreen.storyboard ]; then mv bitchat/LaunchScreen.storyboard bitchat/LaunchScreen.storyboard.ios; fi
+
+# Build the macOS app
+build: #check generate
     @echo "Building BitChat for macOS..."
-    @xcodebuild -project "{{project}}" -scheme "{{macos_scheme}}" -configuration Debug -derivedDataPath "{{derived_data}}" CODE_SIGNING_ALLOWED=NO build
+    @xcodebuild -project bitchat.xcodeproj -scheme "bitchat (macOS)" -configuration Debug CODE_SIGN_IDENTITY="" CODE_SIGNING_REQUIRED=NO CODE_SIGN_ENTITLEMENTS="" build
 
+# Run the macOS app
 run: build
-    @app="{{derived_data}}/Build/Products/Debug/bitchat.app"; test -d "$app" || (echo "❌ Built app not found at $app" && exit 1); open "$app"
+    @echo "Launching BitChat..."
+    @find ~/Library/Developer/Xcode/DerivedData -name "bitchat.app" -path "*/Debug/*" -not -path "*/Index.noindex/*" | head -1 | xargs -I {} open "{}"
 
-# Backward-compatible alias for the old quick-run recipe.
-dev-run: run
+# Clean build artifacts and restore original files
+clean: restore
+    @echo "Cleaning build artifacts..."
+    @rm -rf ~/Library/Developer/Xcode/DerivedData/bitchat-* 2>/dev/null || true
+    @# Only remove the generated project if we have a backup, otherwise use git
+    @if [ -f bitchat.xcodeproj/project.pbxproj.backup ]; then \
+        rm -rf bitchat.xcodeproj; \
+    else \
+        git checkout -- bitchat.xcodeproj/project.pbxproj 2>/dev/null || echo "⚠️  Could not restore project.pbxproj"; \
+    fi
+    @rm -f project-macos.yml 2>/dev/null || true
+    @echo "✅ Cleaned and restored original files"
 
-test:
-    @swift test
-
-test-ios: check
-    @xcodebuild -project "{{project}}" -scheme "{{ios_scheme}}" -sdk iphonesimulator -destination 'platform=iOS Simulator,name=iPhone 17' -derivedDataPath "{{derived_data}}" test
-
-# Artifact-only cleanup. In particular, this recipe never invokes Git and
-# never writes, moves, restores, or removes source/configuration files.
-clean:
-    @echo "Cleaning repo-local build artifacts..."
-    @rm -rf -- "{{derived_data}}" ".build"
-    @echo "✅ Cleaned {{derived_data}} and .build; tracked files were untouched"
-
-# Retain the familiar command, but keep it artifact-only as well.
-nuke: clean
-    @echo "Cleaning nested package build caches..."
-    @find localPackages -type d -name .build -prune -exec rm -rf -- {} +
-    @rm -rf -- ".cache"
-    @echo "✅ Removed repository build caches; tracked files were untouched"
+# Quick run without cleaning (for development)
+dev-run: check
+    @echo "Quick development build..."
+    @xcodebuild -project bitchat.xcodeproj -scheme "bitchat_macOS" -configuration Debug CODE_SIGN_IDENTITY="" CODE_SIGNING_REQUIRED=NO CODE_SIGN_ENTITLEMENTS="" build
+    @find ~/Library/Developer/Xcode/DerivedData -name "bitchat.app" -path "*/Debug/*" -not -path "*/Index.noindex/*" | head -1 | xargs -I {} open "{}"
 
+# Show app info
 info:
-    @echo "BitChat - decentralized mesh messaging"
-    @echo "macOS 13+ and iOS 16+"
-    @echo "Bluetooth mesh behavior requires physical Bluetooth-capable devices"
+    @echo "BitChat - Decentralized Mesh Messaging"
+    @echo "======================================"
+    @echo "• Native macOS SwiftUI app"
+    @echo "• Bluetooth LE mesh networking"
+    @echo "• End-to-end encryption"
+    @echo "• No internet required"
+    @echo "• Works offline with nearby devices"
+    @echo ""
+    @echo "Requirements:"
+    @echo "• macOS 13.0+ (Ventura)"
+    @echo "• Bluetooth LE capable Mac"
+    @echo "• Physical device (no simulator support)"
+    @echo ""
+    @echo "Usage:"
+    @echo "• Set nickname and start chatting"
+    @echo "• Use /join #channel for group chats"
+    @echo "• Use /msg @user for private messages"
+    @echo "• Triple-tap logo for emergency wipe"
+
+# Force clean everything (nuclear option)
+nuke:
+    @echo "🧨 Nuclear clean - removing all build artifacts and backups..."
+    @rm -rf ~/Library/Developer/Xcode/DerivedData/bitchat-* 2>/dev/null || true
+    @rm -rf bitchat.xcodeproj 2>/dev/null || true
+    @rm -f bitchat.xcodeproj/project.pbxproj.backup 2>/dev/null || true
+    @rm -f bitchat/Info.plist.backup 2>/dev/null || true
+    @# Restore iOS-specific files if they were moved
+    @if [ -f bitchat/LaunchScreen.storyboard.ios ]; then mv bitchat/LaunchScreen.storyboard.ios bitchat/LaunchScreen.storyboard; fi
+    @git checkout bitchat.xcodeproj/project.pbxproj bitchat/Info.plist 2>/dev/null || echo "⚠️  Not a git repo or no changes to restore"
+    @echo "✅ Nuclear clean complete"

PRIVACY_POLICY.md

@@ -1,160 +1,165 @@
 # bitchat Privacy Policy
 
-*Last updated: July 2026*
+*Last updated: June 2026*
 
 ## Our Commitment
 
-bitchat is designed for private, account-free communication. This policy describes what the app keeps on your device, what it sends when you use mesh or optional internet features, and how long local data can remain.
+bitchat is designed with privacy as its foundation. We believe private communication is a fundamental human right. This policy explains how bitchat protects your privacy.
 
 ## Summary
 
-- **No project-operated accounts or messaging servers** — Bluetooth mesh is peer-to-peer; optional internet features use public or user-selected Nostr relays.
-- **No analytics, advertising, telemetry, or tracking** — the app does not contain an analytics or advertising SDK.
-- **No sale of data** — the project does not sell user data or build advertising profiles.
-- **Open source** — the storage, networking, and cryptography described here can be inspected in the source code.
+- **No personal data collection** - We don't collect names, emails, or phone numbers
+- **No accounts or company servers** - Mesh chat works peer-to-peer; optional Nostr features use public or user-selected relays
+- **No tracking** - We have no analytics, telemetry, or user tracking
+- **Open source** - You can verify these claims by reading our code
 
-## What bitchat Stores on Your Device
+## What Information bitchat Stores
 
-1. **Identity and cryptographic keys**
-   - Noise, signing, group, prekey, and optional Nostr identity material is generated locally.
-   - Secret keys are stored in the system keychain as device-only items. Public keys are shared when required for messaging, verification, groups, or Nostr events.
-   - Keys remain until they are rotated, removed by the relevant feature, or erased with panic wipe. Because operating-system keychains can outlive an uninstall, bitchat records a non-secret install marker and deletes surviving app keys before use after a later reinstall.
+### On Your Device Only
 
-2. **Nickname, preferences, and relationships**
-   - Your nickname, settings, favorites, petnames, read-receipt identifiers, and bounded operational metadata are stored locally.
-   - The share extension can retain one item you choose to share in the app-group preferences for up to 24 hours. The app shows the destination and a preview for review; it does not send the item automatically. The item is cleared when you add it to the composer, cancel, panic-wipe, or it expires.
+1. **Identity Keys**
+   - Cryptographic private keys generated on first launch or when optional Nostr identities are created
+   - Stored locally in your device's secure storage
+   - Allows you to maintain "favorite" relationships across app restarts
+   - Private keys never leave your device; public keys are shared when needed for messaging
 
-3. **Private group state**
-   - Group names, rosters, creator identity, and key epoch are stored as protected files in Application Support.
-   - Current group keys are stored in the keychain. Group state remains until you leave or remove the group, panic-wipe the app, or remove the app.
+2. **Nickname**
+   - The display name you choose (or auto-generated)
+   - Stored only on your device
+   - Shared with peers you communicate with
 
-4. **Queued and carried private messages**
-   - An outgoing private message that has not been acknowledged may remain for up to 24 hours in a bounded, encrypted outbox. The outbox is sealed with ChaCha20-Poly1305 and its key is stored in the keychain.
-   - A device acting as a courier may store a bounded opaque end-to-end encrypted envelope for another user for up to 24 hours. The courier cannot read its message content.
-   - A panic wipe deletes both stores.
+3. **Message History** (if enabled)
+   - When room owners enable retention, messages are saved locally
+   - Stored encrypted on your device
+   - You can delete this at any time
 
-5. **Recent public mesh messages and notices**
-   - Signed public mesh messages may be kept in a protected local gossip archive for up to 6 hours so they can cross mesh partitions and survive a relaunch.
-   - Public bulletin-board posts and deletion tombstones persist until the post's author-selected expiry, at most seven days. Both stores are bounded and panic-wipeable.
-   - These items are public to the mesh or board where they are posted; they are not confidential messages.
+4. **Favorite Peers**
+   - Public keys of peers you mark as favorites
+   - Stored only on your device
+   - Allows you to recognize these peers in future sessions
 
-6. **Media attachments**
-   - Voice notes and images you send or receive can be stored under Application Support so they remain playable while referenced by the app.
-   - Incoming media is subject to a 100 MB quota with oldest-file eviction. All stored media, sent and received, is also deleted once it is more than seven days old, and immediately by panic wipe or app removal.
+5. **Optional Location Channel State**
+   - Your selected geohash channel, bookmarked geohashes, teleport flags, and bookmark display names
+   - Stored locally on your device so the location-channel UI can restore your choices
+   - Per-geohash Nostr identities are derived locally from a device seed stored in secure storage
+   - Exact latitude and longitude are not persisted by bitchat
 
-7. **Optional location-channel state**
-   - Your selected geohash channel, bookmarks, teleport flags, and bookmark display names are stored locally so the UI can restore them.
-   - Per-geohash Nostr identities are derived locally from a device seed stored in the keychain.
-   - bitchat does not persist exact latitude or longitude and does not include exact coordinates in mesh or Nostr messages.
+### Temporary Session Data
 
-## Temporary Session Data
+During each session, bitchat temporarily maintains:
+- Active peer connections (forgotten when app closes)
+- Routing information for message delivery
+- Cached messages for offline peers (12 hours max)
+- Your current location while optional location channels are enabled, used locally to compute geohash channels and friendly place names
 
-While running, bitchat maintains active connections, routing state, deduplication state, and bounded in-memory conversation timelines. Closing the app clears the in-memory timelines and active connections, but it does not erase the persistent stores listed above.
+## What Information is Shared
 
-## What Is Shared
+### With Other bitchat Users
 
-### With Nearby Mesh Users
+When you use bitchat, nearby peers can see:
+- Your chosen nickname
+- Your ephemeral public key (changes each session)
+- Messages you send to public rooms or directly to them
+- Your approximate Bluetooth signal strength (for connection quality)
 
-Depending on the feature you use, nearby peers can receive:
+### With Room Members
 
-- Your chosen nickname and public Noise/signing identity material.
-- Announce metadata such as supported capability flags and a bounded list of short direct-neighbor identifiers. When the bridge is enabled, an announce can also include its coarse rendezvous geohash cell.
-- Public mesh messages, public notices, and group-control packets you intentionally send.
-- Private ciphertext addressed to them, or opaque courier ciphertext they agree to carry.
-- Radio metadata available to the receiver, such as approximate Bluetooth signal strength.
+When you join a password-protected room:
+- Your messages are visible to others with the password
+- Your nickname appears in the member list
+- Room owners can see you've joined
 
-Noise identity keys can persist across sessions; do not treat them as anonymous identifiers. Panic wipe rotates local identity state.
+### With Nostr Relays (Optional Features)
 
-### With Private Group Members
+If you enable Nostr-backed features:
+- Private fallback messages to mutual favorites are sent as encrypted NIP-17 gift wraps. Relays can see event metadata, but not message content.
+- Public location-channel messages, location notes, and presence are scoped with geohash tags. Relays and other participants can see the geohash tag, event kind, timestamp, and public key used for that geohash.
+- Exact GPS coordinates are not included in Nostr events by bitchat. The geohash precision you choose can still reveal an approximate area, from region-level to building-level.
+- Automatic presence heartbeats are limited to low-precision geohashes (region, province, and city). More precise geohash posts happen only when you use those channels or location notes.
 
-Private group members receive the group's name, roster, key epoch, and encrypted group traffic needed to participate. Group messages are confidential to devices holding the current group key, subject to the security of those devices and members.
+## What We DON'T Do
 
-### With Nostr Relays and Internet Gateways
+bitchat **never**:
+- Collects personal information
+- Sells or shares your exact GPS location
+- Stores data on servers we operate
+- Sells your data to advertisers or data brokers
+- Uses analytics or telemetry
+- Creates user profiles
+- Requires registration
 
-Internet-backed features are optional. When enabled or used:
+## Encryption
 
-- Private fallback messages use BitChat's app-specific encrypted envelopes. This format is not NIP-17, NIP-44, or NIP-59 compatible. Relays can observe the recipient public-key tag, event timing and size, and network metadata, but not the message plaintext or stable sender identity.
-- Public location-channel messages, notes, notices, and presence include a geohash tag, event kind, timestamp, and a public key. A geohash reveals an approximate area; finer precision reveals a smaller area.
-- The optional mesh bridge publishes bridge-enabled public mesh messages and presence to a neighborhood rendezvous cell. Those messages are public to participants and relays for that cell. A per-message “nearby only” choice prevents that message from crossing the bridge.
-- Bridge courier drops contain opaque end-to-end encrypted envelopes and a rotating recipient tag. Relays still observe timing and network metadata.
-- A device with gateway features enabled may relay signed bridge/location traffic or opaque courier envelopes for nearby mesh devices.
+All private messages use end-to-end encryption:
+- **X25519** for key exchange
+- **AES-256-GCM** for message encryption
+- **Ed25519** for digital signatures
+- **Argon2id** for password-protected rooms
 
-Nostr relays are operated by third parties. Their retention, logging, availability, and privacy practices are outside the project's control. Public events and encrypted events may remain on relays according to each relay's policy.
+## Your Rights
 
-You can add relays yourself in settings, including `.onion` addresses. Added relays are stored locally, are limited in number, and are erased by panic wipe. Tor routing is on by default; while it is off, every relay you connect to can see your IP address, including relays carrying your private messages.
+You have complete control:
+- **Delete Local State**: Triple-tap the logo to instantly wipe local keys, sessions, caches, and preferences
+- **Leave Anytime**: Close the app and local presence stops; relay-backed presence ages out
+- **No Account**: No account record exists for you to delete from us
+- **Portability**: Your local state stays on your device unless you send messages, use optional relay-backed features, or export it
 
-## Location and Apple Services
+## Bluetooth & Permissions
 
-Location permission is optional and requested as when-in-use access. It is used to compute geohash channels, bridge rendezvous cells, and nearby place labels.
+bitchat requires Bluetooth permission to function:
+- Used only for peer-to-peer communication
+- Bluetooth is not used for tracking
+- You can revoke this permission at any time in system settings
 
-- Exact coordinates are not included in bitchat mesh or Nostr payloads and are not persisted by bitchat.
-- A selected geohash can still reveal an approximate area to peers and relays.
-- When bitchat asks the operating system for a friendly place name, Apple's `CLGeocoder` service may process the location under Apple's privacy terms.
-- Revoking location permission stops live location sampling. Saved bookmarks remain until you remove them, panic-wipe the app, or remove the app.
+## Location Permission
 
-## Microphone, Camera, and Media Permissions
-
-- Microphone access is used only while you record a voice note or actively hold live push-to-talk. The resulting audio is sent to the mesh conversation you selected; public-conversation audio is public to that mesh, while private-conversation audio uses the private transport protections described below.
-- Voice-note and live-audio files can remain in Application Support under the media retention rules above.
-- Camera access is used to scan peer-verification QR codes. Photo-library access is used when you choose an image to send.
-- These permissions can be revoked in system settings. bitchat does not record microphone or camera input while the related capture UI is inactive.
-
-## Cryptography
-
-Private and public features use different protections:
-
-- Mesh private sessions use Noise XX with X25519, ChaCha20-Poly1305, and SHA-256.
-- Private group messages use ChaCha20-Poly1305; group state and relevant mesh packets use Ed25519 signatures.
-- Nostr events use secp256k1 Schnorr signatures. BitChat private envelopes use secp256k1 key agreement, HKDF-SHA256, and XChaCha20-Poly1305. The envelope format is proprietary, only interoperates with BitChat clients, and does not provide forward secrecy against later compromise of the recipient's static Nostr private key.
-- The persistent private-message outbox uses ChaCha20-Poly1305 with a key held in the keychain. Some other protected local identity state uses AES-GCM.
-- Public mesh, bridge, geohash, and board content is signed or authenticated as appropriate but is intentionally not confidential.
-
-No cryptographic system can protect content after a recipient reads, copies, screenshots, or exports it.
-
-## Data Retention Summary
-
-- **In-memory chat timelines and active connections:** until the app closes or state is cleared.
-- **Queued outgoing private messages:** until acknowledged, dropped by bounded policy, or 24 hours, whichever comes first.
-- **Opaque courier envelopes:** until handed off, evicted by bounded policy, or 24 hours, whichever comes first.
-- **Recent public mesh gossip:** up to 6 hours.
-- **Public board posts and tombstones:** until expiry, at most seven days.
-- **Media:** seven days, or sooner by quota eviction, panic wipe, or app removal.
-- **Groups, favorites, preferences, identity keys, and bookmarks:** until removed by the feature, panic wipe, or app removal.
-- **Nostr data:** according to the policies of the relays that receive it.
-
-## Your Controls
-
-- **Panic wipe:** Triple-tap the logo to synchronously cancel in-flight media work and clear local keys, sessions, preferences, groups, queues, carried mail, public archives, board data, and media managed by the app.
-- **Notification previews:** Hidden by default, so lock-screen alerts do not show message text, sender names, or geohashes. Full previews can be turned on in settings.
-- **Clearing a conversation:** Clearing the mesh timeline also deletes the recent public gossip this device had stored on disk.
-- **Feature controls:** Location channels, mesh bridge, internet gateway, and related internet behaviors can be disabled in the app. Some already-published relay data cannot be recalled.
-- **System permissions:** Bluetooth, location, microphone, camera, and photo-library access can be revoked in system settings.
-- **No account:** The project operates no account record for you to request or export.
-
-## What the Project Does Not Do
-
-bitchat does not:
-
-- Operate an account database or project-owned messaging backend.
-- Include advertising, analytics, or tracking SDKs.
-- Sell user data or create advertising profiles.
-- Include exact GPS coordinates in bitchat mesh or Nostr message payloads.
+Location permission is optional and is used only for location channels:
+- Used to compute local geohash channels and display names
+- Requested as when-in-use permission
+- Exact coordinates are not shared in messages or stored by bitchat
+- Selected and bookmarked geohashes may persist locally until you remove them, use panic wipe, or delete the app
+- You can revoke this permission at any time in system settings
 
 ## Children's Privacy
 
-The project does not knowingly operate a service that collects children's personal data. The app has no account registration or age-verification system. Users and guardians should understand that public mesh, board, bridge, and location-channel posts are visible to other participants and may be relayed.
+bitchat does not knowingly collect information from children. The app has no age verification because it collects no personal information from anyone.
+
+## Data Retention
+
+- **Messages**: Deleted from memory when app closes (unless room retention is enabled)
+- **Identity Key**: Persists until you delete the app
+- **Favorites**: Persist until you remove them or delete the app
+- **Location channel choices**: Selected/bookmarked geohashes persist locally until removed, panic-wiped, or the app is deleted
+- **Nostr relay data**: Public geohash events and encrypted gift wraps may be retained by relays according to each relay's policy
+- **Everything Else**: Exists only during active sessions
+
+## Security Measures
+
+- All communication is encrypted
+- No accounts or company servers
+- Optional Nostr relays receive only the events needed for Nostr-backed private fallback or public location channels
+- Open source code for public audit
+- Regular security updates
+- Cryptographic signatures prevent tampering
 
 ## Changes to This Policy
 
-Material behavior changes will be reflected in this document and its “Last updated” date. Updating this policy cannot retroactively retrieve data that remained only on a user's device.
+If we update this policy:
+- The "Last updated" date will change
+- The updated policy will be included in the app
+- No retroactive changes can make us collect data already held only in your app
 
 ## Contact
 
 bitchat is an open source project. For privacy questions:
+- View our source code: [https://github.com/permissionlesstech/bitchat/tree/main](https://github.com/permissionlesstech/bitchat/tree/main)
+- Open an issue on GitHub
+- Join the discussion in public rooms
 
-- View the source: [https://github.com/permissionlesstech/bitchat](https://github.com/permissionlesstech/bitchat)
-- Open an issue on GitHub.
+## Philosophy
+
+Privacy isn't just a feature—it's the entire point. bitchat proves that modern communication doesn't require surrendering your privacy. No accounts, no company servers, no analytics. Just people talking freely.
 
 ---
 
-*This policy is released into the public domain under The Unlicense, like the project itself.*
+*This policy is released into the public domain under The Unlicense, just like bitchat itself.*

Package.swift

@@ -63,11 +63,7 @@ let package = Package(
                 // Only the vector fixture: declaring the whole "Noise"
                 // directory would claim its .swift test files as resources
                 // and silently drop them from compilation.
-                .process("Noise/NoiseTestVectors.json"),
-                // Frozen envelopes produced by the released iOS (733098bb)
-                // and Android (b7f0b33d) private-DM implementations; prove
-                // receive compatibility independently of the local generator.
-                .process("Nostr/Fixtures")
+                .process("Noise/NoiseTestVectors.json")
             ]
         )
     ]

README.md

@@ -8,14 +8,6 @@ A decentralized peer-to-peer messaging app with dual transport architecture: loc
 
 📲 [App Store](https://apps.apple.com/us/app/bitchat-mesh/id6748219622)
 
-📲 [Play Store](https://play.google.com/store/apps/details?id=com.bitchat.droid)
-
-### Getting a copy you can trust
-
-Install from the App Store, or build from source you have verified. A compiled build from anywhere else cannot be verified — see [Verifying bitchat](docs/VERIFYING-A-BUILD.md) for how to check source against the per-release hash manifest, and for what to do if that is the only build you can get.
-
-This matters more than it usually would: this repository has been the target of takedown demands, and when a repository or releases page disappears, mirrors appear that nobody can check.
-
 ## License
 
 This project is released into the public domain. See the [LICENSE](LICENSE) file for details.
@@ -26,8 +18,8 @@ This project is released into the public domain. See the [LICENSE](LICENSE) file
 - **Location-Based Channels**: Geographic chat rooms using geohash coordinates over global Nostr relays
 - **Intelligent Message Routing**: Automatically chooses best transport (Bluetooth → Nostr fallback)
 - **Decentralized Mesh Network**: Automatic peer discovery and multi-hop message relay over Bluetooth LE
-- **Privacy First**: No accounts, no phone numbers, no servers. Note that the mesh does use a persistent per-device identifier derived from your identity key — see [the whitepaper](WHITEPAPER.md) on identity and metadata for what a nearby radio can observe
-- **Private Message End-to-End Encryption**: [Noise Protocol](https://noiseprotocol.org) for mesh, BitChat private envelopes for Nostr fallback
+- **Privacy First**: No accounts, no phone numbers, no persistent identifiers
+- **Private Message End-to-End Encryption**: [Noise Protocol](https://noiseprotocol.org) for mesh, NIP-17 for Nostr
 - **IRC-Style Commands**: Familiar `/slap`, `/msg`, `/who` style interface
 - **Universal App**: Native support for iOS and macOS
 - **Emergency Wipe**: Triple-tap to instantly clear all data
@@ -42,7 +34,7 @@ BitChat uses a **hybrid messaging architecture** with two complementary transpor
 - **Local Communication**: Direct peer-to-peer within Bluetooth range
 - **Multi-hop Relay**: Messages route through nearby devices (max 7 hops)
 - **No Internet Required**: Works completely offline in disaster scenarios
-- **Noise Protocol Encryption**: End-to-end encryption, with forward secrecy for live sessions (store-and-forward mail is sealed without it — see the whitepaper)
+- **Noise Protocol Encryption**: End-to-end encryption with forward secrecy
 - **Binary Protocol**: Compact packet format optimized for Bluetooth LE constraints
 - **Automatic Discovery**: Peer discovery and connection management
 - **Adaptive Power**: Battery-optimized duty cycling
@@ -51,16 +43,10 @@ BitChat uses a **hybrid messaging architecture** with two complementary transpor
 
 - **Global Reach**: Connect with users worldwide via internet relays
 - **Location Channels**: Geographic chat rooms using geohash coordinates
-- **440+ Relay Network**: Distributed across the globe for reliability
-- **BitChat Private Envelopes**: App-specific encrypted private messages over Nostr relays
+- **290+ Relay Network**: Distributed across the globe for reliability
+- **NIP-17 Encryption**: Gift-wrapped private messages for internet privacy
 - **Ephemeral Keys**: Fresh cryptographic identity per geohash area
 
-BitChat's private-envelope format is proprietary and is **not** NIP-17,
-NIP-44, or NIP-59 compatible. It uses Nostr as a relay transport but only
-interoperates with BitChat clients: private payloads travel inside kind-1059
-events whose `v2:`-prefixed content is a BitChat-specific XChaCha20-Poly1305
-construction, not NIP-44 encryption.
-
 ### Channel Types
 
 #### `mesh #bluetooth`
@@ -94,7 +80,7 @@ Private messages use **intelligent transport selection**:
 2. **Nostr Fallback** (when Bluetooth unavailable)
 
    - Uses recipient's Nostr public key
-   - BitChat's app-specific private-envelope encryption
+   - NIP-17 gift-wrapping for privacy
    - Routes through global relay network
 
 3. **Smart Queuing** (when neither available)
@@ -107,62 +93,30 @@ For detailed protocol documentation, see the [Technical Whitepaper](WHITEPAPER.m
 
 ### Option 1: Using Xcode
 
-```bash
-open bitchat.xcodeproj
-```
+   ```bash
+   cd bitchat
+   open bitchat.xcodeproj
+   ```
 
-For a signed device build, create your ignored local configuration and replace
-the example team ID with your Apple Developer Team ID:
-
-```bash
-cp Configs/Local.xcconfig.example Configs/Local.xcconfig
-```
-
-`Local.xcconfig.example` derives unique app and App Group identifiers from that
-team ID. The entitlement files already reference `$(APP_GROUP_ID)`, so tracked
-project or entitlement files do not need to be edited.
-
-Useful command-line checks from the repository root:
-
-```bash
-# macOS Debug build without signing
-xcodebuild -project bitchat.xcodeproj -scheme "bitchat (macOS)" \
-  -configuration Debug CODE_SIGNING_ALLOWED=NO build
-
-# Full SwiftPM test suite
-swift test
-
-# iOS simulator tests
-xcodebuild -project bitchat.xcodeproj -scheme "bitchat (iOS)" \
-  -sdk iphonesimulator \
-  -destination 'platform=iOS Simulator,name=iPhone 17' test
-```
-
-If `iPhone 17` is unavailable, choose an installed simulator from:
-
-```bash
-xcodebuild -showdestinations -project bitchat.xcodeproj -scheme "bitchat (iOS)"
-```
+   To run on a device there're a few steps to prepare the code:
+   - Clone the local configs: `cp Configs/Local.xcconfig.example Configs/Local.xcconfig`
+   - Add your Developer Team ID into the newly created `Configs/Local.xcconfig`
+      - Bundle ID would be set to `chat.bitchat.<team_id>` (unless you set to something else)
+   - Entitlements need to be updated manually (TODO: Automate):
+      - Search and replace `group.chat.bitchat` with `group.<your_bundle_id>` (e.g. `group.chat.bitchat.ABC123`)
 
 ### Option 2: Using `just`
 
-```bash
-brew install just
-just check
-just run
-```
+   ```bash
+   brew install just
+   ```
 
-`just build` and `just run` use the current `bitchat (macOS)` scheme and keep
-Xcode output in the ignored `.DerivedData/` directory. They never patch source,
-project, configuration, or entitlement files.
-
-`just clean` removes only `.DerivedData/` and `.build/`. It does not invoke Git
-or restore tracked files, so uncommitted work is preserved. `just test` runs the
-SwiftPM suite and `just test-ios` runs the iPhone 17 simulator suite.
+Want to try this on macos: `just run` will set it up and run from source.
+Run `just clean` afterwards to restore things to original state for mobile app building and development.
 
 ## Localization
 
-- App localizations live in `bitchat/Localizable.xcstrings`.
-- Share extension strings are separate in `bitchatShareExtension/Localization/Localizable.xcstrings`.
+- Base app resources live under `bitchat/Localization/Base.lproj/`. Add new copy to `Localizable.strings` and plural rules to `Localizable.stringsdict`.
+- Share extension strings are separate in `bitchatShareExtension/Localization/Base.lproj/Localizable.strings`.
 - Prefer keys that describe intent (`app_info.features.offline.title`) and reuse existing ones where possible.
 - Run `xcodebuild -project bitchat.xcodeproj -scheme "bitchat (macOS)" -configuration Debug CODE_SIGNING_ALLOWED=NO build` to compile-check any localization updates.

SECURITY.md

@@ -1,45 +0,0 @@
-# Security policy
-
-bitchat is a security-focused messenger, and reports about its security are taken seriously. This page says how to report, what counts as a vulnerability here, and what to expect.
-
-## Reporting a vulnerability
-
-**Use GitHub's private vulnerability reporting:** [Report a vulnerability](https://github.com/permissionlesstech/bitchat/security/advisories/new) (Security tab → "Report a vulnerability").
-
-Please do not open a public issue for anything that could put people at risk before a fix ships. bitchat is used by people in hostile network environments; a public proof-of-concept can be acted on faster than a patch can reach them.
-
-A useful report says what an attacker can do, against which build (App Store version or commit hash), and how to reproduce it. A failing test or a packet capture is worth more than speculation about impact.
-
-## What to expect
-
-This is a volunteer-maintained project. The aim is to acknowledge reports within a week and to move on confirmed vulnerabilities immediately — historically, confirmed protocol and key-handling issues have been fixed within days. You'll be kept in the loop in the advisory thread, and credited in the fix unless you'd rather not be. There is no bug bounty.
-
-## Supported versions
-
-Fixes ship to the latest App Store release and `main`. Older releases are not patched; the fix is to update.
-
-## Scope
-
-In scope — the properties the app promises:
-
-- Confidentiality and integrity of private messages and media (Noise sessions over BLE; over Nostr, bitchat's own ephemeral private-envelope format — a proprietary scheme, *not* NIP-17/NIP-44/NIP-59, see `WHITEPAPER.md`)
-- Identity: key handling, verification, impersonation, session binding
-- The panic wipe actually destroying what it claims to destroy
-- Metadata exposure beyond what the documentation already discloses (see `PRIVACY_POLICY.md` and `docs/privacy-assessment.md`)
-- Downgrade paths: anything that silently moves traffic from an encrypted path to a plaintext one
-- Tor routing: anything that makes traffic bypass Tor while the Tor preference is on
-- Supply-chain integrity of the source and its vendored binaries (see `docs/VERIFYING-A-BUILD.md`)
-
-Out of scope — documented design properties, not vulnerabilities:
-
-- Public visibility of mesh announces and geohash channels: broadcast content, nicknames, and public keys are public by design
-- Bluetooth proximity being observable: anyone in radio range can tell a BLE device is present
-- Mesh flooding/relay behavior inherent to a broadcast mesh (rate limits exist; the topology is what it is)
-- Behavior of third-party Nostr relays
-- Denial of service requiring physical proximity, and battery-drain attacks in general
-
-If you're unsure whether something is in scope, report it privately anyway — a false alarm costs a few minutes; a real issue reported publicly can cost much more.
-
-## Verifying what you're running
-
-If your concern is that the app or source you have has been tampered with, that has its own document: `docs/VERIFYING-A-BUILD.md`.

WHITEPAPER.md

@@ -18,14 +18,14 @@ bitchat is a decentralized, peer-to-peer messaging application for secure, priva
 * **Authentication:** peers are identified by cryptographic keys; announcements are signed and verified.
 * **Resilience:** the network functions in lossy, low-bandwidth, partitioned environments with churning membership.
 * **Eventual delivery:** a message to an out-of-range peer should still arrive — relayed by the mesh, carried by a moving person, or resting on an internet relay — within a bounded retention window.
-* **Ephemerality by default:** conversation timelines live in memory only. Everything the store-and-forward stack persists is either sealed ciphertext or already-public broadcast traffic, and all of it dies with the panic wipe. Media is the exception: accepted images and voice notes are written to disk unsealed, protected by the platform's data-protection class rather than by app-layer encryption, and bounded by a storage quota.
+* **Ephemerality by default:** no plaintext message content is ever written to disk. Everything the store-and-forward stack persists is either sealed ciphertext or already-public broadcast traffic, and all of it dies with the panic wipe.
 
 ## 2. Architecture Overview
 
 Two transports implement a common `Transport` interface and are coordinated by a `MessageRouter`:
 
 * **BLE mesh** — every device is simultaneously a GATT central and peripheral, relaying packets in a controlled flood. No infrastructure, pairing, or accounts.
-* **Nostr** — private messages to mutual favorites travel in BitChat's app-specific encrypted envelopes over public relays (over Tor where enabled), bridging separate meshes through the internet.
+* **Nostr** — private messages to mutual favorites travel as NIP-17 gift-wrapped events over public relays (over Tor where enabled), bridging separate meshes through the internet.
 
 The router prefers a live mesh link, falls back to Nostr, and engages the courier system when neither can deliver promptly.
 
@@ -36,17 +36,13 @@ Each device holds two long-term key pairs in the Keychain:
 * a **Curve25519 static key** for Noise key agreement — its SHA-256 fingerprint is the peer's stable identity, and
 * an **Ed25519 signing key** for packet signatures.
 
-On the mesh, peers appear under a short 8-byte peer ID. That ID is **not ephemeral**: it is the first 8 bytes of the SHA-256 fingerprint of the device's Noise static key, so it is stable across sessions, reboots, and reinstalls that preserve the keychain, and it changes only when the identity itself is replaced by a panic wipe. Favoriting pins the full Noise public key so identity survives across sessions. Mutual favorites also exchange Nostr public keys for the internet path. Optional QR verification binds a nickname to a fingerprint in person.
-
-Signed announcements additionally carry the nickname, the Noise static public key, and the Ed25519 signing public key in cleartext (§4.5), so a passive receiver in radio range can link a device across time and place regardless of the peer ID. Unlinkable presence is not a property this protocol currently provides; see §9.
+On the mesh, peers appear under short ephemeral IDs derived per session; favoriting pins the full Noise public key so identity survives across sessions. Mutual favorites also exchange Nostr public keys for the internet path. Optional QR verification binds a nickname to a fingerprint in person.
 
 ## 4. BLE Mesh Layer
 
 ### 4.1 Packet Format
 
-A compact binary header (version, type, TTL, timestamp, flags) is followed by an 8-byte sender ID, an optional 8-byte recipient ID, the payload, and an optional Ed25519 signature. Version 2 packets may carry an explicit source route. Signatures exclude the TTL byte so relays can decrement it without invalidating them.
-
-Only `noiseEncrypted` and `noiseHandshake` packets are padded, toward 256/512/1024/2048-byte buckets; every other type — public messages, announcements, board posts, group messages, fragments, files, and voice frames — goes out at its natural length. Padding is PKCS#7-style with pad bytes equal to the pad length, and because that length must fit one byte, a frame needing more than 255 bytes to reach its bucket is emitted unpadded. Payload length is therefore observable for most traffic.
+A compact binary header (version, type, TTL, timestamp, flags) is followed by an 8-byte sender ID, an optional 8-byte recipient ID, the payload, and an optional Ed25519 signature. Version 2 packets may carry an explicit source route. Signatures exclude the TTL byte so relays can decrement it without invalidating them. Packets other than fragments are padded toward uniform sizes.
 
 ### 4.2 Flood Control
 
@@ -82,9 +78,7 @@ Courier envelopes are sealed to the recipient's *static* key with the one-way No
 
 ### 5.3 Nostr Path
 
-Private messages to mutual favorites use BitChat's proprietary private-envelope protocol. An unsigned inner message (kind 14) is encrypted and placed in a sender-signed seal (kind 13); that seal is encrypted again inside a public envelope (kind 1059) signed by a one-time key, so relays learn neither the stable sender identity nor the content. Each encrypted content field is `v2:` followed by base64url of a 24-byte nonce, XChaCha20-Poly1305 ciphertext, and its 16-byte tag. Keys come from secp256k1 ECDH and HKDF-SHA256 (the derivation reuses a "nip44-v2" info label but is not the NIP-44 key schedule).
-
-This format reuses NIP-17/NIP-59 kind numbers but is **not NIP-17, NIP-44, or NIP-59 compatible** and interoperates only with BitChat clients. The outer `p` tag exposes the recipient's Nostr public key to relays; the plaintext and stable sender identity remain inside authenticated ciphertext. Public seal and envelope timestamps are randomized by up to ±15 minutes, while the actual message timestamp is encrypted. The protocol does not provide forward secrecy: compromise of the recipient's static Nostr private key can expose stored envelopes addressed to that key.
+Private messages to mutual favorites are wrapped per NIP-17/NIP-59: a rumor (kind 14) sealed (kind 13) and gift-wrapped (kind 1059) under a throwaway ephemeral key, so relays learn neither sender nor content.
 
 ## 6. Store and Forward
 
@@ -111,7 +105,7 @@ Public broadcast messages are cached (1000 packets) and reconciled between peers
 
 ### 6.4 Nostr Mailboxes
 
-BitChat private envelopes rest on Nostr relays; clients re-subscribe with a 24-hour lookback on reconnect, covering the both-devices-offline case for mutual favorites whenever either side touches the internet.
+Gift-wrapped messages rest on Nostr relays; clients re-subscribe with a 24-hour lookback on reconnect, covering the both-devices-offline case for mutual favorites whenever either side touches the internet.
 
 ### 6.5 Delivery Metrics
 
@@ -128,12 +122,12 @@ Bare local counters (deposits, handovers, sprays, opens, outbox flushes and drop
 
 ## 8. Security Considerations
 
-* **Relay nodes** cannot read private traffic; they forward opaque ciphertext. Padding applies to Noise frames only (§4.1), so other packet types relay at their natural length.
+* **Relay nodes** cannot read private traffic; they forward padded, opaque ciphertext.
 * **Couriers** are quota-bounded mailbags. A malicious courier can drop mail (redundant copies and deposit retry mitigate this) but cannot read it, link it across days, or amplify it — copy budgets are capped and every envelope is validated against size and lifetime policy on deposit.
 * **Flooding abuse** is bounded by TTL clamps, deduplication, per-depositor quotas, connect-rate limits, and announce-rate limiting.
 * **Replay** of public broadcasts is bounded by the 6-hour acceptance window plus deduplication; private payloads are protected by Noise nonces.
-* **Metadata is the weakest part of this design, and the peer ID does not help.** The 8-byte sender ID in every packet header is derived from a never-rotating key (§3), and announcements publish the static keys and nickname in cleartext, so a passive listener can enumerate participants and follow a device between places. Announcements also carry up to ten direct-neighbor IDs (§4.3), which hands a single sniffer the local adjacency graph. Origin packets leave at the default TTL, so hop distance identifies the originator. Daily-rotating courier tags do limit correlation of carried mail, and Nostr traffic can ride Tor. Addressing the radio-layer exposure is future work (§9).
-* **No forward secrecy for sealed mail or Nostr private envelopes** (§5.2–5.3) means compromise of a recipient's static key can expose retained ciphertext addressed to that key.
+* **Metadata.** BLE proximity is inherently observable; ephemeral IDs and daily-rotating courier tags limit long-term correlation. Nostr traffic can ride Tor.
+* **No forward secrecy for sealed mail** (§5.2) is the main cryptographic trade-off of the offline path.
 
 ## 9. Future Work
 
@@ -141,9 +135,6 @@ Bare local counters (deposits, handovers, sprays, opens, outbox flushes and drop
 * Couriered media beyond the 16 KiB text cap.
 * Probabilistic relay and edge-of-network TTL boosting for very dense and very sparse graphs.
 * Multi-hop courier routing informed by encounter history.
-* **Rotating on-air identity.** Epoch-rotating peer IDs, with static-key disclosure moved inside the encrypted handshake and mutual favorites recognising each other through a tag derived from their shared secret, so presence stops being linkable across sessions (§3, §8).
-* **Padding for non-Noise packet types**, and closing the gap where a frame needing more than 255 bytes of padding is emitted unpadded (§4.1).
-* Making the neighbor list in announcements optional, or restricted to authenticated links (§4.3).
 
 ---
 

bitchat.xcodeproj/project.pbxproj

@@ -70,7 +70,6 @@
 		A6E32D1B2E762EA70032EA8A /* Exceptions for "bitchat" folder in "bitchatShareExtension" target */ = {
 			isa = PBXFileSystemSynchronizedBuildFileExceptionSet;
 			membershipExceptions = (
-				Services/SharedContentHandoff.swift,
 				Services/TransportConfig.swift,
 			);
 			target = 57CA17A36A2532A6CFF367BB /* bitchatShareExtension */;
@@ -93,7 +92,7 @@
 		A6E32D232E762EAB0032EA8A /* Exceptions for "bitchatShareExtension" folder in "bitchatShareExtension" target */ = {
 			isa = PBXFileSystemSynchronizedBuildFileExceptionSet;
 			membershipExceptions = (
-				Info.plist,
+				ShareViewController.swift,
 			);
 			target = 57CA17A36A2532A6CFF367BB /* bitchatShareExtension */;
 		};
@@ -259,13 +258,9 @@
 			buildConfigurationList = E4EA6DC648DF55FF84032EB5 /* Build configuration list for PBXNativeTarget "bitchatShareExtension" */;
 			buildPhases = (
 				0A08E70F08F55FD5BA8C7EF3 /* Sources */,
-				7E9B64F63F93443FB7BA12DF /* Resources */,
 			);
 			buildRules = (
 			);
-			fileSystemSynchronizedGroups = (
-				A6E32D212E762EAB0032EA8A /* bitchatShareExtension */,
-			);
 			name = bitchatShareExtension;
 			productName = bitchatShareExtension;
 			productReference = 61F92EBA29C47C0FCC482F1F /* bitchatShareExtension.appex */;
@@ -337,7 +332,6 @@
 				es,
 				ar,
 				de,
-				fa,
 				fr,
 				he,
 				id,
@@ -378,11 +372,6 @@
 				E0A1B2C3D4E5F6012345678D /* relays/online_relays_gps.csv in Resources */,
 			);
 		};
-		7E9B64F63F93443FB7BA12DF /* Resources */ = {
-			isa = PBXResourcesBuildPhase;
-			files = (
-			);
-		};
 		C5E027A42ECCDFD700BD6012 /* Resources */ = {
 			isa = PBXResourcesBuildPhase;
 			files = (

bitchat/App/AppArchitecture.swift

@@ -2,6 +2,11 @@ import BitFoundation
 import Combine
 import Foundation
 
+enum SharedContentKind: String, Sendable, Equatable {
+    case text
+    case url
+}
+
 enum RuntimeScenePhase: String, Sendable, Equatable {
     case active
     case inactive
@@ -13,8 +18,6 @@ enum TorLifecycleEvent: String, Sendable, Equatable {
     case willRestart
     case didBecomeReady
     case preferenceChanged
-    /// Bootstrap ran out its deadline without completing.
-    case bootstrapDidStall
 }
 
 enum AppEvent: Sendable, Equatable {
@@ -22,7 +25,7 @@ enum AppEvent: Sendable, Equatable {
     case startupCompleted
     case scenePhaseChanged(RuntimeScenePhase)
     case openedURL(String)
-    case sharedContentReadyForReview(SharedContentKind)
+    case sharedContentAccepted(SharedContentKind)
     case notificationOpened(peerID: PeerID?)
     case deepLinkOpened(String)
     case torLifecycleChanged(TorLifecycleEvent)

bitchat/App/AppChromeModel.swift

@@ -17,34 +17,16 @@ final class AppChromeModel: ObservableObject {
     @Published var showBluetoothAlert = false
     @Published var bluetoothAlertMessage = ""
     @Published var bluetoothState: CBManagerState = .unknown
-    /// Tor bootstrap has stalled (network likely blocks it); drives the
-    /// connectivity banner. Mirrored from `ChatViewModel.torBlocked`.
-    @Published private(set) var torBlocked = false
     @Published var showScreenshotPrivacyWarning = false
-    /// Triple-tapping the logo asks first; the dialog lives on the header.
-    @Published var showPanicConfirmation = false
-    /// Mirrors `ChatViewModel.panicRecoveryBlocked` for the chrome: a wipe
-    /// that did not commit must be visible, not just logged — the person who
-    /// triggered it needs to know data may remain on the device.
-    @Published private(set) var panicWipeBlocked = false
 
     private let chatViewModel: ChatViewModel
-    private let onPanicWipe: () -> Void
     private var cancellables = Set<AnyCancellable>()
-    /// The composer owns capture state above ChatViewModel. ContentView
-    /// installs this hook so both panic entry points synchronously stop it.
-    private var prepareForPanic: (@MainActor () -> Void)?
 
     /// Bulletin-board coordinator, created on first use of the board sheet.
     private(set) lazy var boardManager = BoardManager(transport: chatViewModel.meshService)
 
-    init(
-        chatViewModel: ChatViewModel,
-        privateInboxModel: PrivateInboxModel,
-        onPanicWipe: @escaping () -> Void = {}
-    ) {
+    init(chatViewModel: ChatViewModel, privateInboxModel: PrivateInboxModel) {
         self.chatViewModel = chatViewModel
-        self.onPanicWipe = onPanicWipe
         self.nickname = chatViewModel.nickname
 
         bind(privateInboxModel: privateInboxModel)
@@ -94,8 +76,7 @@ final class AppChromeModel: ObservableObject {
     /// neighbor claim but never announced to us) fall back to a short ID.
     func meshTopologyDisplayModel() -> MeshTopologyDisplayModel {
         let mesh = chatViewModel.meshService
-        guard let diagnostics = mesh as? MeshDiagnosing,
-              let snapshot = diagnostics.currentMeshTopology() else { return .empty }
+        guard let snapshot = mesh.currentMeshTopology() else { return .empty }
         let nicknames = mesh.getPeerNicknames()
 
         let nodes = snapshot.nodes.map { peerID -> MeshTopologyDisplayModel.Node in
@@ -116,30 +97,7 @@ final class AppChromeModel: ObservableObject {
         showScreenshotPrivacyWarning = true
     }
 
-    func setPanicPreparation(_ preparation: (@MainActor () -> Void)?) {
-        prepareForPanic = preparation
-    }
-
-    /// Entry point for the header triple-tap: confirm before destroying.
-    /// The Settings-pane button has always confirmed; the gesture now goes
-    /// through the same dialog so a mis-tap can't wipe the device.
-    func requestPanicWipe() {
-        showPanicConfirmation = true
-    }
-
     func panicClearAllData() {
-        // A wipe invalidates everything on screen, and its outcome must be
-        // visible: the success message and the failed-wipe banner both live
-        // on the root timeline, so a sheet left up (the App Info danger-zone
-        // path keeps its sheet presented) would hide the one signal that says
-        // whether the wipe worked.
-        isAppInfoPresented = false
-        isLocationChannelsSheetPresented = false
-        isNoticesSheetPresented = false
-        showingFingerprintFor = nil
-
-        prepareForPanic?()
-        onPanicWipe()
         chatViewModel.panicClearAllData()
     }
 
@@ -171,14 +129,6 @@ final class AppChromeModel: ObservableObject {
             .receive(on: DispatchQueue.main)
             .assign(to: &$bluetoothState)
 
-        chatViewModel.$torBlocked
-            .receive(on: DispatchQueue.main)
-            .assign(to: &$torBlocked)
-
-        chatViewModel.$panicRecoveryBlocked
-            .receive(on: DispatchQueue.main)
-            .assign(to: &$panicWipeBlocked)
-
         hasUnreadPrivateMessages = !privateInboxModel.unreadPeerIDs.isEmpty
     }
 }

bitchat/App/AppRuntime.swift

@@ -27,7 +27,6 @@ final class AppRuntime: ObservableObject {
     let peerListModel: PeerListModel
     let appChromeModel: AppChromeModel
     let boardAlertsModel: BoardAlertsModel
-    let sharedContentImportModel: SharedContentImportModel
 
     private let idBridge: NostrIdentityBridge
     private var cancellables = Set<AnyCancellable>()
@@ -42,8 +41,7 @@ final class AppRuntime: ObservableObject {
 
     init(
         keychain: KeychainManagerProtocol = KeychainManager.makeDefault(),
-        idBridge: NostrIdentityBridge = NostrIdentityBridge(),
-        sharedContentStore: SharedContentStore? = nil
+        idBridge: NostrIdentityBridge = NostrIdentityBridge()
     ) {
         self.idBridge = idBridge
         let conversations = ConversationStore()
@@ -86,20 +84,9 @@ final class AppRuntime: ObservableObject {
             peerIdentityStore: peerIdentityStore,
             locationPresenceStore: locationPresenceStore
         )
-        let resolvedSharedContentStore: SharedContentStore?
-        if let sharedContentStore {
-            resolvedSharedContentStore = sharedContentStore
-        } else if let sharedDefaults = UserDefaults(suiteName: BitchatApp.groupID) {
-            resolvedSharedContentStore = SharedContentStore(defaults: sharedDefaults)
-        } else {
-            resolvedSharedContentStore = nil
-        }
-        let sharedContentImportModel = SharedContentImportModel(store: resolvedSharedContentStore)
-        self.sharedContentImportModel = sharedContentImportModel
         self.appChromeModel = AppChromeModel(
             chatViewModel: self.chatViewModel,
-            privateInboxModel: self.privateInboxModel,
-            onPanicWipe: { sharedContentImportModel.discardAll() }
+            privateInboxModel: self.privateInboxModel
         )
         let chatViewModel = self.chatViewModel
         self.boardAlertsModel = BoardAlertsModel(
@@ -119,15 +106,13 @@ final class AppRuntime: ObservableObject {
                 }
             )
         )
-        if chatViewModel.networkActivationAllowed {
-            GeoRelayDirectory.shared.prefetchIfNeeded()
-        }
+
+        GeoRelayDirectory.shared.prefetchIfNeeded()
         bindRuntimeObservers()
         NotificationDelegate.shared.runtime = self
     }
 
     func start() {
-        guard chatViewModel.networkActivationAllowed else { return }
         guard !started else {
             checkForSharedContent()
             return
@@ -152,26 +137,11 @@ final class AppRuntime: ObservableObject {
         NetworkActivationService.shared.start()
         GeohashPresenceService.shared.start()
         checkForSharedContent()
-        performMediaMaintenance()
 
         record(.launched)
         record(.startupCompleted)
     }
 
-    /// Drops media that has outlived the retention window, then applies the
-    /// explicit protection class to files that older builds wrote without
-    /// one. Expiry runs first so the migration never touches files the
-    /// sweep is about to delete. Detached because `AppRuntime` is
-    /// main-actor and both passes go file by file through the media tree;
-    /// best-effort, nothing at launch depends on their results.
-    private func performMediaMaintenance() {
-        Task.detached(priority: .utility) {
-            let store = BLEIncomingFileStore()
-            store.expireAgedMedia()
-            store.migrateFileProtectionIfNeeded()
-        }
-    }
-
     func handleOpenURL(_ url: URL) {
         record(.openedURL(url.absoluteString))
 
@@ -181,14 +151,12 @@ final class AppRuntime: ObservableObject {
     }
 
     func handleDidBecomeActiveNotification() {
-        guard chatViewModel.networkActivationAllowed else { return }
         chatViewModel.handleDidBecomeActive()
         checkForSharedContent()
     }
 
     #if os(macOS)
     func handleMacDidBecomeActiveNotification() {
-        guard chatViewModel.networkActivationAllowed else { return }
         record(.scenePhaseChanged(.active))
         chatViewModel.handleDidBecomeActive()
         checkForSharedContent()
@@ -207,7 +175,6 @@ final class AppRuntime: ObservableObject {
             didEnterBackground = true
 
         case .active:
-            guard chatViewModel.networkActivationAllowed else { return }
             record(.scenePhaseChanged(.active))
             chatViewModel.meshService.startServices()
             TorManager.shared.setAppForeground(true)
@@ -255,7 +222,6 @@ final class AppRuntime: ObservableObject {
         actionIdentifier: String = UNNotificationDefaultActionIdentifier,
         userInfo: [AnyHashable: Any]
     ) {
-        guard chatViewModel.networkActivationAllowed else { return }
         if actionIdentifier == NotificationService.waveActionID {
             chatViewModel.sendMeshWave()
             return
@@ -307,8 +273,6 @@ private extension AppRuntime {
         NotificationCenter.default.publisher(for: .TorWillRestart)
             .receive(on: DispatchQueue.main)
             .sink { [weak self] _ in
-                guard self?.chatViewModel.networkActivationAllowed == true
-                else { return }
                 self?.record(.torLifecycleChanged(.willRestart))
                 self?.chatViewModel.handleTorWillRestart()
             }
@@ -317,8 +281,6 @@ private extension AppRuntime {
         NotificationCenter.default.publisher(for: .TorDidBecomeReady)
             .receive(on: DispatchQueue.main)
             .sink { [weak self] _ in
-                guard self?.chatViewModel.networkActivationAllowed == true
-                else { return }
                 self?.record(.torLifecycleChanged(.didBecomeReady))
                 self?.chatViewModel.handleTorDidBecomeReady()
             }
@@ -327,28 +289,14 @@ private extension AppRuntime {
         NotificationCenter.default.publisher(for: .TorWillStart)
             .receive(on: DispatchQueue.main)
             .sink { [weak self] _ in
-                guard self?.chatViewModel.networkActivationAllowed == true
-                else { return }
                 self?.record(.torLifecycleChanged(.willStart))
                 self?.chatViewModel.handleTorWillStart()
             }
             .store(in: &cancellables)
 
-        NotificationCenter.default.publisher(for: .TorBootstrapDidStall)
-            .receive(on: DispatchQueue.main)
-            .sink { [weak self] _ in
-                guard self?.chatViewModel.networkActivationAllowed == true
-                else { return }
-                self?.record(.torLifecycleChanged(.bootstrapDidStall))
-                self?.chatViewModel.handleTorBootstrapDidStall()
-            }
-            .store(in: &cancellables)
-
         NotificationCenter.default.publisher(for: .TorUserPreferenceChanged)
             .receive(on: DispatchQueue.main)
             .sink { [weak self] notification in
-                guard self?.chatViewModel.networkActivationAllowed == true
-                else { return }
                 self?.record(.torLifecycleChanged(.preferenceChanged))
                 self?.chatViewModel.handleTorPreferenceChanged(notification)
             }
@@ -365,22 +313,36 @@ private extension AppRuntime {
     }
 
     func checkForSharedContent() {
-        let previousID = sharedContentImportModel.offer?.id
-        guard let payload = sharedContentImportModel.refresh(
-            destination: currentSharedContentDestination
-        ) else { return }
-
-        if previousID != payload.id {
-            record(.sharedContentReadyForReview(payload.kind))
+        guard let userDefaults = UserDefaults(suiteName: BitchatApp.groupID),
+              let sharedContent = userDefaults.string(forKey: "sharedContent"),
+              let sharedDate = userDefaults.object(forKey: "sharedContentDate") as? Date else {
+            return
         }
-    }
 
-    var currentSharedContentDestination: SharedContentDestination {
-        SharedContentDestination.resolve(
-            selectedPrivatePeerID: privateConversationModel.selectedPeerID,
-            privateDisplayName: privateConversationModel.selectedHeaderState?.displayName,
-            activeChannel: locationChannelsModel.selectedChannel
-        )
+        guard Date().timeIntervalSince(sharedDate) < TransportConfig.uiShareAcceptWindowSeconds else {
+            return
+        }
+
+        let contentKind = SharedContentKind(rawValue: userDefaults.string(forKey: "sharedContentType") ?? "") ?? .text
+
+        userDefaults.removeObject(forKey: "sharedContent")
+        userDefaults.removeObject(forKey: "sharedContentType")
+        userDefaults.removeObject(forKey: "sharedContentDate")
+
+        switch contentKind {
+        case .url:
+            if let data = sharedContent.data(using: .utf8),
+               let urlData = try? JSONSerialization.jsonObject(with: data) as? [String: String],
+               let url = urlData["url"] {
+                chatViewModel.sendMessage(url)
+            } else {
+                chatViewModel.sendMessage(sharedContent)
+            }
+        case .text:
+            chatViewModel.sendMessage(sharedContent)
+        }
+
+        record(.sharedContentAccepted(contentKind))
     }
 
     func handleNostrRelayConnectionChanged(_ isConnected: Bool) {
@@ -389,9 +351,7 @@ private extension AppRuntime {
         let becameConnected = isConnected && !lastNostrRelayConnectedState
         lastNostrRelayConnectedState = isConnected
 
-        guard chatViewModel.networkActivationAllowed,
-              started,
-              becameConnected else { return }
+        guard started, becameConnected else { return }
 
         let isInitialConnection = !didHandleInitialNostrConnection
         didHandleInitialNostrConnection = true
@@ -424,24 +384,16 @@ private extension AppRuntime {
     }
 
     func handleScreenshotCaptured() {
-        let isLocationChannelActive: Bool = {
-            if case .location = chatViewModel.activeChannel { return true }
-            return false
-        }()
-
-        switch Self.resolveScreenshotResponse(
-            isLocationChannelsSheetPresented: appChromeModel.isLocationChannelsSheetPresented,
-            isAppInfoPresented: appChromeModel.isAppInfoPresented,
-            hasPrivateChatOpen: chatViewModel.selectedPrivateChatPeer != nil,
-            isLocationChannelActive: isLocationChannelActive
-        ) {
-        case .warnLocally:
+        if appChromeModel.isLocationChannelsSheetPresented {
             appChromeModel.triggerScreenshotPrivacyWarning()
-        case .ignore:
-            break
-        case .forwardToChat:
-            chatViewModel.handleScreenshotCaptured()
+            return
         }
+
+        if appChromeModel.isAppInfoPresented {
+            return
+        }
+
+        chatViewModel.handleScreenshotCaptured()
     }
 
     func openExternalURL(_ url: URL) {
@@ -458,40 +410,3 @@ private extension AppRuntime {
         }
     }
 }
-
-// MARK: - Screenshot routing
-
-extension AppRuntime {
-    /// What a screenshot triggers. Nothing on this table sends anything to
-    /// a public channel (see `ChatLifecycleCoordinator.handleScreenshotCaptured`).
-    enum ScreenshotCaptureResponse: Equatable {
-        /// Show the local location-privacy alert; nothing is sent anywhere.
-        case warnLocally
-        /// Do nothing. App Info holds no conversation or location content.
-        case ignore
-        /// Hand to the chat layer: a DM notice goes to the peer when a
-        /// secure session exists; public timelines stay silent. Mesh
-        /// deliberately gets no local alert either — a mesh screenshot
-        /// reveals no place and triggers no send, so there is nothing to
-        /// warn about, and alerting on every screenshot would train people
-        /// to dismiss the one alert that matters (the location one).
-        case forwardToChat
-    }
-
-    /// Pure decision table so the screenshot routing is testable without a
-    /// runtime.
-    nonisolated static func resolveScreenshotResponse(
-        isLocationChannelsSheetPresented: Bool,
-        isAppInfoPresented: Bool,
-        hasPrivateChatOpen: Bool,
-        isLocationChannelActive: Bool
-    ) -> ScreenshotCaptureResponse {
-        if isLocationChannelsSheetPresented { return .warnLocally }
-        if isAppInfoPresented { return .ignore }
-        // A geohash timeline screenshot still reveals a place — warn the
-        // person taking it, locally, with the same alert the channel sheet
-        // uses.
-        if !hasPrivateChatOpen, isLocationChannelActive { return .warnLocally }
-        return .forwardToChat
-    }
-}

bitchat/App/ConversationStore.swift

@@ -39,17 +39,15 @@ final class Conversation: ObservableObject, Identifiable {
     @Published private(set) var messages: [BitchatMessage] = []
     @Published private(set) var isUnread: Bool = false
 
-    /// Incrementally-maintained message-ID → logical-index map for O(1)
-    /// dedup and delivery-status lookup. Logical indexes are physical array
-    /// indexes plus `indexOffset`; trimming from the head advances the offset
-    /// instead of rewriting every surviving dictionary entry. This matters
-    /// after the 1337-message cap is reached, when every steady-state tail
-    /// append evicts one old row.
-    ///
-    /// Out-of-order inserts and middle removals still reindex only the
-    /// affected suffix. Full filtering resets the offset while rebuilding.
+    /// Incrementally-maintained message-ID → index map for O(1) dedup and
+    /// delivery-status lookup. Kept in sync on every mutation:
+    /// - tail append: single insert
+    /// - out-of-order insert: suffix reindex from the insertion point
+    /// - trim: full rebuild — `removeFirst(k)` is already O(n), so the
+    ///   rebuild does not change the asymptotics, and trim only happens once
+    ///   the cap (1337) is reached. Simple and correct beats the
+    ///   offset-tracking alternative here.
     private var indexByMessageID: [String: Int] = [:]
-    private var indexOffset = 0
 
     fileprivate init(id: ConversationID, cap: Int) {
         self.id = id
@@ -63,7 +61,7 @@ final class Conversation: ObservableObject, Identifiable {
     }
 
     func message(withID messageID: String) -> BitchatMessage? {
-        guard let index = physicalIndex(forMessageID: messageID) else { return nil }
+        guard let index = indexByMessageID[messageID] else { return nil }
         return messages[index]
     }
 
@@ -103,7 +101,7 @@ final class Conversation: ObservableObject, Identifiable {
             reindex(from: index)
         } else {
             messages.append(message)
-            indexByMessageID[message.id] = indexOffset + messages.count - 1
+            indexByMessageID[message.id] = messages.count - 1
         }
 
         return InsertResult(inserted: true, trimmedMessageIDs: trimIfNeeded())
@@ -113,7 +111,7 @@ final class Conversation: ObservableObject, Identifiable {
     /// timeline position (in-place updates like media progress reuse the
     /// original timestamp); a new message goes through ordered insertion.
     fileprivate func upsert(_ message: BitchatMessage) -> UpsertOutcome {
-        if let index = physicalIndex(forMessageID: message.id) {
+        if let index = indexByMessageID[message.id] {
             messages[index] = message
             return .updated
         }
@@ -127,7 +125,7 @@ final class Conversation: ObservableObject, Identifiable {
     /// `.read` is never downgraded to `.delivered` or `.sent`.
     /// Returns `true` when the status was applied.
     fileprivate func applyDeliveryStatus(_ status: DeliveryStatus, forMessageID messageID: String) -> Bool {
-        guard let index = physicalIndex(forMessageID: messageID) else { return false }
+        guard let index = indexByMessageID[messageID] else { return false }
         let message = messages[index]
         guard !Self.shouldSkipStatusUpdate(current: message.deliveryStatus, new: status) else { return false }
 
@@ -144,7 +142,7 @@ final class Conversation: ObservableObject, Identifiable {
     /// observers still need an @Published emission to re-render.
     @discardableResult
     fileprivate func republishMessage(withID messageID: String) -> Bool {
-        guard let index = physicalIndex(forMessageID: messageID) else { return false }
+        guard let index = indexByMessageID[messageID] else { return false }
         messages[index] = messages[index]
         return true
     }
@@ -159,14 +157,10 @@ final class Conversation: ObservableObject, Identifiable {
     /// Removes a single message by ID. Returns the removed message, or
     /// `nil` when no message with that ID exists.
     fileprivate func remove(messageID: String) -> BitchatMessage? {
-        guard let index = physicalIndex(forMessageID: messageID) else { return nil }
+        guard let index = indexByMessageID[messageID] else { return nil }
         let removed = messages.remove(at: index)
         indexByMessageID.removeValue(forKey: messageID)
-        if index == 0 {
-            indexOffset += 1
-        } else {
-            reindex(from: index)
-        }
+        reindex(from: index)
         return removed
     }
 
@@ -183,7 +177,6 @@ final class Conversation: ObservableObject, Identifiable {
         for id in removedIDs {
             indexByMessageID.removeValue(forKey: id)
         }
-        indexOffset = 0
         reindex(from: 0)
         return removedIDs
     }
@@ -191,7 +184,6 @@ final class Conversation: ObservableObject, Identifiable {
     fileprivate func clearMessages() {
         messages.removeAll()
         indexByMessageID.removeAll()
-        indexOffset = 0
     }
 
     // MARK: Diagnostics
@@ -213,10 +205,9 @@ final class Conversation: ObservableObject, Identifiable {
             let message = messages[position]
             // Count equality + every message resolving to its own position
             // proves the index is exactly the inverse map (no stale extras).
-            if let logicalIndex = indexByMessageID[message.id] {
-                let expectedIndex = indexOffset + position
-                if logicalIndex != expectedIndex {
-                    violations.append("\(label): message \(message.id.prefix(8))… at \(position) indexed at \(logicalIndex - indexOffset)")
+            if let index = indexByMessageID[message.id] {
+                if index != position {
+                    violations.append("\(label): message \(message.id.prefix(8))… at \(position) indexed at \(index)")
                 }
             } else {
                 violations.append("\(label): message \(message.id.prefix(8))… at \(position) missing from index")
@@ -230,32 +221,12 @@ final class Conversation: ObservableObject, Identifiable {
 
     // MARK: Internals
 
-    static func shouldSkipStatusUpdate(current: DeliveryStatus, new: DeliveryStatus) -> Bool {
+    static func shouldSkipStatusUpdate(current: DeliveryStatus?, new: DeliveryStatus) -> Bool {
+        guard let current else { return false }
         if current == new { return true }
 
-        // Never downgrade to a weaker delivery state. Ordering of certainty:
-        // sending < sent < carried < delivered < read. A late `.sent` write
-        // (e.g. the optimistic stamp after routing) must not clobber the
-        // `.carried` the router already set when it handed a copy to a
-        // courier/bridge, nor a `.delivered`/`.read` ack. A late asynchronous
-        // failure is weaker than a confirmed recipient receipt too, so it may
-        // not replace `.delivered`/`.read`. Same for the
-        // `.sending` stamp a pre-handshake resend emits asynchronously: it
-        // can land after the message already reached `.sent`, and "Sent" was
-        // already truthful. (`.failed` → `.sending` stays allowed so a real
-        // failure retry is visible.)
         switch (current, new) {
-        case (.read, .delivered), (.read, .carried), (.read, .sent), (.read, .sending), (.read, .failed):
-            return true
-        case (.delivered, .carried), (.delivered, .sent), (.delivered, .sending), (.delivered, .failed):
-            return true
-        case (.carried, .sent), (.carried, .sending):
-            return true
-        case (.sent, .sending):
-            return true
-        case (_, .notSentYet):
-            // .notSentYet is the pre-transport initial state; once a message
-            // has any real status, resetting to it is always a downgrade.
+        case (.read, .delivered), (.read, .sent):
             return true
         default:
             return false
@@ -281,17 +252,10 @@ final class Conversation: ObservableObject, Identifiable {
 
     private func reindex(from start: Int) {
         for index in start..<messages.count {
-            indexByMessageID[messages[index].id] = indexOffset + index
+            indexByMessageID[messages[index].id] = index
         }
     }
 
-    private func physicalIndex(forMessageID messageID: String) -> Int? {
-        guard let logicalIndex = indexByMessageID[messageID] else { return nil }
-        let index = logicalIndex - indexOffset
-        guard messages.indices.contains(index) else { return nil }
-        return index
-    }
-
     /// Trims oldest messages over the cap; returns the trimmed message IDs.
     private func trimIfNeeded() -> [String] {
         guard messages.count > cap else { return [] }
@@ -301,7 +265,7 @@ final class Conversation: ObservableObject, Identifiable {
             indexByMessageID.removeValue(forKey: id)
         }
         messages.removeFirst(overflow)
-        indexOffset += overflow
+        reindex(from: 0)
         return trimmedIDs
     }
 }
@@ -445,40 +409,6 @@ final class ConversationStore: ObservableObject {
     @discardableResult
     func setDeliveryStatus(_ status: DeliveryStatus, forMessageID messageID: String) -> Bool {
         guard let ids = conversationIDsByMessageID[messageID] else { return false }
-        return applyDeliveryStatus(status, forMessageID: messageID, among: ids)
-    }
-
-    /// Applies an authenticated delivery/read receipt only to the supplied
-    /// direct-conversation aliases. A colliding message ID in another peer's
-    /// conversation (or a public timeline) must not inherit the receipt.
-    ///
-    /// Stable and ephemeral aliases can temporarily hold the same message
-    /// instance during handoff. The shared helper republishes every targeted
-    /// alias even when the first mutation already changed that instance.
-    @discardableResult
-    func setDeliveryStatus(
-        _ status: DeliveryStatus,
-        forMessageID messageID: String,
-        inDirectPeerAliases peerIDs: Set<PeerID>
-    ) -> Bool {
-        guard !peerIDs.isEmpty,
-              let indexedIDs = conversationIDsByMessageID[messageID] else {
-            return false
-        }
-        let allowedIDs = Set(peerIDs.map { ConversationID.directPeer($0) })
-        return applyDeliveryStatus(
-            status,
-            forMessageID: messageID,
-            among: indexedIDs.intersection(allowedIDs)
-        )
-    }
-
-    private func applyDeliveryStatus(
-        _ status: DeliveryStatus,
-        forMessageID messageID: String,
-        among ids: Set<ConversationID>
-    ) -> Bool {
-        guard !ids.isEmpty else { return false }
         var applied = false
         var skipped: [ConversationID] = []
         for id in ids {
@@ -897,8 +827,8 @@ extension Conversation {
     /// (positions 0 and 1 swap their index entries). Requires >= 2 messages.
     func _testCorruptIndexEntries() {
         guard messages.count >= 2 else { return }
-        indexByMessageID[messages[0].id] = indexOffset + 1
-        indexByMessageID[messages[1].id] = indexOffset
+        indexByMessageID[messages[0].id] = 1
+        indexByMessageID[messages[1].id] = 0
     }
 
     /// Drops a message's index entry entirely (count mismatch + missing).
@@ -912,8 +842,8 @@ extension Conversation {
     func _testCorruptOrderingPreservingIndex() {
         guard messages.count >= 2 else { return }
         messages.swapAt(0, messages.count - 1)
-        indexByMessageID[messages[0].id] = indexOffset
-        indexByMessageID[messages[messages.count - 1].id] = indexOffset + messages.count - 1
+        indexByMessageID[messages[0].id] = 0
+        indexByMessageID[messages[messages.count - 1].id] = messages.count - 1
     }
 }
 
@@ -953,7 +883,7 @@ extension ConversationStore {
 extension Conversation {
     fileprivate func _testAppendBypassingTrim(_ message: BitchatMessage) {
         messages.append(message)
-        indexByMessageID[message.id] = indexOffset + messages.count - 1
+        indexByMessageID[message.id] = messages.count - 1
     }
 }
 #endif

bitchat/App/ConversationUIModel.swift

@@ -9,11 +9,9 @@ import UIKit
 final class ConversationUIModel: ObservableObject {
     @Published private(set) var showAutocomplete = false
     @Published private(set) var autocompleteSuggestions: [String] = []
-    @Published private(set) var selectedAutocompleteIndex = 0
     @Published private(set) var currentNickname: String
     @Published private(set) var isBatchingPublic = false
     @Published private(set) var canSendMediaInCurrentContext = true
-    @Published private(set) var legacyPrivateMediaConsentRequest: LegacyPrivateMediaConsentRequest?
     /// Who is talking live in the public mesh channel right now (floor
     /// courtesy: the composer mic tints "busy" while someone holds the floor).
     @Published private(set) var activeLiveVoiceTalker: String?
@@ -37,7 +35,6 @@ final class ConversationUIModel: ObservableObject {
         self.isBatchingPublic = chatViewModel.isBatchingPublic
         self.showAutocomplete = chatViewModel.showAutocomplete
         self.autocompleteSuggestions = chatViewModel.autocompleteSuggestions
-        self.selectedAutocompleteIndex = chatViewModel.selectedAutocompleteIndex
         self.canSendMediaInCurrentContext = chatViewModel.canSendMediaInCurrentContext
 
         bind()
@@ -106,31 +103,6 @@ final class ConversationUIModel: ObservableObject {
         chatViewModel.completeNickname(nickname, in: &text)
     }
 
-    /// Accept the currently highlighted mention suggestion, if any.
-    func completeSelectedSuggestion(in text: inout String) -> Bool {
-        guard showAutocomplete,
-              autocompleteSuggestions.indices.contains(selectedAutocompleteIndex)
-        else { return false }
-        _ = completeNickname(autocompleteSuggestions[selectedAutocompleteIndex], in: &text)
-        return true
-    }
-
-    /// Dismiss the mention suggestion panel without inserting (Escape).
-    func dismissAutocomplete() {
-        guard showAutocomplete else { return }
-        chatViewModel.showAutocomplete = false
-        chatViewModel.autocompleteSuggestions = []
-        chatViewModel.autocompleteRange = nil
-        chatViewModel.selectedAutocompleteIndex = 0
-    }
-
-    func moveAutocompleteSelection(by delta: Int) {
-        guard showAutocomplete, !autocompleteSuggestions.isEmpty else { return }
-        let count = min(4, autocompleteSuggestions.count)
-        let next = (selectedAutocompleteIndex + delta + count) % count
-        chatViewModel.selectedAutocompleteIndex = next
-    }
-
     func formatMessage(_ message: BitchatMessage, colorScheme: ColorScheme, theme: AppTheme? = nil) -> AttributedString {
         chatViewModel.formatMessageAsText(message, colorScheme: colorScheme, theme: theme)
     }
@@ -155,18 +127,6 @@ final class ConversationUIModel: ObservableObject {
         message.sender == currentNickname || message.senderPeerID == chatViewModel.meshService.myPeerID
     }
 
-    /// Whether a private-message row should show the filled verification seal
-    /// next to the sender name (#1439). Scoped to DMs only — public timelines
-    /// have different trust semantics and stay undressed.
-    func showsVerifiedSeal(for message: BitchatMessage) -> Bool {
-        guard message.isPrivate,
-              message.sender != "system",
-              !isSentByCurrentUser(message),
-              let peerID = message.senderPeerID else { return false }
-        guard let fingerprint = chatViewModel.getFingerprint(for: peerID) else { return false }
-        return chatViewModel.peerIdentityStore.isVerified(fingerprint)
-    }
-
     func senderDisplayName(for peerID: PeerID, fallbackMessages: [BitchatMessage]) -> String? {
         if peerID.isGeoDM || peerID.isGeoChat {
             return chatViewModel.geohashDisplayName(for: peerID)
@@ -193,13 +153,6 @@ final class ConversationUIModel: ObservableObject {
         chatViewModel.sendVoiceNote(at: url)
     }
 
-    func resolveLegacyPrivateMediaConsent(requestID: UUID, approved: Bool) {
-        chatViewModel.resolveLegacyPrivateMediaConsent(
-            requestID: requestID,
-            approved: approved
-        )
-    }
-
     /// Capture backend for the mic gesture: live PTT when the current DM
     /// peer can hear it now, classic voice note otherwise.
     func makeVoiceCaptureSession() -> VoiceCaptureSession {
@@ -232,10 +185,6 @@ final class ConversationUIModel: ObservableObject {
             .receive(on: DispatchQueue.main)
             .assign(to: &$autocompleteSuggestions)
 
-        chatViewModel.$selectedAutocompleteIndex
-            .receive(on: DispatchQueue.main)
-            .assign(to: &$selectedAutocompleteIndex)
-
         chatViewModel.$isBatchingPublic
             .receive(on: DispatchQueue.main)
             .assign(to: &$isBatchingPublic)
@@ -244,10 +193,6 @@ final class ConversationUIModel: ObservableObject {
             .receive(on: DispatchQueue.main)
             .assign(to: &$activeLiveVoiceTalker)
 
-        chatViewModel.$legacyPrivateMediaConsentRequest
-            .receive(on: DispatchQueue.main)
-            .assign(to: &$legacyPrivateMediaConsentRequest)
-
         conversations.$activeChannel
             .receive(on: DispatchQueue.main)
             .sink { [weak self] channel in
@@ -262,15 +207,6 @@ final class ConversationUIModel: ObservableObject {
                 self?.refreshComputedState()
             }
             .store(in: &cancellables)
-
-        // Verify/unverify while a DM is open must repaint existing rows —
-        // showsVerifiedSeal is computed per render, so forward the store change.
-        chatViewModel.peerIdentityStore.$verifiedFingerprints
-            .receive(on: DispatchQueue.main)
-            .sink { [weak self] _ in
-                self?.objectWillChange.send()
-            }
-            .store(in: &cancellables)
     }
 
     private func refreshComputedState() {

bitchat/App/LocationPresenceStore.swift

@@ -7,147 +7,45 @@ final class LocationPresenceStore: ObservableObject {
     @Published private(set) var geoNicknames: [String: String] = [:]
     @Published private(set) var teleportedGeo: Set<String> = []
 
-    private let teleportedGeoCapacity: Int
-    private var teleportedGeoOrder: [String] = []
-    private let geoNicknameCapacity: Int
-    private var geoNicknameOrder: [String] = []
-
-    init(
-        teleportedGeoCapacity: Int = TransportConfig.geoTeleportedParticipantsCap,
-        geoNicknameCapacity: Int = TransportConfig.geoNicknameParticipantsCap
-    ) {
-        self.teleportedGeoCapacity = max(0, teleportedGeoCapacity)
-        self.geoNicknameCapacity = max(0, geoNicknameCapacity)
-    }
-
     func setCurrentGeohash(_ geohash: String?) {
-        let normalized = geohash?.lowercased()
-        if currentGeohash != normalized {
-            // Presence markers are scoped to the active geohash channel.
-            clearTeleportedGeo()
-            clearGeoNicknames()
-        }
-        currentGeohash = normalized
+        currentGeohash = geohash?.lowercased()
     }
 
     func setNickname(_ nickname: String, for pubkeyHex: String) {
-        guard geoNicknameCapacity > 0 else {
-            clearGeoNicknames()
-            return
-        }
-
-        let nickname = nickname.normalizedNickname
-        let key = pubkeyHex.lowercased()
-        if geoNicknames[key] != nil {
-            geoNicknames[key] = nickname
-            return
-        }
-
-        while geoNicknameOrder.count >= geoNicknameCapacity, let oldest = geoNicknameOrder.first {
-            geoNicknameOrder.removeFirst()
-            geoNicknames.removeValue(forKey: oldest)
-        }
-
-        geoNicknames[key] = nickname
-        geoNicknameOrder.append(key)
+        geoNicknames[pubkeyHex.lowercased()] = nickname
     }
 
     func replaceGeoNicknames(_ nicknames: [String: String]) {
-        guard geoNicknameCapacity > 0 else {
-            clearGeoNicknames()
-            return
-        }
-
-        var seen: Set<String> = []
-        var ordered: [String] = []
-        var normalized: [String: String] = [:]
-        for (key, value) in nicknames {
-            let lower = key.lowercased()
-            guard seen.insert(lower).inserted else { continue }
-            ordered.append(lower)
-            normalized[lower] = value.normalizedNickname
-        }
-        if ordered.count > geoNicknameCapacity {
-            let kept = Array(ordered.suffix(geoNicknameCapacity))
-            ordered = kept
-            normalized = Dictionary(uniqueKeysWithValues: kept.compactMap { key in
-                normalized[key].map { (key, $0) }
-            })
-        }
-        geoNicknameOrder = ordered
-        geoNicknames = normalized
+        geoNicknames = Dictionary(
+            uniqueKeysWithValues: nicknames.map { key, value in
+                (key.lowercased(), value)
+            }
+        )
     }
 
     func clearGeoNicknames() {
         geoNicknames.removeAll()
-        geoNicknameOrder.removeAll()
-    }
-
-    func retainGeoNicknames(keeping pubkeys: Set<String>) {
-        let allowed = Set(pubkeys.map { $0.lowercased() })
-        geoNicknameOrder = geoNicknameOrder.filter { allowed.contains($0) }
-        geoNicknames = geoNicknames.filter { allowed.contains($0.key) }
     }
 
     func markTeleported(_ pubkeyHex: String) {
-        guard teleportedGeoCapacity > 0 else {
-            clearTeleportedGeo()
-            return
-        }
-
-        let key = pubkeyHex.lowercased()
-        guard !teleportedGeo.contains(key) else { return }
-
-        while teleportedGeoOrder.count >= teleportedGeoCapacity, let oldest = teleportedGeoOrder.first {
-            teleportedGeoOrder.removeFirst()
-            teleportedGeo.remove(oldest)
-        }
-
-        teleportedGeo.insert(key)
-        teleportedGeoOrder.append(key)
+        teleportedGeo.insert(pubkeyHex.lowercased())
     }
 
     func clearTeleported(_ pubkeyHex: String) {
-        let key = pubkeyHex.lowercased()
-        teleportedGeo.remove(key)
-        teleportedGeoOrder.removeAll { $0 == key }
+        teleportedGeo.remove(pubkeyHex.lowercased())
     }
 
     func replaceTeleportedGeo(_ pubkeys: Set<String>) {
-        guard teleportedGeoCapacity > 0 else {
-            clearTeleportedGeo()
-            return
-        }
-
-        var seen: Set<String> = []
-        var ordered: [String] = []
-        for key in pubkeys.map({ $0.lowercased() }) where !seen.contains(key) {
-            seen.insert(key)
-            ordered.append(key)
-        }
-        if ordered.count > teleportedGeoCapacity {
-            ordered = Array(ordered.suffix(teleportedGeoCapacity))
-        }
-        teleportedGeoOrder = ordered
-        teleportedGeo = Set(ordered)
-    }
-
-    func retainTeleportedGeo(keeping pubkeys: Set<String>) {
-        let allowed = Set(pubkeys.map { $0.lowercased() })
-        teleportedGeoOrder = teleportedGeoOrder.filter { allowed.contains($0) }
-        teleportedGeo = teleportedGeo.intersection(allowed)
+        teleportedGeo = Set(pubkeys.map { $0.lowercased() })
     }
 
     func clearTeleportedGeo() {
         teleportedGeo.removeAll()
-        teleportedGeoOrder.removeAll()
     }
 
     func reset() {
         currentGeohash = nil
         geoNicknames.removeAll()
-        geoNicknameOrder.removeAll()
         teleportedGeo.removeAll()
-        teleportedGeoOrder.removeAll()
     }
 }

bitchat/App/NearbyNotesCounter.swift

@@ -17,62 +17,16 @@ final class NearbyNotesCounter: ObservableObject {
     static let shared = NearbyNotesCounter()
 
     @Published private(set) var noteCount = 0
-    /// Whether an explicit notes act (the empty-timeline "check for notes"
-    /// tap, opening the notices sheet's geo tab, or a successful /drop) has
-    /// unlocked the counter this session. Until then nothing subscribes:
-    /// merely looking at the mesh timeline must not open a building-precision
-    /// relay REQ that leaks location passively.
-    @Published private(set) var revealed = false
 
     private var manager: LocationNotesManager?
     private var managerCancellable: AnyCancellable?
     private var channelsCancellable: AnyCancellable?
-    private var permissionCancellable: AnyCancellable?
     private var settingCancellable: AnyCancellable?
     private var activeHolders = 0
     private let locationManager: LocationChannelManager
-    private let managerFactory: @MainActor (String) -> LocationNotesManager
-    private let releaseManager: @MainActor (LocationNotesManager?) -> Void
-    private let locationNotesEnabled: @MainActor () -> Bool
-    private let locationNotesSettingsPublisher: AnyPublisher<Void, Never>
 
-    init(
-        locationManager: LocationChannelManager = .shared,
-        managerFactory: @escaping @MainActor (String) -> LocationNotesManager = { LocationNotesPool.shared.acquire($0) },
-        releaseManager: @escaping @MainActor (LocationNotesManager?) -> Void = { LocationNotesPool.shared.release($0) },
-        locationNotesEnabled: @escaping @MainActor () -> Bool = { LocationNotesSettings.enabled },
-        locationNotesSettings: AnyPublisher<Void, Never>? = nil
-    ) {
+    init(locationManager: LocationChannelManager = .shared) {
         self.locationManager = locationManager
-        self.managerFactory = managerFactory
-        self.releaseManager = releaseManager
-        self.locationNotesEnabled = locationNotesEnabled
-        self.locationNotesSettingsPublisher = locationNotesSettings
-            ?? NotificationCenter.default
-                .publisher(for: LocationNotesSettings.didChangeNotification)
-                .map { _ in () }
-                .eraseToAnyPublisher()
-    }
-
-    /// Whether the empty-timeline "check for notes" hint should render.
-    /// The permission gate matters: `retarget()` never subscribes without
-    /// location authorization, so offering the hint to an unauthorized
-    /// install would be a silent dead-end — tap, `revealed` flips, the hint
-    /// vanishes, and nothing else happens for the session. The hint never
-    /// prompts; it simply stays hidden until permission exists. The caller
-    /// passes its own observed permission state so the hint re-renders when
-    /// authorization changes.
-    func offersRevealHint(permissionState: LocationChannelManager.PermissionState) -> Bool {
-        !revealed && locationNotesEnabled() && permissionState == .authorized
-    }
-
-    /// Marks the one explicit act that lets the counter subscribe. Sticky for
-    /// the rest of the session (the singleton's lifetime); `deactivate()`
-    /// deliberately does not reset it.
-    func reveal() {
-        guard !revealed else { return }
-        revealed = true
-        retarget()
     }
 
     /// Begins (or keeps) the notes subscription for the current building
@@ -84,16 +38,10 @@ final class NearbyNotesCounter: ObservableObject {
         channelsCancellable = locationManager.$availableChannels
             .receive(on: DispatchQueue.main)
             .sink { [weak self] _ in self?.retarget() }
-        // CoreLocation can revoke authorization while the view remains
-        // mounted. `availableChannels` deliberately retains its last value,
-        // so permission must be an independent invalidation signal or the
-        // building REQ survives on stale coordinates.
-        permissionCancellable = locationManager.$permissionState
-            .receive(on: DispatchQueue.main)
-            .sink { [weak self] _ in self?.retarget() }
         // The app-info kill switch must take effect immediately, not on the
         // next location change or remount.
-        settingCancellable = locationNotesSettingsPublisher
+        settingCancellable = NotificationCenter.default
+            .publisher(for: LocationNotesSettings.didChangeNotification)
             .receive(on: DispatchQueue.main)
             .sink { [weak self] _ in self?.retarget() }
         retarget()
@@ -103,39 +51,33 @@ final class NearbyNotesCounter: ObservableObject {
         activeHolders = max(0, activeHolders - 1)
         guard activeHolders == 0 else { return }
         channelsCancellable = nil
-        permissionCancellable = nil
         settingCancellable = nil
         managerCancellable = nil
-        releaseManager(manager)
+        manager?.cancel()
         manager = nil
         noteCount = 0
     }
 
     private func retarget() {
         guard activeHolders > 0,
-              revealed,
-              locationNotesEnabled(),
+              LocationNotesSettings.enabled,
               locationManager.permissionState == .authorized,
               let geohash = locationManager.availableChannels
                   .first(where: { $0.level == .building })?.geohash
         else {
             managerCancellable = nil
-            releaseManager(manager)
+            manager?.cancel()
             manager = nil
             noteCount = 0
             return
         }
 
         if let manager {
-            guard manager.geohash != geohash.lowercased() else { return }
-            // Pooled managers are shared; never retarget one in place —
-            // release the old cell and acquire the new one.
-            managerCancellable = nil
-            releaseManager(manager)
-            self.manager = nil
+            manager.setGeohash(geohash)
+            return
         }
 
-        let fresh = managerFactory(geohash)
+        let fresh = LocationNotesManager(geohash: geohash)
         manager = fresh
         managerCancellable = fresh.$notes
             .receive(on: DispatchQueue.main)

bitchat/App/PeerListModel.swift

@@ -39,27 +39,12 @@ struct GroupChatRow: Identifiable, Equatable {
     var id: String { peerID.id }
 }
 
-/// A direct conversation whose person is NOT in any roster above it. Without
-/// this section, a DM from a passerby became unreachable the moment they went
-/// offline: the roster filters to connected/reachable/mutual-favorite, the
-/// header envelope only exists while unread, and /msg can't resolve offline
-/// strangers — the thread was still in memory with no row anywhere in the UI.
-struct RecentChatRow: Identifiable, Equatable {
-    let peerID: PeerID
-    let displayName: String
-    let hasUnread: Bool
-    let lastActivity: Date
-
-    var id: String { peerID.id }
-}
-
 @MainActor
 final class PeerListModel: ObservableObject {
     @Published private(set) var allPeers: [BitchatPeer] = []
     @Published private(set) var meshRows: [MeshPeerRow] = []
     @Published private(set) var geohashPeople: [GeohashPersonRow] = []
     @Published private(set) var groupRows: [GroupChatRow] = []
-    @Published private(set) var recentChatRows: [RecentChatRow] = []
     @Published private(set) var reachableMeshPeerCount = 0
     @Published private(set) var connectedMeshPeerCount = 0
     @Published private(set) var visibleGeohashPeerCount = 0
@@ -158,17 +143,6 @@ final class PeerListModel: ObservableObject {
             }
             .store(in: &cancellables)
 
-        // Direct-conversation changes reorder or create recent-chat rows.
-        // Filtered to `.direct` so public-timeline traffic (every mesh or
-        // geohash message emits a change) doesn't rebuild the sheet.
-        conversations.changes
-            .receive(on: DispatchQueue.main)
-            .sink { [weak self] change in
-                guard case .direct = Self.changedConversationID(change) else { return }
-                self?.refresh()
-            }
-            .store(in: &cancellables)
-
         chatViewModel.groupStore.$groups
             .receive(on: DispatchQueue.main)
             .sink { [weak self] _ in
@@ -239,7 +213,7 @@ final class PeerListModel: ObservableObject {
 
             return MeshPeerRow(
                 peerID: peer.peerID,
-                displayName: isMe ? chatViewModel.nickname : peer.displayName,
+                displayName: isMe ? chatViewModel.nickname : peer.nickname,
                 isMe: isMe,
                 hasUnread: chatViewModel.hasUnreadMessages(for: peer.peerID),
                 isBlocked: !isMe && chatViewModel.isPeerBlocked(peer.peerID),
@@ -265,7 +239,6 @@ final class PeerListModel: ObservableObject {
 
         let geohashPeople = buildGeohashPeople()
         let groupRows = buildGroupRows()
-        let recentChatRows = buildRecentChatRows(meshRows: meshRows, geohashPeople: geohashPeople)
 
         self.meshRows = meshRows
         reachableMeshPeerCount = meshCounts.reachable
@@ -273,111 +246,19 @@ final class PeerListModel: ObservableObject {
         self.geohashPeople = geohashPeople
         visibleGeohashPeerCount = geohashPeople.count
         self.groupRows = groupRows
-        self.recentChatRows = recentChatRows
         renderID = (
             meshRows.map {
-                "\($0.id)-\($0.displayName)-\($0.isConnected)-\($0.isReachable)-\($0.hasUnread)-\($0.isFavorite)-\($0.isBlocked)"
+                "\($0.id)-\($0.isConnected)-\($0.isReachable)-\($0.hasUnread)-\($0.isFavorite)-\($0.isBlocked)"
             } +
             geohashPeople.map {
                 "geo:\($0.id)-\($0.isTeleported)-\($0.isBlocked)-\($0.displayName)"
             } +
             groupRows.map {
                 "group:\($0.id)-\($0.name)-\($0.memberCount)-\($0.hasUnread)"
-            } +
-            recentChatRows.map {
-                "chat:\($0.id)-\($0.displayName)-\($0.hasUnread)"
             }
         ).joined(separator: "|")
     }
 
-    /// Direct conversations with people absent from the rosters above:
-    /// the offline passerby DM, the geoDM from a channel since left. Rows
-    /// mirrored under both an ephemeral and a stable peer ID collapse to
-    /// one row per identity (newest activity wins), matching how the
-    /// private-chat coordinators consolidate on open.
-    private func buildRecentChatRows(
-        meshRows: [MeshPeerRow],
-        geohashPeople: [GeohashPersonRow]
-    ) -> [RecentChatRow] {
-        // A conversation can be keyed by the stable Noise peer ID while the
-        // roster lists the ephemeral one — compare fingerprints too.
-        var visibleIdentities = Set<String>()
-        for row in meshRows {
-            visibleIdentities.insert(row.peerID.id)
-            if let fingerprint = chatViewModel.getFingerprint(for: row.peerID) {
-                visibleIdentities.insert(fingerprint)
-            }
-        }
-        // Someone visible in the geohash section must not also get a chat
-        // row: their GeoDM conversation is keyed by the nostr_ form of the
-        // same pubkey the roster lists.
-        for person in geohashPeople {
-            visibleIdentities.insert(PeerID(nostr_: person.id).id)
-        }
-
-        struct Candidate {
-            let peerID: PeerID
-            let lastActivity: Date
-        }
-        var bestByIdentity: [String: Candidate] = [:]
-
-        for (id, conversation) in conversations.conversationsByID {
-            guard case .direct(let handle) = id else { continue }
-            let peerID = handle.routingPeerID
-            // Groups have their own section; blocked people get no row.
-            guard !peerID.isGroup else { continue }
-            guard let lastMessage = conversation.messages.last else { continue }
-            guard !chatViewModel.isPeerBlocked(peerID) else { continue }
-
-            let fingerprint = chatViewModel.getFingerprint(for: peerID)
-            if visibleIdentities.contains(peerID.id) { continue }
-            if let fingerprint, visibleIdentities.contains(fingerprint) { continue }
-
-            let identityKey = fingerprint ?? peerID.id
-            if let existing = bestByIdentity[identityKey],
-               existing.lastActivity >= lastMessage.timestamp {
-                continue
-            }
-            bestByIdentity[identityKey] = Candidate(peerID: peerID, lastActivity: lastMessage.timestamp)
-        }
-
-        return bestByIdentity.values
-            .sorted { $0.lastActivity > $1.lastActivity }
-            .map { candidate in
-                RecentChatRow(
-                    peerID: candidate.peerID,
-                    displayName: displayName(for: candidate.peerID),
-                    hasUnread: chatViewModel.hasUnreadMessages(for: candidate.peerID),
-                    lastActivity: candidate.lastActivity
-                )
-            }
-    }
-
-    /// GeoDM conversations resolve through the Nostr mapping —
-    /// `resolveNickname` only consults mesh identity sources and would
-    /// render a `nostr_…` key as an opaque `anonnost` fallback.
-    private func displayName(for peerID: PeerID) -> String {
-        if peerID.isGeoDM {
-            return chatViewModel.geohashDisplayName(for: peerID)
-        }
-        return chatViewModel.resolveNickname(for: peerID)
-    }
-
-    private static func changedConversationID(_ change: ConversationChange) -> ConversationID {
-        switch change {
-        case .appended(let id, _),
-             .updated(let id, _),
-             .statusChanged(let id, _, _),
-             .messageRemoved(let id, _),
-             .cleared(let id),
-             .removed(let id),
-             .unreadChanged(let id, _):
-            return id
-        case .migrated(_, let to):
-            return to
-        }
-    }
-
     private func buildGroupRows() -> [GroupChatRow] {
         let myFingerprint = chatViewModel.meshService.noiseIdentityFingerprint()
         return chatViewModel.groupStore.groups.map { group in

bitchat/App/PrivacyScreen.swift

@@ -1,100 +0,0 @@
-//
-// PrivacyScreen.swift
-// bitchat
-//
-// This is free and unencumbered software released into the public domain.
-// For more information, see <https://unlicense.org>
-//
-
-#if os(iOS)
-import UIKit
-
-/// Covers the window while the app is not frontmost, so the snapshot iOS takes
-/// for the app switcher shows a placeholder instead of the open conversation.
-///
-/// The cover is added on `willResignActive` and removed on `didBecomeActive`.
-/// Both are deliberately UIKit notifications rather than SwiftUI's `scenePhase`:
-/// the snapshot is captured shortly after `willResignActive`, and adding an
-/// opaque subview to the window synchronously in that callback is the only way
-/// to guarantee it is in the render tree before the capture. A SwiftUI overlay
-/// driven by state may not have been laid out yet.
-///
-/// Panic wipe separately deletes any snapshots already on disk; this keeps new
-/// ones from containing anything worth deleting.
-final class PrivacyScreen {
-    static let shared = PrivacyScreen()
-
-    private var cover: UIView?
-    private var observers: [NSObjectProtocol] = []
-
-    private init() {}
-
-    /// Idempotent: repeated calls do not stack observers.
-    ///
-    /// `queue: nil` is required, not incidental. Passing an `OperationQueue`
-    /// would enqueue the handler to run in a later runloop turn, which the
-    /// snapshot can beat; with no queue the block runs synchronously on the
-    /// thread that posted the notification — the main thread, for UIApplication
-    /// lifecycle notifications.
-    func install() {
-        guard observers.isEmpty else { return }
-        let center = NotificationCenter.default
-        observers = [
-            center.addObserver(
-                forName: UIApplication.willResignActiveNotification,
-                object: nil,
-                queue: nil
-            ) { _ in
-                PrivacyScreen.shared.show()
-            },
-            center.addObserver(
-                forName: UIApplication.didBecomeActiveNotification,
-                object: nil,
-                queue: nil
-            ) { _ in
-                PrivacyScreen.shared.hide()
-            }
-        ]
-    }
-
-    private func show() {
-        guard cover == nil, let window = Self.activeWindow() else { return }
-
-        // Opaque rather than a blur: blurred large text can stay partly
-        // legible, and the snapshot is stored on disk.
-        let view = UIView(frame: window.bounds)
-        view.backgroundColor = .systemBackground
-        view.autoresizingMask = [.flexibleWidth, .flexibleHeight]
-
-        let label = UILabel()
-        label.text = "bitchat"
-        label.font = .monospacedSystemFont(ofSize: 22, weight: .medium)
-        label.textColor = .secondaryLabel
-        label.translatesAutoresizingMaskIntoConstraints = false
-        view.addSubview(label)
-        NSLayoutConstraint.activate([
-            label.centerXAnchor.constraint(equalTo: view.centerXAnchor),
-            label.centerYAnchor.constraint(equalTo: view.centerYAnchor)
-        ])
-
-        window.addSubview(view)
-        cover = view
-    }
-
-    private func hide() {
-        cover?.removeFromSuperview()
-        cover = nil
-    }
-
-    private static func activeWindow() -> UIWindow? {
-        UIApplication.shared.connectedScenes
-            .compactMap { $0 as? UIWindowScene }
-            .flatMap(\.windows)
-            .first { $0.isKeyWindow } ??
-        UIApplication.shared.connectedScenes
-            .compactMap { $0 as? UIWindowScene }
-            .flatMap(\.windows)
-            .first
-    }
-}
-#endif

bitchat/App/PrivateConversationModels.swift

@@ -265,10 +265,10 @@ final class PrivateConversationModel: ObservableObject {
         let headerPeerID = chatViewModel.getShortIDForNoiseKey(conversationPeerID)
         let peer = chatViewModel.getPeer(byID: headerPeerID)
         let displayName = resolveDisplayName(for: conversationPeerID, headerPeerID: headerPeerID, peer: peer)
-        // Geo DMs are always routed through BitChat private envelopes over
-        // Nostr; their nostr_ keys never resolve to a reachable mesh peer, so
-        // resolveAvailability would report .offline. Report .nostrAvailable
-        // so the header shows the globe instead of a misleading "offline" tag.
+        // Geo DMs are always routed over Nostr (NIP-17); their nostr_ keys
+        // never resolve to a reachable mesh peer, so resolveAvailability would
+        // report .offline. Report .nostrAvailable so the header shows the
+        // globe instead of a misleading "offline" tag.
         let availability = conversationPeerID.isGeoDM
             ? .nostrAvailable
             : resolveAvailability(for: headerPeerID, peer: peer)
@@ -294,21 +294,6 @@ final class PrivateConversationModel: ObservableObject {
         if conversationPeerID.isGeoDM, case .location(let channel) = locationChannelsModel.selectedChannel {
             return "#\(channel.geohash)/@\(chatViewModel.geohashDisplayName(for: conversationPeerID))"
         }
-        // Local alias wins over a live peer row's announced nickname.
-        if headerPeerID.id.count == 16 {
-            let candidates = chatViewModel.identityManager.getCryptoIdentitiesByPeerIDPrefix(headerPeerID)
-            if let identity = candidates.first,
-               let social = chatViewModel.identityManager.getSocialIdentity(for: identity.fingerprint),
-               let pet = social.localPetname, !pet.isEmpty {
-                return pet
-            }
-        } else if let noiseKey = headerPeerID.noiseKey {
-            let fingerprint = noiseKey.sha256Fingerprint()
-            if let social = chatViewModel.identityManager.getSocialIdentity(for: fingerprint),
-               let pet = social.localPetname, !pet.isEmpty {
-                return pet
-            }
-        }
         if let displayName = peer?.displayName {
             return displayName
         }
@@ -323,15 +308,23 @@ final class PrivateConversationModel: ObservableObject {
         if headerPeerID.id.count == 16 {
             let candidates = chatViewModel.identityManager.getCryptoIdentitiesByPeerIDPrefix(headerPeerID)
             if let identity = candidates.first,
-               let social = chatViewModel.identityManager.getSocialIdentity(for: identity.fingerprint),
-               !social.claimedNickname.isEmpty {
-                return social.claimedNickname
+               let social = chatViewModel.identityManager.getSocialIdentity(for: identity.fingerprint) {
+                if let pet = social.localPetname, !pet.isEmpty {
+                    return pet
+                }
+                if !social.claimedNickname.isEmpty {
+                    return social.claimedNickname
+                }
             }
         } else if let noiseKey = headerPeerID.noiseKey {
             let fingerprint = noiseKey.sha256Fingerprint()
-            if let social = chatViewModel.identityManager.getSocialIdentity(for: fingerprint),
-               !social.claimedNickname.isEmpty {
-                return social.claimedNickname
+            if let social = chatViewModel.identityManager.getSocialIdentity(for: fingerprint) {
+                if let pet = social.localPetname, !pet.isEmpty {
+                    return pet
+                }
+                if !social.claimedNickname.isEmpty {
+                    return social.claimedNickname
+                }
             }
         }
 
@@ -357,10 +350,7 @@ final class PrivateConversationModel: ObservableObject {
         }
         if let noiseKey = Data(hexString: headerPeerID.id),
            let favoriteStatus = FavoritesPersistenceService.shared.getFavoriteStatus(for: noiseKey),
-           favoriteStatus.isMutual,
-           // No stored recipient key means no Nostr delivery — and the
-           // "end-to-end encrypted" caption keys off .nostrAvailable.
-           favoriteStatus.peerNostrPublicKey != nil {
+           favoriteStatus.isMutual {
             return .nostrAvailable
         }
         if chatViewModel.meshService.isPeerConnected(headerPeerID) || chatViewModel.connectedPeers.contains(headerPeerID) {

bitchat/App/SharedContentImportModel.swift

@@ -1,119 +0,0 @@
-import BitFoundation
-import Combine
-import Foundation
-
-enum SharedContentDestination: Sendable, Equatable {
-    case mesh
-    case geohash(String)
-    case privateConversation(peerID: PeerID, displayName: String)
-
-    static func resolve(
-        selectedPrivatePeerID: PeerID?,
-        privateDisplayName: String?,
-        activeChannel: ChannelID
-    ) -> SharedContentDestination {
-        if let selectedPrivatePeerID {
-            let fallback = String(selectedPrivatePeerID.id.prefix(12))
-            return .privateConversation(
-                peerID: selectedPrivatePeerID,
-                displayName: privateDisplayName?.trimmedOrNilIfEmpty ?? fallback
-            )
-        }
-
-        switch activeChannel {
-        case .mesh:
-            return .mesh
-        case .location(let channel):
-            return .geohash(channel.geohash.lowercased())
-        }
-    }
-
-    var displayName: String {
-        switch self {
-        case .mesh:
-            return "#mesh"
-        case .geohash(let geohash):
-            return "#\(geohash)"
-        case .privateConversation(_, let displayName):
-            return displayName
-        }
-    }
-}
-
-struct SharedContentOffer: Identifiable, Sendable, Equatable {
-    let payload: SharedContentPayload
-    let destination: SharedContentDestination
-
-    var id: UUID { payload.id }
-}
-
-/// Holds a pending extension handoff until the user chooses a destination and
-/// explicitly adds it to the composer. This type has no send dependency by
-/// design: confirming an import can never transmit a message.
-@MainActor
-final class SharedContentImportModel: ObservableObject {
-    @Published private(set) var offer: SharedContentOffer?
-
-    private let store: SharedContentStore?
-
-    init(store: SharedContentStore?) {
-        self.store = store
-    }
-
-    @discardableResult
-    func refresh(
-        destination: SharedContentDestination,
-        now: Date = Date()
-    ) -> SharedContentPayload? {
-        guard let payload = store?.pending(now: now) else {
-            offer = nil
-            return nil
-        }
-
-        let nextOffer = SharedContentOffer(payload: payload, destination: destination)
-        if offer != nextOffer {
-            offer = nextOffer
-        }
-        return payload
-    }
-
-    func updateDestination(_ destination: SharedContentDestination) {
-        guard let offer, offer.destination != destination else { return }
-        self.offer = SharedContentOffer(payload: offer.payload, destination: destination)
-    }
-
-    /// Returns composer text only when the currently displayed destination is
-    /// still current and the reviewed envelope is still the stored envelope.
-    /// A destination change updates the prompt and requires another tap.
-    func confirm(
-        destination: SharedContentDestination,
-        now: Date = Date()
-    ) -> String? {
-        guard let offer else { return nil }
-        guard offer.destination == destination else {
-            updateDestination(destination)
-            return nil
-        }
-        guard let payload = store?.consume(id: offer.id, now: now) else {
-            _ = refresh(destination: destination, now: now)
-            return nil
-        }
-
-        self.offer = nil
-        return payload.composerText
-    }
-
-    func cancel(destination: SharedContentDestination, now: Date = Date()) {
-        guard let offer else { return }
-        store?.discard(id: offer.id)
-        self.offer = nil
-        // If a newer share replaced the reviewed envelope, surface it rather
-        // than losing it with the older cancellation.
-        _ = refresh(destination: destination, now: now)
-    }
-
-    func discardAll() {
-        store?.discardAll()
-        offer = nil
-    }
-}

bitchat/App/VerificationModel.swift

@@ -8,9 +8,6 @@ struct FingerprintPresentationState: Equatable {
     let theirFingerprint: String?
     let myFingerprint: String
     let isVerified: Bool
-    /// User-assigned local alias (petname), if any — distinct from the
-    /// peer-claimed nickname.
-    let localPetname: String?
     /// Number of currently-valid vouches from peers the user verified
     /// (0 when the peer is explicitly verified — the stronger badge wins).
     let voucherCount: Int
@@ -23,11 +20,6 @@ struct FingerprintPresentationState: Equatable {
     var canToggleVerification: Bool {
         encryptionStatus == .noiseSecured || encryptionStatus == .noiseVerified
     }
-
-    /// Alias field is editable once we know who we're looking at.
-    var canEditLocalAlias: Bool {
-        theirFingerprint != nil
-    }
 }
 
 enum VerificationScanOutcome: Equatable {
@@ -83,46 +75,6 @@ final class VerificationModel: ObservableObject {
         chatViewModel.unverifyFingerprint(for: peerID)
     }
 
-    /// Persist a local alias for this peer. Empty/whitespace clears it so the
-    /// claimed nickname shows again. Display paths prefer `localPetname`
-    /// when set (#1439).
-    func setLocalPetname(_ petname: String?, for peerID: PeerID) {
-        let statusPeerID = chatViewModel.getShortIDForNoiseKey(peerID)
-        guard let fingerprint = chatViewModel.getFingerprint(for: statusPeerID) else { return }
-
-        let trimmed = petname?.trimmingCharacters(in: .whitespacesAndNewlines)
-        let normalized: String? = (trimmed?.isEmpty == false) ? trimmed : nil
-
-        let existing = chatViewModel.identityManager.getSocialIdentity(for: fingerprint)
-        let claimed = existing?.claimedNickname
-            ?? chatViewModel.meshService.peerNickname(peerID: statusPeerID)
-            ?? chatViewModel.resolveNickname(for: statusPeerID)
-        var identity = existing ?? SocialIdentity(
-            fingerprint: fingerprint,
-            localPetname: nil,
-            claimedNickname: claimed,
-            trustLevel: .unknown,
-            isFavorite: false,
-            isBlocked: false,
-            notes: nil
-        )
-        identity.localPetname = normalized
-        // Prefer the mesh-announced name for claimedNickname so we don't
-        // persist a previous alias as the "claimed" identity.
-        if let announced = chatViewModel.meshService.peerNickname(peerID: statusPeerID),
-           !announced.isEmpty {
-            identity.claimedNickname = announced
-        } else if identity.claimedNickname.isEmpty {
-            identity.claimedNickname = claimed
-        }
-        chatViewModel.identityManager.updateSocialIdentity(identity)
-        // Rebuild peer rows so PeerList / DM header pick up the new display name
-        // without waiting for an unrelated mesh event.
-        chatViewModel.unifiedPeerService.refreshPeers()
-        NotificationCenter.default.post(name: Notification.Name("peerStatusUpdated"), object: nil)
-        objectWillChange.send()
-    }
-
     func isVerified(peerID: PeerID) -> Bool {
         guard let fingerprint = chatViewModel.getFingerprint(for: peerID) else { return false }
         return peerIdentityStore.isVerified(fingerprint)
@@ -134,8 +86,6 @@ final class VerificationModel: ObservableObject {
         let theirFingerprint = chatViewModel.getFingerprint(for: statusPeerID)
         let peerNickname = resolveDisplayName(for: peerID, statusPeerID: statusPeerID)
         let isVerified = theirFingerprint.map { peerIdentityStore.isVerified($0) } ?? false
-        let localPetname = theirFingerprint
-            .flatMap { chatViewModel.identityManager.getSocialIdentity(for: $0)?.localPetname }
 
         // Vouch state is recomputed on read: only vouchers still in the
         // verified set count, so removing a verification silently retires the
@@ -160,7 +110,6 @@ final class VerificationModel: ObservableObject {
             theirFingerprint: theirFingerprint,
             myFingerprint: chatViewModel.getMyFingerprint(),
             isVerified: isVerified,
-            localPetname: localPetname,
             voucherCount: vouchers.count,
             voucherNames: voucherNames
         )
@@ -209,15 +158,6 @@ final class VerificationModel: ObservableObject {
     }
 
     private func resolveDisplayName(for peerID: PeerID, statusPeerID: PeerID) -> String {
-        // Prefer an explicit local alias even when a live peer row exists —
-        // peer.displayName already does this once UnifiedPeerService rebuilds,
-        // but read social identity directly so the fingerprint sheet header
-        // updates before that rebuild lands.
-        if let fingerprint = chatViewModel.getFingerprint(for: statusPeerID),
-           let pet = chatViewModel.identityManager.getSocialIdentity(for: fingerprint)?.localPetname,
-           !pet.isEmpty {
-            return pet
-        }
         if let peer = chatViewModel.getPeer(byID: statusPeerID) {
             return peer.displayName
         }
@@ -231,6 +171,9 @@ final class VerificationModel: ObservableObject {
             }
             let fingerprint = data.sha256Fingerprint()
             if let social = chatViewModel.identityManager.getSocialIdentity(for: fingerprint) {
+                if let pet = social.localPetname, !pet.isEmpty {
+                    return pet
+                }
                 if !social.claimedNickname.isEmpty {
                     return social.claimedNickname
                 }

bitchat/BitchatApp.swift

@@ -41,7 +41,6 @@ struct BitchatApp: App {
                 .environmentObject(runtime.peerListModel)
                 .environmentObject(runtime.appChromeModel)
                 .environmentObject(runtime.boardAlertsModel)
-                .environmentObject(runtime.sharedContentImportModel)
                 .onAppear {
                     appDelegate.runtime = runtime
                     runtime.start()
@@ -74,10 +73,7 @@ final class AppDelegate: NSObject, UIApplicationDelegate {
     weak var runtime: AppRuntime?
 
     func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]? = nil) -> Bool {
-        // Installed before the first resign-active so the app-switcher snapshot
-        // never captures an open conversation.
-        PrivacyScreen.shared.install()
-        return true
+        true
     }
 
     func applicationWillTerminate(_ application: UIApplication) {

bitchat/Features/media/ImageUtils.swift

@@ -206,7 +206,7 @@ enum ImageUtils {
         } else {
             directory = try applicationFilesDirectory().appendingPathComponent("images/outgoing", isDirectory: true)
         }
-        try FileManager.default.createDirectory(at: directory, withIntermediateDirectories: true, attributes: BLEIncomingFileStore.mediaProtectionAttributes)
+        try FileManager.default.createDirectory(at: directory, withIntermediateDirectories: true, attributes: nil)
         return directory.appendingPathComponent(fileName)
     }
 

bitchat/Features/voice/AudioSessionCoordinator.swift

@@ -1,472 +0,0 @@
-//
-// AudioSessionCoordinator.swift
-// bitchat
-//
-// This is free and unencumbered software released into the public domain.
-// For more information, see <https://unlicense.org>
-//
-
-import AVFoundation
-import BitLogger
-import Foundation
-
-/// The raw audio-session calls the coordinator makes, abstracted so the
-/// state machine is unit-testable with a mock (and compiles on the macOS
-/// test host, where `AVAudioSession` doesn't exist).
-///
-/// Calls arrive on the coordinator's private serial queue — never the main
-/// thread. `setCategory`/`setActive` block on IPC to the audio server
-/// (observed >1 s under contention on device, tripping the system gesture
-/// gate), and Apple explicitly recommends activating the session off the
-/// main thread.
-protocol SessionApplying: Sendable {
-    func setCategory(_ category: AudioSessionCoordinator.Category) throws
-    func setActive(_ active: Bool, notifyOthersOnDeactivation: Bool) throws
-}
-
-/// Sole owner of `AVAudioSession` category/activation for voice features.
-///
-/// Talk-over means capture (push-to-talk) and playback (inbound bursts,
-/// voice notes) can be live simultaneously; letting each engine configure
-/// the shared session directly made them stomp each other's category and
-/// route mid-flight (the AURemoteIO -10851 dead-input class). Instead every
-/// client acquires a `Token` and the coordinator:
-///
-/// - reference-counts activation: `setActive(true)` only on the first
-///   holder, `setActive(false, notifyOthersOnDeactivation:)` only when the
-///   last one releases — no client can deactivate another's session;
-/// - keeps one escalating category: playback-only holders get `.playback`,
-///   any capture holder escalates to `.playAndRecord`, and the category is
-///   never downgraded while anyone still holds a token (capture ending must
-///   not yank the route out from under live playback);
-/// - fans out `onInterrupted` on system interruptions and when the active
-///   route's device disappears (no auto-resume: bursts are transient, the
-///   next press or burst simply re-acquires). The escalating category change
-///   fans out separately as `onCategoryEscalated` — the session stays live,
-///   so holders that can rebuild their engine against the new configuration
-///   keep playing (talk-over is bidirectional); holders that don't provide
-///   it fall back to `onInterrupted`.
-///
-/// Threading: all state lives on a private serial queue, which both
-/// serializes rapid acquire/release pairs and keeps the blocking session IPC
-/// off the main thread (`acquire` is `async` for exactly that hop; `release`
-/// is fire-and-forget onto the queue). Holder callbacks always run on the
-/// main actor.
-///
-/// Microphone *permission* queries stay with their callers; this type owns
-/// only category and activation.
-///
-/// `@unchecked Sendable`: every mutable property is confined to `queue`.
-final class AudioSessionCoordinator: @unchecked Sendable {
-    enum Use {
-        case playback
-        case capture
-    }
-
-    /// The session category the coordinator has applied (the `SessionApplying`
-    /// adapter maps these to concrete `AVAudioSession` category/mode/options).
-    enum Category {
-        case playback
-        case playAndRecord
-    }
-
-    /// Opaque handle for one client's hold on the session. Release exactly
-    /// once when done (extra releases are ignored).
-    ///
-    /// `@unchecked` because the stored callbacks are `@MainActor`-isolated
-    /// closures (non-Sendable as stored types). Lifecycle state is protected
-    /// by `stateLock`, and callbacks are only ever invoked on the main actor.
-    final class Token: @unchecked Sendable {
-        fileprivate enum CallbackKind: Sendable {
-            case interrupted
-            case categoryEscalated
-        }
-
-        /// A callback snapshot is only valid for the lifecycle epoch in which
-        /// it was captured. `release` advances the epoch synchronously before
-        /// its queue work, so a callback already headed to the main actor can't
-        /// reach a client that has since released this token and reacquired a
-        /// different one.
-        fileprivate struct CallbackTicket: Sendable {
-            let token: Token
-            let kind: CallbackKind
-            let lifecycleEpoch: UInt64
-        }
-
-        private enum Lifecycle {
-            /// Registered on the session queue, but `acquire` has not yet
-            /// returned into the client's main-actor call frame.
-            case acquiring
-            case ready
-            case released
-        }
-
-        fileprivate let onInterrupted: @MainActor () -> Void
-        fileprivate let onCategoryEscalated: (@MainActor () -> Void)?
-        private let stateLock = NSLock()
-        private var lifecycle = Lifecycle.acquiring
-        private var lifecycleEpoch: UInt64 = 0
-        /// A terminal event that lands while the token is registered but not
-        /// yet handed off invalidates the acquire before its caller can start.
-        private var terminalEventPendingHandoff = false
-
-        fileprivate init(
-            onInterrupted: @escaping @MainActor () -> Void,
-            onCategoryEscalated: (@MainActor () -> Void)?
-        ) {
-            self.onInterrupted = onInterrupted
-            self.onCategoryEscalated = onCategoryEscalated
-        }
-
-        /// Records an event at the same linearization point at which the
-        /// coordinator snapshots its holders. An acquiring token cannot safely
-        /// receive a callback yet: terminal events invalidate the acquire,
-        /// while category escalation needs no callback because its engine will
-        /// start against the already-escalated configuration.
-        fileprivate func record(_ kind: CallbackKind) -> CallbackTicket? {
-            stateLock.withLock {
-                switch lifecycle {
-                case .acquiring:
-                    switch kind {
-                    case .interrupted:
-                        terminalEventPendingHandoff = true
-                    case .categoryEscalated:
-                        break
-                    }
-                    return nil
-                case .ready:
-                    return CallbackTicket(token: self, kind: kind, lifecycleEpoch: lifecycleEpoch)
-                case .released:
-                    return nil
-                }
-            }
-        }
-
-        /// Completes the main-actor ownership handoff if no terminal event
-        /// invalidated it. Because `acquire` itself is main-actor isolated, a
-        /// successful handoff returns directly into the caller without another
-        /// actor hop; no callback can interleave before the caller stores the
-        /// returned token.
-        fileprivate func completeHandoff() -> Bool {
-            stateLock.withLock {
-                guard lifecycle == .acquiring,
-                      !terminalEventPendingHandoff
-                else { return false }
-                lifecycle = .ready
-                return true
-            }
-        }
-
-        /// Marks the token dead synchronously, before the asynchronous holder
-        /// removal. Returns false for an already-released token.
-        fileprivate func markReleased() -> Bool {
-            stateLock.withLock {
-                guard lifecycle != .released else { return false }
-                lifecycle = .released
-                lifecycleEpoch &+= 1
-                terminalEventPendingHandoff = false
-                return true
-            }
-        }
-
-        /// Revalidates a queue snapshot at the main-actor delivery boundary.
-        /// The lock is deliberately released before invoking client code: real
-        /// callbacks commonly call `release` on this same token.
-        @MainActor
-        fileprivate func deliver(_ ticket: CallbackTicket) {
-            let isLive = stateLock.withLock {
-                lifecycle == .ready && lifecycleEpoch == ticket.lifecycleEpoch
-            }
-            guard isLive else { return }
-            switch ticket.kind {
-            case .interrupted:
-                onInterrupted()
-            case .categoryEscalated:
-                (onCategoryEscalated ?? onInterrupted)()
-            }
-        }
-    }
-
-    /// Deterministic suspension points for lifecycle race tests. Production
-    /// instances use the nil defaults; the hooks never move session calls off
-    /// the coordinator queue or callback execution off the main actor.
-    struct TestingHooks: Sendable {
-        let beforeAcquireHandoff: (@Sendable () async -> Void)?
-        let beforeCallbackDelivery: (@Sendable () async -> Void)?
-
-        init(
-            beforeAcquireHandoff: (@Sendable () async -> Void)? = nil,
-            beforeCallbackDelivery: (@Sendable () async -> Void)? = nil
-        ) {
-            self.beforeAcquireHandoff = beforeAcquireHandoff
-            self.beforeCallbackDelivery = beforeCallbackDelivery
-        }
-    }
-
-    static let shared = AudioSessionCoordinator(session: SystemAudioSession())
-
-    private let session: SessionApplying
-    private let testingHooks: TestingHooks
-    /// Confines all mutable state, serializes whole acquire/release
-    /// operations (two rapid presses can't interleave their category and
-    /// activation calls), and hosts the blocking session IPC off main.
-    private let queue = DispatchQueue(label: "chat.bitchat.audio-session", qos: .userInitiated)
-
-    // Queue-confined state.
-    private var holders: [ObjectIdentifier: Token] = [:]
-    private var currentCategory: Category?
-    private var sessionActive = false
-    /// Written once in init, read in deinit — never touched concurrently.
-    private var observers: [NSObjectProtocol] = []
-
-    init(session: SessionApplying, testingHooks: TestingHooks = TestingHooks()) {
-        self.session = session
-        self.testingHooks = testingHooks
-        observeSystemNotifications()
-    }
-
-    deinit {
-        for observer in observers {
-            NotificationCenter.default.removeObserver(observer)
-        }
-    }
-
-    /// Configures + activates the session for `use` and registers the caller
-    /// as a holder. The blocking `AVAudioSession` calls run on the session
-    /// queue — the caller suspends instead of stalling its thread (a PTT
-    /// press used to block main >1 s in `setActive`, tripping the system
-    /// gesture gate). `onInterrupted` fires (on the main actor) when the
-    /// client must stop using the session: a system interruption began or
-    /// its route's device went away. The client should stop its engine,
-    /// finalize any artifacts, and release — resuming means acquiring again.
-    ///
-    /// `onCategoryEscalated` fires instead when the session category
-    /// escalated underneath the holder (a capture client joined): the session
-    /// stays active, so a holder that can rebuild its engine against the new
-    /// configuration should restart and keep going. Holders that pass `nil`
-    /// get `onInterrupted` for escalation too. Escalation is delivered before
-    /// `acquire` returns, so the new holder starts its engine strictly after
-    /// existing ones were told to rebuild. Main-actor isolation is also the
-    /// ownership handoff boundary: if interruption or route loss lands after
-    /// queue registration but before that boundary, the provisional holder is
-    /// removed and `acquire` throws `CancellationError` instead of returning a
-    /// token whose callback already fired.
-    @MainActor
-    func acquire(
-        _ use: Use,
-        onInterrupted: @escaping @MainActor () -> Void,
-        onCategoryEscalated: (@MainActor () -> Void)? = nil
-    ) async throws -> Token {
-        let token = Token(onInterrupted: onInterrupted, onCategoryEscalated: onCategoryEscalated)
-        let reconfigured: [Token.CallbackTicket] = try await withCheckedThrowingContinuation { continuation in
-            queue.async {
-                do {
-                    continuation.resume(returning: try self.activateOnQueue(use, registering: token))
-                } catch {
-                    continuation.resume(throwing: error)
-                }
-            }
-        }
-
-        // Escalating playback -> playAndRecord reconfigures the hardware
-        // route; engines started against the old configuration must restart.
-        if !reconfigured.isEmpty {
-            SecureLogger.info("AudioSession: category escalated to playAndRecord with \(reconfigured.count) live holder(s)", category: .session)
-            await deliver(reconfigured)
-        }
-        if let beforeAcquireHandoff = testingHooks.beforeAcquireHandoff {
-            await beforeAcquireHandoff()
-        }
-        guard token.completeHandoff() else {
-            // A call/Siri interruption or route loss landed after registration
-            // but before ownership handoff. Remove the provisional holder and
-            // fail instead of starting a client engine after the stop event.
-            release(token)
-            throw CancellationError()
-        }
-        return token
-    }
-
-    /// Drops one holder. Deactivates the session (notifying other apps) only
-    /// when the last holder releases. Safe to call more than once, from any
-    /// thread (including `deinit` paths): the work is fire-and-forget onto
-    /// the session queue, so the blocking deactivation IPC never runs on the
-    /// caller.
-    func release(_ token: Token) {
-        guard token.markReleased() else { return }
-        queue.async {
-            self.releaseOnQueue(token)
-        }
-    }
-
-    // MARK: - Queue-confined core
-
-    /// Returns callback tickets for pre-existing live holders whose engines
-    /// must restart because this acquire escalated the category.
-    private func activateOnQueue(_ use: Use, registering token: Token) throws -> [Token.CallbackTicket] {
-        let target: Category = (use == .capture || currentCategory == .playAndRecord) ? .playAndRecord : .playback
-        let categoryChanged = target != currentCategory
-        let previousCategory = currentCategory
-        if categoryChanged {
-            try session.setCategory(target)
-            currentCategory = target
-        }
-        if !sessionActive {
-            do {
-                try session.setActive(true, notifyOthersOnDeactivation: false)
-            } catch {
-                // Activation failed (e.g. a phone call owns the hardware):
-                // with no holder registered, an escalated category recorded
-                // here would stick and pin later playback-only acquires to
-                // .playAndRecord. Existing holders keep the category the
-                // hardware really has.
-                if categoryChanged, holders.isEmpty {
-                    currentCategory = previousCategory
-                }
-                throw error
-            }
-            sessionActive = true
-        }
-
-        let reconfigured = categoryChanged
-            ? holders.values.compactMap { $0.record(.categoryEscalated) }
-            : []
-        holders[ObjectIdentifier(token)] = token
-        return reconfigured
-    }
-
-    private func releaseOnQueue(_ token: Token) {
-        guard holders.removeValue(forKey: ObjectIdentifier(token)) != nil else { return }
-        guard holders.isEmpty else { return }
-        currentCategory = nil
-        guard sessionActive else { return }
-        sessionActive = false
-        do {
-            try session.setActive(false, notifyOthersOnDeactivation: true)
-        } catch {
-            SecureLogger.error("AudioSession: deactivation failed: \(error)", category: .session)
-        }
-    }
-
-    private func onQueue<T: Sendable>(_ body: @escaping @Sendable () -> T) async -> T {
-        await withCheckedContinuation { continuation in
-            queue.async {
-                continuation.resume(returning: body())
-            }
-        }
-    }
-
-    @MainActor
-    private func deliver(_ tickets: [Token.CallbackTicket]) async {
-        guard !tickets.isEmpty else { return }
-        if let beforeCallbackDelivery = testingHooks.beforeCallbackDelivery {
-            await beforeCallbackDelivery()
-        }
-        for ticket in tickets {
-            ticket.token.deliver(ticket)
-        }
-    }
-
-    // MARK: - System events (internal so tests can drive them directly)
-
-    /// A system interruption began: the session is already deactivated by the
-    /// OS, so just mark it inactive and tell every ready holder (on the main
-    /// actor) to stop. A provisional acquiring holder is invalidated instead.
-    /// No auto-resume — the next acquire re-activates.
-    func handleInterruptionBegan() async {
-        let tickets = await onQueue { () -> [Token.CallbackTicket] in
-            self.sessionActive = false
-            return self.holders.values.compactMap { $0.record(.interrupted) }
-        }
-        await deliver(tickets)
-    }
-
-    /// The active route's input/output device disappeared (e.g. BT headset
-    /// off): ready holders' engines are wedged against a dead route — stop
-    /// them; invalidate a holder whose acquire has not returned yet.
-    func handleRouteDeviceUnavailable() async {
-        let tickets = await onQueue {
-            self.holders.values.compactMap { $0.record(.interrupted) }
-        }
-        await deliver(tickets)
-    }
-
-    /// Test hook: suspends until every session operation enqueued before this
-    /// call — including fire-and-forget `release`s — has completed.
-    func drain() async {
-        await onQueue {}
-    }
-
-    private func observeSystemNotifications() {
-        #if os(iOS)
-        let center = NotificationCenter.default
-        observers.append(center.addObserver(
-            forName: AVAudioSession.interruptionNotification,
-            object: AVAudioSession.sharedInstance(),
-            queue: .main
-        ) { [weak self] note in
-            guard let raw = note.userInfo?[AVAudioSessionInterruptionTypeKey] as? UInt,
-                  AVAudioSession.InterruptionType(rawValue: raw) == .began,
-                  let self
-            else { return }
-            SecureLogger.info("AudioSession: interruption began", category: .session)
-            Task { await self.handleInterruptionBegan() }
-        })
-        observers.append(center.addObserver(
-            forName: AVAudioSession.routeChangeNotification,
-            object: AVAudioSession.sharedInstance(),
-            queue: .main
-        ) { [weak self] note in
-            guard let raw = note.userInfo?[AVAudioSessionRouteChangeReasonKey] as? UInt,
-                  AVAudioSession.RouteChangeReason(rawValue: raw) == .oldDeviceUnavailable,
-                  let self
-            else { return }
-            SecureLogger.info("AudioSession: route device became unavailable", category: .session)
-            Task { await self.handleRouteDeviceUnavailable() }
-        })
-        #endif
-    }
-}
-
-// MARK: - Production adapter
-
-#if os(iOS)
-private struct SystemAudioSession: SessionApplying {
-    func setCategory(_ category: AudioSessionCoordinator.Category) throws {
-        let session = AVAudioSession.sharedInstance()
-        switch category {
-        case .playback:
-            try session.setCategory(.playback, mode: .spokenAudio, options: [.mixWithOthers])
-        case .playAndRecord:
-            // allowBluetoothHFP is not available on iOS Simulator
-            #if targetEnvironment(simulator)
-            try session.setCategory(
-                .playAndRecord,
-                mode: .default,
-                options: [.defaultToSpeaker, .allowBluetoothA2DP, .mixWithOthers]
-            )
-            #else
-            try session.setCategory(
-                .playAndRecord,
-                mode: .default,
-                options: [.defaultToSpeaker, .allowBluetoothA2DP, .allowBluetoothHFP, .mixWithOthers]
-            )
-            #endif
-        }
-    }
-
-    func setActive(_ active: Bool, notifyOthersOnDeactivation: Bool) throws {
-        try AVAudioSession.sharedInstance().setActive(
-            active,
-            options: notifyOthersOnDeactivation ? [.notifyOthersOnDeactivation] : []
-        )
-    }
-}
-#else
-/// macOS has no app-level audio session; the coordinator still runs its
-/// bookkeeping so client code is identical across platforms.
-private struct SystemAudioSession: SessionApplying {
-    func setCategory(_ category: AudioSessionCoordinator.Category) throws {}
-    func setActive(_ active: Bool, notifyOthersOnDeactivation: Bool) throws {}
-}
-#endif

bitchat/Features/voice/PTTBurstPlayer.swift

@@ -6,142 +6,10 @@
 // For more information, see <https://unlicense.org>
 //
 
-@preconcurrency import AVFoundation
+import AVFoundation
 import BitLogger
 import Foundation
 
-/// The engine operations behind live-burst playback, abstracted so the
-/// player's lifecycle (jitter start, category-escalation restart, stop) is
-/// unit-testable without real audio hardware.
-@MainActor
-protocol PTTPlaybackEngine: AnyObject {
-    /// The object `AVAudioEngineConfigurationChange` notifications are posted
-    /// for (nil for mocks — no observer is registered).
-    var configChangeObject: AnyObject? { get }
-    func start() throws
-    func play()
-    func stop()
-    func schedule(
-        _ buffer: AVAudioPCMBuffer,
-        completionType: PTTPlaybackCompletionType,
-        completionHandler: @escaping @Sendable (PTTPlaybackCompletionEvent) -> Void
-    )
-}
-
-/// The lifecycle point requested from `AVAudioPlayerNode` for a scheduled
-/// buffer. `dataConsumed` only means the node no longer needs the bytes; it
-/// may arrive before the render pipeline has made the audio audible.
-enum PTTPlaybackCompletionType: Equatable, Sendable {
-    case dataConsumed
-    case dataPlayedBack
-}
-
-enum PTTPlaybackCompletionEvent: Equatable, Sendable {
-    case dataConsumed
-    case dataPlayedBack
-    /// AVAudioPlayerNode invokes the requested callback when the node is
-    /// stopped too. That is not audible completion and must remain replayable.
-    case playbackStopped
-}
-
-/// One `AVAudioEngine` + `AVAudioPlayerNode` pair. Created fresh per (re)start:
-/// an engine instantiated against an earlier audio-session configuration keeps
-/// rendering to the stale route (same class of failure as the capture side's
-/// fresh-engine-per-press rule).
-@MainActor
-private final class SystemPTTPlaybackEngine: PTTPlaybackEngine {
-    private let engine = AVAudioEngine()
-    private let node = AVAudioPlayerNode()
-
-    init(format: AVAudioFormat) {
-        engine.attach(node)
-        engine.connect(node, to: engine.mainMixerNode, format: format)
-    }
-
-    var configChangeObject: AnyObject? { engine }
-
-    func start() throws {
-        engine.prepare()
-        try engine.start()
-    }
-
-    func play() {
-        node.play()
-    }
-
-    func stop() {
-        node.stop()
-        engine.stop()
-    }
-
-    func schedule(
-        _ buffer: AVAudioPCMBuffer,
-        completionType: PTTPlaybackCompletionType,
-        completionHandler: @escaping @Sendable (PTTPlaybackCompletionEvent) -> Void
-    ) {
-        let callbackType: AVAudioPlayerNodeCompletionCallbackType = switch completionType {
-        case .dataConsumed: .dataConsumed
-        case .dataPlayedBack: .dataPlayedBack
-        }
-        let scheduledEngine = engine
-        node.scheduleBuffer(buffer, completionCallbackType: callbackType) { [weak scheduledEngine] callbackType in
-            // The API invokes this callback when the player is stopped as
-            // well. A configuration change can stop the engine before its
-            // notification reaches MainActor, so do not misclassify that
-            // flushed tail as audible playback.
-            guard scheduledEngine?.isRunning == true else {
-                completionHandler(.playbackStopped)
-                return
-            }
-            switch callbackType {
-            case .dataConsumed:
-                completionHandler(.dataConsumed)
-            case .dataRendered:
-                completionHandler(.dataConsumed)
-            case .dataPlayedBack:
-                completionHandler(.dataPlayedBack)
-            @unknown default:
-                completionHandler(.playbackStopped)
-            }
-        }
-    }
-}
-
-/// Completion callbacks arrive off the main actor, while engine rebuilds are
-/// serialized on it. This small lock-backed latch lets a rebuild atomically
-/// claim only buffers whose completion has not already fired — even when the
-/// callback's hop back to the main actor is still queued.
-private final class PTTPlaybackCompletionState: @unchecked Sendable {
-    private enum State {
-        case scheduled
-        case completed
-        case retired
-    }
-
-    private let lock = NSLock()
-    private var state: State = .scheduled
-
-    /// Returns true exactly once when playback completion wins the race with
-    /// an engine rebuild or stop.
-    func complete() -> Bool {
-        lock.withLock {
-            guard case .scheduled = state else { return false }
-            state = .completed
-            return true
-        }
-    }
-
-    /// Returns true exactly once when a rebuild or stop claims this
-    /// still-pending schedule. Later callbacks from that engine are stale.
-    func retireIfPending() -> Bool {
-        lock.withLock {
-            guard case .scheduled = state else { return false }
-            state = .retired
-            return true
-        }
-    }
-}
-
 /// Plays one inbound live voice burst with a small jitter buffer.
 ///
 /// Frames are decoded and scheduled back-to-back on an `AVAudioPlayerNode`;
@@ -149,77 +17,27 @@ private final class PTTPlaybackCompletionState: @unchecked Sendable {
 /// buffer arrives, which self-heals timing without explicit silence
 /// insertion. Playback starts once `TransportConfig.pttJitterBufferSeconds`
 /// of audio is queued or `pttJitterDeadlineSeconds` has elapsed.
-///
-/// Talk-over is bidirectional: when push-to-talk capture starts while this
-/// burst plays, the session category escalates underneath the engine — the
-/// player rebuilds a fresh engine against the new configuration and keeps
-/// streaming instead of dying. Real interruptions (phone call, route device
-/// gone) still stop it; the burst keeps assembling to file either way.
 @MainActor
 final class PTTBurstPlayer {
-    /// Restart-on-reconfigure ceiling: a burst is at most ~2 minutes, so a
-    /// handful of category/route changes is plenty — beyond it something is
-    /// thrashing and stopping cleanly beats an engine-rebuild loop.
-    private static let maxEngineRestarts = 8
-
-    private let makeEngine: @MainActor () -> PTTPlaybackEngine
-    private var engine: PTTPlaybackEngine
+    private let engine = AVAudioEngine()
+    private let node = AVAudioPlayerNode()
     private let decoder: PTTFrameDecoder
-    private let coordinator: AudioSessionCoordinator
-    /// Injectable so tests don't fight over the app-wide exclusive-playback
-    /// slot (a parallel test's `play()` would stop this player mid-test).
-    private let exclusivity: VoiceNotePlaybackCoordinator
 
     private var queuedBuffers: [AVAudioPCMBuffer] = []
     private var queuedDuration: TimeInterval = 0
-    private struct ScheduledBuffer {
-        let id: UInt64
-        let buffer: AVAudioPCMBuffer
-        let completionState: PTTPlaybackCompletionState
-    }
-    /// Buffers handed to the current engine whose completion has not yet
-    /// been processed on the main actor. Keeping the buffers themselves lets
-    /// a category-escalation rebuild replay the unfinished tail in order.
-    private var scheduledBuffers: [ScheduledBuffer] = []
-    private var nextScheduledBufferID: UInt64 = 0
-    /// Bumped on every engine rebuild or stop so completion tasks from a
-    /// torn-down engine cannot mutate the current generation's pending list.
-    private var engineGeneration = 0
-    private var engineRestarts = 0
+    private var scheduledCount = 0
     private var engineStarted = false
     private var finished = false
-    /// Latched off (internal read so tests can await the async failure path).
-    private(set) var stopped = false
-    /// A session acquire is in flight (it suspends off-main for the blocking
-    /// session IPC); gates `startIfReady` against double acquisition.
-    private var acquiringSession = false
+    private var stopped = false
     private var deadlineTask: Task<Void, Never>?
-    private var sessionToken: AudioSessionCoordinator.Token?
-    /// Reserved before the session acquire suspends. Activation succeeds only
-    /// if no newer playback request claimed the floor in the meantime.
-    private var playbackReservation: VoiceNotePlaybackCoordinator.Reservation?
-    private var configChangeObserver: NSObjectProtocol?
 
     private(set) var isPlaying = false
 
-    /// Fires exactly once when the player stops for good (drain-out, cancel,
-    /// interruption, failure). `ChatLiveVoiceCoordinator` uses it to unpark
-    /// the draining player it keeps alive after the assembly — the player's
-    /// only long-lived owner — is discarded on burst END.
-    var onStopped: (() -> Void)?
-
-    init?(
-        coordinator: AudioSessionCoordinator? = nil,
-        exclusivity: VoiceNotePlaybackCoordinator? = nil,
-        makeEngine: (@MainActor () -> PTTPlaybackEngine)? = nil
-    ) {
+    init?() {
         guard let format = PTTAudioFormat.pcmFormat, let decoder = PTTFrameDecoder() else { return nil }
         self.decoder = decoder
-        self.coordinator = coordinator ?? .shared
-        self.exclusivity = exclusivity ?? .shared
-        let factory = makeEngine ?? { SystemPTTPlaybackEngine(format: format) }
-        self.makeEngine = factory
-        self.engine = factory()
+        engine.attach(node)
+        engine.connect(node, to: engine.mainMixerNode, format: format)
 
         deadlineTask = Task { [weak self] in
             try? await Task.sleep(nanoseconds: UInt64(TransportConfig.pttJitterDeadlineSeconds * 1_000_000_000))
@@ -227,21 +45,6 @@ final class PTTBurstPlayer {
         }
     }
 
-    deinit {
-        // Backstop for an owner dropping the player before it stopped: the
-        // session coordinator retains registered tokens strongly, so a token
-        // leaked here would keep the session active (and pin any escalated
-        // category) for the app's lifetime. `release` is fire-and-forget
-        // onto the coordinator's queue, so it is deinit-safe.
-        if let token = sessionToken {
-            coordinator.release(token)
-        }
-        if let observer = configChangeObserver {
-            NotificationCenter.default.removeObserver(observer)
-        }
-        deadlineTask?.cancel()
-    }
-
     /// Decodes and queues frames (in burst order). Starts playback when the
     /// jitter buffer fills.
     func enqueue(_ frames: [Data]) {
@@ -261,119 +64,49 @@ final class PTTBurstPlayer {
     /// The burst ended: stop once everything scheduled has played out.
     func finishAfterDrain() {
         finished = true
-        // The complete burst is queued — no jitter left to wait for. This
-        // also matters when END lands while the async session acquire is
-        // still in flight: the queued audio must play out, not be treated
-        // as already drained.
-        startIfReady(force: true)
         stopIfDrained()
     }
 
-    /// Immediate stop (cancel, another playback taking over, interruption,
-    /// teardown).
+    /// Immediate stop (cancel, another playback taking over, teardown).
     func stop() {
         guard !stopped else { return }
         stopped = true
         deadlineTask?.cancel()
-        removeConfigObserver()
         queuedBuffers = []
-        retireScheduledBuffers()
         if engineStarted {
+            node.stop()
             engine.stop()
         }
         isPlaying = false
-        releaseSessionToken()
-        exclusivity.deactivate(self)
-        onStopped?()
+        VoiceNotePlaybackCoordinator.shared.deactivate(self)
     }
 
     private func startIfReady(force: Bool) {
-        guard !engineStarted, !acquiringSession, !stopped, !queuedBuffers.isEmpty else { return }
+        guard !engineStarted, !stopped, !queuedBuffers.isEmpty else { return }
         guard force || queuedDuration >= TransportConfig.pttJitterBufferSeconds else { return }
 
-        // Acquiring the session suspends for its blocking IPC (off the main
-        // actor); frames arriving meanwhile keep queueing and are flushed
-        // onto the engine once it starts.
-        acquiringSession = true
-        playbackReservation = exclusivity.reserve(self)
-        Task { [weak self] in
-            await self?.acquireSessionAndStart()
-        }
-    }
-
-    private func acquireSessionAndStart() async {
-        let token: AudioSessionCoordinator.Token
+        #if os(iOS)
         do {
-            token = try await coordinator.acquire(
-                .playback,
-                onInterrupted: { [weak self] in self?.stop() },
-                onCategoryEscalated: { [weak self] in self?.restartEngine() }
-            )
+            let session = AVAudioSession.sharedInstance()
+            try session.setCategory(.playback, mode: .spokenAudio, options: [.mixWithOthers])
+            try session.setActive(true, options: [])
         } catch {
-            acquiringSession = false
             SecureLogger.error("PTT playback session activation failed: \(error)", category: .session)
-            // Playing unregistered would leave the engine exposed: another
-            // holder's last release deactivates the session mid-play, and no
-            // interruption/escalation fan-out ever reaches us. Bail like the
-            // engine-start failure below; the burst still assembles to file.
-            // (stop() also fires onStopped so a parked draining player is
-            // unparked instead of leaking.)
-            stop()
-            return
-        }
-        acquiringSession = false
-        // stop() (cancel, exclusivity, teardown) may have landed while the
-        // session was activating: hand the token straight back.
-        guard !stopped else {
-            coordinator.release(token)
-            return
-        }
-        sessionToken = token
-        guard let playbackReservation,
-              exclusivity.isCurrent(playbackReservation, for: self)
-        else {
-            // The request was superseded while audio-session activation was
-            // suspended. Do not even start the retired engine.
-            stop()
-            return
         }
+        #endif
 
-        // Observe reconfiguration before starting so nothing lands between.
-        registerConfigObserver()
+        engine.prepare()
         do {
             try engine.start()
         } catch {
-            // A capture racing this start can reconfigure the session while
-            // the engine spins up (its escalation fan-out no-ops on a player
-            // that never started): rebuild once against the settled
-            // configuration — counted against the restart cap — before
-            // giving up.
-            SecureLogger.warning("PTT playback engine failed to start (\(error)) — rebuilding once", category: .session)
-            removeConfigObserver()
-            engineRestarts += 1
-            engine = makeEngine()
-            registerConfigObserver()
-            do {
-                try engine.start()
-            } catch {
-                SecureLogger.error("PTT playback engine failed to start: \(error)", category: .session)
-                // stop() removes the observer, hands the token back, and
-                // fires onStopped for any parked draining owner.
-                stop()
-                return
-            }
-        }
-        engineStarted = true
-        guard exclusivity.activate(self, reservation: playbackReservation)
-        else {
-            // A newer user-initiated playback reserved the floor while this
-            // older PTT request was suspended in audio-session activation.
-            // Never let the late completion steal playback back.
-            stop()
+            SecureLogger.error("PTT playback engine failed to start: \(error)", category: .session)
+            stopped = true
             return
         }
+        engineStarted = true
         isPlaying = true
-        engine.play()
+        VoiceNotePlaybackCoordinator.shared.activate(self)
+        node.play()
 
         let buffered = queuedBuffers
         queuedBuffers = []
@@ -383,119 +116,21 @@ final class PTTBurstPlayer {
         }
     }
 
-    /// The audio session was reconfigured underneath the running engine
-    /// (category escalation for talk-over, or an engine configuration
-    /// change): rebuild a fresh engine against the new configuration and
-    /// keep streaming. Buffers already completed stay completed; the
-    /// unfinished scheduled tail is replayed in order on the fresh engine,
-    /// and frames still arriving continue scheduling after it.
-    private func restartEngine() {
-        guard engineStarted, !stopped else { return }
-        engineRestarts += 1
-        guard engineRestarts <= Self.maxEngineRestarts else {
-            SecureLogger.warning("PTT playback: engine reconfigured \(engineRestarts) times in one burst — stopping", category: .session)
-            stop()
-            return
-        }
-
-        removeConfigObserver()
-        // Claim the unfinished tail before stopping the old engine. Stopping
-        // a player node may itself invoke its completion handlers; retiring
-        // the claimed entries first makes those callbacks unambiguously stale.
-        // A completion that fired just before this rebuild wins the latch and
-        // is excluded even if its MainActor task has not run yet.
-        let buffersToReplay = scheduledBuffers.compactMap { scheduled in
-            scheduled.completionState.retireIfPending() ? scheduled.buffer : nil
-        }
-        scheduledBuffers = []
-        engineGeneration += 1
-        engine.stop()
-        engine = makeEngine()
-        registerConfigObserver()
-        do {
-            try engine.start()
-        } catch {
-            SecureLogger.error("PTT playback engine failed to restart after session reconfigure: \(error)", category: .session)
-            stop()
-            return
-        }
-        engine.play()
-        for buffer in buffersToReplay {
-            schedule(buffer)
-        }
-        SecureLogger.info("PTT playback: engine restarted after session reconfigure", category: .session)
-        // If every old buffer completed before the rebuild, a finished burst
-        // can stop now. Otherwise the replayed tail keeps it alive until its
-        // new-generation completions arrive.
-        stopIfDrained()
-    }
-
-    private func registerConfigObserver() {
-        guard let object = engine.configChangeObject else { return }
-        configChangeObserver = NotificationCenter.default.addObserver(
-            forName: .AVAudioEngineConfigurationChange,
-            object: object,
-            queue: .main
-        ) { [weak self] _ in
-            Task { @MainActor [weak self] in
-                self?.restartEngine()
-            }
-        }
-    }
-
-    private func removeConfigObserver() {
-        if let observer = configChangeObserver {
-            NotificationCenter.default.removeObserver(observer)
-            configChangeObserver = nil
-        }
-    }
-
     private func schedule(_ buffer: AVAudioPCMBuffer) {
-        let id = nextScheduledBufferID
-        nextScheduledBufferID &+= 1
-        let completionState = PTTPlaybackCompletionState()
-        scheduledBuffers.append(ScheduledBuffer(
-            id: id,
-            buffer: buffer,
-            completionState: completionState
-        ))
-        let generation = engineGeneration
-        engine.schedule(buffer, completionType: .dataPlayedBack) { [weak self, completionState] event in
-            guard event == .dataPlayedBack else { return }
-            // Mark completion before hopping to MainActor. A rebuild can then
-            // distinguish already-completed audio from an unfinished tail
-            // even when this task has not run yet.
-            guard completionState.complete() else { return }
+        scheduledCount += 1
+        node.scheduleBuffer(buffer) { [weak self] in
             Task { @MainActor [weak self] in
-                guard let self, self.engineGeneration == generation else { return }
-                self.scheduledBuffers.removeAll { $0.id == id }
+                guard let self else { return }
+                self.scheduledCount -= 1
                 self.stopIfDrained()
             }
         }
     }
 
-    private func retireScheduledBuffers() {
-        engineGeneration += 1
-        for scheduled in scheduledBuffers {
-            _ = scheduled.completionState.retireIfPending()
-        }
-        scheduledBuffers = []
-    }
-
     private func stopIfDrained() {
-        guard finished, scheduledBuffers.isEmpty else { return }
-        // Started: everything scheduled has played out. Never started with
-        // nothing queued or in flight (e.g. no decodable frames): nothing
-        // will ever play. Otherwise the engine start is still pending (the
-        // async session acquire) and the queued audio must play out first.
-        guard engineStarted || (!acquiringSession && queuedBuffers.isEmpty) else { return }
+        guard finished, scheduledCount <= 0 else { return }
         stop()
     }
-
-    private func releaseSessionToken() {
-        sessionToken.map(coordinator.release)
-        sessionToken = nil
-    }
 }
 
 extension PTTBurstPlayer: ExclusivePlayback {

bitchat/Features/voice/PTTCaptureEngine.swift

@@ -10,85 +10,12 @@ import AVFoundation
 import BitLogger
 import Foundation
 
-/// Owns one capture token and returns it even when the capture engine's owner
-/// disappears without reaching its normal stop/cancel path. The coordinator
-/// retains registered tokens strongly, so relying on `Token.deinit` cannot
-/// reclaim an abandoned hold.
-final class PTTCaptureSessionLease: @unchecked Sendable {
-    private let coordinator: AudioSessionCoordinator
-    private let lock = NSLock()
-    private var token: AudioSessionCoordinator.Token?
-
-    init(coordinator: AudioSessionCoordinator) {
-        self.coordinator = coordinator
-    }
-
-    func install(_ token: AudioSessionCoordinator.Token) {
-        let previous = lock.withLock {
-            let previous = self.token
-            self.token = token
-            return previous
-        }
-        previous.map(coordinator.release)
-    }
-
-    func release() {
-        let token = lock.withLock {
-            let token = self.token
-            self.token = nil
-            return token
-        }
-        token.map(coordinator.release)
-    }
-
-    deinit {
-        release()
-    }
-}
-
-/// Monotonic capture identity shared by main-actor lifecycle code and queued
-/// engine callbacks. Removing a notification observer does not cancel a block
-/// already enqueued on the main queue, so every callback must also prove it
-/// still belongs to the current hold before mutating capture state.
-final class PTTCaptureGeneration: @unchecked Sendable {
-    private let lock = NSLock()
-    private var value: UInt = 0
-
-    func begin() -> UInt {
-        lock.withLock {
-            value &+= 1
-            return value
-        }
-    }
-
-    func invalidate() {
-        lock.withLock { value &+= 1 }
-    }
-
-    func invalidate(ifCurrent generation: UInt) -> Bool {
-        lock.withLock {
-            guard value == generation else { return false }
-            value &+= 1
-            return true
-        }
-    }
-
-    func isCurrent(_ generation: UInt) -> Bool {
-        lock.withLock { value == generation }
-    }
-}
-
 /// Captures microphone audio for a live push-to-talk burst, producing both:
 /// - live AAC frames via `onFrames` (called on the capture queue), and
 /// - a finalized `.m4a` voice note on `stop()` — the same artifact
 ///   `VoiceRecorder` produces, so the existing voice-note send pipeline
 ///   handles delivery to receivers that missed the live stream.
-/// `@unchecked Sendable`: every mutable property is confined to one executor —
-/// the capture `queue` (resampler/encoder/file/counters) or the main actor
-/// (`engine`, `engineStarted`, `sessionLease`, `configChangeObserver`) — so
-/// weak references may cross the `@Sendable` tap/notification closures, which
-/// immediately hop back to the owning executor.
-final class PTTCaptureEngine: @unchecked Sendable {
+final class PTTCaptureEngine {
     /// Hard cap matching `VoiceRecorder.maxRecordingDuration`: past it the
     /// engine keeps running (the UI owns the gesture) but stops encoding.
     private static let maxCaptureDuration: TimeInterval = 120
@@ -99,9 +26,6 @@ final class PTTCaptureEngine: @unchecked Sendable {
     /// enable the mic (AURemoteIO -10851, observed on iPhone field tests).
     private var engine = AVAudioEngine()
     private let queue = DispatchQueue(label: "chat.bitchat.ptt.capture", qos: .userInitiated)
-    private let coordinator: AudioSessionCoordinator
-    private let sessionLease: PTTCaptureSessionLease
-    private let captureGeneration = PTTCaptureGeneration()
 
     // Capture-queue-confined state.
     private var resampler: PTTInputResampler?
@@ -111,10 +35,10 @@ final class PTTCaptureEngine: @unchecked Sendable {
     private var encodedFrameCount = 0
     private var running = false
     private var captureStart = Date()
-    /// Whether `engine.start()` succeeded for the current capture
-    /// (see `stopEngineIfStarted`).
-    @MainActor private var engineStarted = false
-    @MainActor private var configChangeObserver: NSObjectProtocol?
+    /// Whether `engine.start()` succeeded for the current capture (main-actor
+    /// callers only; see `stopEngineIfStarted`).
+    private var engineStarted = false
+
     /// Called on the capture queue with each batch of encoded AAC frames.
     var onFrames: (([Data]) -> Void)?
 
@@ -123,41 +47,11 @@ final class PTTCaptureEngine: @unchecked Sendable {
         case audioSetupFailed
     }
 
-    init(coordinator: AudioSessionCoordinator = .shared) {
-        self.coordinator = coordinator
-        self.sessionLease = PTTCaptureSessionLease(coordinator: coordinator)
-    }
+    func start(outputURL: URL) throws {
+        #if os(iOS)
+        try Self.configureAudioSession()
+        #endif
 
-    deinit {
-        sessionLease.release()
-    }
-
-    /// Async because acquiring the session hops its blocking IPC off the main
-    /// actor (a PTT press used to stall main >1 s in `setActive`); the engine
-    /// itself still starts back on main once the session is configured.
-    @MainActor
-    func start(outputURL: URL) async throws {
-        let generation = captureGeneration.begin()
-        let token = try await coordinator.acquire(.capture) { [weak self] in
-            self?.handleInterruption(for: generation)
-        }
-        // The hold ended (stop/cancel) while the session was activating:
-        // starting the engine now would leave a hot mic after release.
-        guard captureGeneration.isCurrent(generation) else {
-            coordinator.release(token)
-            throw CancellationError()
-        }
-        sessionLease.install(token)
-        do {
-            try beginCapture(outputURL: outputURL, generation: generation)
-        } catch {
-            releaseSessionToken()
-            throw error
-        }
-    }
-
-    @MainActor
-    private func beginCapture(outputURL: URL, generation: UInt) throws {
         // Fresh engine per capture so its input unit binds to the session
         // that is active *now* (see `engine` doc comment).
         engine = AVAudioEngine()
@@ -189,30 +83,13 @@ final class PTTCaptureEngine: @unchecked Sendable {
         }
 
         engine.inputNode.installTap(onBus: 0, bufferSize: 4096, format: inputFormat) { [weak self] buffer, _ in
-            self?.queue.async { self?.process(buffer, generation: generation) }
-        }
-        // Route/category changes reconfigure the engine underneath the tap;
-        // stop and finalize cleanly — the .m4a captured so far still sends.
-        // Registered before start() so no reconfigure lands unobserved
-        // (handleInterruption also validates this capture generation).
-        configChangeObserver = NotificationCenter.default.addObserver(
-            forName: .AVAudioEngineConfigurationChange,
-            object: engine,
-            queue: .main
-        ) { [weak self] _ in
-            Task { @MainActor [weak self] in
-                self?.handleInterruption(for: generation)
-            }
+            self?.queue.async { self?.process(buffer) }
         }
         engine.prepare()
         do {
             try engine.start()
         } catch {
             SecureLogger.error("PTT: capture engine failed to start (input: \(Int(inputFormat.sampleRate)) Hz, \(inputFormat.channelCount) ch): \(error)", category: .session)
-            if let observer = configChangeObserver {
-                NotificationCenter.default.removeObserver(observer)
-                configChangeObserver = nil
-            }
             engine.inputNode.removeTap(onBus: 0)
             queue.sync { self.teardown(deleteFile: true) }
             throw error
@@ -223,9 +100,7 @@ final class PTTCaptureEngine: @unchecked Sendable {
 
     /// Stops capture and finalizes the `.m4a`. Returns the file URL and the
     /// number of encoded AAC frames (each `PTTAudioFormat.frameDuration` long).
-    @MainActor
     func stop() -> (url: URL?, encodedFrames: Int) {
-        captureGeneration.invalidate()
         stopEngineIfStarted()
         let result: (URL?, Int) = queue.sync {
             let url = fileURL
@@ -233,70 +108,34 @@ final class PTTCaptureEngine: @unchecked Sendable {
             teardown(deleteFile: false)
             return (url, frames)
         }
-        releaseSessionToken()
+        #if os(iOS)
+        Self.deactivateAudioSession()
+        #endif
         return result
     }
 
-    @MainActor
     func cancel() {
-        captureGeneration.invalidate()
         stopEngineIfStarted()
         queue.sync { teardown(deleteFile: true) }
-        releaseSessionToken()
-    }
-
-    /// Audio session interrupted (call, Siri) or the engine was reconfigured
-    /// mid-capture: behave like `stop()` — finalize the `.m4a` container but
-    /// keep `fileURL`/`encodedFrameCount` so the caller's pending `stop()`
-    /// still returns the note for delivery.
-    @MainActor
-    private func handleInterruption(for generation: UInt) {
-        // Also invalidate a start whose acquire has registered its token but
-        // has not returned to this actor yet. Without this bump the callback
-        // is lost while `engineStarted == false`, and the resumed start can
-        // open the mic after the stop signal.
-        guard captureGeneration.invalidate(ifCurrent: generation) else { return }
-        guard engineStarted else {
-            releaseSessionToken()
-            return
-        }
-        stopEngineIfStarted()
-        queue.sync {
-            running = false
-            // Releasing the AVAudioFile finalizes the .m4a container.
-            file = nil
-            encoder = nil
-            resampler = nil
-        }
-        releaseSessionToken()
-        SecureLogger.info("PTT: capture interrupted — burst finalized early", category: .session)
+        #if os(iOS)
+        Self.deactivateAudioSession()
+        #endif
     }
 
     /// Touching `inputNode` on an engine that never started instantiates its
     /// input unit against whatever session is active and spams AURemoteIO
     /// errors — a canceled-before-start hold must not touch the engine.
-    @MainActor
     private func stopEngineIfStarted() {
-        if let observer = configChangeObserver {
-            NotificationCenter.default.removeObserver(observer)
-            configChangeObserver = nil
-        }
         guard engineStarted else { return }
         engineStarted = false
         engine.inputNode.removeTap(onBus: 0)
         engine.stop()
     }
 
-    @MainActor
-    private func releaseSessionToken() {
-        sessionLease.release()
-    }
-
     // MARK: - Capture queue
 
-    private func process(_ buffer: AVAudioPCMBuffer, generation: UInt) {
-        guard captureGeneration.isCurrent(generation),
-              running,
+    private func process(_ buffer: AVAudioPCMBuffer) {
+        guard running,
               Date().timeIntervalSince(captureStart) < Self.maxCaptureDuration,
               let resampled = resampler?.resample(buffer)
         else { return }
@@ -323,4 +162,22 @@ final class PTTCaptureEngine: @unchecked Sendable {
         }
         fileURL = nil
     }
+
+    // MARK: - Audio session (iOS)
+
+    #if os(iOS)
+    private static func configureAudioSession() throws {
+        let session = AVAudioSession.sharedInstance()
+        #if targetEnvironment(simulator)
+        try session.setCategory(.playAndRecord, mode: .default, options: [.defaultToSpeaker, .allowBluetoothA2DP])
+        #else
+        try session.setCategory(.playAndRecord, mode: .default, options: [.defaultToSpeaker, .allowBluetoothA2DP, .allowBluetoothHFP])
+        #endif
+        try session.setActive(true, options: .notifyOthersOnDeactivation)
+    }
+
+    private static func deactivateAudioSession() {
+        try? AVAudioSession.sharedInstance().setActive(false, options: .notifyOthersOnDeactivation)
+    }
+    #endif
 }

bitchat/Features/voice/VoiceCaptureSession.swift

@@ -26,56 +26,30 @@ protocol VoiceCaptureSession: AnyObject {
     /// nothing valid was captured.
     func finish() async -> URL?
     func cancel() async
-    /// Stops capture and suppresses every later send before returning.
-    func panicCancelSynchronously()
 }
 
 /// The classic record-then-send backend, wrapping the shared `VoiceRecorder`.
 @MainActor
 final class VoiceNoteCaptureSession: VoiceCaptureSession {
-    private let recorder: VoiceRecorder
-    private let owner = VoiceRecorder.RecordingOwner()
-
     var isLive: Bool { false }
 
-    init(recorder: VoiceRecorder = .shared) {
-        self.recorder = recorder
-    }
-
     func requestPermission() async -> Bool {
-        await recorder.requestPermission()
+        await VoiceRecorder.shared.requestPermission()
     }
 
     func start() async throws {
-        try await recorder.startRecording(owner: owner)
+        try await VoiceRecorder.shared.startRecording()
     }
 
     func finish() async -> URL? {
-        await recorder.stopRecording(owner: owner)
+        await VoiceRecorder.shared.stopRecording()
     }
 
     func cancel() async {
-        await recorder.cancelRecording(owner: owner)
-    }
-
-    func panicCancelSynchronously() {
-        recorder.panicCancelSynchronously(owner: owner)
+        await VoiceRecorder.shared.cancelRecording()
     }
 }
 
-/// Testable surface of the live capture engine. Production uses
-/// `PTTCaptureEngine`; tests can supply captured-frame counts without opening
-/// real audio hardware.
-@MainActor
-protocol PTTCapturing: AnyObject {
-    var onFrames: (([Data]) -> Void)? { get set }
-    func start(outputURL: URL) async throws
-    func stop() -> (url: URL?, encodedFrames: Int)
-    func cancel()
-}
-
-extension PTTCaptureEngine: PTTCapturing {}
-
 /// Live push-to-talk backend: streams `VoiceBurstPacket`s to one peer while
 /// recording, then finalizes the same audio as a standard voice note whose
 /// file name carries the burst ID (`voice_<burstID>.m4a`) so receivers that
@@ -86,8 +60,7 @@ final class PTTLiveVoiceSession: VoiceCaptureSession {
     let burstID: Data
 
     private let sendPacket: (Data) -> Void
-    private let capture: any PTTCapturing
-    private let now: () -> Date
+    private let capture = PTTCaptureEngine()
     /// Capture-queue-confined stream state: packetizes frames and lazily
     /// emits START so packet order is guaranteed by queue serialization.
     private final class StreamState {
@@ -106,17 +79,10 @@ final class PTTLiveVoiceSession: VoiceCaptureSession {
     /// - Parameter sendPacket: delivers one encoded `VoiceBurstPacket` to the
     ///   target peer; must be safe to call from any queue (BLEService hops to
     ///   its own message queue internally).
-    init(
-        sendPacket: @escaping (Data) -> Void,
-        capture: (any PTTCapturing)? = nil,
-        now: @escaping () -> Date = Date.init,
-        burstID: Data? = nil
-    ) {
-        self.burstID = burstID ?? VoiceBurstPacket.makeBurstID()
+    init(sendPacket: @escaping (Data) -> Void) {
+        self.burstID = VoiceBurstPacket.makeBurstID()
         self.sendPacket = sendPacket
-        self.capture = capture ?? PTTCaptureEngine()
-        self.now = now
-        self.stream = StreamState(burstID: self.burstID)
+        self.stream = StreamState(burstID: burstID)
     }
 
     func requestPermission() async -> Bool {
@@ -151,31 +117,16 @@ final class PTTLiveVoiceSession: VoiceCaptureSession {
             }
         }
         do {
-            try await capture.start(outputURL: outputURL)
-        } catch is CancellationError {
-            // The hold was released/canceled while the session acquire was
-            // in flight: the engine never started and the capture already
-            // handed its token back — nothing to retry. A coordinator-side
-            // interruption during handoff also cancels acquire, but that is
-            // not a successful start and must propagate to the view model.
-            guard completed else { throw CancellationError() }
-            return
+            try capture.start(outputURL: outputURL)
         } catch {
             // The HAL can briefly report a dead input right after the audio
             // session (re)activates while the route settles; one retry after
             // a short pause covers it (observed on iPhone field tests).
             SecureLogger.warning("PTT: capture start failed (\(error)) — retrying once after route settle", category: .session)
             try? await Task.sleep(nanoseconds: 150_000_000)
-            // The hold may have been released/canceled during the retry pause.
-            // Starting the mic now would leave it live and streaming after the
-            // user let go, so bail instead of opening a hot mic.
-            guard !completed else {
-                capture.cancel()
-                return
-            }
-            try await capture.start(outputURL: outputURL)
+            try capture.start(outputURL: outputURL)
         }
-        startDate = now()
+        startDate = Date()
         SecureLogger.info("PTT: live burst \(burstID.hexEncodedString()) capture started", category: .session)
     }
 
@@ -183,16 +134,11 @@ final class PTTLiveVoiceSession: VoiceCaptureSession {
         guard !completed else { return nil }
         completed = true
 
-        let elapsed = startDate.map { now().timeIntervalSince($0) } ?? 0
+        let elapsed = startDate.map { Date().timeIntervalSince($0) } ?? 0
         let (url, encodedFrames) = capture.stop()
         // stop() drained the capture queue, so touching `stream` is safe now.
 
-        let capturedDuration = Double(encodedFrames) * PTTAudioFormat.frameDuration
-
-        guard elapsed >= VoiceRecorder.minRecordingDuration,
-              capturedDuration >= VoiceRecorder.minRecordingDuration,
-              let url
-        else {
+        guard elapsed >= VoiceRecorder.minRecordingDuration, let url else {
             sendControlPacket(.canceled)
             if let url {
                 try? FileManager.default.removeItem(at: url)
@@ -203,30 +149,17 @@ final class PTTLiveVoiceSession: VoiceCaptureSession {
         for packet in stream.packetizer.flush() {
             sendPacket(packet)
         }
-        let durationMs = UInt32((capturedDuration * 1000).rounded())
+        let durationMs = UInt32((Double(encodedFrames) * PTTAudioFormat.frameDuration * 1000).rounded())
         sendControlPacket(.end(totalDataPackets: stream.packetizer.dataPacketCount, durationMs: durationMs))
         SecureLogger.info("PTT: live burst \(burstID.hexEncodedString()) finished — \(stream.packetizer.dataPacketCount) data packets, \(encodedFrames) frames, \(durationMs) ms", category: .session)
         return url
     }
 
     func cancel() async {
-        let alreadyCompleted = completed
-        completed = true
-        // Always tear down the capture, even if a quick-release already marked
-        // us completed: the engine can start late (during start()'s retry
-        // pause), and only capture.cancel() stops the mic and deactivates the
-        // session. It is idempotent, so a redundant call is harmless.
-        capture.cancel()
-        if !alreadyCompleted {
-            sendControlPacket(.canceled)
-        }
-    }
-
-    func panicCancelSynchronously() {
-        // Do not emit a canceled packet: it would itself be pre-panic
-        // conversation data racing the emergency transport reset.
+        guard !completed else { return }
         completed = true
         capture.cancel()
+        sendControlPacket(.canceled)
     }
 
     private func sendControlPacket(_ kind: VoiceBurstPacket.Kind) {
@@ -244,7 +177,7 @@ final class PTTLiveVoiceSession: VoiceCaptureSession {
         let directory = base
             .appendingPathComponent("files", isDirectory: true)
             .appendingPathComponent("voicenotes/outgoing", isDirectory: true)
-        try FileManager.default.createDirectory(at: directory, withIntermediateDirectories: true, attributes: BLEIncomingFileStore.mediaProtectionAttributes)
+        try FileManager.default.createDirectory(at: directory, withIntermediateDirectories: true, attributes: nil)
         return directory.appendingPathComponent("voice_\(burstID.hexEncodedString()).m4a")
     }
 }

bitchat/Features/voice/VoiceNotePlaybackController.swift

@@ -9,9 +9,6 @@ final class VoiceNotePlaybackController: NSObject, ObservableObject, AVAudioPlay
     @Published private(set) var duration: TimeInterval = 0
     @Published private(set) var progress: Double = 0
 
-    /// Internal lifecycle visibility for deterministic acquisition tests.
-    var isPlaybackStartPending: Bool { sessionAcquireInFlight }
-
     /// rounded so 4.9s shows "00:05"
     var roundedDuration: Int {
         guard duration.isFinite else { return 0 }
@@ -27,24 +24,9 @@ final class VoiceNotePlaybackController: NSObject, ObservableObject, AVAudioPlay
     private var player: AVAudioPlayer?
     private var timer: Timer?
     private var url: URL
-    /// Test seam; `AudioSessionCoordinator.shared` when nil.
-    private let sessionCoordinatorOverride: AudioSessionCoordinator?
-    /// Injectable so tests don't fight over the app-wide exclusive-playback
-    /// slot (a parallel test's `play()` would pause this controller mid-test).
-    private let exclusivity: VoiceNotePlaybackCoordinator
-    private var sessionToken: AudioSessionCoordinator.Token?
-    /// A session acquire is in flight (it suspends off-main for the blocking
-    /// session IPC); gates against double acquisition on rapid play taps.
-    private var sessionAcquireInFlight = false
 
-    init(
-        url: URL,
-        sessionCoordinator: AudioSessionCoordinator? = nil,
-        exclusivity: VoiceNotePlaybackCoordinator? = nil
-    ) {
+    init(url: URL) {
         self.url = url
-        self.sessionCoordinatorOverride = sessionCoordinator
-        self.exclusivity = exclusivity ?? .shared
         super.init()
         // Don't load anything eagerly - wait until user interaction or view is fully displayed
     }
@@ -69,16 +51,6 @@ final class VoiceNotePlaybackController: NSObject, ObservableObject, AVAudioPlay
 
     deinit {
         timer?.invalidate()
-        player?.stop()
-        // A per-row @StateObject can be discarded mid-playback (navigating
-        // away). Leaking the token here would hold the session forever —
-        // never deactivating it, and pinning any escalated category for the
-        // app's lifetime. `release` is fire-and-forget onto the coordinator's
-        // queue, so it is deinit-safe: only the Sendable token crosses.
-        if let token = sessionToken {
-            sessionToken = nil
-            (sessionCoordinatorOverride ?? .shared).release(token)
-        }
     }
 
     func replaceURL(_ url: URL) {
@@ -96,15 +68,11 @@ final class VoiceNotePlaybackController: NSObject, ObservableObject, AVAudioPlay
 
     func play() {
         guard ensurePlayerReady() else { return }
-        exclusivity.activate(self)
-        isPlaying = true
+        VoiceNotePlaybackCoordinator.shared.activate(self)
+        player?.play()
         startTimer()
         updateProgress()
-        // Acquired here (not in ensurePlayerReady): scrubbing a paused note
-        // must not hold the session while nothing is audible. The session
-        // calls block on audio-server IPC, so they run off the main thread;
-        // the player starts once the session is configured.
-        startPlayerAfterAcquiringSession()
+        isPlaying = true
     }
 
     func pause() {
@@ -112,7 +80,6 @@ final class VoiceNotePlaybackController: NSObject, ObservableObject, AVAudioPlay
         stopTimer()
         updateProgress()
         isPlaying = false
-        releaseSession()
     }
 
     func stop() {
@@ -121,8 +88,7 @@ final class VoiceNotePlaybackController: NSObject, ObservableObject, AVAudioPlay
         stopTimer()
         updateProgress()
         isPlaying = false
-        releaseSession()
-        exclusivity.deactivate(self)
+        VoiceNotePlaybackCoordinator.shared.deactivate(self)
     }
 
     func seek(to fraction: Double) {
@@ -130,11 +96,8 @@ final class VoiceNotePlaybackController: NSObject, ObservableObject, AVAudioPlay
         let clamped = max(0, min(1, fraction))
         if let player = player {
             player.currentTime = clamped * player.duration
-            // While the session acquire is still in flight, don't start
-            // audio pre-activation — the pending acquire's completion starts
-            // playback (from the new position) once the session resolves.
-            if isPlaying, !sessionAcquireInFlight {
-                startPreparedPlayer()
+            if isPlaying {
+                player.play()
             }
             updateProgress()
         }
@@ -149,20 +112,18 @@ final class VoiceNotePlaybackController: NSObject, ObservableObject, AVAudioPlay
             self.stopTimer()
             self.updateProgress()
             self.isPlaying = false
-            self.releaseSession()
-            self.exclusivity.deactivate(self)
+            VoiceNotePlaybackCoordinator.shared.deactivate(self)
         }
     }
 
     // MARK: - Private Helpers
 
     private func preparePlayer(for url: URL) {
-        // Load metadata synchronously, but do not call prepareToPlay here:
-        // paused scrubbing reaches this path and must not acquire playback
-        // hardware outside the AudioSessionCoordinator token lifetime.
+        // Prepare player synchronously (only called when playback is requested)
         do {
             let player = try AVAudioPlayer(contentsOf: url)
             player.delegate = self
+            player.prepareToPlay()
             self.player = player
             duration = player.duration
             currentTime = player.currentTime
@@ -180,81 +141,18 @@ final class VoiceNotePlaybackController: NSObject, ObservableObject, AVAudioPlay
         if player == nil {
             preparePlayer(for: url)
         }
+        #if os(iOS)
+        let session = AVAudioSession.sharedInstance()
+        do {
+            try session.setCategory(.playback, mode: .spokenAudio, options: [.mixWithOthers])
+            try session.setActive(true, options: [])
+        } catch {
+            SecureLogger.error("Failed to activate audio session: \(error)", category: .session)
+        }
+        #endif
         return player != nil
     }
 
-    /// All entry points (SwiftUI actions, `pauseForExclusivity`, the
-    /// delegate's main-queue hop) run on the main thread; the acquire itself
-    /// suspends while the blocking session IPC runs on the coordinator's
-    /// queue, and the player starts when it resolves. An acquire failure
-    /// leaves playback stopped: starting without a registered token would
-    /// bypass interruption fan-out and the coordinator's refcount. A
-    /// pause/stop landing mid-acquire hands the token straight back.
-    private func startPlayerAfterAcquiringSession() {
-        if sessionToken != nil {
-            startPreparedPlayer()
-            return
-        }
-        guard !sessionAcquireInFlight else { return }
-        sessionAcquireInFlight = true
-        let coordinator = sessionCoordinatorOverride ?? AudioSessionCoordinator.shared
-        Task { @MainActor [weak self] in
-            var token: AudioSessionCoordinator.Token?
-            do {
-                token = try await coordinator.acquire(.playback) { [weak self] in
-                    self?.pause()
-                }
-            } catch {
-                SecureLogger.error("Failed to activate audio session: \(error)", category: .session)
-            }
-            guard let self else {
-                // The row was discarded while acquiring; deinit had no token
-                // to release yet.
-                token.map(coordinator.release)
-                return
-            }
-            self.sessionAcquireInFlight = false
-            guard self.isPlaying else {
-                // Paused/stopped while the session was activating.
-                token.map(coordinator.release)
-                return
-            }
-            guard let token else {
-                self.failPlaybackStart()
-                return
-            }
-            self.sessionToken = token
-            self.startPreparedPlayer()
-        }
-    }
-
-    @discardableResult
-    private func startPreparedPlayer() -> Bool {
-        guard let player,
-              player.prepareToPlay(),
-              player.play()
-        else {
-            SecureLogger.error("Voice note player refused to start " + url.lastPathComponent, category: .session)
-            failPlaybackStart()
-            return false
-        }
-        return true
-    }
-
-    private func failPlaybackStart() {
-        player?.pause()
-        stopTimer()
-        updateProgress()
-        isPlaying = false
-        releaseSession()
-        exclusivity.deactivate(self)
-    }
-
-    private func releaseSession() {
-        sessionToken.map((sessionCoordinatorOverride ?? .shared).release)
-        sessionToken = nil
-    }
-
     private func startTimer() {
         if timer != nil { return }
         timer = Timer.scheduledTimer(withTimeInterval: 0.05, repeats: true) { [weak self] _ in
@@ -299,59 +197,21 @@ extension VoiceNotePlaybackController: ExclusivePlayback {
 final class VoiceNotePlaybackCoordinator {
     static let shared = VoiceNotePlaybackCoordinator()
 
-    struct Reservation: Equatable {
-        fileprivate let generation: UInt64
-    }
-
     private weak var activeController: (any ExclusivePlayback)?
-    private weak var latestReservedController: (any ExclusivePlayback)?
-    private var latestReservation = Reservation(generation: 0)
 
-    /// Internal so tests can isolate their own exclusivity slot; the app
-    /// uses `shared`.
-    init() {}
+    private init() {}
 
-    /// Records playback intent without interrupting audio that is already
-    /// audible. Async starters reserve before suspension, then activate only
-    /// after their audio resource is ready.
-    func reserve(_ controller: any ExclusivePlayback) -> Reservation {
-        latestReservation = Reservation(generation: latestReservation.generation &+ 1)
-        latestReservedController = controller
-        return latestReservation
-    }
-
-    /// Immediate activation for synchronous/user-initiated playback.
-    @discardableResult
-    func activate(_ controller: any ExclusivePlayback) -> Reservation {
-        let reservation = reserve(controller)
-        _ = activate(controller, reservation: reservation)
-        return reservation
-    }
-
-    /// Commits an earlier reservation only when it is still the newest
-    /// playback request. This prevents an older async acquire from stealing
-    /// the floor after a newer play gesture.
-    @discardableResult
-    func activate(_ controller: any ExclusivePlayback, reservation: Reservation) -> Bool {
-        guard isCurrent(reservation, for: controller) else { return false }
+    func activate(_ controller: any ExclusivePlayback) {
         if activeController === controller {
-            return true
+            return
         }
         activeController?.pauseForExclusivity()
         activeController = controller
-        return true
-    }
-
-    func isCurrent(_ reservation: Reservation, for controller: any ExclusivePlayback) -> Bool {
-        latestReservation == reservation && latestReservedController === controller
     }
 
     func deactivate(_ controller: any ExclusivePlayback) {
         if activeController === controller {
             activeController = nil
         }
-        if latestReservedController === controller {
-            latestReservedController = nil
-        }
     }
 }

bitchat/Features/voice/VoiceRecorder.swift

@@ -1,95 +1,21 @@
 import Foundation
 import AVFoundation
 
-/// The small surface of `AVAudioRecorder` that `VoiceRecorder` owns. Keeping
-/// it behind a protocol lets lifecycle races be tested without opening the
-/// microphone on the test host.
-protocol VoiceAudioRecording: AnyObject {
-    var isRecording: Bool { get }
-    var isMeteringEnabled: Bool { get set }
-    func prepareToRecord() -> Bool
-    func record(forDuration duration: TimeInterval) -> Bool
-    func stop()
-}
-
-extension AVAudioRecorder: VoiceAudioRecording {}
-
-protocol VoiceAudioRecorderCreating {
-    func makeRecorder(url: URL) throws -> any VoiceAudioRecording
-}
-
-private struct SystemVoiceAudioRecorderFactory: VoiceAudioRecorderCreating {
-    func makeRecorder(url: URL) throws -> any VoiceAudioRecording {
-        let settings: [String: Any] = [
-            AVFormatIDKey: kAudioFormatMPEG4AAC,
-            AVSampleRateKey: 16_000,
-            AVNumberOfChannelsKey: 1,
-            AVEncoderBitRateKey: 16_000
-        ]
-        return try AVAudioRecorder(url: url, settings: settings)
-    }
-}
-
 /// Manages audio capture for mesh voice notes with predictable encoding settings.
 actor VoiceRecorder {
-    enum RecorderError: Error, Equatable {
+    enum RecorderError: Error {
         case microphoneAccessDenied
         case recordingInProgress
-        case failedToStartRecording
     }
 
     static let shared = VoiceRecorder()
 
+    private let paddingInterval: TimeInterval = 0.5
+    private let maxRecordingDuration: TimeInterval = 120
     static let minRecordingDuration: TimeInterval = 1
 
-    /// Identity of one press/hold. Every lifecycle mutation must present the
-    /// same owner that started the recorder, so a stale finish or cancel from
-    /// another hold cannot stop or delete the current recording.
-    final class RecordingOwner: @unchecked Sendable {}
-
-    /// Test-only scheduling seams for lifecycle boundaries that otherwise rely
-    /// on wall-clock sleeps. Production uses the real padding delay.
-    struct TestingHooks: Sendable {
-        let waitForStopPadding: (@Sendable (TimeInterval) async -> Void)?
-
-        init(waitForStopPadding: (@Sendable (TimeInterval) async -> Void)? = nil) {
-            self.waitForStopPadding = waitForStopPadding
-        }
-    }
-
-    private let sessionCoordinator: AudioSessionCoordinator
-    private let recorderFactory: any VoiceAudioRecorderCreating
-    private let permissionGranted: () -> Bool
-    private let paddingInterval: TimeInterval
-    private let maxRecordingDuration: TimeInterval
-    private let outputDirectory: URL?
-    private let testingHooks: TestingHooks
-
-    private var recorder: (any VoiceAudioRecording)?
+    private var recorder: AVAudioRecorder?
     private var currentURL: URL?
-    private var sessionToken: AudioSessionCoordinator.Token?
-    private var activeOwner: RecordingOwner?
-    /// True only while `startRecording()` is suspended in session acquire.
-    /// A second start is rejected instead of superseding the first one.
-    private var startInFlight = false
-
-    init(
-        sessionCoordinator: AudioSessionCoordinator = .shared,
-        recorderFactory: any VoiceAudioRecorderCreating = SystemVoiceAudioRecorderFactory(),
-        permissionGranted: (() -> Bool)? = nil,
-        paddingInterval: TimeInterval = 0.5,
-        maxRecordingDuration: TimeInterval = 120,
-        outputDirectory: URL? = nil,
-        testingHooks: TestingHooks = TestingHooks()
-    ) {
-        self.sessionCoordinator = sessionCoordinator
-        self.recorderFactory = recorderFactory
-        self.permissionGranted = permissionGranted ?? Self.hasSystemPermission
-        self.paddingInterval = paddingInterval
-        self.maxRecordingDuration = maxRecordingDuration
-        self.outputDirectory = outputDirectory
-        self.testingHooks = testingHooks
-    }
 
     // MARK: - Permissions
 
@@ -115,130 +41,82 @@ actor VoiceRecorder {
     // MARK: - Recording Lifecycle
 
     @discardableResult
-    func startRecording(owner: RecordingOwner) async throws -> URL {
-        if activeOwner != nil {
+    func startRecording() throws -> URL {
+        if recorder?.isRecording == true {
             throw RecorderError.recordingInProgress
         }
 
-        guard permissionGranted() else {
+        #if os(iOS)
+        let session = AVAudioSession.sharedInstance()
+        guard session.recordPermission == .granted else {
             throw RecorderError.microphoneAccessDenied
         }
-
-        activeOwner = owner
-        startInFlight = true
-
-        // The acquire suspends while the blocking session IPC runs on the
-        // coordinator's queue (never this actor's thread or main).
-        let token: AudioSessionCoordinator.Token
-        do {
-            token = try await sessionCoordinator.acquire(.capture) { [weak self] in
-                Task { await self?.handleSessionInterruption(for: owner) }
-            }
-        } catch {
-            guard activeOwner === owner else {
-                throw CancellationError()
-            }
-            startInFlight = false
-            activeOwner = nil
-            throw error
+        #if targetEnvironment(simulator)
+        // allowBluetoothHFP is not available on iOS Simulator
+        try session.setCategory(
+            .playAndRecord,
+            mode: .default,
+            options: [.defaultToSpeaker, .allowBluetoothA2DP]
+        )
+        #else
+        try session.setCategory(
+            .playAndRecord,
+            mode: .default,
+            options: [.defaultToSpeaker, .allowBluetoothA2DP, .allowBluetoothHFP]
+        )
+        #endif
+        try session.setActive(true, options: .notifyOthersOnDeactivation)
+        #endif
+        #if os(macOS)
+        guard AVCaptureDevice.authorizationStatus(for: .audio) == .authorized else {
+            throw RecorderError.microphoneAccessDenied
         }
+        #endif
 
-        // Actor reentrancy: release/cancel may have ended this hold while the
-        // blocking session activation was still in progress.
-        guard activeOwner === owner, startInFlight else {
-            sessionCoordinator.release(token)
-            throw CancellationError()
-        }
-        startInFlight = false
-        sessionToken = token
+        let outputURL = try makeOutputURL()
+        let settings: [String: Any] = [
+            AVFormatIDKey: kAudioFormatMPEG4AAC,
+            AVSampleRateKey: 16_000,
+            AVNumberOfChannelsKey: 1,
+            AVEncoderBitRateKey: 16_000
+        ]
 
-        var outputURL: URL?
-        do {
-            let newURL = try makeOutputURL()
-            outputURL = newURL
-            let audioRecorder = try recorderFactory.makeRecorder(url: newURL)
-            audioRecorder.isMeteringEnabled = true
-            guard audioRecorder.prepareToRecord() else {
-                throw RecorderError.failedToStartRecording
-            }
-            guard audioRecorder.record(forDuration: maxRecordingDuration) else {
-                throw RecorderError.failedToStartRecording
-            }
+        let audioRecorder = try AVAudioRecorder(url: outputURL, settings: settings)
+        audioRecorder.isMeteringEnabled = true
+        audioRecorder.prepareToRecord()
+        audioRecorder.record(forDuration: maxRecordingDuration)
 
-            recorder = audioRecorder
-            currentURL = newURL
-            return newURL
-        } catch {
-            releaseSessionToken()
-            recorder = nil
-            currentURL = nil
-            activeOwner = nil
-            if let outputURL {
-                try? FileManager.default.removeItem(at: outputURL)
-            }
-            throw error
-        }
+        recorder = audioRecorder
+        currentURL = outputURL
+        return outputURL
     }
 
-    func stopRecording(owner: RecordingOwner) async -> URL? {
-        guard activeOwner === owner else { return nil }
-
-        // `finish()` can race a still-suspended start on a direct caller even
-        // though the UI normally routes quick releases through cancel().
-        if startInFlight {
-            activeOwner = nil
-            startInFlight = false
-            return nil
-        }
-
-        guard let activeRecorder = recorder else {
-            let sessionURL = currentURL
-            releaseSessionToken()
-            currentURL = nil
-            activeOwner = nil
-            return sessionURL
+    func stopRecording() async -> URL? {
+        guard let recorder, recorder.isRecording else {
+            return currentURL
         }
 
         let sessionURL = currentURL
 
-        if activeRecorder.isRecording, paddingInterval > 0 {
-            if let waitForStopPadding = testingHooks.waitForStopPadding {
-                await waitForStopPadding(paddingInterval)
-            } else {
-                try? await Task.sleep(nanoseconds: UInt64(paddingInterval * 1_000_000_000))
-            }
-        }
+        try? await Task.sleep(nanoseconds: UInt64(paddingInterval * 1_000_000_000))
 
-        // Cancellation or interruption may have run during the padding sleep.
-        // Only the recorder whose stop began here may be finalized by it.
-        guard activeOwner === owner,
-              let recorder = self.recorder,
-              recorder === activeRecorder
-        else { return nil }
+        recorder.stop()
 
-        if activeRecorder.isRecording {
-            activeRecorder.stop()
+        // A new session may have started during the sleep — don't touch its state
+        if self.recorder === recorder {
+            cleanupSession()
+            self.recorder = nil
+            currentURL = nil
         }
-        releaseSessionToken()
-        self.recorder = nil
-        currentURL = nil
-        activeOwner = nil
 
         return sessionURL
     }
 
-    func cancelRecording(owner: RecordingOwner) async {
-        guard activeOwner === owner else { return }
-
-        // Invalidate ownership before cleanup. An actor-reentrant start whose
-        // session acquire resumes later will observe the mismatch and release
-        // its token without opening the microphone.
-        activeOwner = nil
-        startInFlight = false
+    func cancelRecording() {
         if let recorder, recorder.isRecording {
             recorder.stop()
         }
-        releaseSessionToken()
+        cleanupSession()
         if let currentURL {
             try? FileManager.default.removeItem(at: currentURL)
         }
@@ -246,61 +124,15 @@ actor VoiceRecorder {
         currentURL = nil
     }
 
-    /// Panic is a synchronous security boundary: the caller must know the
-    /// microphone, audio-session lease, and partial file are gone before it
-    /// rotates identities or deletes the media tree. VoiceRecorder is an
-    /// independent actor and this cleanup path never hops to MainActor, so a
-    /// short semaphore join is safe even when invoked by the UI actor.
-    nonisolated
-    func panicCancelSynchronously(owner: RecordingOwner) {
-        let finished = DispatchSemaphore(value: 0)
-        Task {
-            await cancelRecording(owner: owner)
-            finished.signal()
-        }
-        finished.wait()
-    }
-
-    /// The audio session was interrupted (call, Siri) or reconfigured: stop
-    /// the recorder but keep `recorder`/`currentURL` so the caller's pending
-    /// `stopRecording()` still returns the partial note.
-    private func handleSessionInterruption(for owner: RecordingOwner) async {
-        // A callback captured for a released token must never stop a newer
-        // recording. Conversely, an interruption delivered while acquire is
-        // still suspended invalidates that acquire before it can open the mic.
-        guard activeOwner === owner else { return }
-        if startInFlight {
-            activeOwner = nil
-            startInFlight = false
-            return
-        }
-        startInFlight = false
-        if let recorder, recorder.isRecording {
-            recorder.stop()
-        }
-        releaseSessionToken()
-    }
-
     // MARK: - Helpers
 
-    private static func hasSystemPermission() -> Bool {
-        #if os(iOS)
-        AVAudioSession.sharedInstance().recordPermission == .granted
-        #elseif os(macOS)
-        AVCaptureDevice.authorizationStatus(for: .audio) == .authorized
-        #else
-        true
-        #endif
-    }
-
     private func makeOutputURL() throws -> URL {
         let formatter = DateFormatter()
         formatter.dateFormat = "yyyyMMdd_HHmmss"
-        let fileName = "voice_\(formatter.string(from: Date()))_\(UUID().uuidString).m4a"
+        let fileName = "voice_\(formatter.string(from: Date())).m4a"
 
-        let baseDirectory = try outputDirectory
-            ?? applicationFilesDirectory().appendingPathComponent("voicenotes/outgoing", isDirectory: true)
-        try FileManager.default.createDirectory(at: baseDirectory, withIntermediateDirectories: true, attributes: BLEIncomingFileStore.mediaProtectionAttributes)
+        let baseDirectory = try applicationFilesDirectory().appendingPathComponent("voicenotes/outgoing", isDirectory: true)
+        try FileManager.default.createDirectory(at: baseDirectory, withIntermediateDirectories: true, attributes: nil)
         return baseDirectory.appendingPathComponent(fileName)
     }
 
@@ -314,11 +146,9 @@ actor VoiceRecorder {
         #endif
     }
 
-    /// Fire-and-forget: the coordinator hops the blocking deactivation IPC
-    /// onto its own queue.
-    private func releaseSessionToken() {
-        guard let token = sessionToken else { return }
-        sessionToken = nil
-        sessionCoordinator.release(token)
+    private func cleanupSession() {
+        #if os(iOS)
+        try? AVAudioSession.sharedInstance().setActive(false, options: .notifyOthersOnDeactivation)
+        #endif
     }
 }

bitchat/Identity/IdentityModels.swift

@@ -14,22 +14,18 @@
 ///
 /// ## Overview
 /// BitChat's identity system separates concerns across three distinct layers:
-/// 1. **Network Identity**: the 8-byte peer ID seen on air
+/// 1. **Ephemeral Identity**: Short-lived, rotatable peer IDs for privacy
 /// 2. **Cryptographic Identity**: Long-term Noise static keys for security
-/// 3. **Social Identity**: assigned names and trust relationships
+/// 3. **Social Identity**: User-assigned names and trust relationships
 ///
-/// The layers are separate concerns, but they are not independent: the network
-/// identity is *derived* from the cryptographic one, so it does not provide
-/// unlinkability. Rotating peer IDs would be a change to this model, not a
-/// description of it — see the note below.
+/// This separation allows users to maintain stable cryptographic identities
+/// while frequently rotating their network identifiers for privacy.
 ///
 /// ## Three-Layer Architecture
 ///
-/// ### Layer 1: Network Identity
-/// - 8-byte peer ID = first 8 bytes of the Noise static key fingerprint
-/// - **Not ephemeral and not rotating.** It is stable across sessions and
-///   reboots, and changes only when the underlying identity is replaced by a
-///   panic wipe. A passive observer can use it to track a device.
+/// ### Layer 1: Ephemeral Identity
+/// - Random 8-byte peer IDs that rotate periodically
+/// - Provides network-level privacy and prevents tracking
 /// - Changes don't affect cryptographic relationships
 /// - Includes handshake state tracking
 ///
@@ -37,7 +33,7 @@
 /// - Based on Noise Protocol static key pairs
 /// - Fingerprint derived from SHA256 of public key
 /// - Enables end-to-end encryption and authentication
-/// - The root of the peer ID above, and never rotated on a schedule
+/// - Persists across peer ID rotations
 ///
 /// ### Layer 3: Social Identity
 /// - User-assigned names (petnames) for contacts
@@ -48,13 +44,10 @@
 /// ## Privacy Design
 /// The model is designed with privacy-first principles:
 /// - No mandatory persistent storage
-/// - Optional identity caching with explicit consent
+/// - Optional identity caching with user consent
+/// - Ephemeral IDs prevent long-term tracking
 /// - Social mappings stored locally only
 ///
-/// It does **not** currently prevent long-term tracking by a passive radio
-/// observer: the peer ID is stable (Layer 1) and signed announcements carry the
-/// static keys and nickname in cleartext.
-///
 /// ## Trust Model
 /// Four levels of trust:
 /// 1. **Unknown**: New or unverified peers
@@ -63,17 +56,17 @@
 /// 4. **Verified**: Cryptographic verification completed
 ///
 /// ## Identity Resolution
-/// When a peer's ID changes (a panic wipe on their side, or a future rotation):
+/// When a peer rotates their ephemeral ID:
 /// 1. Cryptographic handshake reveals their fingerprint
 /// 2. System looks up social identity by fingerprint
-/// 3. UI seamlessly maintains existing relationships
+/// 3. UI seamlessly maintains user relationships
 /// 4. Historical messages remain properly attributed
 ///
 /// ## Conflict Resolution
 /// Handles edge cases like:
 /// - Multiple peers claiming same nickname
 /// - Nickname changes and conflicts
-/// - Identity replacement during active chats
+/// - Identity rotation during active chats
 /// - Network partitions and rejoins
 ///
 /// ## Usage Example
@@ -92,12 +85,8 @@ import BitFoundation
 
 // MARK: - Three-Layer Identity Model
 
-/// Represents the network layer of identity — the peer ID seen on air, plus the
-/// handshake state tracked against it.
-///
-/// Named "ephemeral" for historical reasons; the peer ID is in fact stable,
-/// being derived from the Noise static key fingerprint. It does not rotate and
-/// does not prevent tracking.
+/// Represents the ephemeral layer of identity - short-lived peer IDs that provide network privacy.
+/// These IDs rotate periodically to prevent tracking while maintaining cryptographic relationships.
 struct EphemeralIdentity {
     var handshakeState: HandshakeState
 }
@@ -110,9 +99,8 @@ enum HandshakeState {
 }
 
 /// Represents the cryptographic layer of identity - the stable Noise Protocol static key pair.
-/// This identity outlives any change to a peer's network ID and enables secure communication.
-/// The fingerprint serves as the permanent identifier for a peer's cryptographic identity, and
-/// its first 8 bytes are the peer ID broadcast on the mesh.
+/// This identity persists across ephemeral ID rotations and enables secure communication.
+/// The fingerprint serves as the permanent identifier for a peer's cryptographic identity.
 struct CryptographicIdentity: Codable {
     let fingerprint: String     // SHA256 of public key
     let publicKey: Data         // Noise static public key
@@ -173,24 +161,24 @@ struct VouchRecord: Codable, Equatable {
 struct IdentityCache: Codable {
     // Fingerprint -> Social mapping
     var socialIdentities: [String: SocialIdentity] = [:]
-
+    
     // Nickname -> [Fingerprints] reverse index
     // Multiple fingerprints can claim same nickname
     var nicknameIndex: [String: Set<String>] = [:]
-
+    
     // Verified fingerprints (cryptographic proof)
     var verifiedFingerprints: Set<String> = []
-
+    
     // Last interaction timestamps (privacy: optional)
-    var lastInteractions: [String: Date] = [:]
-
+    var lastInteractions: [String: Date] = [:] 
+    
     // Blocked Nostr pubkeys (lowercased hex) for geohash chats
     var blockedNostrPubkeys: Set<String> = []
 
     // Vouching (transitive verification). All three fields are Optional so
-    // caches persisted before this feature decode cleanly — decodeIfPresent
-    // is used below, and a missing key must not trip the "unreadable cache"
-    // recovery path that discards everything.
+    // caches persisted before this feature decode cleanly — the synthesized
+    // decoder uses decodeIfPresent for optionals, and a missing key must not
+    // trip the "unreadable cache" recovery path that discards everything.
 
     // Vouchee fingerprint -> accepted vouches (capped per vouchee)
     var vouchesByVouchee: [String: [VouchRecord]]? = nil
@@ -201,50 +189,6 @@ struct IdentityCache: Codable {
     // Fingerprint -> when we verified it (orders outgoing vouch batches;
     // entries verified before this field exists sort as oldest)
     var verifiedAt: [String: Date]? = nil
-
-    // Stable Noise fingerprints that proved encrypted private-media support
-    // inside an authenticated Noise session. Optional for decoding caches
-    // written before this migration. Entries are monotonic until a panic wipe
-    // so an old/replayed announce cannot silently downgrade a peer.
-    var privateMediaCapableFingerprints: Set<String>? = nil
-
-    // Noise-fingerprint -> Ed25519 announcement key, learned only from the
-    // authenticated peer-state payload. This prevents a self-signed announce
-    // containing a copied public Noise key from replacing a previously bound
-    // public-message signing identity. Optional for old cache compatibility.
-    var authenticatedSigningKeysByFingerprint: [String: Data]? = nil
-
-    // Fingerprint -> Cryptographic identity (noise + pinned signing key).
-    // Persisting the signing-key pin is security-critical: it must survive
-    // app restarts so an attacker cannot replay a known peer's
-    // noiseKey/peerID with their own signing key and be treated as first
-    // contact (TOFU downgrade).
-    var cryptographicIdentities: [String: CryptographicIdentity] = [:]
-
-    // Schema version for future migrations
-    var version: Int = 1
-
-    init() {}
-
-    // Custom decoding so caches written by older builds (missing newer keys
-    // such as `cryptographicIdentities` or the vouching fields) still load
-    // instead of being discarded. Every field uses decodeIfPresent so a
-    // missing key falls back to its default rather than throwing.
-    init(from decoder: Decoder) throws {
-        let container = try decoder.container(keyedBy: CodingKeys.self)
-        socialIdentities = try container.decodeIfPresent([String: SocialIdentity].self, forKey: .socialIdentities) ?? [:]
-        nicknameIndex = try container.decodeIfPresent([String: Set<String>].self, forKey: .nicknameIndex) ?? [:]
-        verifiedFingerprints = try container.decodeIfPresent(Set<String>.self, forKey: .verifiedFingerprints) ?? []
-        lastInteractions = try container.decodeIfPresent([String: Date].self, forKey: .lastInteractions) ?? [:]
-        blockedNostrPubkeys = try container.decodeIfPresent(Set<String>.self, forKey: .blockedNostrPubkeys) ?? []
-        vouchesByVouchee = try container.decodeIfPresent([String: [VouchRecord]].self, forKey: .vouchesByVouchee)
-        vouchBatchSentAt = try container.decodeIfPresent([String: Date].self, forKey: .vouchBatchSentAt)
-        verifiedAt = try container.decodeIfPresent([String: Date].self, forKey: .verifiedAt)
-        privateMediaCapableFingerprints = try container.decodeIfPresent(Set<String>.self, forKey: .privateMediaCapableFingerprints)
-        authenticatedSigningKeysByFingerprint = try container.decodeIfPresent([String: Data].self, forKey: .authenticatedSigningKeysByFingerprint)
-        cryptographicIdentities = try container.decodeIfPresent([String: CryptographicIdentity].self, forKey: .cryptographicIdentities) ?? [:]
-        version = try container.decodeIfPresent(Int.self, forKey: .version) ?? 1
-    }
 }
 
 //

bitchat/Identity/SecureIdentityStateManager.swift

@@ -140,14 +140,6 @@ protocol SecureIdentityStateManagerProtocol {
     func markVouchBatchSent(to fingerprint: String, at date: Date)
     func signingPublicKey(forFingerprint fingerprint: String) -> Data?
     func mostRecentlyVerifiedFingerprints(limit: Int, excluding fingerprint: String) -> [String]
-
-    // MARK: Noise-authenticated announcement identity
-    func bindAuthenticatedSigningPublicKey(_ signingPublicKey: Data, fingerprint: String)
-    func authenticatedSigningPublicKey(forFingerprint fingerprint: String) -> Data?
-
-    // MARK: Private-media downgrade protection
-    func markPrivateMediaCapable(fingerprint: String)
-    func hasObservedPrivateMediaCapability(fingerprint: String) -> Bool
 }
 
 /// Singleton manager for secure identity state persistence and retrieval.
@@ -160,30 +152,18 @@ final class SecureIdentityStateManager: SecureIdentityStateManagerProtocol {
     
     // In-memory state
     private var ephemeralSessions: [PeerID: EphemeralIdentity] = [:]
-    // Cryptographic identities (including pinned signing keys) live inside
-    // `cache` so they persist across app restarts; see IdentityCache.
+    private var cryptographicIdentities: [String: CryptographicIdentity] = [:]
     private var cache: IdentityCache = IdentityCache()
     
     // Thread safety
     private let queue = DispatchQueue(label: "bitchat.identity.state", attributes: .concurrent)
-    private let queueSpecificKey = DispatchSpecificKey<UInt8>()
     
     // Pending-save coalescing flag. Reads/writes are serialized on `queue`.
-    //
-    // Persistence is SYNCHRONOUS: every mutating API runs its mutate + encrypt
-    // + keychain write inside `queue.sync(flags: .barrier)`, so when the call
-    // returns the write is already complete and NOTHING is left scheduled on
-    // the queue. This is deliberate — a retained DispatchSourceTimer (the
-    // original design) kept the dispatch machinery alive and prevented the
-    // unit-test process from exiting, and fire-and-forget `queue.async(.barrier)`
-    // (a later design) left a backlog of instrumented barrier saves still
-    // draining when LLVM's `--enable-code-coverage` `atexit` handler dumped
-    // `.profraw`, deadlocking the process at teardown on the constrained CI
-    // runner. Synchronous persistence has zero outstanding dispatch at exit, so
-    // neither failure mode is possible. `pendingSave` is now effectively always
-    // false after any mutation (saveIdentityCache persists inline and clears
-    // it); it remains only as a belt-and-suspenders flag read by `forceSave`
-    // and `deinit`.
+    // Persistence is done with a fire-and-forget `queue.async(.barrier)` rather
+    // than a retained DispatchSourceTimer: a lingering, never-cancelled timer
+    // keeps the dispatch machinery alive and prevents the unit-test process from
+    // exiting. (The original code used Timer.scheduledTimer on a GCD queue with
+    // no run loop, so saves never actually fired.)
     private var pendingSave = false
 
     // Encryption key
@@ -234,7 +214,6 @@ final class SecureIdentityStateManager: SecureIdentityStateManagerProtocol {
 
         self.encryptionKey = loadedKey
         self.encryptionKeyIsEphemeral = keyIsEphemeral
-        queue.setSpecific(key: queueSpecificKey, value: 1)
 
         // Only read the persisted cache when we hold the real key; with an
         // ephemeral key the decrypt would fail and discard the real cache.
@@ -244,22 +223,7 @@ final class SecureIdentityStateManager: SecureIdentityStateManagerProtocol {
     }
     
     deinit {
-        // Do NOT dispatch onto `queue` here. `deinit` can run on any thread
-        // (including one draining `queue`), and the object is being
-        // deallocated: a `queue.sync` risks a re-entrant same-queue wait
-        // (deadlock) and a `queue.async` schedules work that resurrects `self`
-        // and may not drain before process exit.
-        //
-        // A flush here is redundant anyway: every mutating API already
-        // persists inline within its own barrier, so the keychain is already
-        // up to date. As a queue-free best-effort belt-and-suspenders, only
-        // flush if something is still pending. This is a direct read of
-        // in-hand state — safe because a deallocating object has no other
-        // live references, so nothing can be mutating `cache` concurrently.
-        if pendingSave {
-            pendingSave = false
-            persist(snapshot: cache)
-        }
+        forceSave()
     }
     
     // MARK: - Secure Loading/Saving
@@ -284,27 +248,21 @@ final class SecureIdentityStateManager: SecureIdentityStateManagerProtocol {
         }
     }
     
-    /// Persists the cache. Always invoked on `queue` under a barrier (its
-    /// callers run inside `queue.sync(flags: .barrier)`), so `cache` is read
-    /// while serialized. The encode + keychain write are done here (already on
-    /// the exclusive barrier context), synchronously, so no separate hop is
-    /// scheduled and nothing is left to keep the process alive.
+    /// Persists the cache. Always invoked on `queue` under a barrier (its callers
+    /// run inside `queue.async(.barrier)`), so it simply marks the cache dirty
+    /// and persists it on the same serialized context — no timer, nothing left
+    /// scheduled to keep the process alive.
     private func saveIdentityCache() {
         pendingSave = true
-        // On the barrier context already: snapshot is trivially consistent.
-        persist(snapshot: cache)
-        pendingSave = false
+        performSave()
     }
 
-    /// Encodes, seals, and writes a *snapshot* of the cache to the keychain.
-    ///
-    /// Takes the cache by value so callers can capture a consistent snapshot
-    /// under `queue` and then encode without holding it. Reading `cache`
-    /// concurrently with a barrier writer would be a data race on the
-    /// dictionary storage, which — because `JSONEncoder` walks that storage —
-    /// can spin forever (observed as a CI test-suite hang), so the snapshot
-    /// must be taken on `queue`, never off it.
-    private func persist(snapshot: IdentityCache) {
+    /// Writes the cache to the keychain. Must run on `queue` with exclusive
+    /// (barrier) access.
+    private func performSave() {
+        guard pendingSave else { return }
+        pendingSave = false
+
         // Never persist under an ephemeral key — it would overwrite the real
         // cache with data the next launch cannot decrypt.
         guard !encryptionKeyIsEphemeral else {
@@ -313,7 +271,7 @@ final class SecureIdentityStateManager: SecureIdentityStateManagerProtocol {
         }
 
         do {
-            let data = try JSONEncoder().encode(snapshot)
+            let data = try JSONEncoder().encode(cache)
             let sealedBox = try AES.GCM.seal(data, using: encryptionKey)
             let saved = keychain.saveIdentityKey(sealedBox.combined!, forKey: cacheKey)
             if saved {
@@ -324,26 +282,14 @@ final class SecureIdentityStateManager: SecureIdentityStateManagerProtocol {
         }
     }
 
-    // Force a flush (for app-termination / lifecycle events — NOT from
-    // `deinit`, which persists inline; see the deinit note). Every mutating
-    // API already persists inline inside its own barrier via
-    // `saveIdentityCache`, so by the time this is called the keychain is
-    // already up to date and this is normally a no-op; it exists as a
-    // belt-and-suspenders flush of any `pendingSave` left set.
-    //
-    // Runs synchronously inside a `queue.sync(flags: .barrier)`: the barrier
-    // makes the `cache` read race-free (a plain off-queue read races in-flight
-    // barrier writers — JSONEncoder walking a concurrently-mutated dictionary
-    // can spin forever, which surfaced as a CI hang), and being synchronous it
-    // leaves nothing scheduled to keep the process alive at teardown. Safe
-    // against re-entrant deadlock because this is never invoked from `deinit`
-    // (the only path that can run *on* `queue`).
+    // Force immediate save (for app termination / lifecycle events). Mutations
+    // already persist synchronously via saveIdentityCache, so this is normally a
+    // no-op (performSave early-returns when nothing is pending). Runs directly on
+    // the caller's thread — deliberately NOT a `queue.sync(barrier)`, which is
+    // reachable from `deinit` and from async tests on the swift-concurrency
+    // cooperative pool where a blocking barrier-sync can starve/deadlock it.
     func forceSave() {
-        queue.sync(flags: .barrier) {
-            guard pendingSave else { return }
-            pendingSave = false
-            persist(snapshot: cache)
-        }
+        performSave()
     }
     
     // MARK: - Social Identity Management
@@ -357,33 +303,15 @@ final class SecureIdentityStateManager: SecureIdentityStateManagerProtocol {
     // MARK: - Cryptographic Identities
 
     /// Insert or update a cryptographic identity and optionally persist its signing key and claimed nickname.
-    ///
-    /// TOFU signing-key pinning: once a signing key has been persisted for a
-    /// fingerprint, an update carrying a *different* signing key is refused in
-    /// full (including the claimed-nickname update) and security-logged. This
-    /// mirrors `BLEPeerRegistry.upsertVerifiedAnnounce` — without it, an
-    /// attacker replaying a victim's noiseKey/peerID with their own signing
-    /// key could overwrite the victim's persisted identity while the victim is
-    /// offline or after an app restart. The refusal is permanent: there is
-    /// currently no targeted in-app way to reset the pin (`setVerified` does
-    /// not touch it). Recovering from a legitimate signing re-key requires the
-    /// peer to establish a new noise identity (new peerID) or the local user
-    /// to wipe all identity data (`clearAllIdentityData`, e.g. panic wipe).
     /// - Parameters:
     ///   - fingerprint: SHA-256 hex of the Noise static public key
     ///   - noisePublicKey: Noise static public key data
     ///   - signingPublicKey: Optional Ed25519 signing public key for authenticating public messages
     ///   - claimedNickname: Optional latest claimed nickname to persist into social identity
     func upsertCryptographicIdentity(fingerprint: String, noisePublicKey: Data, signingPublicKey: Data?, claimedNickname: String? = nil) {
-        queue.sync(flags: .barrier) {
+        queue.async(flags: .barrier) {
             let now = Date()
-            if var existing = self.cache.cryptographicIdentities[fingerprint] {
-                if let pinnedSigningKey = existing.signingPublicKey,
-                   let announcedSigningKey = signingPublicKey,
-                   pinnedSigningKey != announcedSigningKey {
-                    SecureLogger.warning("🚨 Refusing to replace pinned signing key for \(fingerprint.prefix(8))… (possible impersonation attempt)", category: .security)
-                    return
-                }
+            if var existing = self.cryptographicIdentities[fingerprint] {
                 // Update keys if changed
                 if existing.publicKey != noisePublicKey {
                     existing = CryptographicIdentity(
@@ -392,11 +320,11 @@ final class SecureIdentityStateManager: SecureIdentityStateManagerProtocol {
                         signingPublicKey: signingPublicKey ?? existing.signingPublicKey,
                         firstSeen: existing.firstSeen
                     )
-                    self.cache.cryptographicIdentities[fingerprint] = existing
+                    self.cryptographicIdentities[fingerprint] = existing
                 } else {
                     // Update signing key
                     existing.signingPublicKey = signingPublicKey ?? existing.signingPublicKey
-                    self.cache.cryptographicIdentities[fingerprint] = existing
+                    self.cryptographicIdentities[fingerprint] = existing
                 }
                 // Persist updated state (already assigned in branches above)
             } else {
@@ -407,7 +335,7 @@ final class SecureIdentityStateManager: SecureIdentityStateManagerProtocol {
                     signingPublicKey: signingPublicKey,
                     firstSeen: now
                 )
-                self.cache.cryptographicIdentities[fingerprint] = entry
+                self.cryptographicIdentities[fingerprint] = entry
             }
 
             // Optionally persist claimed nickname into social identity
@@ -439,72 +367,12 @@ final class SecureIdentityStateManager: SecureIdentityStateManagerProtocol {
         queue.sync {
             // Defensive: ensure hex and correct length
             guard peerID.isShort else { return [] }
-            return cache.cryptographicIdentities.values.filter { $0.fingerprint.hasPrefix(peerID.id) }
-        }
-    }
-
-    // MARK: - Private-media downgrade protection
-
-    func markPrivateMediaCapable(fingerprint: String) {
-        guard !fingerprint.isEmpty else { return }
-        let insertAndPersist = {
-            var pinned = self.cache.privateMediaCapableFingerprints ?? []
-            guard pinned.insert(fingerprint).inserted else { return }
-            self.cache.privateMediaCapableFingerprints = pinned
-            self.saveIdentityCache()
-        }
-        // Downgrade decisions can run immediately after an authenticated
-        // announce. Make the pin visible before returning; merely enqueueing a
-        // barrier leaves a cross-queue window where a replay can look legacy.
-        // The queue-specific fast path prevents self-deadlock if a future
-        // identity-state mutation records the capability from inside `queue`.
-        if DispatchQueue.getSpecific(key: queueSpecificKey) != nil {
-            insertAndPersist()
-        } else {
-            queue.sync(flags: .barrier, execute: insertAndPersist)
-        }
-    }
-
-    func hasObservedPrivateMediaCapability(fingerprint: String) -> Bool {
-        guard !fingerprint.isEmpty else { return false }
-        return queue.sync {
-            cache.privateMediaCapableFingerprints?.contains(fingerprint) == true
-        }
-    }
-
-    // MARK: - Noise-authenticated announcement identity
-
-    func bindAuthenticatedSigningPublicKey(_ signingPublicKey: Data, fingerprint: String) {
-        guard signingPublicKey.count == AuthenticatedPeerStatePacket.signingPublicKeyLength,
-              !fingerprint.isEmpty else { return }
-        let bindAndPersist = {
-            var bindings = self.cache.authenticatedSigningKeysByFingerprint ?? [:]
-            let bindingChanged = bindings[fingerprint] != signingPublicKey
-            bindings[fingerprint] = signingPublicKey
-            self.cache.authenticatedSigningKeysByFingerprint = bindings
-            if var cryptoIdentity = self.cache.cryptographicIdentities[fingerprint] {
-                cryptoIdentity.signingPublicKey = signingPublicKey
-                self.cache.cryptographicIdentities[fingerprint] = cryptoIdentity
-            }
-            guard bindingChanged else { return }
-            self.saveIdentityCache()
-        }
-        if DispatchQueue.getSpecific(key: queueSpecificKey) != nil {
-            bindAndPersist()
-        } else {
-            queue.sync(flags: .barrier, execute: bindAndPersist)
-        }
-    }
-
-    func authenticatedSigningPublicKey(forFingerprint fingerprint: String) -> Data? {
-        guard !fingerprint.isEmpty else { return nil }
-        return queue.sync {
-            cache.authenticatedSigningKeysByFingerprint?[fingerprint]
+            return cryptographicIdentities.values.filter { $0.fingerprint.hasPrefix(peerID.id) }
         }
     }
     
     func updateSocialIdentity(_ identity: SocialIdentity) {
-        queue.sync(flags: .barrier) {
+        queue.async(flags: .barrier) {
             let previousClaimedNickname = self.cache.socialIdentities[identity.fingerprint]?.claimedNickname
             self.cache.socialIdentities[identity.fingerprint] = identity
             
@@ -540,7 +408,7 @@ final class SecureIdentityStateManager: SecureIdentityStateManagerProtocol {
     }
     
     func setFavorite(_ fingerprint: String, isFavorite: Bool) {
-        queue.sync(flags: .barrier) {
+        queue.async(flags: .barrier) {
             if var identity = self.cache.socialIdentities[fingerprint] {
                 identity.isFavorite = isFavorite
                 self.cache.socialIdentities[fingerprint] = identity
@@ -578,7 +446,7 @@ final class SecureIdentityStateManager: SecureIdentityStateManagerProtocol {
     func setBlocked(_ fingerprint: String, isBlocked: Bool) {
         SecureLogger.info("User \(isBlocked ? "blocked" : "unblocked"): \(fingerprint)", category: .security)
         
-        queue.sync(flags: .barrier) {
+        queue.async(flags: .barrier) {
             if var identity = self.cache.socialIdentities[fingerprint] {
                 identity.isBlocked = isBlocked
                 if isBlocked {
@@ -612,7 +480,7 @@ final class SecureIdentityStateManager: SecureIdentityStateManagerProtocol {
     
     func setNostrBlocked(_ pubkeyHexLowercased: String, isBlocked: Bool) {
         let key = pubkeyHexLowercased.lowercased()
-        queue.sync(flags: .barrier) {
+        queue.async(flags: .barrier) {
             if isBlocked {
                 self.cache.blockedNostrPubkeys.insert(key)
             } else {
@@ -635,7 +503,7 @@ final class SecureIdentityStateManager: SecureIdentityStateManagerProtocol {
     }
     
     func updateHandshakeState(peerID: PeerID, state: HandshakeState) {
-        queue.sync(flags: .barrier) {
+        queue.async(flags: .barrier) {
             self.ephemeralSessions[peerID]?.handshakeState = state
             
             // If handshake completed, update last interaction
@@ -651,10 +519,11 @@ final class SecureIdentityStateManager: SecureIdentityStateManagerProtocol {
     func clearAllIdentityData() {
         SecureLogger.warning("Clearing all identity data", category: .security)
         
-        queue.sync(flags: .barrier) {
+        queue.async(flags: .barrier) {
             self.cache = IdentityCache()
             self.ephemeralSessions.removeAll()
-
+            self.cryptographicIdentities.removeAll()
+            
             // Delete from keychain
             let deleted = self.keychain.deleteIdentityKey(forKey: self.cacheKey)
             SecureLogger.logKeyOperation(.delete, keyType: "identity cache", success: deleted)
@@ -662,8 +531,8 @@ final class SecureIdentityStateManager: SecureIdentityStateManagerProtocol {
     }
     
     func removeEphemeralSession(peerID: PeerID) {
-        queue.sync(flags: .barrier) {
-            _ = self.ephemeralSessions.removeValue(forKey: peerID)
+        queue.async(flags: .barrier) {
+            self.ephemeralSessions.removeValue(forKey: peerID)
         }
     }
     
@@ -672,7 +541,7 @@ final class SecureIdentityStateManager: SecureIdentityStateManagerProtocol {
     func setVerified(fingerprint: String, verified: Bool) {
         SecureLogger.info("Fingerprint \(verified ? "verified" : "unverified"): \(fingerprint)", category: .security)
         
-        queue.sync(flags: .barrier) {
+        queue.async(flags: .barrier) {
             if verified {
                 self.cache.verifiedFingerprints.insert(fingerprint)
                 var verifiedAt = self.cache.verifiedAt ?? [:]
@@ -840,7 +709,7 @@ final class SecureIdentityStateManager: SecureIdentityStateManagerProtocol {
 
     /// The peer's announce-bound Ed25519 signing key, if seen this session.
     func signingPublicKey(forFingerprint fingerprint: String) -> Data? {
-        queue.sync { cache.cryptographicIdentities[fingerprint]?.signingPublicKey }
+        queue.sync { cryptographicIdentities[fingerprint]?.signingPublicKey }
     }
 
     /// Verified fingerprints ordered most recently verified first (entries

bitchat/Info.plist

@@ -31,8 +31,6 @@
 	</array>
 	<key>CFBundleVersion</key>
 	<string>$(CURRENT_PROJECT_VERSION)</string>
-	<key>LSApplicationCategoryType</key>
-	<string>public.app-category.social-networking</string>
 	<key>LSMinimumSystemVersion</key>
 	<string>$(MACOSX_DEPLOYMENT_TARGET)</string>
 	<key>NSBluetoothAlwaysUsageDescription</key>
@@ -42,9 +40,9 @@
 	<key>NSCameraUsageDescription</key>
 	<string>bitchat uses the camera to scan QR codes to verify peers.</string>
 	<key>NSLocationWhenInUseUsageDescription</key>
-	<string>bitchat uses your location to compute optional geohash channels, bridge cells, and nearby place labels. Exact coordinates are not included in bitchat messages.</string>
+	<string>bitchat uses your approximate location to compute local geohash channels for optional public chats. Exact GPS is never shared.</string>
 	<key>NSMicrophoneUsageDescription</key>
-	<string>bitchat uses the microphone while you record voice notes or hold live push-to-talk, then sends that audio to your selected mesh conversation.</string>
+	<string>bitchat uses the microphone to record voice notes that relay across the mesh.</string>
 	<key>NSPhotoLibraryUsageDescription</key>
 	<string>bitchat lets you pick images from your photo library to share with nearby peers.</string>
 	<key>UIBackgroundModes</key>

bitchat/Models/BitchatMessage+Media.swift

@@ -24,7 +24,7 @@ extension BitchatMessage {
             do {
                 let base = try FileManager.default.url(for: .applicationSupportDirectory, in: .userDomainMask, appropriateFor: nil, create: true)
                 let filesDir = base.appendingPathComponent("files", isDirectory: true)
-                try FileManager.default.createDirectory(at: filesDir, withIntermediateDirectories: true, attributes: BLEIncomingFileStore.mediaProtectionAttributes)
+                try FileManager.default.createDirectory(at: filesDir, withIntermediateDirectories: true, attributes: nil)
                 self.filesDir = filesDir
             } catch {
                 filesDir = nil

bitchat/Models/BitchatPeer.swift

@@ -15,10 +15,6 @@ struct BitchatPeer: Equatable {
     
     // Nostr identity (if known)
     var nostrPublicKey: String?
-
-    /// Device-local alias (petname). Never sent over the wire; when set it
-    /// outranks the peer-claimed `nickname` for display only.
-    var localPetname: String?
     
     // Connection state
     enum ConnectionState {
@@ -33,22 +29,13 @@ struct BitchatPeer: Equatable {
             return .bluetoothConnected
         } else if isReachable {
             return .meshReachable
-        } else if favoriteStatus?.isMutual == true, reachableNostrPublicKey != nil {
-            // Mutual favorites can communicate via Nostr when offline — but
-            // only with a stored recipient key. NostrTransport applies the
-            // same rule when computing reachable peers; without a key,
-            // "available" would be a lie, and the DM header's
-            // "end-to-end encrypted" caption keys off this state.
+        } else if favoriteStatus?.isMutual == true {
+            // Mutual favorites can communicate via Nostr when offline
             return .nostrAvailable
         } else {
             return .offline
         }
     }
-
-    /// The Nostr key a private envelope would actually be sealed to, if any.
-    var reachableNostrPublicKey: String? {
-        nostrPublicKey ?? favoriteStatus?.peerNostrPublicKey
-    }
     
     var isFavorite: Bool {
         favoriteStatus?.isFavorite ?? false
@@ -64,10 +51,7 @@ struct BitchatPeer: Equatable {
     
     // Display helpers
     var displayName: String {
-        if let localPetname, !localPetname.isEmpty {
-            return localPetname
-        }
-        return nickname.isEmpty ? String(peerID.id.prefix(8)) : nickname
+        nickname.isEmpty ? String(peerID.id.prefix(8)) : nickname
     }
     
     var statusIcon: String {
@@ -94,15 +78,13 @@ struct BitchatPeer: Equatable {
         nickname: String,
         lastSeen _: Date = Date(),
         isConnected: Bool = false,
-        isReachable: Bool = false,
-        localPetname: String? = nil
+        isReachable: Bool = false
     ) {
         self.peerID = peerID
         self.noisePublicKey = noisePublicKey
         self.nickname = nickname
         self.isConnected = isConnected
         self.isReachable = isReachable
-        self.localPetname = localPetname
         
         // Load favorite status - will be set later by the manager
         self.favoriteStatus = nil

bitchat/Models/NoisePayload.swift

@@ -30,7 +30,7 @@ struct NoisePayload {
         
         // Safely get the first byte
         let firstByte = data[data.startIndex]
-        guard let type = NoisePayloadType.decoded(rawValue: firstByte) else {
+        guard let type = NoisePayloadType(rawValue: firstByte) else {
             return nil
         }
         

bitchat/Noise/NoiseSecurityConstants.swift

@@ -6,60 +6,14 @@
 // For more information, see <https://unlicense.org>
 //
 
-import BitFoundation
 import Foundation
 
 enum NoiseSecurityConstants {
     // Maximum message size to prevent memory exhaustion
     static let maxMessageSize = 65535 // 64KB as per Noise spec
-
-    /// The extracted transport nonce (4 bytes) and Poly1305 tag (16 bytes)
-    /// added by `NoiseCipherState` around every transport plaintext.
-    static let transportCiphertextOverhead = 20
-
-    /// Private files are an explicit BitChat extension to the ordinary Noise
-    /// message-size ceiling. They remain bounded by the same framed-file cap
-    /// used by the binary and fragment decoders. Only the `.privateFile`
-    /// typed-payload path is allowed to use this larger budget.
-    private static let privateFileOuterPacketOverhead =
-        (BinaryProtocol.v1HeaderSize + 2) // v2 adds two length bytes
-        + BinaryProtocol.senderIDSize
-        + BinaryProtocol.recipientIDSize
-    static let maxPrivateFilePlaintextSize = FileTransferLimits.maxFramedFileBytes
-        - privateFileOuterPacketOverhead
-        - transportCiphertextOverhead
-    static let maxPrivateFileCiphertextSize =
-        maxPrivateFilePlaintextSize + transportCiphertextOverhead
     
     // Maximum handshake message size
     static let maxHandshakeMessageSize = 2048 // 2KB to accommodate XX pattern
-
-    // Noise XX message 1 contains only the initiator's 32-byte ephemeral key.
-    static let xxInitialMessageSize = 32
-
-    // Bounds an ordinary initiator whose message 1 or 2 is lost.
-    static let ordinaryHandshakeTimeout: TimeInterval = 10
-
-    // Bounds the receive-only rollback quarantine created by an unauthenticated
-    // inbound message 1. A lost message 3 must not strand outbound traffic.
-    static let ordinaryResponderHandshakeTimeout: TimeInterval = 20
-
-    // A released client may immediately retry after both crossed initiators
-    // yielded. Give that unilateral retry a brief head start before the
-    // patched side spends its one bounded recovery.
-    static let handshakeCollisionRecoveryDelay: TimeInterval = 0.2
-
-    // Rate-limited recovery remains actionable without spinning.
-    static let handshakeRateLimitRecoveryDelay: TimeInterval = 60
-
-    // Covers only reordering between a winning message 3 and the losing
-    // crossed message 1.
-    static let recentInitiatorCompletionGracePeriod: TimeInterval = 1
-
-    // After unauthenticated responder rollback, reject another attempt long
-    // enough that paced message 1 traffic cannot keep outbound paused. A
-    // legitimate peer converges through the one manager-owned local retry.
-    static let ordinaryReconnectRollbackCooldown: TimeInterval = 60
     
     // Session timeout - sessions older than this should be renegotiated
     static let sessionTimeout: TimeInterval = 86400 // 24 hours

bitchat/Noise/NoiseSecurityValidator.swift

@@ -14,19 +14,6 @@ struct NoiseSecurityValidator {
     static func validateMessageSize(_ data: Data) -> Bool {
         return data.count <= NoiseSecurityConstants.maxMessageSize
     }
-
-    static func validateCiphertextSize(_ data: Data) -> Bool {
-        data.count <= NoiseSecurityConstants.maxMessageSize
-            + NoiseSecurityConstants.transportCiphertextOverhead
-    }
-
-    static func validatePrivateFileMessageSize(_ data: Data) -> Bool {
-        data.count <= NoiseSecurityConstants.maxPrivateFilePlaintextSize
-    }
-
-    static func validatePrivateFileCiphertextSize(_ data: Data) -> Bool {
-        data.count <= NoiseSecurityConstants.maxPrivateFileCiphertextSize
-    }
     
     /// Validate handshake message size
     static func validateHandshakeMessageSize(_ data: Data) -> Bool {

bitchat/Noise/NoiseSession.swift

@@ -66,10 +66,7 @@ class NoiseSession {
             
             // Only initiator writes the first message
             if role == .initiator {
-                guard let handshake = handshakeState else {
-                    throw NoiseSessionError.invalidState
-                }
-                let message = try handshake.writeMessage()
+                let message = try handshakeState!.writeMessage()
                 sentHandshakeMessages.append(message)
                 return message
             } else {

bitchat/Noise/NoiseSessionError.swift

@@ -11,11 +11,4 @@ enum NoiseSessionError: Error, Equatable {
     case notEstablished
     case sessionNotFound
     case alreadyEstablished
-    case peerIdentityMismatch
-}
-
-/// The manager owns the exact attempt's one bounded recovery. Packet handling
-/// must not launch its historical second, immediate restart for this failure.
-struct NoiseManagedHandshakeFailure: Error {
-    let underlying: Error
 }

bitchat/Noise/SecureNoiseSession.swift

@@ -24,12 +24,8 @@ final class SecureNoiseSession: NoiseSession {
             throw NoiseSecurityError.sessionExhausted
         }
         
-        // Ordinary Noise messages keep the protocol ceiling. Finalized media
-        // is the sole typed-payload extension and remains under the framed-file
-        // cap enforced again at the service and file-decoder layers.
-        let isPrivateFile = NoisePayloadType.isPrivateFile(rawValue: plaintext.first)
-            && NoiseSecurityValidator.validatePrivateFileMessageSize(plaintext)
-        guard NoiseSecurityValidator.validateMessageSize(plaintext) || isPrivateFile else {
+        // Validate message size
+        guard NoiseSecurityValidator.validateMessageSize(plaintext) else {
             throw NoiseSecurityError.messageTooLarge
         }
         
@@ -46,11 +42,8 @@ final class SecureNoiseSession: NoiseSession {
             throw NoiseSecurityError.sessionExpired
         }
         
-        // The payload type is encrypted, so a large candidate can only be
-        // bounded here; `NoiseEncryptionService.decrypt` authenticates it and
-        // then requires the resulting type to be `.privateFile`.
-        guard NoiseSecurityValidator.validateCiphertextSize(ciphertext)
-                || NoiseSecurityValidator.validatePrivateFileCiphertextSize(ciphertext) else {
+        // Validate message size
+        guard NoiseSecurityValidator.validateMessageSize(ciphertext) else {
             throw NoiseSecurityError.messageTooLarge
         }
         

bitchat/Nostr/GeoRelayDirectory.swift

@@ -32,23 +32,6 @@ struct GeoRelayDirectoryDependencies {
     var retrySleep: (TimeInterval) async -> Void
     var activeNotificationName: Notification.Name?
     var autoStart: Bool
-    var validationPolicy: GeoRelayDirectoryValidationPolicy
-}
-
-struct GeoRelayDirectoryValidationPolicy: Sendable {
-    let maximumBytes: Int
-    let maximumRows: Int
-    let maximumEntries: Int
-    let minimumRemoteEntries: Int
-    let minimumRetainedFraction: Double
-
-    static let live = GeoRelayDirectoryValidationPolicy(
-        maximumBytes: 512 * 1024,
-        maximumRows: 5_000,
-        maximumEntries: 5_000,
-        minimumRemoteEntries: 50,
-        minimumRetainedFraction: 0.5
-    )
 }
 
 private extension GeoRelayDirectoryDependencies {
@@ -61,57 +44,21 @@ private extension GeoRelayDirectoryDependencies {
 #else
         let activeNotificationName: Notification.Name? = nil
 #endif
-        let validationPolicy = GeoRelayDirectoryValidationPolicy.live
 
         return Self(
             userDefaults: .standard,
             notificationCenter: .default,
             now: Date.init,
-            // Runtime refreshes only from bitchat's reviewed copy. Upstream
-            // georelays/main is imported by a validator-backed pull request,
-            // so an upstream mutation cannot immediately retarget clients.
-            remoteURL: URL(string: "https://raw.githubusercontent.com/permissionlesstech/bitchat/refs/heads/main/relays/online_relays_gps.csv")!,
+            remoteURL: URL(string: "https://raw.githubusercontent.com/permissionlesstech/georelays/refs/heads/main/nostr_relays.csv")!,
             fetchInterval: TransportConfig.geoRelayFetchIntervalSeconds,
             refreshCheckInterval: TransportConfig.geoRelayRefreshCheckIntervalSeconds,
             retryInitialSeconds: TransportConfig.geoRelayRetryInitialSeconds,
             retryMaxSeconds: TransportConfig.geoRelayRetryMaxSeconds,
-            // Only wait for Tor when Tor is switched on. With it off, the fetch
-            // is meant to go direct through the same unproxied session the relay
-            // sockets already use — and `TorManager` has been shut down, so
-            // awaiting readiness would spend the whole bootstrap timeout on
-            // every refresh and freeze the directory on its cached copy.
-            //
-            // Deliberately keyed on the preference rather than live readiness:
-            // if Tor is wanted but not ready, this must keep returning false so
-            // the fetch is skipped instead of silently leaking the IP.
-            awaitTorReady: {
-                guard NetworkActivationService.persistedTorPreference() else { return true }
-                return await TorManager.shared.awaitReady()
-            },
+            awaitTorReady: { await TorManager.shared.awaitReady() },
             makeFetchData: {
                 let session = TorURLSession.shared.session
                 return { request in
-                    let (bytes, response) = try await session.bytes(for: request)
-                    guard let response = response as? HTTPURLResponse,
-                          (200...299).contains(response.statusCode),
-                          response.url == request.url else {
-                        throw URLError(.badServerResponse)
-                    }
-
-                    let maximumBytes = validationPolicy.maximumBytes
-                    guard response.expectedContentLength <= Int64(maximumBytes) else {
-                        throw URLError(.dataLengthExceedsMaximum)
-                    }
-                    var data = Data()
-                    if response.expectedContentLength > 0 {
-                        data.reserveCapacity(Int(response.expectedContentLength))
-                    }
-                    for try await byte in bytes {
-                        guard data.count < maximumBytes else {
-                            throw URLError(.dataLengthExceedsMaximum)
-                        }
-                        data.append(byte)
-                    }
+                    let (data, _) = try await session.data(for: request)
                     return data
                 }
             },
@@ -129,11 +76,7 @@ private extension GeoRelayDirectoryDependencies {
                     )
                     let dir = base.appendingPathComponent("bitchat", isDirectory: true)
                     try? FileManager.default.createDirectory(at: dir, withIntermediateDirectories: true)
-                    // v2 ignores caches populated from the old direct-upstream
-                    // trust path and subjects every load to strict validation.
-                    let legacyCache = dir.appendingPathComponent("georelays_cache.csv")
-                    try? FileManager.default.removeItem(at: legacyCache)
-                    return dir.appendingPathComponent("georelays_cache_v2.csv")
+                    return dir.appendingPathComponent("georelays_cache.csv")
                 } catch {
                     return nil
                 }
@@ -151,8 +94,7 @@ private extension GeoRelayDirectoryDependencies {
                 try? await Task.sleep(nanoseconds: nanoseconds)
             },
             activeNotificationName: activeNotificationName,
-            autoStart: true,
-            validationPolicy: validationPolicy
+            autoStart: true
         )
     }
 }
@@ -183,7 +125,7 @@ final class GeoRelayDirectory {
     }
 
     private enum DetachedFetchOutcome: Sendable {
-        case success(entries: [Entry], csv: Data)
+        case success(entries: [Entry], csv: String)
         case torNotReady
         case invalidData
         case network(String)
@@ -270,8 +212,6 @@ final class GeoRelayDirectory {
         )
         let awaitTorReady = dependencies.awaitTorReady
         let fetchData = dependencies.makeFetchData()
-        let validationPolicy = dependencies.validationPolicy
-        let baselineEntries = Set(entries)
 
         Task { [weak self] in
             guard let self else { return }
@@ -279,9 +219,7 @@ final class GeoRelayDirectory {
             let outcome = await Self.fetchRemoteOutcome(
                 request: request,
                 awaitTorReady: awaitTorReady,
-                fetchData: fetchData,
-                validationPolicy: validationPolicy,
-                baselineEntries: baselineEntries
+                fetchData: fetchData
             )
 
             switch outcome {
@@ -300,9 +238,7 @@ final class GeoRelayDirectory {
     nonisolated private static func fetchRemoteOutcome(
         request: URLRequest,
         awaitTorReady: @escaping @Sendable () async -> Bool,
-        fetchData: @escaping @Sendable (URLRequest) async throws -> Data,
-        validationPolicy: GeoRelayDirectoryValidationPolicy,
-        baselineEntries: Set<Entry>
+        fetchData: @escaping @Sendable (URLRequest) async throws -> Data
     ) async -> DetachedFetchOutcome {
         await Task.detached(priority: .utility) {
             let ready = await awaitTorReady()
@@ -310,16 +246,16 @@ final class GeoRelayDirectory {
 
             do {
                 let data = try await fetchData(request)
-                guard let parsed = Self.validatedEntries(
-                    from: data,
-                    policy: validationPolicy,
-                    minimumEntries: validationPolicy.minimumRemoteEntries,
-                    baselineEntries: baselineEntries
-                ) else {
+                guard let text = String(data: data, encoding: .utf8) else {
                     return .invalidData
                 }
 
-                return .success(entries: parsed, csv: data)
+                let parsed = Self.parseCSV(text)
+                guard !parsed.isEmpty else {
+                    return .invalidData
+                }
+
+                return .success(entries: parsed, csv: text)
             } catch {
                 return .network(error.localizedDescription)
             }
@@ -333,7 +269,7 @@ final class GeoRelayDirectory {
     }
 
     @MainActor
-    private func handleFetchSuccess(entries parsed: [Entry], csv: Data) {
+    private func handleFetchSuccess(entries parsed: [Entry], csv: String) {
         entries = parsed
         persistCache(csv)
         dependencies.userDefaults.set(dependencies.now(), forKey: lastFetchKey)
@@ -385,8 +321,9 @@ final class GeoRelayDirectory {
         cleanupState.retryTask = nil
     }
 
-    private func persistCache(_ data: Data) {
+    private func persistCache(_ text: String) {
         guard let url = dependencies.cacheURL() else { return }
+        guard let data = text.data(using: .utf8) else { return }
         do {
             try dependencies.writeData(data, url)
         } catch {
@@ -399,12 +336,9 @@ final class GeoRelayDirectory {
         // Prefer cached file if present
         if let cache = dependencies.cacheURL(),
            let data = dependencies.readData(cache),
-           let entries = Self.validatedEntries(
-               from: data,
-               policy: dependencies.validationPolicy,
-               minimumEntries: 1
-           ) {
-            return entries
+           let text = String(data: data, encoding: .utf8) {
+            let arr = Self.parseCSV(text)
+            if !arr.isEmpty { return arr }
         }
 
         // Try bundled resource(s)
@@ -412,157 +346,36 @@ final class GeoRelayDirectory {
 
         for url in bundleCandidates {
             if let data = dependencies.readData(url),
-               let entries = Self.validatedEntries(
-                   from: data,
-                   policy: dependencies.validationPolicy,
-                   minimumEntries: 1
-               ) {
-                return entries
+               let text = String(data: data, encoding: .utf8) {
+                let arr = Self.parseCSV(text)
+                if !arr.isEmpty { return arr }
             }
         }
 
         // Try filesystem path (development/test)
         if let cwd = dependencies.currentDirectoryPath(),
            let data = dependencies.readData(URL(fileURLWithPath: cwd).appendingPathComponent("relays/online_relays_gps.csv")),
-           let entries = Self.validatedEntries(
-               from: data,
-               policy: dependencies.validationPolicy,
-               minimumEntries: 1
-           ) {
-            return entries
+           let text = String(data: data, encoding: .utf8) {
+            return Self.parseCSV(text)
         }
 
         SecureLogger.warning("GeoRelayDirectory: no local CSV found; entries empty", category: .session)
         return []
     }
 
-    /// Parses the fixed three-column format as an all-or-nothing trust unit.
-    /// One malformed or conflicting row rejects the complete dataset rather
-    /// than silently shrinking or partially replacing the current directory.
-    nonisolated static func validatedEntries(
-        from data: Data,
-        policy: GeoRelayDirectoryValidationPolicy,
-        minimumEntries: Int,
-        baselineEntries: Set<Entry>? = nil
-    ) -> [Entry]? {
-        guard !data.isEmpty, data.count <= policy.maximumBytes,
-              let text = String(data: data, encoding: .utf8),
-              !text.hasPrefix("\u{feff}") else {
-            return nil
-        }
-
+    nonisolated static func parseCSV(_ text: String) -> [Entry] {
+        var result: Set<Entry> = []
         let lines = text.split(whereSeparator: { $0.isNewline })
-            .map { $0.trimmingCharacters(in: .whitespacesAndNewlines) }
-            .filter { !$0.isEmpty }
-        guard let header = lines.first,
-              lines.count - 1 <= policy.maximumRows else {
-            return nil
+        for (idx, raw) in lines.enumerated() {
+            guard let line = raw.trimmedOrNilIfEmpty else { continue }
+            if idx == 0 && line.lowercased().contains("relay url") { continue }
+            let parts = line.split(separator: ",").map { $0.trimmed }
+            guard parts.count >= 3 else { continue }
+            guard let host = NostrRelayURL.directoryAddress(parts[0]) else { continue }
+            guard let lat = Double(parts[1]), let lon = Double(parts[2]) else { continue }
+            result.insert(Entry(host: host, lat: lat, lon: lon))
         }
-
-        let headerParts = header
-            .split(separator: ",", omittingEmptySubsequences: false)
-            .map { $0.trimmingCharacters(in: .whitespacesAndNewlines).lowercased() }
-        let supportedHeaders = [
-            ["relay url", "latitude", "longitude"],
-            ["relay url", "lat", "lon"]
-        ]
-        guard supportedHeaders.contains(headerParts) else {
-            return nil
-        }
-
-        var entriesByHost: [String: Entry] = [:]
-        for line in lines.dropFirst() {
-            let parts = line
-                .split(separator: ",", omittingEmptySubsequences: false)
-                .map { $0.trimmingCharacters(in: .whitespacesAndNewlines) }
-            guard parts.count == 3,
-                  let host = validatedDirectoryAddress(parts[0]),
-                  let latitude = Double(parts[1]), latitude.isFinite,
-                  (-90.0...90.0).contains(latitude),
-                  let longitude = Double(parts[2]), longitude.isFinite,
-                  (-180.0...180.0).contains(longitude) else {
-                return nil
-            }
-
-            let entry = Entry(host: host, lat: latitude, lon: longitude)
-            if let existing = entriesByHost[host], existing != entry {
-                // One endpoint cannot truthfully occupy two coordinates. Do
-                // not let row ordering choose which location clients trust.
-                return nil
-            }
-            entriesByHost[host] = entry
-            guard entriesByHost.count <= policy.maximumEntries else { return nil }
-        }
-
-        let parsedEntries = Set(entriesByHost.values)
-        guard parsedEntries.count >= minimumEntries else { return nil }
-
-        if let baselineEntries {
-            guard (0...1).contains(policy.minimumRetainedFraction) else { return nil }
-            let requiredOverlap = Int(
-                ceil(Double(baselineEntries.count) * policy.minimumRetainedFraction)
-            )
-            guard parsedEntries.intersection(baselineEntries).count >= requiredOverlap else {
-                return nil
-            }
-        }
-
-        return parsedEntries.sorted {
-            ($0.host, $0.lat, $0.lon) < ($1.host, $1.lat, $1.lon)
-        }
-    }
-
-    nonisolated private static func validatedDirectoryAddress(_ rawValue: String) -> String? {
-        let value = rawValue.trimmingCharacters(in: .whitespacesAndNewlines)
-        guard !value.isEmpty,
-              value.unicodeScalars.allSatisfy({
-                  $0.isASCII && !CharacterSet.controlCharacters.contains($0)
-              }) else {
-            return nil
-        }
-
-        let candidate = value.contains("://") ? value : "wss://\(value)"
-        guard let components = URLComponents(string: candidate),
-              let scheme = components.scheme?.lowercased(),
-              scheme == "wss" || scheme == "https",
-              components.user == nil,
-              components.password == nil,
-              components.query == nil,
-              components.fragment == nil,
-              components.path.isEmpty || components.path == "/",
-              let rawHost = components.host else {
-            return nil
-        }
-
-        let host = rawHost.lowercased()
-        guard !host.isEmpty, host.count <= 253,
-              host.unicodeScalars.allSatisfy({ $0.isASCII }),
-              !host.hasSuffix("."),
-              host != "localhost",
-              !host.hasSuffix(".localhost"),
-              !host.hasSuffix(".local"),
-              !host.hasSuffix(".internal") else {
-            return nil
-        }
-
-        let labels = host.split(separator: ".", omittingEmptySubsequences: false)
-        let allowed = CharacterSet(charactersIn: "abcdefghijklmnopqrstuvwxyz0123456789-")
-        guard labels.count >= 2,
-              !labels.allSatisfy({ $0.allSatisfy(\.isNumber) }),
-              labels.allSatisfy({ label in
-                  (1...63).contains(label.count) &&
-                  label.first != "-" &&
-                  label.last != "-" &&
-                  label.unicodeScalars.allSatisfy { allowed.contains($0) }
-              }) else {
-            return nil
-        }
-
-        if let port = components.port {
-            guard (1...65_535).contains(port) else { return nil }
-            if port != 443 { return "\(host):\(port)" }
-        }
-        return host
+        return Array(result)
     }
 
     // MARK: - Observers & Timers

bitchat/Nostr/NostrIdentity.swift

@@ -1,8 +1,7 @@
 import Foundation
 import P256K
 
-/// Manages the secp256k1 identity used by BitChat's Nostr relay features,
-/// including the proprietary private-envelope transport.
+/// Manages Nostr identity (secp256k1 keypair) for NIP-17 private messaging
 struct NostrIdentity: Codable {
     let privateKey: Data
     let publicKey: Data

bitchat/Nostr/NostrIdentityBridge.swift

@@ -76,9 +76,10 @@ final class NostrIdentityBridge {
             deviceSeedCache = existing
             return existing
         }
-        // CryptoKit key generation cannot fail, unlike SecRandomCopyBytes —
-        // a discarded failure here would persist an all-zero identity seed.
-        let seed = SymmetricKey(size: .bits256).withUnsafeBytes { Data($0) }
+        var seed = Data(count: 32)
+        _ = seed.withUnsafeMutableBytes { ptr in
+            SecRandomCopyBytes(kSecRandomDefault, 32, ptr.baseAddress!)
+        }
         // Ensure availability after first unlock to prevent unintended rotation when locked
         keychain.save(key: deviceSeedKey, data: seed, service: keychainService, accessible: kSecAttrAccessibleAfterFirstUnlockThisDeviceOnly)
         deviceSeedCache = seed

bitchat/Nostr/NostrProtocol.swift

@@ -7,26 +7,16 @@ import Security
 // Note: This file depends on Data extension from BinaryEncodingUtils.swift
 // Make sure BinaryEncodingUtils.swift is included in the target
 
-/// BitChat's private-envelope protocol transported over Nostr relays.
-///
-/// This construction is deliberately BitChat-specific and is **not** NIP-17,
-/// NIP-44, or NIP-59 compatible, even though it historically reuses those
-/// NIPs' kind numbers (1059/13/14) and a `v2:` content prefix. It uses Nostr
-/// events and secp256k1 identities, but the XChaCha20-Poly1305 payload layout
-/// and key derivation are proprietary and interoperate only with BitChat
-/// clients.
+/// NIP-17 Protocol Implementation for Private Direct Messages
 struct NostrProtocol {
-
+    
     /// Nostr event kinds
     enum EventKind: Int {
         case metadata = 0
         case textNote = 1
-        // BitChat's proprietary private-envelope layers. These reuse the
-        // NIP-17/NIP-59 kind numbers (14/13/1059) for historical reasons, but
-        // the encrypted payloads are BitChat-specific and not NIP-compatible.
-        case dm = 14 // unsigned inner message (inside ciphertext)
-        case seal = 13 // sender-signed seal (inside ciphertext)
-        case giftWrap = 1059 // public outer envelope (one-time key)
+        case dm = 14 // NIP-17 DM rumor kind
+        case seal = 13 // NIP-17 sealed event
+        case giftWrap = 1059 // NIP-59 gift wrap
         case ephemeralEvent = 20000
         case geohashPresence = 20001
         case deletion = 5 // NIP-09 event deletion request
@@ -35,46 +25,29 @@ struct NostrProtocol {
         /// its NIP-40 expiration — the whole point is store-and-forward.
         case courierDrop = 1401
     }
-
-    /// Bound work before Base64-decoding either encrypted layer of an inbound
-    /// private envelope, and before parsing each decrypted nested JSON layer.
-    /// Real envelopes are normally a few KiB; 64 KiB leaves ample headroom
-    /// without letting an addressed relay event drive unbounded allocation.
-    static let maximumPrivateEnvelopeCiphertextBytes = 64 * 1024
-
-    /// Create a BitChat private envelope for relay transport (outer kind 1059).
+    
+    /// Create a NIP-17 private message
     static func createPrivateMessage(
         content: String,
         recipientPubkey: String,
         senderIdentity: NostrIdentity
     ) throws -> NostrEvent {
-        try createPrivateMessage(
-            content: content,
-            recipientPubkey: recipientPubkey,
-            senderIdentity: senderIdentity,
-            messageTags: []
-        )
-    }
-
-    private static func createPrivateMessage(
-        content: String,
-        recipientPubkey: String,
-        senderIdentity: NostrIdentity,
-        messageTags: [[String]]
-    ) throws -> NostrEvent {
-        // 1. Create the rumor (unsigned inner event)
+        
+        // Creating private message
+        
+        // 1. Create the rumor (unsigned event)
         let rumor = NostrEvent(
             pubkey: senderIdentity.publicKeyHex,
             createdAt: Date(),
-            kind: .dm,
-            tags: messageTags,
+            kind: .dm, // NIP-17: DM rumor kind 14
+            tags: [],
             content: content
         )
-
+        
         // 2. Seal the rumor (encrypt to recipient) and sign it with the SENDER'S
-        //    real identity key so the recipient can authenticate who sent the
-        //    message; signing with a throwaway key leaves DMs
-        //    forgeable/impersonatable.
+        //    real identity key. NIP-17 requires the seal be signed by the sender
+        //    so the recipient can authenticate who sent the message; signing with
+        //    a throwaway key leaves DMs forgeable/impersonatable.
         let senderKey = try senderIdentity.schnorrSigningKey()
         let sealedEvent = try createSeal(
             rumor: rumor,
@@ -82,39 +55,28 @@ struct NostrProtocol {
             senderKey: senderKey
         )
 
-        // 3. Wrap the sealed event with a throwaway ephemeral key (the wrap
+        // 3. Gift wrap the sealed event with a throwaway ephemeral key (the wrap
         //    layer hides the sender's identity from relays; createGiftWrap mints
         //    its own ephemeral key internally).
         let giftWrap = try createGiftWrap(
             seal: sealedEvent,
             recipientPubkey: recipientPubkey
         )
-
+        
+        // Created gift wrap
+        
         return giftWrap
     }
-
-    /// Decrypt a received BitChat private envelope.
-    /// Returns the content, sender pubkey, and the actual message timestamp (not the randomized outer timestamp)
+    
+    /// Decrypt a received NIP-17 message
+    /// Returns the content, sender pubkey, and the actual message timestamp (not the randomized gift wrap timestamp)
     static func decryptPrivateMessage(
         giftWrap: NostrEvent,
         recipientIdentity: NostrIdentity
     ) throws -> (content: String, senderPubkey: String, timestamp: Int) {
-
-        // 0. Validate the untrusted outer envelope before any decryption work.
-        //    Every BitChat client (released iOS and current Android) publishes
-        //    exactly one outer recipient `p` tag on a validly signed kind-1059
-        //    wrap; anything else is malformed or misbound.
-        guard giftWrap.content.utf8.count <= maximumPrivateEnvelopeCiphertextBytes else {
-            SecureLogger.error("❌ Rejecting DM: oversized outer envelope ciphertext", category: .session)
-            throw NostrError.invalidCiphertext
-        }
-        guard giftWrap.kind == EventKind.giftWrap.rawValue,
-              giftWrap.tags == [["p", recipientIdentity.publicKeyHex]],
-              giftWrap.isValidSignature() else {
-            SecureLogger.error("❌ Rejecting DM: malformed or misbound outer envelope", category: .session)
-            throw NostrError.invalidEvent
-        }
-
+        
+        // Starting decryption
+        
         // 1. Unwrap the gift wrap
         let seal: NostrEvent
         do {
@@ -129,13 +91,10 @@ struct NostrProtocol {
         }
         
         // 2. Authenticate the seal. The seal MUST be signed by the sender's real
-        //    identity key; without this check a DM is forgeable by anyone who
-        //    knows the recipient's npub. Every BitChat sender emits a tagless
-        //    kind-13 seal, so bind the decrypted layer to that exact shape.
-        guard seal.kind == EventKind.seal.rawValue,
-              seal.tags.isEmpty,
-              seal.isValidSignature() else {
-            SecureLogger.error("❌ Rejecting DM: seal is malformed or its signature is missing/invalid", category: .session)
+        //    identity key (NIP-17); without this check a DM is forgeable by anyone
+        //    who knows the recipient's npub. Verify the seal's own signature.
+        guard seal.isValidSignature() else {
+            SecureLogger.error("❌ Rejecting DM: seal signature is missing or invalid", category: .session)
             throw NostrError.invalidEvent
         }
 
@@ -152,16 +111,11 @@ struct NostrProtocol {
             throw error
         }
 
-        // 4. The rumor is intentionally unsigned; sender authentication comes
-        //    from the seal. The sender claimed inside the rumor must match the
-        //    key that actually signed the seal, otherwise the sender field is
-        //    unauthenticated and spoofable. Also bind the inner kind and tag
-        //    shape to what BitChat clients actually emit.
-        guard rumor.kind == EventKind.dm.rawValue,
-              validInnerMessageTags(rumor.tags, recipientPubkey: recipientIdentity.publicKeyHex),
-              rumor.sig == nil,
-              seal.pubkey == rumor.pubkey else {
-            SecureLogger.error("❌ Rejecting DM: rumor is malformed or does not match seal signer", category: .session)
+        // 4. The sender claimed inside the rumor must match the key that actually
+        //    signed the seal, otherwise the sender field is unauthenticated and
+        //    spoofable.
+        guard seal.pubkey == rumor.pubkey else {
+            SecureLogger.error("❌ Rejecting DM: rumor pubkey does not match seal signer", category: .session)
             throw NostrError.invalidEvent
         }
 
@@ -169,17 +123,6 @@ struct NostrProtocol {
         return (content: rumor.content, senderPubkey: seal.pubkey, timestamp: rumor.created_at)
     }
 
-    /// Released iOS envelopes use no inner tags, while current Android
-    /// envelopes place exactly the authenticated recipient's `p` tag on the
-    /// unsigned inner event. Accept only those two historical shapes;
-    /// alternate recipients, duplicate tags, and extra tags are rejected.
-    private static func validInnerMessageTags(
-        _ tags: [[String]],
-        recipientPubkey: String
-    ) -> Bool {
-        tags.isEmpty || tags == [["p", recipientPubkey]]
-    }
-
     #if DEBUG
     static func createPrivateMessageWithInvalidSealSignatureForTesting(
         content: String,
@@ -222,23 +165,6 @@ struct NostrProtocol {
         )
         return try createGiftWrap(seal: seal, recipientPubkey: recipientPubkey)
     }
-
-    /// Reproduces historical wire shapes (current Android places exactly one
-    /// recipient `p` tag on the unsigned inner event) without making the
-    /// production encoder depend on that quirk.
-    static func createPrivateMessageWithInnerTagsForTesting(
-        content: String,
-        recipientPubkey: String,
-        senderIdentity: NostrIdentity,
-        innerMessageTags: [[String]]
-    ) throws -> NostrEvent {
-        try createPrivateMessage(
-            content: content,
-            recipientPubkey: recipientPubkey,
-            senderIdentity: senderIdentity,
-            messageTags: innerMessageTags
-        )
-    }
     #endif
 
     /// Create a geohash-scoped ephemeral public message (kind 20000)
@@ -338,32 +264,22 @@ struct NostrProtocol {
 
     /// Create a mesh-bridge public message (kind 20000) for a geohash-cell
     /// rendezvous. The distinct `r` tag keeps bridge traffic out of geohash
-    /// channel subscriptions (which filter on `#g`); `m` is
-    /// `[stable ID, mesh sender ID, wire timestamp in ms]`. Element 1 is the
-    /// content-stable mesh message ID (`MeshMessageIdentity`) for v1.7.0
-    /// parsers, which key their dedup on `m[1]` unconditionally and need it
-    /// per-message-unique. Current parsers key bridge rows by the authenticated
-    /// event ID and recompute elements 2-3 only as a radio-copy hint; the mesh
-    /// coordinates are public and cannot authenticate the Nostr signer.
+    /// channel subscriptions (which filter on `#g`); `m` carries the original
+    /// mesh message ID so receivers dedup the bridged copy against the radio
+    /// copy by timeline ID.
     static func createBridgeMeshEvent(
         content: String,
         cell: String,
         senderIdentity: NostrIdentity,
         nickname: String? = nil,
-        meshSenderID: String? = nil,
-        meshTimestampMs: UInt64? = nil
+        meshMessageID: String? = nil
     ) throws -> NostrEvent {
         var tags = [["r", cell]]
         if let nickname = nickname?.trimmedOrNilIfEmpty {
             tags.append(["n", nickname])
         }
-        if let meshSenderID = meshSenderID?.trimmedOrNilIfEmpty, let meshTimestampMs {
-            let stableID = MeshMessageIdentity.stableID(
-                senderIDHex: meshSenderID,
-                timestampMs: meshTimestampMs,
-                content: content
-            )
-            tags.append(["m", stableID, meshSenderID, String(meshTimestampMs)])
+        if let meshMessageID = meshMessageID?.trimmedOrNilIfEmpty {
+            tags.append(["m", meshMessageID])
         }
         let event = NostrEvent(
             pubkey: senderIdentity.publicKeyHex,
@@ -409,7 +325,7 @@ struct NostrProtocol {
     ) throws -> NostrEvent {
         let tags = [
             ["x", recipientTagHex],
-            ["expiration", String(Int(expiresAt.timeIntervalSince1970))]
+            ["expiration", String(Int(expiresAt.timeIntervalSince1970))],
         ]
         let event = NostrEvent(
             pubkey: senderIdentity.publicKeyHex,
@@ -542,19 +458,14 @@ struct NostrProtocol {
             recipientKey: recipientKey
         )
         
-        // Check UTF-8 size before allocating Data or invoking the general
-        // JSON parser on attacker-influenced plaintext.
-        guard decrypted.utf8.count <= maximumPrivateEnvelopeCiphertextBytes else {
-            throw NostrError.invalidCiphertext
-        }
         guard let data = decrypted.data(using: .utf8),
               let sealDict = try JSONSerialization.jsonObject(with: data) as? [String: Any] else {
             throw NostrError.invalidEvent
         }
-
+        
         let seal = try NostrEvent(from: sealDict)
         // Unwrapped seal
-
+        
         return seal
     }
     
@@ -569,23 +480,16 @@ struct NostrProtocol {
             recipientKey: recipientKey
         )
         
-        guard decrypted.utf8.count <= maximumPrivateEnvelopeCiphertextBytes else {
-            throw NostrError.invalidCiphertext
-        }
         guard let data = decrypted.data(using: .utf8),
               let rumorDict = try JSONSerialization.jsonObject(with: data) as? [String: Any] else {
             throw NostrError.invalidEvent
         }
-
+        
         return try NostrEvent(from: rumorDict)
     }
-
-    // MARK: - BitChat private-envelope encryption
-    //
-    // Not NIP-44: the `v2:` prefix, base64url(nonce24 || ciphertext || tag)
-    // layout, XChaCha20-Poly1305 cipher, and HKDF parameters are all
-    // BitChat-specific.
-
+    
+    // MARK: - Encryption (NIP-44 v2)
+    
     private static func encrypt(
         plaintext: String,
         recipientPubkey: String,
@@ -596,25 +500,22 @@ struct NostrProtocol {
             throw NostrError.invalidPublicKey
         }
         
+        // Encrypting message (NIP-44 v2: XChaCha20-Poly1305, versioned)
+        
         // Derive shared secret
         let sharedSecret = try deriveSharedSecret(
             privateKey: senderKey,
             publicKey: recipientPubkeyData
         )
-        // Derive the BitChat private-envelope symmetric key (HKDF-SHA256)
-        let key = try derivePrivateEnvelopeKey(from: sharedSecret)
-
+        // Derive NIP-44 v2 symmetric key (HKDF-SHA256 with label in info)
+        let key = try deriveNIP44V2Key(from: sharedSecret)
+        
         // 24-byte random nonce for XChaCha20-Poly1305
         var nonce24 = Data(count: 24)
-        let randomStatus = nonce24.withUnsafeMutableBytes { ptr in
+        _ = nonce24.withUnsafeMutableBytes { ptr in
             SecRandomCopyBytes(kSecRandomDefault, 24, ptr.baseAddress!)
         }
-        // Never encrypt with an unrandomized nonce: nonce reuse under the same
-        // key breaks XChaCha20-Poly1305 confidentiality and authenticity.
-        guard randomStatus == errSecSuccess else {
-            throw NostrError.cryptographicFailure
-        }
-
+        
         let pt = Data(plaintext.utf8)
         let sealed = try XChaCha20Poly1305Compat.seal(plaintext: pt, key: key, nonce24: nonce24)
         
@@ -631,12 +532,8 @@ struct NostrProtocol {
         senderPubkey: String,
         recipientKey: P256K.Schnorr.PrivateKey
     ) throws -> String {
-        // Expect BitChat's historical `v2:` private-envelope framing, and
-        // bound work before Base64 decoding attacker-sized input.
-        guard ciphertext.utf8.count <= maximumPrivateEnvelopeCiphertextBytes,
-              ciphertext.hasPrefix("v2:") else {
-            throw NostrError.invalidCiphertext
-        }
+        // Expect NIP-44 v2 format
+        guard ciphertext.hasPrefix("v2:") else { throw NostrError.invalidCiphertext }
         let encoded = String(ciphertext.dropFirst(3))
         guard let data = Base64URLCoding.decode(encoded),
               data.count > (24 + 16),
@@ -652,7 +549,7 @@ struct NostrProtocol {
         // Try decryption with even-Y then odd-Y when sender pubkey is x-only
         func attemptDecrypt(using pubKeyData: Data) throws -> Data {
             let ss = try deriveSharedSecret(privateKey: recipientKey, publicKey: pubKeyData)
-            let key = try derivePrivateEnvelopeKey(from: ss)
+            let key = try deriveNIP44V2Key(from: ss)
             return try XChaCha20Poly1305Compat.open(
                 ciphertext: Data(ct),
                 tag: Data(tag),
@@ -662,25 +559,18 @@ struct NostrProtocol {
         }
 
         // If 32 bytes (x-only) try both parities, otherwise single try
-        let plaintext: Data
         if senderPubkeyData.count == 32 {
             let even = Data([0x02]) + senderPubkeyData
             if let pt = try? attemptDecrypt(using: even) {
-                plaintext = pt
-            } else {
-                let odd = Data([0x03]) + senderPubkeyData
-                plaintext = try attemptDecrypt(using: odd)
+                return String(data: pt, encoding: .utf8) ?? ""
             }
+            let odd = Data([0x03]) + senderPubkeyData
+            let pt = try attemptDecrypt(using: odd)
+            return String(data: pt, encoding: .utf8) ?? ""
         } else {
-            plaintext = try attemptDecrypt(using: senderPubkeyData)
+            let pt = try attemptDecrypt(using: senderPubkeyData)
+            return String(data: pt, encoding: .utf8) ?? ""
         }
-
-        // Authenticated plaintext that is not valid UTF-8 is a malformed
-        // envelope, not an empty message.
-        guard let decoded = String(data: plaintext, encoding: .utf8) else {
-            throw NostrError.invalidCiphertext
-        }
-        return decoded
     }
     
     private static func deriveSharedSecret(
@@ -740,8 +630,7 @@ struct NostrProtocol {
         let sharedSecretData = sharedSecret.withUnsafeBytes { Data($0) }
         // ECDH shared secret derived
         
-        // Return raw ECDH shared secret; HKDF is applied by
-        // derivePrivateEnvelopeKey
+        // Return raw ECDH shared secret; HKDF is applied by deriveNIP44V2Key
         return sharedSecretData
     }
     
@@ -801,10 +690,6 @@ struct NostrEvent: Codable {
               let content = dict["content"] as? String else {
             throw NostrError.invalidEvent
         }
-
-        guard Self.isWithinInboundTagLimits(tags) else {
-            throw NostrError.invalidEvent
-        }
         
         self.id = dict["id"] as? String ?? ""
         self.pubkey = pubkey
@@ -814,21 +699,6 @@ struct NostrEvent: Codable {
         self.content = content
         self.sig = dict["sig"] as? String
     }
-
-    /// Bounds untrusted relay tag arrays so attackers cannot force large
-    /// allocations or expensive joins on the inbound hot path.
-    static func isWithinInboundTagLimits(_ tags: [[String]]) -> Bool {
-        guard tags.count <= TransportConfig.nostrMaxEventTags else { return false }
-
-        for tag in tags {
-            guard tag.count <= TransportConfig.nostrMaxEventTagValues else { return false }
-            guard tag.allSatisfy({ $0.utf8.count <= TransportConfig.nostrMaxEventTagValueBytes }) else {
-                return false
-            }
-        }
-
-        return true
-    }
     
     func sign(with key: P256K.Schnorr.PrivateKey) throws -> NostrEvent {
         let (eventId, eventIdHash) = try calculateEventId()
@@ -836,12 +706,9 @@ struct NostrEvent: Codable {
         // Sign with Schnorr (BIP-340)
         var messageBytes = [UInt8](eventIdHash)
         var auxRand = [UInt8](repeating: 0, count: 32)
-        let auxStatus = auxRand.withUnsafeMutableBytes { ptr in
+        _ = auxRand.withUnsafeMutableBytes { ptr in
             SecRandomCopyBytes(kSecRandomDefault, 32, ptr.baseAddress!)
         }
-        guard auxStatus == errSecSuccess else {
-            throw NostrError.cryptographicFailure
-        }
         let schnorrSignature = try key.signature(message: &messageBytes, auxiliaryRand: &auxRand)
         
         let signatureHex = schnorrSignature.dataRepresentation.hexEncodedString()
@@ -898,17 +765,12 @@ enum NostrError: Error {
     case invalidPublicKey
     case invalidEvent
     case invalidCiphertext
-    case cryptographicFailure
 }
 
-// MARK: - BitChat private-envelope key derivation
+// MARK: - NIP-44 v2 helpers (XChaCha20-Poly1305)
 
 private extension NostrProtocol {
-    /// The HKDF info string retains the historical "nip44-v2" label for wire
-    /// compatibility with deployed clients, but this is not the NIP-44 key
-    /// schedule: NIP-44 derives a conversation key via HKDF-extract with that
-    /// label as the *salt* and uses ChaCha20 with per-message expanded keys.
-    static func derivePrivateEnvelopeKey(from sharedSecretData: Data) throws -> Data {
+    static func deriveNIP44V2Key(from sharedSecretData: Data) throws -> Data {
         let derivedKey = HKDF<CryptoKit.SHA256>.deriveKey(
             inputKeyMaterial: SymmetricKey(data: sharedSecretData),
             salt: Data(),

bitchat/Nostr/NostrRelayManager.swift

@@ -48,14 +48,7 @@ private struct URLSessionAdapter: NostrRelaySessionProtocol {
     let base: URLSession
 
     func webSocketTask(with url: URL) -> NostrRelayConnectionProtocol {
-        let task = base.webSocketTask(with: url)
-        // Byte bound per inbound frame; without it the per-relay buffer cap
-        // (nostrInboundPerRelayBufferCap) bounds FRAMES but not BYTES, and a
-        // hostile relay could pile up cap × 1 MiB (URLSession default) per
-        // connection. See TransportConfig.nostrInboundMaxFrameBytes for the
-        // sizing rationale. Oversized frames fail the receive with an error.
-        task.maximumMessageSize = TransportConfig.nostrInboundMaxFrameBytes
-        return URLSessionWebSocketTaskAdapter(base: task)
+        URLSessionWebSocketTaskAdapter(base: base.webSocketTask(with: url))
     }
 }
 
@@ -76,18 +69,6 @@ struct NostrRelayManagerDependencies {
     /// Uniform random value in [0, 1) used to jitter reconnect backoff.
     /// Injectable so tests can pin or sweep the jitter deterministically.
     var jitterUnit: () -> Double
-    /// Where relay-settings changes are observed. Injectable so a test can use
-    /// its own center instead of racing the process-wide one.
-    var notificationCenter: NotificationCenter = .default
-    /// Relays added by hand, merged with the built-in set. Injectable so tests
-    /// do not have to write to shared preferences.
-    var customRelays: () -> [String] = { NostrRelaySettings.customRelays() }
-    /// Whether a location channel is currently open. Mirrors the third arm of
-    /// `NetworkActivationService`'s gate: teleporting into a geohash needs no
-    /// location permission, and without this the relays would stay filtered out
-    /// for someone who denied location and has no mutual favorites.
-    var isInLocationChannel: () -> Bool = { false }
-    var selectedChannelPublisher: AnyPublisher<ChannelID, Never> = Empty().eraseToAnyPublisher()
 }
 
 private extension NostrRelayManagerDependencies {
@@ -116,12 +97,7 @@ private extension NostrRelayManagerDependencies {
                 DispatchQueue.main.asyncAfter(deadline: .now() + delay, execute: action)
             },
             now: Date.init,
-            jitterUnit: { Double.random(in: 0..<1) },
-            isInLocationChannel: {
-                if case .location = LocationChannelManager.shared.selectedChannel { return true }
-                return false
-            },
-            selectedChannelPublisher: LocationChannelManager.shared.$selectedChannel.eraseToAnyPublisher()
+            jitterUnit: { Double.random(in: 0..<1) }
         )
     }
 }
@@ -130,10 +106,7 @@ private extension NostrRelayManagerDependencies {
 @MainActor
 final class NostrRelayManager: ObservableObject {
     static let shared = NostrRelayManager()
-    // Track gift-wraps (kind 1059) we initiated so we can log OK acks at info.
-    // Entries are removed only on OK acks (or panic wipe); relays that never
-    // ack leave entries behind for the process lifetime. Observability-only
-    // state, bounded in practice by outbound DM volume.
+    // Track gift-wraps (kind 1059) we initiated so we can log OK acks at info
     private(set) static var pendingGiftWrapIDs = Set<String>()
     static func registerPendingGiftWrap(id: String) {
         pendingGiftWrapIDs.insert(id)
@@ -151,41 +124,16 @@ final class NostrRelayManager: ObservableObject {
         var nextReconnectTime: Date?
     }
     
-    // Built-in relays carry private-message envelopes, so avoid relays known to
-    // reject the kinds they use.
-    nonisolated private static let builtInRelays = [
+    // Default relays carry NIP-17 gift wraps, so avoid relays known to reject kind 1059.
+    private static let defaultRelays = [
         "wss://relay.damus.io",
         "wss://nos.lol",
         "wss://relay.primal.net",
         "wss://offchain.pub"
         // For local testing, you can add: "ws://localhost:8080"
     ]
-    /// Exposed so the relay settings UI can reject re-adding a built-in.
-    /// `nonisolated` because it is an immutable constant with no actor state.
-    nonisolated static let builtInRelayURLs = Set(
-        builtInRelays.compactMap { NostrRelayURL.normalized($0) }
-    )
-
-    /// The relays private messages target: the built-in set plus any added by
-    /// hand. Four hardcoded hostnames are four names for a censor to block, so
-    /// the added ones are what keeps this reachable without a new build.
-    ///
-    /// Cached rather than computed per access: `allowedRelayList` consults the
-    /// set once per candidate URL, and recomputing would mean a `UserDefaults`
-    /// read and a fresh normalize-and-dedupe pass inside that loop. Refreshed
-    /// from `reloadDefaultRelays()` on construction and whenever the relay
-    /// settings change.
-    private var defaultRelays: [String] = []
-    private var defaultRelaySet: Set<String> = []
-
-    private func reloadDefaultRelays() {
-        var seen = Set<String>()
-        defaultRelays = (Self.builtInRelays + dependencies.customRelays())
-            .compactMap { NostrRelayURL.normalized($0) }
-            .filter { seen.insert($0).inserted }
-        defaultRelaySet = Set(defaultRelays)
-    }
-
+    private static let defaultRelaySet = Set(defaultRelays.compactMap { NostrRelayURL.normalized($0) })
+    
     @Published private(set) var relays: [Relay] = []
     @Published private(set) var isConnected = false
     /// Whether a relay that carries private messages is connected. DMs
@@ -268,15 +216,6 @@ final class NostrRelayManager: ObservableObject {
     }
     private var messageQueue: [PendingSend] = []
     private let messageQueueLock = NSLock()
-    /// Non-queued sends whose callers require relay durability. A WebSocket
-    /// write only proves bytes left this process; NIP-01 `OK` is the relay's
-    /// accept/reject acknowledgment.
-    private struct ConfirmedSendState {
-        let token: UUID
-        var awaitingRelays: Set<String>
-        let completion: (Bool) -> Void
-    }
-    private var confirmedSends: [String: ConfirmedSendState] = [:]
     // Total pending sends dropped at the queue cap; drives the sampled
     // overflow warning (first + every Nth drop).
     private var pendingSendDropCount = 0
@@ -291,42 +230,11 @@ final class NostrRelayManager: ObservableObject {
     
     // Bump generation to invalidate scheduled reconnects when we reset/disconnect
     private var connectionGeneration: Int = 0
-
-    // Per-relay off-main inbound pipeline: raw socket frames are parsed and
-    // Schnorr-verified in arrival order OFF the main actor (this is the single
-    // signature verification for the whole inbound path — downstream handlers
-    // receive only verified events), then hop back to the main actor for dedup
-    // recording and handler dispatch.
-    //
-    // Each relay connection owns its OWN AsyncStream + consumer task, so N
-    // relays verify in parallel while every relay's frames stay in arrival
-    // order (a single subscription's events for a relay all arrive on that
-    // relay's socket, so per-relay ordering preserves per-subscription
-    // ordering). A burst of EVENT frames from one busy/malicious relay only
-    // blocks that relay's own verification backlog — DMs, OKs, EOSEs, and
-    // events from every other relay keep flowing on their own pipelines.
-    //
-    // Each stream is bounded (`.bufferingNewest`) so a relay flooding faster
-    // than its verification drains sheds its own oldest frames instead of
-    // growing memory without bound; it can never starve other relays.
-    //
-    // Continuations live in a lock-guarded, `Sendable` router (see
-    // `InboundFrameRouter` at file scope) so the raw socket receive callback
-    // (which is NOT main-actor isolated) can route a frame to the right relay
-    // stream without a per-frame main hop, while the main actor owns pipeline
-    // creation/teardown. The expensive work (Schnorr verify) is what runs
-    // off-main; the yield stays cheap.
-    private let inboundRouter = InboundFrameRouter()
-
-    convenience init() {
-        self.init(dependencies: .live())
-    }
-
-    internal init(dependencies: NostrRelayManagerDependencies) {
-        self.dependencies = dependencies
+    
+    init() {
+        self.dependencies = .live()
         hasMutualFavorites = dependencies.hasMutualFavorites()
         hasLocationPermission = dependencies.hasLocationPermission()
-        reloadDefaultRelays()
         applyDefaultRelayPolicy(force: true)
         // Deterministic JSON shape for outbound requests
         self.encoder.outputFormatting = .sortedKeys
@@ -348,93 +256,35 @@ final class NostrRelayManager: ObservableObject {
                 self.applyDefaultRelayPolicy()
             }
             .store(in: &cancellables)
-        dependencies.selectedChannelPublisher
+    }
+
+    internal init(dependencies: NostrRelayManagerDependencies) {
+        self.dependencies = dependencies
+        hasMutualFavorites = dependencies.hasMutualFavorites()
+        hasLocationPermission = dependencies.hasLocationPermission()
+        applyDefaultRelayPolicy(force: true)
+        // Deterministic JSON shape for outbound requests
+        self.encoder.outputFormatting = .sortedKeys
+        dependencies.mutualFavoritesPublisher
             .receive(on: DispatchQueue.main)
-            .sink { [weak self] _ in
-                self?.applyDefaultRelayPolicy()
+            .sink { [weak self] favorites in
+                guard let self = self else { return }
+                self.hasMutualFavorites = !favorites.isEmpty
+                self.applyDefaultRelayPolicy()
             }
             .store(in: &cancellables)
-        // Adding or removing a relay by hand changes the target set, so
-        // reconcile connections now rather than at the next send.
-        dependencies.notificationCenter
-            .publisher(for: NostrRelaySettings.didChangeNotification)
+        dependencies.locationPermissionPublisher
             .receive(on: DispatchQueue.main)
-            .sink { [weak self] _ in
-                guard let self else { return }
-                // Reconcile against the previous set: a removed relay is no
-                // longer in `defaultRelays`, so nothing downstream would ever
-                // close its socket or drop its queued sends.
-                let previous = self.defaultRelaySet
-                self.reloadDefaultRelays()
-                self.dropRelays(previous.subtracting(self.defaultRelaySet))
-                self.applyDefaultRelayPolicy(force: true)
+            .sink { [weak self] state in
+                guard let self = self else { return }
+                let authorized = (state == .authorized)
+                if authorized == self.hasLocationPermission { return }
+                self.hasLocationPermission = authorized
+                self.applyDefaultRelayPolicy()
             }
             .store(in: &cancellables)
     }
-
-    deinit {
-        inboundRouter.finishAll()
-    }
-
-    /// Ensure a serial off-main consumer pipeline exists for a relay. Called on
-    /// the main actor when a socket is (re)armed for receiving. Idempotent.
-    ///
-    /// Ordering within the relay is deliberate and security/performance-critical:
-    /// 1. `precheckInboundEvent` (main hop): per-relay stats plus a cheap
-    ///    duplicate LOOKUP — duplicate fan-in from multiple relays dominates
-    ///    real traffic and must never pay for Schnorr verification.
-    /// 2. `isValidSignature()` runs here, off the main actor — the ONLY
-    ///    signature verification on the inbound path (JSON re-serialization +
-    ///    SHA-256 + secp256k1 Schnorr per event).
-    /// 3. `deliverVerifiedInboundEvent` (main hop): authoritative
-    ///    check-and-RECORD plus handler dispatch. Recording only after
-    ///    verification means a forged-signature copy can never poison the
-    ///    dedup cache and suppress the genuine event.
-    private func ensureRelayInboundPipeline(for relayUrl: String) {
-        let started = inboundRouter.startPipeline(for: relayUrl) { [weak self] stream in
-            Task.detached(priority: .userInitiated) {
-                for await frame in stream {
-                    guard let parsed = ParsedInbound(frame.message) else { continue }
-                    guard let self else { return }
-                    switch parsed {
-                    case .event(let subId, let event):
-                        guard await self.precheckInboundEvent(
-                            subscriptionID: subId,
-                            eventID: event.id,
-                            relayUrl: relayUrl
-                        ) else {
-                            continue
-                        }
-                        guard event.isValidSignature() else {
-                            SecureLogger.warning(
-                                "⚠️ Dropped invalid Nostr event id=\(event.id.prefix(16))… sub=\(subId) relay=\(relayUrl)",
-                                category: .session
-                            )
-                            continue
-                        }
-                        await self.deliverVerifiedInboundEvent(subscriptionID: subId, event: event, from: relayUrl)
-                    case .eose, .ok, .notice:
-                        await self.handleParsedMessage(parsed, from: relayUrl)
-                    }
-                }
-            }
-        }
-        if started {
-            SecureLogger.debug("🧵 Started inbound verify pipeline for \(relayUrl)", category: .session)
-        }
-    }
-
-    /// Tear down a relay's inbound pipeline (socket gone or state wiped). The
-    /// consumer drains any already-buffered frames before finishing, so
-    /// in-flight verified events are still delivered.
-    private func teardownRelayInboundPipeline(for relayUrl: String) {
-        inboundRouter.finishPipeline(for: relayUrl)
-    }
-
-    private func teardownAllRelayInboundPipelines() {
-        inboundRouter.finishAll()
-    }
-
+    
     /// Connect to all configured relays
     func connect() {
         // Global network policy gate
@@ -449,8 +299,6 @@ final class NostrRelayManager: ObservableObject {
             task.cancel(with: .goingAway, reason: nil)
         }
         connections.removeAll()
-        // Sockets are gone; drop every relay's inbound verify pipeline.
-        teardownAllRelayInboundPipelines()
         markRelaySocketsClosed(resetState: false)
         // Sockets are gone, so per-relay subscription state is cleared — but
         // durable intent (subscriptionRequestState, messageHandlers, parked
@@ -464,9 +312,6 @@ final class NostrRelayManager: ObservableObject {
         for (_, tracker) in trackers {
             tracker.callback()
         }
-        let confirmed = confirmedSends.values.map(\.completion)
-        confirmedSends.removeAll()
-        confirmed.forEach { $0(false) }
         pendingTorConnectionURLs.removeAll()
         awaitingTorForConnections = false
         torReadyWaitAttempts = 0
@@ -483,7 +328,6 @@ final class NostrRelayManager: ObservableObject {
             task.cancel(with: .goingAway, reason: nil)
         }
         connections.removeAll()
-        teardownAllRelayInboundPipelines()
         markRelaySocketsClosed(resetState: true)
         subscriptions.removeAll()
         pendingSubscriptions.removeAll()
@@ -501,7 +345,6 @@ final class NostrRelayManager: ObservableObject {
         duplicateInboundEventDropCountBySubscription.removeAll()
         inboundEventLogCount = 0
         Self.pendingGiftWrapIDs.removeAll()
-        confirmedSends.removeAll()
 
         messageQueueLock.lock()
         messageQueue.removeAll()
@@ -551,13 +394,13 @@ final class NostrRelayManager: ObservableObject {
             // event locally so it survives a slow bootstrap (queued sends flush
             // when relays connect), then kick off connection setup, which itself
             // waits for Tor readiness.
-            let targetRelays = allowedRelayList(from: relayUrls ?? defaultRelays)
+            let targetRelays = allowedRelayList(from: relayUrls ?? Self.defaultRelays)
             guard !targetRelays.isEmpty else { return }
             enqueuePendingSend(event, pendingRelays: Set(targetRelays))
             ensureConnections(to: targetRelays)
             return
         }
-        let requestedRelays = relayUrls ?? defaultRelays
+        let requestedRelays = relayUrls ?? Self.defaultRelays
         let targetRelays = allowedRelayList(from: requestedRelays)
         guard !targetRelays.isEmpty else { return }
         ensureConnections(to: targetRelays)
@@ -576,97 +419,6 @@ final class NostrRelayManager: ObservableObject {
         }
     }
 
-    /// Attempts an event only on currently connected target relays and
-    /// reports whether at least one relay explicitly accepted it via NIP-01
-    /// `OK`. A successful WebSocket write alone is not durable acceptance.
-    /// Unlike `sendEvent`, this never enters the process-local pending queue;
-    /// callers use it when success unlocks durable state or user-visible
-    /// delivery progress.
-    func sendEventImmediately(
-        _ event: NostrEvent,
-        to relayUrls: [String]? = nil,
-        completion: @escaping (Bool) -> Void
-    ) {
-        guard dependencies.activationAllowed() else {
-            completion(false)
-            return
-        }
-        guard !(shouldUseTor && dependencies.torEnforced() && !dependencies.torIsReady()) else {
-            completion(false)
-            return
-        }
-
-        let requestedRelays = relayUrls ?? defaultRelays
-        let targetRelays = allowedRelayList(from: requestedRelays)
-        let connectedTargets = targetRelays.compactMap { relayUrl -> (String, NostrRelayConnectionProtocol)? in
-            guard let connection = connectedConnection(for: relayUrl) else { return nil }
-            return (relayUrl, connection)
-        }
-        guard !connectedTargets.isEmpty else {
-            completion(false)
-            return
-        }
-
-        let token = UUID()
-        let eventID = event.id
-        if let replaced = confirmedSends.removeValue(forKey: eventID) {
-            replaced.completion(false)
-        }
-        confirmedSends[eventID] = ConfirmedSendState(
-            token: token,
-            awaitingRelays: Set(connectedTargets.map(\.0)),
-            completion: completion
-        )
-        dependencies.scheduleAfter(TransportConfig.nostrConfirmedSendAckTimeoutSeconds) { [weak self] in
-            Task { @MainActor [weak self] in
-                self?.timeoutConfirmedSend(eventID: eventID, token: token)
-            }
-        }
-
-        for (relayUrl, connection) in connectedTargets {
-            sendToRelay(event: event, connection: connection, relayUrl: relayUrl) { [weak self] succeeded in
-                guard let self else { return }
-                // Success only means the bytes reached the socket; wait for
-                // the matching relay OK. A failed write settles this target
-                // as rejected because no OK can arrive for it.
-                if !succeeded {
-                    self.resolveConfirmedSend(
-                        eventID: eventID,
-                        relayURL: relayUrl,
-                        accepted: false,
-                        token: token
-                    )
-                }
-            }
-        }
-    }
-
-    private func resolveConfirmedSend(
-        eventID: String,
-        relayURL: String,
-        accepted: Bool,
-        token: UUID? = nil
-    ) {
-        guard var state = confirmedSends[eventID],
-              token == nil || state.token == token,
-              state.awaitingRelays.remove(relayURL) != nil else { return }
-        if accepted {
-            confirmedSends.removeValue(forKey: eventID)
-            state.completion(true)
-        } else if state.awaitingRelays.isEmpty {
-            confirmedSends.removeValue(forKey: eventID)
-            state.completion(false)
-        } else {
-            confirmedSends[eventID] = state
-        }
-    }
-
-    private func timeoutConfirmedSend(eventID: String, token: UUID) {
-        guard let state = confirmedSends[eventID], state.token == token else { return }
-        confirmedSends.removeValue(forKey: eventID)
-        state.completion(false)
-    }
-
     private func enqueuePendingSend(_ event: NostrEvent, pendingRelays: Set<String>) {
         messageQueueLock.lock()
         messageQueue.append(PendingSend(event: event, pendingRelays: pendingRelays))
@@ -765,7 +517,7 @@ final class NostrRelayManager: ObservableObject {
             // SecureLogger.debug("📋 Subscription filter JSON: \(messageString.prefix(200))...", category: .session)
             
             // Target specific relays if provided; else default. Filter permanently failed relays.
-            let baseUrls = relayUrls ?? defaultRelays
+            let baseUrls = relayUrls ?? Self.defaultRelays
             let urls = allowedRelayList(from: baseUrls).filter { !isPermanentlyFailed($0) }
             let requestState = SubscriptionRequestState(messageString: messageString, relayURLs: Set(urls))
             if subscriptionRequestState[id] == requestState, subscriptionStateExists(id: id, requestState: requestState) {
@@ -807,52 +559,41 @@ final class NostrRelayManager: ObservableObject {
     }
 
     private func applyDefaultRelayPolicy(force: Bool = false) {
-        let shouldAllow = hasMutualFavorites || hasLocationPermission || dependencies.isInLocationChannel()
+        let shouldAllow = hasMutualFavorites || hasLocationPermission
         if !force && shouldAllow == allowDefaultRelays { return }
         allowDefaultRelays = shouldAllow
         if shouldAllow {
             var existing = Set(relays.map { $0.url })
-            for url in defaultRelays where !existing.contains(url) {
+            for url in Self.defaultRelays where !existing.contains(url) {
                 relays.append(Relay(url: url))
                 existing.insert(url)
             }
             if dependencies.activationAllowed() {
-                ensureConnections(to: defaultRelays)
+                ensureConnections(to: Self.defaultRelays)
             }
         } else {
-            dropRelays(defaultRelaySet)
-        }
-    }
-
-    /// Closes and forgets a set of relays: connection, inbound pipeline,
-    /// subscriptions, queued sends addressed only to them, and the published row.
-    private func dropRelays(_ urls: Set<String>) {
-        guard !urls.isEmpty else { return }
-        for url in urls {
-            if let connection = connections[url] {
-                connection.cancel(with: .goingAway, reason: nil)
+            for url in Self.defaultRelays {
+                if let connection = connections[url] {
+                    connection.cancel(with: .goingAway, reason: nil)
+                }
+                connections.removeValue(forKey: url)
+                subscriptions.removeValue(forKey: url)
+                pendingSubscriptions.removeValue(forKey: url)
             }
-            connections.removeValue(forKey: url)
-            teardownRelayInboundPipeline(for: url)
-            subscriptions.removeValue(forKey: url)
-            pendingSubscriptions.removeValue(forKey: url)
-        }
-        messageQueueLock.lock()
-        for index in (0..<messageQueue.count).reversed() {
-            var item = messageQueue[index]
-            item.pendingRelays.subtract(urls)
-            if item.pendingRelays.isEmpty {
-                messageQueue.remove(at: index)
-            } else {
-                messageQueue[index] = item
+            messageQueueLock.lock()
+            for index in (0..<messageQueue.count).reversed() {
+                var item = messageQueue[index]
+                item.pendingRelays.subtract(Self.defaultRelaySet)
+                if item.pendingRelays.isEmpty {
+                    messageQueue.remove(at: index)
+                } else {
+                    messageQueue[index] = item
+                }
             }
+            messageQueueLock.unlock()
+            relays.removeAll { Self.defaultRelaySet.contains($0.url) }
+            updateConnectionStatus()
         }
-        messageQueueLock.unlock()
-        // A relay queued while Tor bootstraps would otherwise reconnect when
-        // the queue drains, overriding the explicit removal.
-        pendingTorConnectionURLs.subtract(urls)
-        relays.removeAll { urls.contains($0.url) }
-        updateConnectionStatus()
     }
 
     private func allowedRelayList(from urls: [String]) -> [String] {
@@ -860,7 +601,7 @@ final class NostrRelayManager: ObservableObject {
         var result: [String] = []
         for rawURL in urls {
             guard let url = NostrRelayURL.normalized(rawURL) else { continue }
-            if !allowDefaultRelays && defaultRelaySet.contains(url) { continue }
+            if !allowDefaultRelays && Self.defaultRelaySet.contains(url) { continue }
             if seen.insert(url).inserted {
                 result.append(url)
             }
@@ -1175,18 +916,13 @@ final class NostrRelayManager: ObservableObject {
         
         connections[urlString] = task
         task.resume()
-
-        // Bring up this relay's own serial verify pipeline before arming the
-        // socket, so inbound frames have somewhere to land.
-        ensureRelayInboundPipeline(for: urlString)
-
+        
         // Start receiving messages
         receiveMessage(from: task, relayUrl: urlString)
         
         // Send initial ping to verify connection
         task.sendPing { [weak self] error in
             DispatchQueue.main.async {
-                guard self?.connections[urlString] === task else { return }
                 if error == nil {
                     SecureLogger.debug("✅ Connected to Nostr relay: \(urlString)", category: .session)
                     self?.updateRelayStatus(urlString, isConnected: true)
@@ -1196,11 +932,7 @@ final class NostrRelayManager: ObservableObject {
                     SecureLogger.error("❌ Failed to connect to Nostr relay \(urlString): \(error?.localizedDescription ?? "Unknown error")", category: .session)
                     self?.updateRelayStatus(urlString, isConnected: false, error: error)
                     // Trigger disconnection handler for proper backoff
-                    self?.handleDisconnection(
-                        relayUrl: urlString,
-                        error: error ?? NSError(domain: "NostrRelay", code: -1, userInfo: nil),
-                        connection: task
-                    )
+                    self?.handleDisconnection(relayUrl: urlString, error: error ?? NSError(domain: "NostrRelay", code: -1, userInfo: nil))
                 }
             }
         }
@@ -1254,23 +986,22 @@ final class NostrRelayManager: ObservableObject {
             
             switch result {
             case .success(let message):
-                // Hand the raw frame to this relay's serial inbound pipeline:
-                // parsing and signature verification run off-main, in arrival
-                // order, independently of every other relay's pipeline. Routing
-                // through the lock-guarded router keeps this off the main actor
-                // (no per-frame main hop).
-                self.inboundRouter.yield(InboundFrame(message: message), to: relayUrl)
-
-
+                // Parse off-main to reduce UI jank, then hop back for state updates
+                Task.detached(priority: .utility) {
+                    guard let parsed = ParsedInbound(message) else { return }
+                    await MainActor.run {
+                        self.handleParsedMessage(parsed, from: relayUrl)
+                    }
+                }
+                
                 // Continue receiving
                 Task { @MainActor in
-                    guard self.connections[relayUrl] === task else { return }
                     self.receiveMessage(from: task, relayUrl: relayUrl)
                 }
                 
             case .failure(let error):
                 DispatchQueue.main.async {
-                    self.handleDisconnection(relayUrl: relayUrl, error: error, connection: task)
+                    self.handleDisconnection(relayUrl: relayUrl, error: error)
                 }
             }
         }
@@ -1280,55 +1011,35 @@ final class NostrRelayManager: ObservableObject {
     // Note: declared at file scope below to avoid MainActor isolation inside this class
     // and keep parsing off the main actor.
 
-    /// First main-actor hop for an inbound EVENT: per-relay stats plus a cheap
-    /// duplicate LOOKUP (no recording) so duplicate fan-in from multiple
-    /// relays never pays for Schnorr verification. Recording happens only
-    /// after the signature verifies (`deliverVerifiedInboundEvent`), so a
-    /// forged-signature copy can never poison the dedup cache and suppress
-    /// the genuine event.
-    private func precheckInboundEvent(subscriptionID: String, eventID: String, relayUrl: String) -> Bool {
-        if let index = relays.firstIndex(where: { $0.url == relayUrl }) {
-            relays[index].messagesReceived += 1
-        }
-        guard !eventID.isEmpty else { return true }
-        let key = InboundEventKey(subscriptionID: subscriptionID, eventID: eventID)
-        if recentInboundEventKeys.contains(key) {
-            recordDuplicateInboundEventDrop(subscriptionID: subscriptionID)
-            return false
-        }
-        return true
-    }
-
-    /// Second main-actor hop, after off-main signature verification:
-    /// authoritative check-and-record (the serial pipeline means the same
-    /// event is never in flight twice, but the record must stay atomic with
-    /// delivery) and handler dispatch.
-    private func deliverVerifiedInboundEvent(subscriptionID subId: String, event: NostrEvent, from relayUrl: String) {
-        guard shouldDeliverInboundEvent(subscriptionID: subId, eventID: event.id) else {
-            return
-        }
-        if event.kind != 1059 {
-            // Per-event logging floods dev builds in busy geohashes; sample it.
-            inboundEventLogCount += 1
-            if inboundEventLogCount == 1 || inboundEventLogCount.isMultiple(of: TransportConfig.nostrInboundEventLogInterval) {
-                SecureLogger.debug("📥 Event #\(inboundEventLogCount) kind=\(event.kind) id=\(event.id.prefix(16))… relay=\(relayUrl)", category: .session)
-            }
-        }
-        if let handler = self.messageHandlers[subId] {
-            handler(event)
-        } else {
-            SecureLogger.warning("⚠️ No handler for subscription \(subId)", category: .session)
-        }
-    }
-
-    // Handle parsed non-EVENT messages on MainActor (state updates and handlers)
+    // Handle parsed message on MainActor (state updates and handlers)
     private func handleParsedMessage(_ parsed: ParsedInbound, from relayUrl: String) {
         switch parsed {
-        case .event:
-            // Events flow through the serial inbound pipeline (precheck →
-            // off-main signature verification → deliverVerifiedInboundEvent)
-            // and never reach this fallback.
-            assertionFailure("inbound EVENT bypassed the verified pipeline")
+        case .event(let subId, let event):
+            if let index = self.relays.firstIndex(where: { $0.url == relayUrl }) {
+                self.relays[index].messagesReceived += 1
+            }
+            guard event.isValidSignature() else {
+                SecureLogger.warning(
+                    "⚠️ Dropped invalid Nostr event id=\(event.id.prefix(16))… sub=\(subId) relay=\(relayUrl)",
+                    category: .session
+                )
+                return
+            }
+            guard shouldDeliverInboundEvent(subscriptionID: subId, eventID: event.id) else {
+                return
+            }
+            if event.kind != 1059 {
+                // Per-event logging floods dev builds in busy geohashes; sample it.
+                inboundEventLogCount += 1
+                if inboundEventLogCount == 1 || inboundEventLogCount.isMultiple(of: TransportConfig.nostrInboundEventLogInterval) {
+                    SecureLogger.debug("📥 Event #\(inboundEventLogCount) kind=\(event.kind) id=\(event.id.prefix(16))… relay=\(relayUrl)", category: .session)
+                }
+            }
+            if let handler = self.messageHandlers[subId] {
+                handler(event)
+            } else {
+                SecureLogger.warning("⚠️ No handler for subscription \(subId)", category: .session)
+            }
         case .eose(let subId):
             if var tracker = eoseTrackers[subId] {
                 // An EOSE proves the relay received the REQ even if the local
@@ -1344,7 +1055,6 @@ final class NostrRelayManager: ObservableObject {
                 }
             }
         case .ok(let eventId, let success, let reason):
-            resolveConfirmedSend(eventID: eventId, relayURL: relayUrl, accepted: success)
             if success {
                 _ = Self.pendingGiftWrapIDs.remove(eventId)
                 SecureLogger.debug("✅ Accepted id=\(eventId.prefix(16))… relay=\(relayUrl)", category: .session)
@@ -1361,12 +1071,7 @@ final class NostrRelayManager: ObservableObject {
         }
     }
     
-    private func sendToRelay(
-        event: NostrEvent,
-        connection: NostrRelayConnectionProtocol,
-        relayUrl: String,
-        completion: ((Bool) -> Void)? = nil
-    ) {
+    private func sendToRelay(event: NostrEvent, connection: NostrRelayConnectionProtocol, relayUrl: String) {
         let req = NostrRequest.event(event)
         
         do {
@@ -1379,20 +1084,17 @@ final class NostrRelayManager: ObservableObject {
                 DispatchQueue.main.async {
                     if let error = error {
                         SecureLogger.error("❌ Failed to send event to \(relayUrl): \(error)", category: .session)
-                        completion?(false)
                     } else {
                         // SecureLogger.debug("✅ Event sent to relay: \(relayUrl)", category: .session)
                         // Update relay stats
                         if let index = self?.relays.firstIndex(where: { $0.url == relayUrl }) {
                             self?.relays[index].messagesSent += 1
                         }
-                        completion?(true)
                     }
                 }
             }
         } catch {
             SecureLogger.error("Failed to encode event: \(error)", category: .session)
-            completion?(false)
         }
     }
     
@@ -1418,7 +1120,7 @@ final class NostrRelayManager: ObservableObject {
         isConnected = relays.contains { $0.isConnected }
         // Relay URLs are normalized before entries are created, so direct
         // set membership is sound.
-        isDMRelayConnected = relays.contains { $0.isConnected && defaultRelaySet.contains($0.url) }
+        isDMRelayConnected = relays.contains { $0.isConnected && Self.defaultRelaySet.contains($0.url) }
     }
     
     /// A relay that drops before sending EOSE must not stall initial-load
@@ -1456,21 +1158,9 @@ final class NostrRelayManager: ObservableObject {
         eoseTrackers[id] = tracker
     }
 
-    private func handleDisconnection(
-        relayUrl: String,
-        error: Error,
-        connection: NostrRelayConnectionProtocol? = nil
-    ) {
-        if let connection, connections[relayUrl] !== connection { return }
+    private func handleDisconnection(relayUrl: String, error: Error) {
         connections.removeValue(forKey: relayUrl)
-        teardownRelayInboundPipeline(for: relayUrl)
         subscriptions.removeValue(forKey: relayUrl)
-        let awaitingConfirmation = confirmedSends.compactMap { eventID, state in
-            state.awaitingRelays.contains(relayUrl) ? eventID : nil
-        }
-        for eventID in awaitingConfirmation {
-            resolveConfirmedSend(eventID: eventID, relayURL: relayUrl, accepted: false)
-        }
         updateRelayStatus(relayUrl, isConnected: false, error: error)
         settleEOSETrackers(droppingRelay: relayUrl)
         // If networking is disallowed, do not schedule reconnection
@@ -1558,9 +1248,8 @@ final class NostrRelayManager: ObservableObject {
         if let connection = connections[normalizedRelayUrl] {
             connection.cancel(with: .goingAway, reason: nil)
             connections.removeValue(forKey: normalizedRelayUrl)
-            teardownRelayInboundPipeline(for: normalizedRelayUrl)
         }
-
+        
         // Attempt immediate reconnection
         connectToRelay(normalizedRelayUrl)
     }
@@ -1653,77 +1342,6 @@ final class NostrRelayManager: ObservableObject {
 
 // MARK: - Off-main inbound parsing helpers (file scope, non-isolated)
 
-/// A single raw socket frame awaiting off-main parse + Schnorr verification.
-private struct InboundFrame: Sendable {
-    let message: URLSessionWebSocketTask.Message
-}
-
-/// Lock-guarded registry of per-relay inbound streams.
-///
-/// The raw WebSocket receive callback is not main-actor isolated, so it needs a
-/// `Sendable` path to route a frame to the correct relay's stream without a
-/// per-frame hop onto the main actor. Pipeline lifecycle (start/finish) is
-/// driven from the main actor; frame delivery (`yield`) can come from any
-/// thread. All access is serialized by a single lock — contention is negligible
-/// because the guarded critical section is only a dictionary lookup + yield.
-private final class InboundFrameRouter: @unchecked Sendable {
-    private let lock = NSLock()
-    private var continuations: [String: AsyncStream<InboundFrame>.Continuation] = [:]
-    private var tasks: [String: Task<Void, Never>] = [:]
-
-    /// Start a relay's stream + consumer if one does not already exist.
-    /// Returns true when a new pipeline was created. The bounded
-    /// `.bufferingNewest` policy makes a single relay shed its OWN oldest
-    /// frames under a flood, never other relays' frames. Buffered memory per
-    /// relay is bounded (not eliminated) at the frame cap times the per-frame
-    /// byte cap (`maximumMessageSize`) — see TransportConfig.
-    func startPipeline(
-        for relayUrl: String,
-        makeConsumer: (AsyncStream<InboundFrame>) -> Task<Void, Never>
-    ) -> Bool {
-        lock.lock()
-        defer { lock.unlock() }
-        if continuations[relayUrl] != nil { return false }
-        let (stream, continuation) = AsyncStream<InboundFrame>.makeStream(
-            bufferingPolicy: .bufferingNewest(TransportConfig.nostrInboundPerRelayBufferCap)
-        )
-        continuations[relayUrl] = continuation
-        tasks[relayUrl] = makeConsumer(stream)
-        return true
-    }
-
-    /// Route a frame to a relay's stream. No-op if the relay has no live
-    /// pipeline (socket already torn down) — the frame is simply dropped, which
-    /// is safe for best-effort Nostr inbound.
-    func yield(_ frame: InboundFrame, to relayUrl: String) {
-        lock.lock()
-        let continuation = continuations[relayUrl]
-        lock.unlock()
-        continuation?.yield(frame)
-    }
-
-    /// Finish a relay's stream. The consumer drains any already-buffered frames
-    /// before exiting, so in-flight verified events are still delivered.
-    func finishPipeline(for relayUrl: String) {
-        lock.lock()
-        let continuation = continuations.removeValue(forKey: relayUrl)
-        tasks.removeValue(forKey: relayUrl)
-        lock.unlock()
-        continuation?.finish()
-    }
-
-    func finishAll() {
-        lock.lock()
-        let allContinuations = continuations
-        continuations.removeAll()
-        tasks.removeAll()
-        lock.unlock()
-        for continuation in allContinuations.values {
-            continuation.finish()
-        }
-    }
-}
-
 private enum ParsedInbound {
     case event(subId: String, event: NostrEvent)
     case ok(eventId: String, success: Bool, reason: String)
@@ -1731,7 +1349,7 @@ private enum ParsedInbound {
     case notice(String)
     
     init?(_ message: URLSessionWebSocketTask.Message) {
-        guard let data = message.dataWithinInboundLimit,
+        guard let data = message.data,
               let array = try? JSONSerialization.jsonObject(with: data) as? [Any],
               array.count >= 2,
               let type = array[0] as? String else {
@@ -1776,19 +1394,11 @@ private enum ParsedInbound {
 }
 
 private extension URLSessionWebSocketTask.Message {
-    /// Prefer rejecting oversized frames before UTF-8/Data materialization
-    /// where we can (string length), and always before JSON parse.
-    var dataWithinInboundLimit: Data? {
-        let maxBytes = TransportConfig.nostrMaxInboundMessageBytes
+    var data: Data? {
         switch self {
-        case .string(let text):
-            guard text.utf8.count <= maxBytes else { return nil }
-            return text.data(using: .utf8)
-        case .data(let data):
-            guard data.count <= maxBytes else { return nil }
-            return data
-        @unknown default:
-            return nil
+        case .string(let text): text.data(using: .utf8)
+        case .data(let data):   data
+        @unknown default:       nil
         }
     }
 }

bitchat/Nostr/NostrRelaySettings.swift

@@ -1,92 +0,0 @@
-//
-// NostrRelaySettings.swift
-// bitchat
-//
-// This is free and unencumbered software released into the public domain.
-// For more information, see <https://unlicense.org>
-//
-
-import BitLogger
-import Foundation
-
-/// Relays someone has added by hand, alongside the built-in set.
-///
-/// The built-in relays are four well-known clearnet hostnames, so a censor
-/// blocking four names ends internet-delivered private messages for everyone.
-/// Adding relays — including `.onion` addresses, or a relay run by whoever
-/// needs it — is the escape hatch that does not require shipping a new build.
-///
-/// Stored normalized so comparisons against connection keys and the built-in
-/// set are exact, and bounded so a long list cannot turn every send into a
-/// fan-out across dozens of sockets.
-enum NostrRelaySettings {
-    /// Enough to add a personal relay, an onion address, and a couple of
-    /// regional fallbacks without letting the connection fan-out grow unbounded.
-    static let maxCustomRelays = 8
-
-    private static let storageKey = "nostr.customRelays"
-
-    static let didChangeNotification = Notification.Name("bitchat.nostrRelaySettingsDidChange")
-
-    enum AddFailure: Error, Equatable {
-        case malformed
-        case alreadyPresent
-        case limitReached
-    }
-
-    /// Normalized relay URLs, in the order they were added.
-    static func customRelays(in defaults: UserDefaults = .standard) -> [String] {
-        let stored = defaults.stringArray(forKey: storageKey) ?? []
-        // Re-normalize on read: a value written by an older build, or edited
-        // outside the app, must not reach the connection layer unchecked.
-        var seen = Set<String>()
-        return stored.compactMap { NostrRelayURL.normalized($0) }
-            .filter { seen.insert($0).inserted }
-    }
-
-    /// Adds a relay, returning the normalized URL or why it was rejected.
-    @discardableResult
-    static func add(
-        _ rawValue: String,
-        builtIn: Set<String>,
-        in defaults: UserDefaults = .standard
-    ) -> Result<String, AddFailure> {
-        // Bare hostnames are the common way people quote a relay, and wss is
-        // the only sensible assumption for one.
-        guard let normalized = NostrRelayURL.normalized(rawValue, defaultScheme: "wss") else {
-            return .failure(.malformed)
-        }
-
-        var current = customRelays(in: defaults)
-        guard !current.contains(normalized), !builtIn.contains(normalized) else {
-            return .failure(.alreadyPresent)
-        }
-        guard current.count < maxCustomRelays else {
-            return .failure(.limitReached)
-        }
-
-        current.append(normalized)
-        write(current, in: defaults)
-        return .success(normalized)
-    }
-
-    static func remove(_ url: String, in defaults: UserDefaults = .standard) {
-        // Same default scheme as `add`, so a relay entered as a bare hostname
-        // can be removed the way it was typed.
-        guard let normalized = NostrRelayURL.normalized(url, defaultScheme: "wss") else { return }
-        let remaining = customRelays(in: defaults).filter { $0 != normalized }
-        write(remaining, in: defaults)
-    }
-
-    /// Panic-wipe hook: an added relay names somewhere someone chose to route
-    /// through, which is exactly the kind of trace a wipe should not leave.
-    static func reset(in defaults: UserDefaults = .standard) {
-        defaults.removeObject(forKey: storageKey)
-        NotificationCenter.default.post(name: didChangeNotification, object: nil)
-    }
-
-    private static func write(_ relays: [String], in defaults: UserDefaults) {
-        defaults.set(relays, forKey: storageKey)
-        NotificationCenter.default.post(name: didChangeNotification, object: nil)
-    }
-}

bitchat/Nostr/NostrRelayURL.swift

@@ -39,4 +39,13 @@ enum NostrRelayURL {
 
         return components.string
     }
+
+    static func directoryAddress(_ rawValue: String) -> String? {
+        guard var normalized = normalized(rawValue, defaultScheme: "wss") else { return nil }
+        for prefix in ["wss://", "ws://"] where normalized.hasPrefix(prefix) {
+            normalized.removeFirst(prefix.count)
+            break
+        }
+        return normalized
+    }
 }

bitchat/PrivacyInfo.xcprivacy

@@ -1,41 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
-<plist version="1.0">
-<dict>
-	<key>NSPrivacyTracking</key>
-	<false/>
-	<key>NSPrivacyTrackingDomains</key>
-	<array/>
-	<key>NSPrivacyCollectedDataTypes</key>
-	<array/>
-	<key>NSPrivacyAccessedAPITypes</key>
-	<array>
-		<dict>
-			<key>NSPrivacyAccessedAPIType</key>
-			<string>NSPrivacyAccessedAPICategoryFileTimestamp</string>
-			<key>NSPrivacyAccessedAPITypeReasons</key>
-			<array>
-				<string>C617.1</string>
-				<string>3B52.1</string>
-			</array>
-		</dict>
-		<dict>
-			<key>NSPrivacyAccessedAPIType</key>
-			<string>NSPrivacyAccessedAPICategorySystemBootTime</string>
-			<key>NSPrivacyAccessedAPITypeReasons</key>
-			<array>
-				<string>35F9.1</string>
-			</array>
-		</dict>
-		<dict>
-			<key>NSPrivacyAccessedAPIType</key>
-			<string>NSPrivacyAccessedAPICategoryUserDefaults</string>
-			<key>NSPrivacyAccessedAPITypeReasons</key>
-			<array>
-				<string>CA92.1</string>
-				<string>1C8F.1</string>
-			</array>
-		</dict>
-	</array>
-</dict>
-</plist>

bitchat/Protocols/BitchatFilePacket.swift

@@ -154,90 +154,3 @@ struct BitchatFilePacket {
         )
     }
 }
-
-/// Wire-compatible identity for private media exchanged by clients using the
-/// current iOS entropy-bearing filenames, without extending the deployed file
-/// TLV. Android clients reject unknown file tags, so eligible senders and
-/// receivers derive the receipt key from fields already on the wire.
-///
-/// Locally-created image and voice-note filenames contain a UUID or live-voice
-/// burst ID. Including the normalized direction keeps a reused filename
-/// distinct across chats while allowing short and full Noise-key peer IDs to
-/// converge. Android and older-iOS timestamp-only names remain ineligible and
-/// retain their legacy random local IDs (transfer-compatible, no receipts).
-enum PrivateMediaMessageIdentity {
-    private static let domain = Data("bitchat-private-media-message-v1".utf8)
-    private static let idPrefix = "media-"
-    private static let digestHexLength = 32
-
-    static func isStableID(_ candidate: String) -> Bool {
-        guard candidate.hasPrefix(idPrefix) else { return false }
-        let digest = candidate.dropFirst(idPrefix.count)
-        guard digest.utf8.count == digestHexLength else { return false }
-        return digest.utf8.allSatisfy { byte in
-            (UInt8(ascii: "0")...UInt8(ascii: "9")).contains(byte)
-                || (UInt8(ascii: "a")...UInt8(ascii: "f")).contains(byte)
-        }
-    }
-
-    static func stableID(
-        senderPeerID: PeerID,
-        recipientPeerID: PeerID,
-        fileName: String?
-    ) -> String? {
-        guard let fileName, !fileName.isEmpty else { return nil }
-        let leafName = (fileName as NSString).lastPathComponent
-        guard leafName == fileName else { return nil }
-
-        let path = leafName as NSString
-        let stem = path.deletingPathExtension
-        let fileExtension = path.pathExtension.lowercased()
-        switch true {
-        case stem.hasPrefix("img_"):
-            guard fileExtension == "jpg" || fileExtension == "jpeg" else { return nil }
-        case stem.hasPrefix("voice_"):
-            guard fileExtension == "m4a" else { return nil }
-        default:
-            return nil
-        }
-        let entropyToken = stem.split(separator: "_").last.map(String.init)
-        let hasUUIDEntropy = entropyToken.flatMap(UUID.init(uuidString:)) != nil
-        let voiceBurstID = stem.hasPrefix("voice_")
-            ? String(stem.dropFirst("voice_".count))
-            : ""
-        let hasBurstEntropy = voiceBurstID.count == 16
-            && voiceBurstID.allSatisfy(\.isHexDigit)
-        guard hasUUIDEntropy || hasBurstEntropy else {
-            return nil
-        }
-
-        let fields = [
-            Data(senderPeerID.toShort().bare.utf8),
-            Data(recipientPeerID.toShort().bare.utf8),
-            Data(leafName.utf8)
-        ]
-        var input = domain
-        for field in fields {
-            guard let length = UInt32(exactly: field.count) else { return nil }
-            var bigEndianLength = length.bigEndian
-            withUnsafeBytes(of: &bigEndianLength) {
-                input.append(contentsOf: $0)
-            }
-            input.append(field)
-        }
-
-        return "\(idPrefix)\(input.sha256Hex().prefix(digestHexLength))"
-    }
-
-    static func stableID(
-        for packet: BitchatFilePacket,
-        senderPeerID: PeerID,
-        recipientPeerID: PeerID
-    ) -> String? {
-        stableID(
-            senderPeerID: senderPeerID,
-            recipientPeerID: recipientPeerID,
-            fileName: packet.fileName
-        )
-    }
-}

bitchat/Protocols/BitchatProtocol.swift

@@ -38,15 +38,11 @@
 /// 7. **Decoding**: Binary data parsed back to message objects
 ///
 /// ## Security Considerations
-/// - Noise frames are padded (to 256/512/1024/2048-byte blocks) to obscure
-///   content length; other packet types are not padded, so their payload
-///   length is observable
+/// - Message padding (to 256/512/1024/2048-byte blocks) obscures actual content length
 /// - Randomized relay jitter reduces the traffic-analysis signal; there is no
 ///   cover traffic or per-message timing obfuscation
 /// - Integration with Noise Protocol for E2E encryption
-/// - The 8-byte sender ID in every header IS a persistent identifier: it is
-///   derived from the long-lived Noise static key and rotates only on a panic
-///   wipe. Treat headers as linkable across sessions.
+/// - No persistent identifiers in protocol headers
 ///
 /// ## Message Types
 /// - **Announce/Leave**: Peer presence notifications
@@ -83,35 +79,12 @@ enum NoisePayloadType: UInt8 {
     case groupKeyUpdate = 0x07      // Creator-signed group state (key rotation / roster update)
     // Live voice (push-to-talk)
     case voiceFrame = 0x08          // One live voice-burst packet (see VoiceBurstPacket)
-    // Finalized private media. `0x20` is the value already deployed by the
-    // Android client. The complete BitchatFilePacket is encrypted inside
-    // Noise before the outer noiseEncrypted packet is fragmented.
-    case privateFile = 0x20
-    // Versioned peer state authenticated by the surrounding Noise session.
-    // This is intentionally distinct from the public announce: announce
-    // capabilities are discovery hints, while this payload proves possession
-    // of the advertised Noise static key before downgrade state is pinned.
-    case authenticatedPeerState = 0x21
     // Verification (QR-based OOB binding)
     case verifyChallenge = 0x10     // Verification challenge
     case verifyResponse  = 0x11     // Verification response
     // Transitive verification (web of trust)
     case vouch = 0x12               // Batch of vouch attestations
 
-    /// #1434 briefly used 0x09 before release. Accept it while prerelease
-    /// builds age out, but never emit it. Decoders canonicalize both values to
-    /// `.privateFile` so the compatibility alias cannot leak into app logic.
-    static let prereleasePrivateFileRawValue: UInt8 = 0x09
-
-    static func decoded(rawValue: UInt8) -> NoisePayloadType? {
-        rawValue == prereleasePrivateFileRawValue ? .privateFile : Self(rawValue: rawValue)
-    }
-
-    static func isPrivateFile(rawValue: UInt8?) -> Bool {
-        guard let rawValue else { return false }
-        return rawValue == privateFile.rawValue || rawValue == prereleasePrivateFileRawValue
-    }
-
     var description: String {
         switch self {
         case .privateMessage: return "privateMessage"
@@ -120,8 +93,6 @@ enum NoisePayloadType: UInt8 {
         case .groupInvite: return "groupInvite"
         case .groupKeyUpdate: return "groupKeyUpdate"
         case .voiceFrame: return "voiceFrame"
-        case .privateFile: return "privateFile"
-        case .authenticatedPeerState: return "authenticatedPeerState"
         case .verifyChallenge: return "verifyChallenge"
         case .verifyResponse: return "verifyResponse"
         case .vouch: return "vouch"

bitchat/Protocols/MeshMessageIdentity.swift

@@ -1,32 +0,0 @@
-//
-// MeshMessageIdentity.swift
-// bitchat
-//
-// This is free and unencumbered software released into the public domain.
-// For more information, see <https://unlicense.org>
-//
-
-import BitFoundation
-import Foundation
-
-/// Content-derived identity for public mesh messages.
-///
-/// The BLE wire carries no message ID for public broadcasts, so every device
-/// recomputes the same stable ID from the signed wire fields (sender ID,
-/// millisecond timestamp, content). That gives the mesh bridge a
-/// cross-device-consistent radio identity with zero wire change. Bridge events
-/// carry this value only as a hint for detecting a radio copy that is already
-/// present: sender/timestamp/content are public, so a different Nostr signer
-/// can copy them and must never be allowed to reserve the genuine event's
-/// authenticated dedup slot.
-enum MeshMessageIdentity {
-    /// Matches the wire truncation in `BLEService.sendMessage`.
-    static func millisecondTimestamp(_ date: Date) -> UInt64 {
-        UInt64(date.timeIntervalSince1970 * 1000)
-    }
-
-    static func stableID(senderIDHex: String, timestampMs: UInt64, content: String) -> String {
-        let input = senderIDHex.lowercased() + "|" + String(timestampMs) + "|" + content.trimmed
-        return String(Data(input.utf8).sha256Hex().prefix(32))
-    }
-}

bitchat/Protocols/Packets.swift

@@ -156,89 +156,6 @@ struct AnnouncementPacket {
     }
 }
 
-/// State that is authoritative only because it is carried inside an
-/// established Noise session. The public announce remains useful for
-/// discovery, but its self-signature cannot prove possession of the copied
-/// Noise public key it contains.
-///
-/// Wire format (v1):
-/// `[version=0x01][type][length][value]...`
-/// - TLV `0x01`: canonical minimal little-endian `PeerCapabilities`
-/// - TLV `0x02`: 32-byte Ed25519 signing public key
-///
-/// Unknown TLVs are skipped for forward compatibility. Unknown versions,
-/// duplicates, non-canonical capability fields, and malformed lengths are
-/// rejected without changing authenticated state.
-struct AuthenticatedPeerStatePacket: Equatable {
-    static let currentVersion: UInt8 = 1
-    static let signingPublicKeyLength = 32
-
-    let capabilities: PeerCapabilities
-    let signingPublicKey: Data
-
-    private enum TLVType: UInt8 {
-        case capabilities = 0x01
-        case signingPublicKey = 0x02
-    }
-
-    func encode() -> Data? {
-        guard signingPublicKey.count == Self.signingPublicKeyLength else { return nil }
-        let capabilityBytes = capabilities.encoded()
-        guard !capabilityBytes.isEmpty, capabilityBytes.count <= 8 else { return nil }
-
-        var data = Data([Self.currentVersion])
-        data.append(TLVType.capabilities.rawValue)
-        data.append(UInt8(capabilityBytes.count))
-        data.append(capabilityBytes)
-        data.append(TLVType.signingPublicKey.rawValue)
-        data.append(UInt8(signingPublicKey.count))
-        data.append(signingPublicKey)
-        return data
-    }
-
-    static func decode(from data: Data) -> AuthenticatedPeerStatePacket? {
-        guard data.first == Self.currentVersion else { return nil }
-
-        var offset = 1
-        var capabilities: PeerCapabilities?
-        var signingPublicKey: Data?
-
-        while offset < data.count {
-            guard offset + 2 <= data.count else { return nil }
-            let typeRaw = data[offset]
-            let length = Int(data[offset + 1])
-            offset += 2
-            guard offset + length <= data.count else { return nil }
-            let value = Data(data[offset..<(offset + length)])
-            offset += length
-
-            guard let type = TLVType(rawValue: typeRaw) else {
-                continue
-            }
-            switch type {
-            case .capabilities:
-                guard capabilities == nil,
-                      !value.isEmpty,
-                      value.count <= 8 else { return nil }
-                let decoded = PeerCapabilities(encoded: value)
-                guard decoded.encoded() == value else { return nil }
-                capabilities = decoded
-
-            case .signingPublicKey:
-                guard signingPublicKey == nil,
-                      value.count == Self.signingPublicKeyLength else { return nil }
-                signingPublicKey = value
-            }
-        }
-
-        guard let capabilities, let signingPublicKey else { return nil }
-        return AuthenticatedPeerStatePacket(
-            capabilities: capabilities,
-            signingPublicKey: signingPublicKey
-        )
-    }
-}
-
 struct PrivateMessagePacket {
     let messageID: String
     let content: String

bitchat/Protocols/PeerCapabilities+Local.swift

@@ -3,11 +3,5 @@ import BitFoundation
 extension PeerCapabilities {
     /// Capabilities this build advertises in its announce packets.
     /// Each feature adds its bit here when it ships.
-    static let localSupported: PeerCapabilities = [
-        .vouch,
-        .prekeys,
-        .groups,
-        .privateMedia,
-        .privateMediaReceipts
-    ]
+    static let localSupported: PeerCapabilities = [.vouch, .prekeys, .groups]
 }

bitchat/Services/AutocompleteService.swift

@@ -55,10 +55,10 @@ final class AutocompleteService {
         
         let fullRange = match.range(at: 0)
         let captureRange = match.range(at: 1)
-        let prefix = nsText.substring(with: captureRange).normalizedNickname.lowercased()
-
+        let prefix = nsText.substring(with: captureRange).lowercased()
+        
         let suggestions = peers
-            .filter { $0.normalizedNickname.lowercased().hasPrefix(prefix) }
+            .filter { $0.lowercased().hasPrefix(prefix) }
             .sorted()
             .prefix(5)
             .map { "@\($0)" }

bitchat/Services/BLE/BLEAnnounceHandler.swift

@@ -14,39 +14,22 @@ struct BLEAnnounceHandlerEnvironment {
     let messageTTL: UInt8
     /// Current time source.
     let now: () -> Date
-    /// Noise and signing public keys already recorded for the peer, if any
-    /// (single registry read so both come from one consistent snapshot).
-    let existingPeerKeys: (PeerID) -> (noisePublicKey: Data?, signingPublicKey: Data?)
-    /// Signing key from the persisted cryptographic identity for the peer, if
-    /// any. Registry pins do not survive app restarts or offline-peer
-    /// eviction; this fallback keeps the TOFU signing-key pin effective for
-    /// returning peers.
-    let persistedSigningPublicKey: (PeerID) -> Data?
-    /// Ed25519 key previously bound to this Noise identity by an authenticated
-    /// peer-state payload, if any (persistent identity-state read).
-    let authenticatedSigningPublicKey: (_ noisePublicKey: Data) -> Data?
+    /// Noise public key already recorded for the peer, if any (registry read).
+    let existingNoisePublicKey: (PeerID) -> Data?
     /// Verifies the packet signature against the announced signing key.
     let verifySignature: (_ packet: BitchatPacket, _ signingPublicKey: Data) -> Bool
     /// Direct link state for the peer (BLE-queue read).
     let linkState: (PeerID) -> (hasPeripheral: Bool, hasCentral: Bool)
-    /// Whether the link this packet arrived on is already bound to a
-    /// different peer ID (ingress-registry + BLE-queue read). Directness
-    /// rides on the unsigned TTL, so a replayed announce can look "direct"
-    /// on the replayer's link; that link must not shortcut an absent peer
-    /// into "connected".
-    let linkBoundToOtherPeer: (_ packet: BitchatPacket, _ peerID: PeerID) -> Bool
     /// Runs the registry mutation phase under the collections barrier.
     let withRegistryBarrier: (() -> Void) -> Void
     /// Upserts the verified announce into the peer registry.
-    /// Returns `nil` when the registry refuses the announce because it carries
-    /// a signing key different from the one already pinned for this peer.
     /// Must only be called from inside `withRegistryBarrier`.
     let upsertVerifiedAnnounce: (
         _ peerID: PeerID,
         _ announcement: AnnouncementPacket,
         _ isConnected: Bool,
         _ now: Date
-    ) -> BLEPeerAnnounceUpdate?
+    ) -> BLEPeerAnnounceUpdate
     /// Debounced reconnect-log decision.
     /// Must only be called from inside `withRegistryBarrier`.
     let shouldEmitReconnectLog: (_ peerID: PeerID, _ now: Date) -> Bool
@@ -126,16 +109,7 @@ final class BLEAnnounceHandler {
         // Suppress announce logs to reduce noise
 
         // Precompute signature verification outside barrier to reduce contention
-        var existingPeerKeys = env.existingPeerKeys(peerID)
-        if existingPeerKeys.signingPublicKey == nil {
-            // The registry entry (and its signing-key pin) is dropped on app
-            // restart and offline-peer eviction, but the persisted
-            // cryptographic identity survives both. Fall back to it so a
-            // returning peer is not treated as first contact — otherwise an
-            // attacker could replay the peer's noiseKey/peerID with their own
-            // signing key and re-pin the identity (TOFU downgrade).
-            existingPeerKeys.signingPublicKey = env.persistedSigningPublicKey(peerID)
-        }
+        let existingNoisePublicKey = env.existingNoisePublicKey(peerID)
         let hasSignature = packet.signature != nil
         let signatureValid: Bool
         if hasSignature {
@@ -149,49 +123,18 @@ final class BLEAnnounceHandler {
         let trustDecision = BLEAnnounceTrustPolicy.evaluate(
             hasSignature: hasSignature,
             signatureValid: signatureValid,
-            existingNoisePublicKey: existingPeerKeys.noisePublicKey,
-            announcedNoisePublicKey: announcement.noisePublicKey,
-            existingSigningPublicKey: existingPeerKeys.signingPublicKey,
-            authenticatedSigningPublicKey: env.authenticatedSigningPublicKey(
-                announcement.noisePublicKey
-            ),
-            announcedSigningPublicKey: announcement.signingPublicKey
+            existingNoisePublicKey: existingNoisePublicKey,
+            announcedNoisePublicKey: announcement.noisePublicKey
         )
         if case .reject(.keyMismatch) = trustDecision {
             SecureLogger.warning("⚠️ Announce key mismatch for \(peerID.id.prefix(8))… — keeping unverified", category: .security)
         }
-        if case .reject(.signingKeyMismatch) = trustDecision {
-            SecureLogger.warning("🚨 Announce signing-key mismatch for \(peerID.id.prefix(8))… — refusing to replace pinned signing key (possible impersonation attempt)", category: .security)
-        }
-        if case .reject(.authenticatedSigningKeyMismatch) = trustDecision {
-            SecureLogger.warning(
-                "⚠️ Announce signing-key replacement rejected for Noise-authenticated peer \(peerID.id.prefix(8))…",
-                category: .security
-            )
-        }
-        var verifiedAnnounce = trustDecision.isVerified
+        let verifiedAnnounce = trustDecision.isVerified
 
         var isNewPeer = false
         var isReconnectedPeer = false
         let directLinkState = env.linkState(peerID)
         let isDirectAnnounce = packet.ttl == env.messageTTL
-        // A "direct" announce arriving on a link that another peer already
-        // owns is either a rotation heal or a replay with its TTL restored;
-        // both are ambiguous, so only the rebind (which containment-checks
-        // the claimed identity) may promote it — never this shortcut.
-        //
-        // Known limitation: denying the shortcut cannot prevent forged
-        // presence outright. A rebind that passes the containment checks
-        // promotes the claimed peer to connected — it must, or a legitimate
-        // rotation on an open link would read as disconnected — so a replay
-        // that wins the rebind (absent victim, cooldown clear) still forges
-        // presence. That residue is presence display only: DMs stay gated on
-        // canDeliverSecurely (no Noise session means retain + courier, see
-        // MessageRouter.sendPrivate). What this check buys: the ambiguous
-        // announce alone never flips presence — forging requires winning the
-        // containment-checked rebind (never steals an identity that owns a
-        // live link; at most one rebind per link per cooldown window).
-        let linkBoundToOtherPeer = isDirectAnnounce && env.linkBoundToOtherPeer(packet, peerID)
 
         env.withRegistryBarrier {
             let hasPeripheralConnection = directLinkState.hasPeripheral
@@ -206,22 +149,12 @@ final class BLEAnnounceHandler {
                 return
             }
 
-            // The registry re-checks the signing-key pin inside the barrier.
-            // The pre-barrier trust check reads the registry outside the
-            // barrier, so this closes the race where two announces for the
-            // same peer are evaluated concurrently.
-            guard let update = env.upsertVerifiedAnnounce(
+            let update = env.upsertVerifiedAnnounce(
                 peerID,
                 announcement,
-                hasPeripheralConnection || hasCentralSubscription || (isDirectAnnounce && !linkBoundToOtherPeer),
+                isDirectAnnounce || hasPeripheralConnection || hasCentralSubscription,
                 now
-            ) else {
-                SecureLogger.warning("🚨 Registry refused announce for \(peerID.id.prefix(8))… — signing key differs from pinned key", category: .security)
-                verifiedAnnounce = false
-                isNewPeer = false
-                isReconnectedPeer = false
-                return
-            }
+            )
             isNewPeer = update.isNewPeer
             isReconnectedPeer = update.wasDisconnected
 

bitchat/Services/BLE/BLEAnnounceHandlingPolicy.swift

@@ -56,8 +56,6 @@ enum BLEAnnounceTrustRejection: Equatable {
     case missingSignature
     case invalidSignature
     case keyMismatch
-    case signingKeyMismatch
-    case authenticatedSigningKeyMismatch
 }
 
 enum BLEAnnounceTrustDecision: Equatable {
@@ -74,34 +72,12 @@ enum BLEAnnounceTrustPolicy {
         hasSignature: Bool,
         signatureValid: Bool,
         existingNoisePublicKey: Data?,
-        announcedNoisePublicKey: Data,
-        existingSigningPublicKey: Data? = nil,
-        authenticatedSigningPublicKey: Data? = nil,
-        announcedSigningPublicKey: Data
+        announcedNoisePublicKey: Data
     ) -> BLEAnnounceTrustDecision {
         if let existingNoisePublicKey, existingNoisePublicKey != announcedNoisePublicKey {
             return .reject(.keyMismatch)
         }
 
-        // Strongest binding first: an Ed25519 key bound to this Noise identity
-        // inside an authenticated Noise session can never be replaced by a
-        // merely self-signed announce.
-        if let authenticatedSigningPublicKey,
-           announcedSigningPublicKey != authenticatedSigningPublicKey {
-            return .reject(.authenticatedSigningKeyMismatch)
-        }
-
-        // TOFU signing-key pinning. The packet signature only proves the
-        // announce is self-consistent — it is verified against the Ed25519 key
-        // carried *inside the same announce*. Since peerIDs derive from the
-        // broadcast (public) noise key, an attacker can replay a victim's
-        // peerID+noiseKey with their own signing key and a valid
-        // self-signature. Once we have bound a signing key to this peer,
-        // refuse to silently replace it.
-        if let existingSigningPublicKey, existingSigningPublicKey != announcedSigningPublicKey {
-            return .reject(.signingKeyMismatch)
-        }
-
         guard hasSignature else {
             return .reject(.missingSignature)
         }

bitchat/Services/BLE/BLEAnnounceThrottle.swift

@@ -1,13 +1,6 @@
 import Foundation
 
-/// Thread-safe announce admission state.
-///
-/// Announce requests originate from the Bluetooth delegate queue, the
-/// concurrent message queue, and the maintenance timer. Keeping the timestamp
-/// behind a lock makes admission and maintenance snapshots atomic when those
-/// request sources race.
-final class BLEAnnounceThrottle: @unchecked Sendable {
-    private let lock = NSLock()
+struct BLEAnnounceThrottle {
     private var lastSent: Date
     private let normalMinimumInterval: TimeInterval
     private let forcedMinimumInterval: TimeInterval
@@ -23,27 +16,16 @@ final class BLEAnnounceThrottle: @unchecked Sendable {
     }
 
     func elapsed(since now: Date) -> TimeInterval {
-        lock.withLock { now.timeIntervalSince(lastSent) }
+        now.timeIntervalSince(lastSent)
     }
 
-    func shouldSend(force: Bool, now: Date) -> Bool {
-        lock.withLock {
-            let minimumInterval = force ? forcedMinimumInterval : normalMinimumInterval
-            guard now.timeIntervalSince(lastSent) >= minimumInterval else {
-                return false
-            }
-
-            lastSent = now
-            return true
+    mutating func shouldSend(force: Bool, now: Date) -> Bool {
+        let minimumInterval = force ? forcedMinimumInterval : normalMinimumInterval
+        guard elapsed(since: now) >= minimumInterval else {
+            return false
         }
-    }
 
-    /// Forgets the last-sent timestamp. A panic rotation calls this so the
-    /// new identity's first announce cannot be swallowed by the old
-    /// identity's throttle debt — otherwise a panic within the forced
-    /// minimum interval of the last announce leaves the rotated identity
-    /// invisible until the next maintenance cycle.
-    func reset() {
-        lock.withLock { lastSent = .distantPast }
+        lastSent = now
+        return true
     }
 }

bitchat/Services/BLE/BLEEngineScheduler.swift

@@ -1,39 +0,0 @@
-import Foundation
-
-/// Schedules deferred engine work: relay jitter, announce delays, protocol
-/// deadlines (ping, capability proof), notification retry backoff, and
-/// fragment pacing.
-///
-/// This is the transport's only source of engine-side delay. Production
-/// wraps the engine queue's `asyncAfter`; tests inject a manually advanced
-/// clock so timer-driven behavior is asserted deterministically instead of
-/// racing the wall clock — product constants used as deadlines are exactly
-/// the hidden-elapsed-deadline flake class the test-timing hygiene rules
-/// exist to contain.
-protocol BLEEngineScheduling: AnyObject {
-    /// Called once by the transport with its engine queue. Scheduled work
-    /// always executes there: deferred bodies touch engine-confined state.
-    func activate(engineQueue: DispatchQueue)
-    /// Runs `work` on the engine queue after `delay`, honoring
-    /// `DispatchWorkItem` cancellation.
-    func schedule(after delay: TimeInterval, execute work: DispatchWorkItem)
-}
-
-extension BLEEngineScheduling {
-    func schedule(after delay: TimeInterval, _ body: @escaping () -> Void) {
-        schedule(after: delay, execute: DispatchWorkItem(block: body))
-    }
-}
-
-/// Production scheduler: a thin veneer over the engine queue.
-final class BLEEngineDispatchScheduler: BLEEngineScheduling {
-    private var queue: DispatchQueue?
-
-    func activate(engineQueue: DispatchQueue) {
-        queue = engineQueue
-    }
-
-    func schedule(after delay: TimeInterval, execute work: DispatchWorkItem) {
-        queue?.asyncAfter(deadline: .now() + delay, execute: work)
-    }
-}

bitchat/Services/BLE/BLEFanoutSelector.swift

@@ -15,10 +15,7 @@ enum BLEFanoutSelector {
         excludedLinks: Set<BLEIngressLinkID> = [],
         peripheralPeerBindings: [String: PeerID] = [:],
         centralPeerBindings: [String: PeerID] = [:],
-        preferredPeripheralPerPeer: [PeerID: String] = [:],
-        collapseDuplicatePeerLinks: Bool = true,
         directedPeerHint: PeerID?,
-        requireDirectPeerLink: Bool = false,
         packetType: UInt8,
         messageID: String
     ) -> BLEFanoutSelection {
@@ -34,14 +31,10 @@ enum BLEFanoutSelector {
                to: directedPeerHint,
                links: rawAllowed,
                peripheralPeerBindings: peripheralPeerBindings,
-               centralPeerBindings: centralPeerBindings,
-               preferredPeripheralPerPeer: preferredPeripheralPerPeer
+               centralPeerBindings: centralPeerBindings
            ) {
             return directedSelection
         }
-        if directedPeerHint != nil, requireDirectPeerLink {
-            return BLEFanoutSelection(peripheralIDs: [], centralIDs: [])
-        }
         if let directedPeerHint,
            hasBoundLink(
                to: directedPeerHint,
@@ -53,20 +46,11 @@ enum BLEFanoutSelector {
             return BLEFanoutSelection(peripheralIDs: [], centralIDs: [])
         }
 
-        // Direct announces are the packet that binds a link to its peer
-        // (BLEService's raw bind and verified rebind). Collapsing them per
-        // peer starves duplicate same-peer links of the announce they need to
-        // become bound — the duplicates then look "pre-announce" forever and
-        // every broadcast sprays down all of them. Announces are small and
-        // throttled, so they go on every live link.
-        let allowed = collapseDuplicatePeerLinks
-            ? collapseDuplicateLinksPerPeer(
-                rawAllowed,
-                peripheralPeerBindings: peripheralPeerBindings,
-                centralPeerBindings: centralPeerBindings,
-                preferredPeripheralPerPeer: preferredPeripheralPerPeer
-            )
-            : rawAllowed
+        let allowed = collapseDuplicateLinksPerPeer(
+            rawAllowed,
+            peripheralPeerBindings: peripheralPeerBindings,
+            centralPeerBindings: centralPeerBindings
+        )
 
         guard shouldSubset(packetType: packetType, directedPeerHint: directedPeerHint) else {
             return BLEFanoutSelection(
@@ -113,8 +97,7 @@ enum BLEFanoutSelector {
         to peerID: PeerID,
         links: (peripheralIDs: [String], centralIDs: [String]),
         peripheralPeerBindings: [String: PeerID],
-        centralPeerBindings: [String: PeerID],
-        preferredPeripheralPerPeer: [PeerID: String]
+        centralPeerBindings: [String: PeerID]
     ) -> BLEFanoutSelection? {
         let directLinks = collapseDuplicateLinksPerPeer(
             (
@@ -122,8 +105,7 @@ enum BLEFanoutSelector {
                 centralIDs: links.centralIDs.filter { centralPeerBindings[$0] == peerID }
             ),
             peripheralPeerBindings: peripheralPeerBindings,
-            centralPeerBindings: centralPeerBindings,
-            preferredPeripheralPerPeer: preferredPeripheralPerPeer
+            centralPeerBindings: centralPeerBindings
         )
 
         guard !directLinks.peripheralIDs.isEmpty || !directLinks.centralIDs.isEmpty else {
@@ -158,8 +140,7 @@ enum BLEFanoutSelector {
     private static func collapseDuplicateLinksPerPeer(
         _ links: (peripheralIDs: [String], centralIDs: [String]),
         peripheralPeerBindings: [String: PeerID],
-        centralPeerBindings: [String: PeerID],
-        preferredPeripheralPerPeer: [PeerID: String]
+        centralPeerBindings: [String: PeerID]
     ) -> (peripheralIDs: [String], centralIDs: [String]) {
         guard !peripheralPeerBindings.isEmpty || !centralPeerBindings.isEmpty else {
             return links
@@ -167,30 +148,13 @@ enum BLEFanoutSelector {
 
         var seenPeers = Set<PeerID>()
         var keptPeripheralIDs: [String] = []
-        // When a peer has several bound peripheral links (duplicate
-        // connections after a restore), collapse onto its preferred one (the
-        // most recently bound) instead of dictionary order — an arbitrary
-        // pick could route a peer's single collapsed copy down a stale link.
         for id in links.peripheralIDs {
-            guard let peer = peripheralPeerBindings[id],
-                  preferredPeripheralPerPeer[peer] == id,
-                  seenPeers.insert(peer).inserted else { continue }
-            keptPeripheralIDs.append(id)
-        }
-        for id in links.peripheralIDs {
-            if let peer = peripheralPeerBindings[id] {
-                if preferredPeripheralPerPeer[peer] == id { continue }
-                if !seenPeers.insert(peer).inserted { continue }
+            if let peer = peripheralPeerBindings[id], !seenPeers.insert(peer).inserted {
+                continue
             }
             keptPeripheralIDs.append(id)
         }
 
-        // Known limitation: centrals collapse in subscription order (oldest
-        // first) — there is no recency signal like the peripheral reverse
-        // map. A central-only peer with duplicate subscriptions rides the
-        // oldest one until the remote side (which owns those connections)
-        // consolidates on its next verified announce (bounded by its
-        // retirement cooldown).
         var keptCentralIDs: [String] = []
         for id in links.centralIDs {
             if let peer = centralPeerBindings[id], !seenPeers.insert(peer).inserted {

bitchat/Services/BLE/BLEFileTransferHandler.swift

@@ -16,8 +16,6 @@ struct BLEFileTransferHandlerEnvironment {
     let peersSnapshot: () -> [PeerID: BLEPeerInfo]
     /// Verifies a packet's signature against a candidate signing key (registry path).
     let verifyPacketSignature: (_ packet: BitchatPacket, _ signingPublicKey: Data) -> Bool
-    /// Local signing key used to authenticate our own gossip-sync replays.
-    let localSigningPublicKey: () -> Data
     /// Resolves a display name from a verified packet signature for peers missing from the registry.
     let signedSenderDisplayName: (_ packet: BitchatPacket, _ peerID: PeerID) -> String?
     /// Tracks the broadcast file packet for gossip sync.
@@ -32,85 +30,10 @@ struct BLEFileTransferHandlerEnvironment {
         _ fallbackExtension: String?,
         _ defaultPrefix: String
     ) -> URL?
-    /// Resolves the durable receiver decision for a stable private-media ID.
-    let privateMediaReceiptState: (
-        _ messageID: String
-    ) -> BLEPrivateMediaReceiptState
-    /// Atomically records a stable private-media ID after the payload save.
-    let commitPrivateMediaFile: (_ messageID: String, _ storedURL: URL) -> Bool
-    /// Rolls back a saved payload when its durable receipt commit fails.
-    let removeIncomingFile: (_ storedURL: URL) -> Void
-    /// Releases the allocator's save-to-UI ownership guard after synchronous
-    /// conversation insertion has completed.
-    let finishIncomingFileDelivery: (_ storedURL: URL) -> Void
-    /// Checks the authenticated sender before any private-media disk work.
-    let isPrivateMediaSenderBlocked: (PeerID) -> Bool
     /// Updates the registry last-seen timestamp for the peer (async barrier write).
     let updatePeerLastSeen: (PeerID) -> Void
-    /// Acknowledges stable private media only after its synchronous
-    /// conversation delivery has completed.
-    let acknowledgePrivateMedia: (_ messageID: String, _ peerID: PeerID) -> Void
-    /// Delivers `.messageReceived` as one main-actor hop while
-    /// `shouldDeliver` remains true before and after the synchronous sink.
-    /// The completion authorizes the stable-media ACK. Finalization runs after
-    /// every delivery attempt, including rejection, so allocator ownership
-    /// cannot leak indefinitely.
-    let deliverMessage: (
-        _ message: BitchatMessage,
-        _ shouldDeliver: @escaping () -> Bool,
-        _ completion: @escaping () -> Void,
-        _ finalization: @escaping (TransportEventDeliveryOutcome) -> Void
-    ) -> Void
-}
-
-/// Process-lifetime reservation cache for stable private-media IDs.
-///
-/// The first arrival reserves its ID before quota enforcement. Concurrent
-/// arrivals remain coalesced in memory, while accepted state is resolved from
-/// the durable ID-to-file ledger so it survives relaunch and becomes retryable
-/// if quota cleanup removed the file.
-private final class PrivateMediaArrivalDeduplicator {
-    enum Reservation {
-        case reserved
-        case pending
-        case accepted(URL)
-        case tombstoned
-        case unavailable
-    }
-
-    private let lock = NSLock()
-    private var pending: Set<String> = []
-
-    func reserve(
-        _ messageID: String,
-        receiptState: () -> BLEPrivateMediaReceiptState
-    ) -> Reservation {
-        lock.lock()
-        defer { lock.unlock() }
-        if pending.contains(messageID) {
-            return .pending
-        }
-
-        switch receiptState() {
-        case .accepted(let existingURL):
-            return .accepted(existingURL)
-        case .tombstoned:
-            return .tombstoned
-        case .unavailable:
-            return .unavailable
-        case .absent:
-            break
-        }
-
-        pending.insert(messageID)
-        return .reserved
-    }
-
-    func finish(_ messageID: String) {
-        lock.lock()
-        defer { lock.unlock() }
-        pending.remove(messageID)
-    }
+    /// Delivers `.messageReceived` to the UI as one main-actor hop.
+    let deliverMessage: (BitchatMessage) -> Void
 }
 
 /// Orchestrates inbound file transfers: self-echo policy, sender display-name
@@ -118,206 +41,61 @@ private final class PrivateMediaArrivalDeduplicator {
 /// and UI delivery.
 final class BLEFileTransferHandler {
     private let environment: BLEFileTransferHandlerEnvironment
-    private let privateMediaArrivals = PrivateMediaArrivalDeduplicator()
 
     init(environment: BLEFileTransferHandlerEnvironment) {
         self.environment = environment
     }
 
-    /// Returns `false` when the raw packet fails sender authentication (or is
-    /// a live self-echo) and must not be relayed onward. Authentication runs
-    /// before the routing decision, so a forged directed packet cannot use a
-    /// node that is not its recipient as an unsigned forwarding hop.
+    /// Returns `false` when the packet fails sender authentication and must
+    /// not be relayed onward. Every other outcome returns `true`: files
+    /// directed to another peer are forwarded untouched, and local-only drops
+    /// (malformed payload, quota, save failure) don't affect multi-hop
+    /// delivery to nodes that may handle them fine.
     @discardableResult
     func handle(_ packet: BitchatPacket, from peerID: PeerID) -> Bool {
         let env = environment
-        let localPeerID = env.localPeerID()
-        let peersSnapshot = env.peersSnapshot()
+        if BLEFileTransferPolicy.isSelfEcho(packet: packet, from: peerID, localPeerID: env.localPeerID()) { return true }
 
-        guard let senderNickname = authenticatedRawSenderNickname(
+        guard let deliveryPlan = BLEFileTransferPolicy.deliveryPlan(packet: packet, localPeerID: env.localPeerID()) else {
+            return true
+        }
+
+        let peersSnapshot = env.peersSnapshot()
+        guard let senderNickname = resolveSenderNickname(
             packet: packet,
             from: peerID,
+            isBroadcast: !deliveryPlan.isPrivateMessage,
             peers: peersSnapshot,
             env: env
         ) else {
-            SecureLogger.warning("🚫 Dropping raw file transfer with missing/invalid signature from \(peerID.id.prefix(8))…", category: .security)
+            SecureLogger.warning("🚫 Dropping file transfer from unverified or unknown peer \(peerID.id.prefix(8))…", category: .security)
             return false
         }
 
-        if BLEFileTransferPolicy.isSelfEcho(packet: packet, from: peerID, localPeerID: localPeerID) {
-            return false
-        }
-
-        guard let deliveryPlan = BLEFileTransferPolicy.deliveryPlan(packet: packet, localPeerID: localPeerID) else {
-            return true
-        }
-
         if deliveryPlan.shouldTrackForSync {
             env.trackPacketSeen(packet)
         }
 
-        _ = storeIncomingPayload(
-            packet.payload,
-            from: peerID,
-            senderNickname: senderNickname,
-            timestamp: Date(timeIntervalSince1970: Double(packet.timestamp) / 1000),
-            isPrivate: deliveryPlan.isPrivateMessage,
-            usesDurableReceipts: false,
-            env: env
-        )
-        // Once authenticated, a local decode/quota/save failure is not proof
-        // that downstream nodes should be denied the valid signed packet.
-        return true
-    }
-
-    /// Accepts a file packet only after it has been authenticated and
-    /// decrypted by the peer's Noise session. The inner packet deliberately
-    /// has no redundant signature: Noise supplies sender authentication and
-    /// confidentiality, while this handler retains the same validation,
-    /// quota, persistence, and UI-delivery behavior as public files.
-    @discardableResult
-    func handlePrivatePayload(_ payload: Data, from peerID: PeerID, timestamp: Date) -> Bool {
-        let env = environment
-        let peers = env.peersSnapshot()
-        let senderNickname = BLEPeerSenderDisplayName.resolveKnownPeer(
-            peerID: peerID,
-            localPeerID: env.localPeerID(),
-            localNickname: env.localNickname(),
-            peers: peers,
-            allowConnectedUnverified: true
-        ) ?? BLEPeerSenderDisplayName.anonymousNickname(for: peerID)
-
-        return storeIncomingPayload(
-            payload,
-            from: peerID,
-            senderNickname: senderNickname,
-            timestamp: timestamp,
-            isPrivate: true,
-            // Every authenticated Noise private-file keeps the stable ID/ACK
-            // contract introduced with capability bit 8. Bit 9 advertises
-            // sender-side automatic retry support; it must not downgrade
-            // prior iOS clients to random IDs or single-check delivery.
-            usesDurableReceipts: true,
-            env: env
-        )
-    }
-
-    private func storeIncomingPayload(
-        _ payload: Data,
-        from peerID: PeerID,
-        senderNickname: String,
-        timestamp: Date,
-        isPrivate: Bool,
-        usesDurableReceipts: Bool,
-        env: BLEFileTransferHandlerEnvironment
-    ) -> Bool {
-
-        let localPeerID = env.localPeerID()
         let filePacket: BitchatFilePacket
         let mime: MimeType
-        switch BLEIncomingFileValidator.validate(payload: payload) {
+        switch BLEIncomingFileValidator.validate(payload: packet.payload) {
         case .success(let acceptance):
             filePacket = acceptance.filePacket
             mime = acceptance.mime
         case .failure(.malformedPayload):
             SecureLogger.error("❌ Failed to decode file transfer payload", category: .session)
-            return false
+            return true
         case .failure(.payloadTooLarge(let bytes)):
             SecureLogger.warning("🚫 Dropping file transfer exceeding size cap (\(bytes) bytes)", category: .security)
-            return false
+            return true
         case .failure(.unsupportedMime(let mimeType, let bytes)):
             SecureLogger.warning("🚫 MIME REJECT: '\(mimeType ?? "<empty>")' not supported. Size=\(bytes)b from \(peerID.id.prefix(8))...", category: .security)
-            return false
+            return true
         case .failure(.magicMismatch(let mime, let bytes, let prefixHex)):
             SecureLogger.warning("🚫 MAGIC REJECT: MIME='\(mime)' size=\(bytes)b prefix=[\(prefixHex)] from \(peerID.id.prefix(8))...", category: .security)
-            return false
-        }
-
-        if isPrivate, env.isPrivateMediaSenderBlocked(peerID) {
-            SecureLogger.debug(
-                "🚫 Dropping private media from blocked peer \(peerID.id.prefix(8))… before disk write",
-                category: .security
-            )
             return true
         }
 
-        let messageID = usesDurableReceipts
-            ? PrivateMediaMessageIdentity.stableID(
-                for: filePacket,
-                senderPeerID: peerID,
-                recipientPeerID: localPeerID
-            )
-            : nil
-        if let messageID {
-            switch privateMediaArrivals.reserve(
-                messageID,
-                receiptState: { env.privateMediaReceiptState(messageID) }
-            ) {
-            case .reserved:
-                break
-            case .pending:
-                // The first arrival has not reached durable storage yet.
-                // Coalesce this retry without ACKing so a failed first save
-                // remains retryable by the sender.
-                SecureLogger.debug(
-                    "📁 Coalesced in-flight private media id=\(messageID.prefix(12))… from \(peerID.id.prefix(8))…",
-                    category: .session
-                )
-                return true
-            case .accepted(let existingFile):
-                env.updatePeerLastSeen(peerID)
-                let message = incomingMessage(
-                    messageID: messageID,
-                    senderNickname: senderNickname,
-                    timestamp: timestamp,
-                    isPrivate: true,
-                    peerID: peerID,
-                    destination: existingFile,
-                    category: storedMediaCategory(
-                        for: existingFile,
-                        fallback: mime.category
-                    ),
-                    env: env
-                )
-                SecureLogger.debug(
-                    "📁 Restored durable private media duplicate id=\(messageID.prefix(12))… from \(peerID.id.prefix(8))… -> \(existingFile.lastPathComponent)",
-                    category: .session
-                )
-                deliverStableMessage(
-                    message,
-                    messageID: messageID,
-                    peerID: peerID,
-                    expectedURL: existingFile,
-                    env: env
-                )
-                return true
-            case .tombstoned:
-                // Explicit deletion is a durable terminal receiver decision.
-                env.updatePeerLastSeen(peerID)
-                env.acknowledgePrivateMedia(messageID, peerID)
-                SecureLogger.debug(
-                    "📁 Dropped explicitly deleted private media id=\(messageID.prefix(12))… from \(peerID.id.prefix(8))…",
-                    category: .session
-                )
-                return true
-            case .unavailable:
-                // Never turn an unreadable ledger into an empty ledger. A
-                // directory-level failure clears on retry; a quarantined
-                // record keeps exactly this ID fail-closed while every other
-                // payload still flows.
-                SecureLogger.warning(
-                    "📁 Withholding private media id=\(messageID.prefix(12))… while durable receipt state is unavailable",
-                    category: .session
-                )
-                return true
-            }
-        }
-        defer {
-            if let messageID {
-                privateMediaArrivals.finish(messageID)
-            }
-        }
-
         // BCH-01-002: Enforce storage quota before saving
         env.enforceStorageQuota(filePacket.content.count)
 
@@ -328,175 +106,82 @@ final class BLEFileTransferHandler {
             mime.defaultExtension,
             mime.category.rawValue
         ) else {
-            return false
+            return true
         }
 
-        if let messageID,
-           !env.commitPrivateMediaFile(messageID, destination) {
-            // A payload without its durable ID mapping cannot safely suppress
-            // a retry after relaunch. Roll it back and withhold UI/ACK.
-            env.removeIncomingFile(destination)
-            return false
-        }
-
-        if isPrivate {
+        if deliveryPlan.isPrivateMessage {
             env.updatePeerLastSeen(peerID)
         }
 
-        let message = incomingMessage(
-            messageID: messageID,
-            senderNickname: senderNickname,
-            timestamp: timestamp,
-            isPrivate: isPrivate,
-            peerID: peerID,
-            destination: destination,
-            category: mime.category,
-            env: env
+        let ts = Date(timeIntervalSince1970: Double(packet.timestamp) / 1000)
+        let message = BitchatMessage(
+            sender: senderNickname,
+            content: "\(mime.category.messagePrefix)\(destination.lastPathComponent)",
+            timestamp: ts,
+            isRelay: false,
+            originalSender: nil,
+            isPrivate: deliveryPlan.isPrivateMessage,
+            recipientNickname: nil,
+            senderPeerID: peerID,
+            // Received messages need an explicit status: BitchatMessage
+            // defaults private messages to .sending, which the media views
+            // render as an in-flight send (empty reveal mask, disabled tap).
+            deliveryStatus: deliveryPlan.isPrivateMessage
+                ? .delivered(to: env.localNickname(), at: ts)
+                : nil
         )
 
         SecureLogger.debug("📁 Stored incoming media from \(peerID.id.prefix(8))… -> \(destination.lastPathComponent)", category: .session)
 
-        if let messageID {
-            deliverStableMessage(
-                message,
-                messageID: messageID,
-                peerID: peerID,
-                expectedURL: destination,
-                env: env
-            )
-        } else {
-            env.deliverMessage(
-                message,
-                { true },
-                {},
-                { outcome in
-                    if outcome == .rejected {
-                        // Raw media has no durable receipt that can redeliver
-                        // it later. Do not leave a newly saved, UI-unowned file
-                        // available for a stale fallback path to misidentify.
-                        env.removeIncomingFile(destination)
-                    } else {
-                        // Plain delegates are invoked without synchronous
-                        // insertion confirmation. Preserve the payload for
-                        // that supported delivery path.
-                        env.finishIncomingFileDelivery(destination)
-                    }
-                }
-            )
-        }
+        env.deliverMessage(message)
         return true
     }
 
-    private func deliverStableMessage(
-        _ message: BitchatMessage,
-        messageID: String,
-        peerID: PeerID,
-        expectedURL: URL,
-        env: BLEFileTransferHandlerEnvironment
-    ) {
-        env.deliverMessage(
-            message,
-            {
-                guard case .accepted(let resolvedURL) =
-                        env.privateMediaReceiptState(messageID) else {
-                    return false
-                }
-                return resolvedURL.standardizedFileURL
-                    == expectedURL.standardizedFileURL
-            },
-            {
-                env.acknowledgePrivateMedia(messageID, peerID)
-            },
-            { _ in
-                env.finishIncomingFileDelivery(expectedURL)
-            }
-        )
-    }
-
-    private func incomingMessage(
-        messageID: String?,
-        senderNickname: String,
-        timestamp: Date,
-        isPrivate: Bool,
-        peerID: PeerID,
-        destination: URL,
-        category: MimeType.Category,
-        env: BLEFileTransferHandlerEnvironment
-    ) -> BitchatMessage {
-        BitchatMessage(
-            id: messageID,
-            sender: senderNickname,
-            content: "\(category.messagePrefix)\(destination.lastPathComponent)",
-            timestamp: timestamp,
-            isRelay: false,
-            originalSender: nil,
-            isPrivate: isPrivate,
-            recipientNickname: nil,
-            senderPeerID: peerID,
-            // Received messages need an explicit status: BitchatMessage
-            // defaults private messages to .sending, which media views render
-            // as an in-flight send.
-            deliveryStatus: isPrivate
-                ? .delivered(to: env.localNickname(), at: timestamp)
-                : nil
-        )
-    }
-
-    /// The durable URL is authoritative during reconstruction. A sender that
-    /// reuses a stable filename with a different MIME type must not change how
-    /// the already-stored payload renders.
-    private func storedMediaCategory(
-        for url: URL,
-        fallback: MimeType.Category
-    ) -> MimeType.Category {
-        let mediaDirectory = url
-            .deletingLastPathComponent()
-            .deletingLastPathComponent()
-            .lastPathComponent
-        switch mediaDirectory {
-        case MimeType.Category.audio.mediaDir:
-            return .audio
-        case MimeType.Category.image.mediaDir:
-            return .image
-        case MimeType.Category.file.mediaDir:
-            return .file
-        default:
-            return fallback
-        }
-    }
-
-    /// Every remaining raw file transfer is signed, regardless of whether it
-    /// is broadcast, addressed to us, or merely passing through. Registry
-    /// signing keys are preferred; persisted identities cover peers that have
-    /// rotated or are not currently present in the registry.
-    private func authenticatedRawSenderNickname(
+    /// Resolves the authenticated display name for a file transfer's sender.
+    ///
+    /// Directed (private) transfers are addressed to us specifically and keep
+    /// the lenient connected-peer path. Broadcast transfers carry an
+    /// attacker-controllable `senderID` exactly like public messages and public
+    /// voice frames — registry membership alone is NOT proof of identity, so a
+    /// valid packet signature from the claimed sender is required before we
+    /// trust it. Without this, a peer that observed a public voice burst could
+    /// spoof a broadcast `voice_<burstID>.m4a` note under the talker's ID and
+    /// overwrite the signature-verified live bubble with attacker audio.
+    private func resolveSenderNickname(
         packet: BitchatPacket,
         from peerID: PeerID,
+        isBroadcast: Bool,
         peers: [PeerID: BLEPeerInfo],
         env: BLEFileTransferHandlerEnvironment
     ) -> String? {
-        guard packet.signature != nil else { return nil }
+        guard isBroadcast else {
+            return BLEPeerSenderDisplayName.resolveKnownPeer(
+                peerID: peerID,
+                localPeerID: env.localPeerID(),
+                localNickname: env.localNickname(),
+                peers: peers,
+                allowConnectedUnverified: true
+            ) ?? env.signedSenderDisplayName(packet, peerID)
+        }
 
-        let localPeerID = env.localPeerID()
-        let candidateKey = peerID == localPeerID
-            ? env.localSigningPublicKey()
-            : peers[peerID]?.signingPublicKey
-        let verifiedWithKnownKey = candidateKey.map {
-            env.verifyPacketSignature(packet, $0)
-        } ?? false
-        let signedDisplayName = verifiedWithKnownKey
-            ? nil
-            : env.signedSenderDisplayName(packet, peerID)
-        guard verifiedWithKnownKey || signedDisplayName != nil else { return nil }
+        // Our own broadcasts replayed back via gossip sync (ttl==0) are
+        // trivially authentic and cannot be verified against the peer registry
+        // or identity cache, so exempt self exactly as `BLEPublicMessageHandler`
+        // does. Verify against the signing key already in the
+        // (synchronously-updated) registry first, then fall back to the
+        // persisted-identity signature lookup for peers not yet cached there.
+        let isSelf = peerID == env.localPeerID()
+        let registrySigningKey = peers[peerID]?.signingPublicKey
+        let verifiedViaRegistry = !isSelf && (registrySigningKey.map { env.verifyPacketSignature(packet, $0) } ?? false)
+        let signedDisplayName = (isSelf || verifiedViaRegistry) ? nil : env.signedSenderDisplayName(packet, peerID)
+        guard isSelf || verifiedViaRegistry || signedDisplayName != nil else { return nil }
 
         return BLEPeerSenderDisplayName.resolveKnownPeer(
             peerID: peerID,
-            localPeerID: localPeerID,
+            localPeerID: env.localPeerID(),
             localNickname: env.localNickname(),
             peers: peers,
-            // The packet signature authenticates the announced peer; the old
-            // connected-but-unsigned leniency is not involved.
-            allowConnectedUnverified: true
-        ) ?? signedDisplayName ?? BLEPeerSenderDisplayName.anonymousNickname(for: peerID)
+            allowConnectedUnverified: false
+        ) ?? signedDisplayName
     }
 }

bitchat/Services/BLE/BLEFragmentAssemblyBuffer.swift

@@ -201,11 +201,8 @@ struct BLEFragmentAssemblyBuffer {
     }
 
     private static func assemblyLimit(for originalType: UInt8) -> Int {
-        if originalType == MessageType.fileTransfer.rawValue
-            || originalType == MessageType.noiseEncrypted.rawValue {
+        if originalType == MessageType.fileTransfer.rawValue {
             // Allow headroom for TLV metadata and binary framing overhead.
-            // A large noiseEncrypted packet can be an E2E-encrypted private
-            // file; its authenticated plaintext is validated after decrypt.
             return FileTransferLimits.maxFramedFileBytes
         }
 

bitchat/Services/BLE/BLEIncomingFileStore.swift

@@ -2,288 +2,17 @@ import BitLogger
 import BitFoundation
 import Foundation
 
-struct PanicRecoveryIntent {
-    let fileMarkerEstablished: Bool
-    let externalMarkerEstablished: Bool
+struct BLEIncomingFileStore {
+    private static let quotaBytes: Int64 = 100 * 1024 * 1024
 
-    var hasDurableMarker: Bool {
-        fileMarkerEstablished || externalMarkerEstablished
-    }
-}
-
-/// Small, dependency-injectable transaction surface used by ChatViewModel.
-/// Production persists the same intent in two independent locations before
-/// any application state is erased. Tests can inject an ephemeral operation
-/// set without touching the developer's Application Support directory.
-struct PanicRecoveryOperations {
-    let isPending: () throws -> Bool
-    let begin: () -> PanicRecoveryIntent
-    let wipeMedia: (PanicRecoveryIntent) throws -> Void
-    let complete: () throws -> Void
-
-    static func ephemeral(
-        wipeMedia: @escaping () throws -> Void = {}
-    ) -> PanicRecoveryOperations {
-        PanicRecoveryOperations(
-            isPending: { false },
-            begin: {
-                PanicRecoveryIntent(
-                    fileMarkerEstablished: false,
-                    externalMarkerEstablished: false
-                )
-            },
-            wipeMedia: { _ in try wipeMedia() },
-            complete: {}
-        )
-    }
-
-    static func live(
-        fileStore: BLEIncomingFileStore = BLEIncomingFileStore(),
-        defaults: UserDefaults = .standard
-    ) -> PanicRecoveryOperations {
-        let defaultsKey = "bitchat.panicResetPending"
-        return PanicRecoveryOperations(
-            isPending: {
-                if defaults.bool(forKey: defaultsKey) {
-                    return true
-                }
-                return try fileStore.isPanicRecoveryPending()
-            },
-            begin: {
-                defaults.set(true, forKey: defaultsKey)
-                let externalMarkerEstablished =
-                    defaults.synchronize()
-                    && defaults.bool(forKey: defaultsKey)
-
-                let fileMarkerEstablished: Bool
-                do {
-                    try fileStore.markPanicRecoveryPending()
-                    fileMarkerEstablished = true
-                } catch {
-                    fileMarkerEstablished = false
-                    SecureLogger.error(
-                        "Failed to persist file panic-recovery marker: \(error)",
-                        category: .security
-                    )
-                }
-
-                return PanicRecoveryIntent(
-                    fileMarkerEstablished: fileMarkerEstablished,
-                    externalMarkerEstablished: externalMarkerEstablished
-                )
-            },
-            wipeMedia: { intent in
-                try fileStore.panicWipe(
-                    hasDurablePendingMarker: intent.hasDurableMarker
-                )
-            },
-            complete: {
-                // Keep the independent defaults latch until the file marker
-                // has definitely cleared. Any failure therefore remains
-                // visible to the next launch.
-                try fileStore.completePanicRecovery()
-                defaults.removeObject(forKey: defaultsKey)
-                guard defaults.synchronize(),
-                      !defaults.bool(forKey: defaultsKey) else {
-                    throw BLEIncomingFileStore.PanicRecoveryError
-                        .externalMarkerCommitFailed
-                }
-            }
-        )
-    }
-}
-
-struct BLEIncomingFileStore: @unchecked Sendable {
-    enum PanicRecoveryError: Error {
-        case externalMarkerCommitFailed
-        case markerWriteFailed(Error)
-        case markerWriteAndMediaWipeFailed(
-            markerError: Error,
-            mediaError: Error
-        )
-    }
-
-    struct PrivateMediaDeletionReservation: Sendable {
-        fileprivate let id: UUID
-    }
-
-    private final class PayloadCoordination: @unchecked Sendable {
-        let lock = NSLock()
-        var pendingDeliveryPaths: Set<String> = []
-        var deletionReservations: [UUID: Set<String>] = [:]
-    }
-
-    private static let defaultQuotaBytes: Int64 = 100 * 1024 * 1024
-    /// How long managed media may stay on disk. Bounds by age what the quota
-    /// only bounds by size; see `expireAgedMedia(retention:)`.
-    static let defaultMediaRetention: TimeInterval = 7 * 24 * 60 * 60
-    /// Kept outside `files/` so deleting the media tree cannot erase the
-    /// fail-closed startup decision before the full panic has committed.
-    private static let panicRecoveryPendingMarkerFileName =
-        ".panic-recovery-pending"
-    /// Compatibility with a short-lived development build that used the
-    /// media-specific name for the same full-transaction latch.
-    private static let legacyPanicRecoveryPendingMarkerFileName =
-        ".panic-media-wipe-pending"
-    private static let mediaSubdirectories = [
-        "voicenotes/incoming",
-        "voicenotes/outgoing",
-        "images/incoming",
-        "images/outgoing",
-        "files/incoming",
-        "files/outgoing"
-    ]
-    /// Name prefix of in-flight live voice captures (progressively written by
-    /// `ChatLiveVoiceCoordinator`). Quota eviction skips them by pattern —
-    /// deleting one mid-stream unlinks the inode under an open `FileHandle`
-    /// and kills playback — and the coordinator's startup sweep deletes any
-    /// orphans a previous session left behind.
-    static let liveCapturePrefix = "voice_live_"
-
-    /// Media payloads follow the same at-rest posture as the app's other
-    /// persistence layers (courier, outbox, receipt index): protected until
-    /// first unlock, so the launch-time retention sweep can still run after
-    /// a reboot. Applied to the media directories so recordings that save
-    /// as they go (live captures, `AVAudioRecorder`) inherit it, and stated
-    /// explicitly at the payload write site like every other store.
-    static var mediaProtectionAttributes: [FileAttributeKey: Any]? {
-        #if os(iOS)
-        return [.protectionKey: FileProtectionType.completeUntilFirstUserAuthentication]
-        #else
-        return nil
-        #endif
-    }
-
-    /// Exposed so callers that write progressively into the store's
-    /// directories (live voice captures) share the same file manager.
-    let fileManager: FileManager
+    private let fileManager: FileManager
     private let baseDirectory: URL?
     private let dateProvider: () -> Date
-    private let panicMarkerWriter: (Data, URL) throws -> Void
-    private let quotaBytes: Int64
-    private let privateMediaReceipts: BLEPrivateMediaReceiptStore
-    private let payloadCoordination: PayloadCoordination
 
-    init(
-        fileManager: FileManager = .default,
-        baseDirectory: URL? = nil,
-        dateProvider: @escaping () -> Date = Date.init,
-        panicMarkerWriter: @escaping (Data, URL) throws -> Void = {
-            try $0.write(to: $1, options: .atomic)
-        },
-        quotaBytes: Int64 = Self.defaultQuotaBytes
-    ) {
+    init(fileManager: FileManager = .default, baseDirectory: URL? = nil, dateProvider: @escaping () -> Date = Date.init) {
         self.fileManager = fileManager
         self.baseDirectory = baseDirectory
         self.dateProvider = dateProvider
-        self.panicMarkerWriter = panicMarkerWriter
-        self.quotaBytes = max(0, quotaBytes)
-        self.privateMediaReceipts = BLEPrivateMediaReceiptStore(
-            fileManager: fileManager,
-            baseDirectory: baseDirectory,
-            now: dateProvider
-        )
-        self.payloadCoordination = PayloadCoordination()
-    }
-
-    /// Panic-wipe every managed incoming and outgoing media artifact before
-    /// returning. Recreating the directory tree keeps later capture/receive
-    /// paths usable without allowing a detached cleanup task to race them.
-    ///
-    /// Marker persistence and deletion are deliberately separate error
-    /// domains: even when both durable marker channels fail, deletion is
-    /// still attempted before this method reports the marker failure.
-    func panicWipe(
-        hasDurablePendingMarker: Bool = false
-    ) throws {
-        // The receipt index caches tombstones as well as accepted payloads,
-        // while payload coordination retains save/delete reservations. Always
-        // invalidate both on return, including partial-failure paths, so no
-        // pre-panic receiver decision survives after identity reset.
-        defer {
-            privateMediaReceipts.resetForPanic()
-            payloadCoordination.lock.lock()
-            payloadCoordination.pendingDeliveryPaths.removeAll(
-                keepingCapacity: false
-            )
-            payloadCoordination.deletionReservations.removeAll(
-                keepingCapacity: false
-            )
-            payloadCoordination.lock.unlock()
-        }
-
-        let markerError: Error?
-        do {
-            try markPanicRecoveryPending()
-            markerError = nil
-        } catch {
-            markerError = error
-            SecureLogger.error(
-                "Could not persist file panic-recovery marker; attempting media deletion anyway: \(error)",
-                category: .security
-            )
-        }
-
-        do {
-            let filesDirectory = try rootDirectory()
-                .appendingPathComponent("files", isDirectory: true)
-            if fileManager.fileExists(atPath: filesDirectory.path) {
-                try fileManager.removeItem(at: filesDirectory)
-            }
-            for subdirectory in Self.mediaSubdirectories {
-                try fileManager.createDirectory(
-                    at: filesDirectory.appendingPathComponent(
-                        subdirectory,
-                        isDirectory: true
-                    ),
-                    withIntermediateDirectories: true,
-                    attributes: Self.mediaProtectionAttributes
-                )
-            }
-        } catch {
-            if let markerError {
-                throw PanicRecoveryError.markerWriteAndMediaWipeFailed(
-                    markerError: markerError,
-                    mediaError: error
-                )
-            }
-            throw error
-        }
-
-        if let markerError, !hasDurablePendingMarker {
-            throw PanicRecoveryError.markerWriteFailed(markerError)
-        }
-    }
-
-    func markPanicRecoveryPending() throws {
-        let markerURL = try panicRecoveryPendingMarkerURL()
-        try fileManager.createDirectory(
-            at: markerURL.deletingLastPathComponent(),
-            withIntermediateDirectories: true,
-            attributes: nil
-        )
-        try panicMarkerWriter(Data([1]), markerURL)
-    }
-
-    func isPanicRecoveryPending() throws -> Bool {
-        try panicRecoveryMarkerURLs().contains {
-            fileManager.fileExists(atPath: $0.path)
-        }
-    }
-
-    func completePanicRecovery() throws {
-        for markerURL in try panicRecoveryMarkerURLs()
-        where fileManager.fileExists(atPath: markerURL.path) {
-            try fileManager.removeItem(at: markerURL)
-        }
-    }
-
-    /// Resolves (and creates) an incoming-media directory for callers that
-    /// write progressively instead of via `save` (live voice captures).
-    func incomingDirectory(subdirectory: String) throws -> URL {
-        let directory = try filesDirectory().appendingPathComponent(subdirectory, isDirectory: true)
-        try fileManager.createDirectory(at: directory, withIntermediateDirectories: true, attributes: Self.mediaProtectionAttributes)
-        return directory
     }
 
     func save(
@@ -293,41 +22,16 @@ struct BLEIncomingFileStore: @unchecked Sendable {
         fallbackExtension: String?,
         defaultPrefix: String
     ) -> URL? {
-        payloadCoordination.lock.lock()
-        defer { payloadCoordination.lock.unlock() }
-
         do {
             let base = try filesDirectory().appendingPathComponent(subdirectory, isDirectory: true)
-            try fileManager.createDirectory(at: base, withIntermediateDirectories: true, attributes: Self.mediaProtectionAttributes)
+            try fileManager.createDirectory(at: base, withIntermediateDirectories: true, attributes: nil)
             let sanitized = sanitizedFileName(
                 preferredName,
                 defaultName: "\(defaultPrefix)_\(Self.timestampString(from: dateProvider()))",
                 fallbackExtension: fallbackExtension
             )
-            let reservedPaths = privateMediaReceipts.reservedPayloadPaths()
-            let deletionPaths = payloadCoordination
-                .deletionReservations.values.reduce(into: Set<String>()) {
-                    $0.formUnion($1)
-                }
-            let allocationReservations = deletionPaths.union(
-                payloadCoordination.pendingDeliveryPaths
-            )
-            let destination = uniqueFileURL(
-                in: base,
-                fileName: sanitized,
-                reservedPaths: (reservedPaths ?? []).union(
-                    allocationReservations
-                ),
-                forceRandomizedName: reservedPaths == nil
-            )
-            var options: Data.WritingOptions = [.atomic]
-            #if os(iOS)
-            options.insert(.completeFileProtectionUntilFirstUserAuthentication)
-            #endif
-            try data.write(to: destination, options: options)
-            payloadCoordination.pendingDeliveryPaths.insert(
-                destination.standardizedFileURL.path
-            )
+            let destination = uniqueFileURL(in: base, fileName: sanitized)
+            try data.write(to: destination, options: .atomic)
             return destination
         } catch {
             SecureLogger.error("❌ Failed to persist incoming media: \(error)", category: .session)
@@ -335,199 +39,7 @@ struct BLEIncomingFileStore: @unchecked Sendable {
         }
     }
 
-    /// Drops THIS instance's in-memory receipt index after a panic wipe.
-    ///
-    /// `panicWipe` already resets the receipt store it runs on, but the
-    /// production wipe runs on the `PanicRecoveryOperations.live()` file
-    /// store while receipt lookups are served by `BLEService`'s own
-    /// `incomingFileStore`. The service's panic path must invalidate its own
-    /// cache explicitly or pre-panic decisions survive in memory.
-    func resetPrivateMediaReceiptsForPanic() {
-        privateMediaReceipts.resetForPanic()
-    }
-
-    func privateMediaReceiptState(
-        messageID: String
-    ) -> BLEPrivateMediaReceiptState {
-        privateMediaReceipts.state(for: messageID)
-    }
-
-    func commitPrivateMediaFile(
-        messageID: String,
-        storedURL: URL
-    ) -> Bool {
-        privateMediaReceipts.commitAccepted(
-            messageID: messageID,
-            storedURL: storedURL
-        )
-    }
-
-    /// Reserves every receipt/UI path before the asynchronous deletion
-    /// barrier. Allocation and reservation share one lock, so either an
-    /// in-flight raw arrival is observed and deletion fails closed, or the
-    /// arrival is forced onto a different filename.
-    func reservePrivateMediaDeletion(
-        messageIDs: [String],
-        payloadRelativePaths: [String: String]
-    ) -> PrivateMediaDeletionReservation? {
-        payloadCoordination.lock.lock()
-        defer { payloadCoordination.lock.unlock() }
-
-        guard let paths = privateMediaReceipts
-            .prospectiveDeletionPayloadPaths(
-                messageIDs: messageIDs,
-                payloadRelativePaths: payloadRelativePaths
-            ),
-        paths.isDisjoint(
-            with: payloadCoordination.pendingDeliveryPaths
-        ) else {
-            return nil
-        }
-
-        let reservation = PrivateMediaDeletionReservation(id: UUID())
-        payloadCoordination.deletionReservations[reservation.id] = paths
-        return reservation
-    }
-
-    func commitPrivateMediaDeletion(
-        reservation: PrivateMediaDeletionReservation,
-        messageIDs: [String],
-        payloadRelativePaths: [String: String],
-        protectedPayloadRelativePaths: Set<String>
-    ) -> Bool {
-        payloadCoordination.lock.lock()
-        defer {
-            payloadCoordination.deletionReservations.removeValue(
-                forKey: reservation.id
-            )
-            payloadCoordination.lock.unlock()
-        }
-        guard payloadCoordination.deletionReservations[reservation.id] != nil
-        else {
-            return false
-        }
-        return privateMediaReceipts.recordDeleted(
-            messageIDs: messageIDs,
-            payloadRelativePaths: payloadRelativePaths,
-            protectedPayloadRelativePaths: protectedPayloadRelativePaths
-        )
-    }
-
-    /// Explicit deletion of a LEGACY (non-stable-ID) incoming payload.
-    ///
-    /// Legacy media has no durable receipt, so the only safe unlink is one
-    /// that can prove no other owner may hold the basename: the path must
-    /// not be pending delivery, must not belong to an in-flight deletion
-    /// reservation, and must not be owned by a stable receipt or journal
-    /// entry. When any of those hold — or receipt state cannot be read —
-    /// the file stays for bounded quota cleanup (the fail-safe fallback).
-    /// Returns true only when the payload was verifiably unlinked.
-    @discardableResult
-    func removeLegacyIncomingFile(relativePath: String) -> Bool {
-        payloadCoordination.lock.lock()
-        defer { payloadCoordination.lock.unlock() }
-
-        guard let payload = incomingPayloadURL(
-            relativePath: relativePath
-        ) else {
-            return false
-        }
-        let standardizedPath = payload.standardizedFileURL.path
-        let reservedByDeletion = payloadCoordination.deletionReservations
-            .values.contains { $0.contains(standardizedPath) }
-        guard !reservedByDeletion,
-              !payloadCoordination.pendingDeliveryPaths.contains(
-                  standardizedPath
-              ),
-              let receiptOwnedPaths =
-                privateMediaReceipts.reservedPayloadPaths(),
-              !receiptOwnedPaths.contains(standardizedPath) else {
-            return false
-        }
-        guard fileManager.fileExists(atPath: payload.path),
-              (try? payload.resourceValues(
-                  forKeys: [.isRegularFileKey]
-              ).isRegularFile) == true else {
-            return false
-        }
-        do {
-            try fileManager.removeItem(at: payload)
-            return !fileManager.fileExists(atPath: payload.path)
-        } catch {
-            SecureLogger.warning(
-                "⚠️ Failed to remove explicitly deleted legacy media: \(error)",
-                category: .session
-            )
-            return false
-        }
-    }
-
-    /// Resolves a `files/`-relative path iff it lands directly inside one of
-    /// the incoming media directories. Anything else is not a deletable
-    /// incoming payload.
-    private func incomingPayloadURL(relativePath: String) -> URL? {
-        guard !relativePath.isEmpty,
-              let base = try? filesDirectory().standardizedFileURL else {
-            return nil
-        }
-        let candidate = base
-            .appendingPathComponent(relativePath, isDirectory: false)
-            .standardizedFileURL
-        let parentPath = candidate.deletingLastPathComponent().path
-        let incomingDirectories = [
-            "voicenotes/incoming",
-            "images/incoming",
-            "files/incoming"
-        ]
-        guard incomingDirectories.contains(where: { relativeDirectory in
-            base.appendingPathComponent(
-                relativeDirectory,
-                isDirectory: true
-            ).standardizedFileURL.path == parentPath
-        }) else {
-            return nil
-        }
-        return candidate
-    }
-
-    /// Releases the short window between disk save and synchronous
-    /// conversation insertion. Before this callback, a deletion transaction
-    /// may not infer ownership from a stale bubble that names the same path.
-    func finishIncomingFileDelivery(at storedURL: URL) {
-        payloadCoordination.lock.lock()
-        defer { payloadCoordination.lock.unlock() }
-        payloadCoordination.pendingDeliveryPaths.remove(
-            storedURL.standardizedFileURL.path
-        )
-    }
-
-    /// Best-effort rollback for a payload whose durable receipt commit failed.
-    func removeIncomingFile(at storedURL: URL) {
-        payloadCoordination.lock.lock()
-        defer { payloadCoordination.lock.unlock() }
-        payloadCoordination.pendingDeliveryPaths.remove(
-            storedURL.standardizedFileURL.path
-        )
-        guard isURLInsideFilesDirectory(storedURL) else { return }
-        do {
-            try fileManager.removeItem(at: storedURL)
-        } catch {
-            SecureLogger.warning(
-                "⚠️ Failed to roll back uncommitted incoming media: \(error)",
-                category: .session
-            )
-        }
-    }
-
-    /// Frees least-recently-modified incoming files until `reservingBytes`
-    /// fits under the quota. Files named `voice_live_*` (in-flight live
-    /// captures) are never evicted regardless of who triggers enforcement —
-    /// a finalized transfer can arrive at quota while a burst is still
-    /// streaming — but they still count toward usage.
     func enforceQuota(reservingBytes: Int) {
-        payloadCoordination.lock.lock()
-        defer { payloadCoordination.lock.unlock() }
-
         do {
             let base = try filesDirectory()
             let incomingDirs = [
@@ -553,26 +65,13 @@ struct BLEIncomingFileStore: @unchecked Sendable {
             }
 
             let currentUsage = allFiles.reduce(0) { $0 + $1.size }
-            let targetUsage = quotaBytes - Int64(reservingBytes)
+            let targetUsage = Self.quotaBytes - Int64(reservingBytes)
             guard currentUsage > targetUsage else { return }
 
             let needToFree = currentUsage - targetUsage
-            let activeDeletionPaths = payloadCoordination
-                .deletionReservations.values.reduce(into: Set<String>()) {
-                    $0.formUnion($1)
-                }
-            let protectedPaths = activeDeletionPaths.union(
-                payloadCoordination.pendingDeliveryPaths
-            )
             var freedSpace: Int64 = 0
             for file in allFiles.sorted(by: { $0.modified < $1.modified }) {
                 guard freedSpace < needToFree else { break }
-                guard !file.url.lastPathComponent.hasPrefix(Self.liveCapturePrefix) else { continue }
-                guard !protectedPaths.contains(
-                    file.url.standardizedFileURL.path
-                ) else {
-                    continue
-                }
                 do {
                     try fileManager.removeItem(at: file.url)
                     freedSpace += file.size
@@ -590,206 +89,16 @@ struct BLEIncomingFileStore: @unchecked Sendable {
         }
     }
 
-    /// Deletes managed media older than `retention`, across both incoming and
-    /// outgoing directories, and reports how many files went away.
-    ///
-    /// The quota sweep above only bounds *size*, and only for incoming files,
-    /// so a received photo or a sent voice note could sit on disk unbounded in
-    /// time — long outliving the conversation it belonged to, which is what a
-    /// seized device gives up. This bounds media by age instead, on the same
-    /// principle as the courier envelope and gossip archive lifetimes.
-    ///
-    /// Honors the same exclusions as quota eviction: in-flight live captures
-    /// and files reserved by an in-progress delivery or deletion are left
-    /// alone regardless of age.
-    @discardableResult
-    func expireAgedMedia(retention: TimeInterval = Self.defaultMediaRetention) -> Int {
-        guard retention > 0 else { return 0 }
-
-        payloadCoordination.lock.lock()
-        defer { payloadCoordination.lock.unlock() }
-
-        let cutoff = dateProvider().addingTimeInterval(-retention)
-        let activeDeletionPaths = payloadCoordination
-            .deletionReservations.values.reduce(into: Set<String>()) {
-                $0.formUnion($1)
-            }
-        let protectedPaths = activeDeletionPaths.union(
-            payloadCoordination.pendingDeliveryPaths
-        )
-
-        var removed = 0
-        do {
-            let base = try filesDirectory()
-            for subdirectory in Self.mediaSubdirectories {
-                let dir = base.appendingPathComponent(subdirectory, isDirectory: true)
-                guard fileManager.fileExists(atPath: dir.path) else { continue }
-                guard let contents = try? fileManager.contentsOfDirectory(
-                    at: dir,
-                    includingPropertiesForKeys: [.contentModificationDateKey],
-                    options: [.skipsHiddenFiles]
-                ) else { continue }
-
-                for fileURL in contents {
-                    guard let modified = try? fileURL.resourceValues(
-                        forKeys: [.contentModificationDateKey]
-                    ).contentModificationDate else { continue }
-                    guard modified < cutoff else { continue }
-                    guard !fileURL.lastPathComponent.hasPrefix(Self.liveCapturePrefix) else { continue }
-                    guard !protectedPaths.contains(
-                        fileURL.standardizedFileURL.path
-                    ) else { continue }
-
-                    do {
-                        try fileManager.removeItem(at: fileURL)
-                        removed += 1
-                    } catch {
-                        SecureLogger.warning(
-                            "⚠️ Failed to expire aged media file: \(error)",
-                            category: .security
-                        )
-                    }
-                }
-            }
-        } catch {
-            SecureLogger.warning(
-                "⚠️ Could not expire aged media: \(error)",
-                category: .security
-            )
-            return removed
-        }
-
-        if removed > 0 {
-            SecureLogger.info(
-                "🗑️ Expired \(removed) media file(s) older than the retention window",
-                category: .security
-            )
-        }
-        return removed
-    }
-
-    /// Stamps the media directories and any resident payloads with the
-    /// explicit protection class, covering files written by builds that
-    /// relied on the container default. Runs every launch: re-stamping an
-    /// equal class is a metadata no-op, and anything carrying a stronger
-    /// class is left alone, so repetition is cheap and can never downgrade.
-    /// In-flight live captures are skipped for symmetry with the retention
-    /// sweep; they receive the class at creation and need no repair.
-    /// Best-effort like the sweep it runs alongside; a file that cannot be
-    /// stamped is logged, not fatal, and the migration moves on to the next
-    /// item. Returns the number of items stamped so the launch path and
-    /// tests can observe coverage.
-    @discardableResult
-    func migrateFileProtectionIfNeeded() -> Int {
-        #if os(iOS)
-        guard let attributes = Self.mediaProtectionAttributes else { return 0 }
-        var stamped = 0
-        guard let base = try? filesDirectory() else { return 0 }
-        for subdirectory in Self.mediaSubdirectories {
-            let dir = base.appendingPathComponent(subdirectory, isDirectory: true)
-            guard fileManager.fileExists(atPath: dir.path) else { continue }
-            let files = (try? fileManager.contentsOfDirectory(
-                at: dir,
-                includingPropertiesForKeys: [.isRegularFileKey, .isDirectoryKey, .fileProtectionKey],
-                options: [.skipsHiddenFiles]
-            )) ?? []
-            stamped += stampProtectionIfWeaker(dir, requireRegularFile: false, attributes: attributes)
-            for fileURL in files {
-                guard !fileURL.lastPathComponent.hasPrefix(Self.liveCapturePrefix) else { continue }
-                stamped += stampProtectionIfWeaker(fileURL, requireRegularFile: true, attributes: attributes)
-            }
-        }
-        return stamped
-        #else
-        return 0
-        #endif
-    }
-
-    #if os(iOS)
-    /// Applies the class to one item, but only when the item currently sits
-    /// at the container default or weaker. The list names the classes that
-    /// are safe to replace; anything else, including classes added in later
-    /// iOS versions, is left alone. Only regular files are stamped when
-    /// `requireRegularFile` is set (and only real directories otherwise),
-    /// matching the caution the legacy-file removal path applies; symlinks
-    /// and other non-regular files are left untouched.
-    private func stampProtectionIfWeaker(
-        _ itemURL: URL,
-        requireRegularFile: Bool,
-        attributes: [FileAttributeKey: Any]
-    ) -> Int {
-        let values = try? itemURL.resourceValues(
-            forKeys: [.isRegularFileKey, .isDirectoryKey, .fileProtectionKey]
-        )
-        if requireRegularFile {
-            guard values?.isRegularFile == true else { return 0 }
-        } else {
-            guard values?.isDirectory == true else { return 0 }
-        }
-        if let current = values?.fileProtection,
-           current != .none,
-           current != .completeUntilFirstUserAuthentication {
-            return 0
-        }
-        do {
-            try fileManager.setAttributes(attributes, ofItemAtPath: itemURL.path)
-            return 1
-        } catch let error as CocoaError where error.code == .fileNoSuchFile {
-            // Quota eviction or a deletion commit on another store instance
-            // can delete an item out from under this migration; that is not
-            // a failure.
-            return 0
-        } catch {
-            SecureLogger.warning(
-                "⚠️ Failed to migrate media file protection: \(error)",
-                category: .security
-            )
-            return 0
-        }
-    }
-    #endif
-
     private func filesDirectory() throws -> URL {
-        let filesDir = try rootDirectory().appendingPathComponent("files", isDirectory: true)
-        try fileManager.createDirectory(at: filesDir, withIntermediateDirectories: true, attributes: Self.mediaProtectionAttributes)
-        return filesDir
-    }
-
-    private func rootDirectory() throws -> URL {
-        try baseDirectory ?? fileManager.url(
+        let root = try baseDirectory ?? fileManager.url(
             for: .applicationSupportDirectory,
             in: .userDomainMask,
             appropriateFor: nil,
             create: true
         )
-    }
-
-    private func panicRecoveryPendingMarkerURL() throws -> URL {
-        try rootDirectory().appendingPathComponent(
-            Self.panicRecoveryPendingMarkerFileName,
-            isDirectory: false
-        )
-    }
-
-    private func panicRecoveryMarkerURLs() throws -> [URL] {
-        let root = try rootDirectory()
-        return [
-            root.appendingPathComponent(
-                Self.panicRecoveryPendingMarkerFileName,
-                isDirectory: false
-            ),
-            root.appendingPathComponent(
-                Self.legacyPanicRecoveryPendingMarkerFileName,
-                isDirectory: false
-            )
-        ]
-    }
-
-    private func isURLInsideFilesDirectory(_ url: URL) -> Bool {
-        guard let filesDirectory = try? filesDirectory().standardizedFileURL else {
-            return false
-        }
-        return url.standardizedFileURL.path.hasPrefix(filesDirectory.path + "/")
+        let filesDir = root.appendingPathComponent("files", isDirectory: true)
+        try fileManager.createDirectory(at: filesDir, withIntermediateDirectories: true, attributes: nil)
+        return filesDir
     }
 
     private func sanitizedFileName(_ name: String?, defaultName: String, fallbackExtension: String?) -> String {
@@ -819,20 +128,11 @@ struct BLEIncomingFileStore: @unchecked Sendable {
         return candidate.isEmpty ? defaultName : candidate
     }
 
-    private func uniqueFileURL(
-        in directory: URL,
-        fileName: String,
-        reservedPaths: Set<String>,
-        forceRandomizedName: Bool
-    ) -> URL {
+    private func uniqueFileURL(in directory: URL, fileName: String) -> URL {
         let directoryPath = directory.standardizedFileURL.path
         func isInsideDirectory(_ url: URL) -> Bool {
             url.standardizedFileURL.path.hasPrefix(directoryPath + "/")
         }
-        func isAvailable(_ url: URL) -> Bool {
-            !reservedPaths.contains(url.standardizedFileURL.path)
-                && !fileManager.fileExists(atPath: url.path)
-        }
 
         var candidate = directory.appendingPathComponent(fileName)
         guard isInsideDirectory(candidate) else {
@@ -840,27 +140,19 @@ struct BLEIncomingFileStore: @unchecked Sendable {
             return directory.appendingPathComponent("blocked_\(UUID().uuidString)")
         }
 
-        let baseName = (fileName as NSString).deletingPathExtension
-        let ext = (fileName as NSString).pathExtension
-        if forceRandomizedName {
-            let suffix = UUID().uuidString
-            let randomizedName = ext.isEmpty
-                ? "\(baseName)_\(suffix)"
-                : "\(baseName)_\(suffix).\(ext)"
-            return directory.appendingPathComponent(randomizedName)
-        }
-
-        if isAvailable(candidate) {
+        if !fileManager.fileExists(atPath: candidate.path) {
             return candidate
         }
 
+        let baseName = (fileName as NSString).deletingPathExtension
+        let ext = (fileName as NSString).pathExtension
         for counter in 1..<100 {
             let newName = ext.isEmpty ? "\(baseName) (\(counter))" : "\(baseName) (\(counter)).\(ext)"
             candidate = directory.appendingPathComponent(newName)
             guard isInsideDirectory(candidate) else {
                 return directory.appendingPathComponent("blocked_\(UUID().uuidString)")
             }
-            if isAvailable(candidate) {
+            if !fileManager.fileExists(atPath: candidate.path) {
                 return candidate
             }
         }

bitchat/Services/BLE/BLEIngressLinkRegistry.swift

@@ -124,45 +124,3 @@ struct BLEIngressLinkRegistry {
         packet.isRSR && packet.ttl == 0
     }
 }
-
-/// Lock-backed shared ownership of the ingress-link registry. Ingress is
-/// recorded on bleQueue the moment a frame decodes (the link identity is
-/// only known there, and the duplicate-ingress gate must answer before
-/// the packet is handed to the engine), while relay and routing decisions
-/// read it from the engine. Every registry mutation is a single
-/// whole-transition method, so readers never observe a torn state.
-final class BLEIngressLinkStore: @unchecked Sendable {
-    private let lock = NSLock()
-    private var registry = BLEIngressLinkRegistry()
-
-    var isEmpty: Bool {
-        lock.withLock { registry.isEmpty }
-    }
-
-    func removeAll() {
-        lock.withLock { registry.removeAll() }
-    }
-
-    func record(for packet: BitchatPacket) -> BLEIngressLinkRecord? {
-        lock.withLock { registry.record(for: packet) }
-    }
-
-    func link(for packet: BitchatPacket) -> BLEIngressLinkID? {
-        lock.withLock { registry.link(for: packet) }
-    }
-
-    func recordIfNew(
-        _ packet: BitchatPacket,
-        link: BLEIngressLinkID,
-        peerID: PeerID,
-        lifetime: TimeInterval
-    ) -> Bool {
-        lock.withLock {
-            registry.recordIfNew(packet, link: link, peerID: peerID, lifetime: lifetime)
-        }
-    }
-
-    func prune(before cutoff: Date) {
-        lock.withLock { registry.prune(before: cutoff) }
-    }
-}

bitchat/Services/BLE/BLELinkAuthState.swift

@@ -1,115 +0,0 @@
-import BitFoundation
-import Foundation
-
-/// Per-link Noise authentication and rebind-containment state.
-///
-/// A peer ID can retain an established Noise session after its physical
-/// link disappears, and link bindings heal on announces whose directness
-/// is forgeable (TTL is unsigned). This state pins the stronger facts the
-/// containment rules need: which exact ingress link a Noise handshake
-/// completed on, each link's revalidation epoch, and the cooldowns that
-/// stop a replayed announce from flip-flopping bindings or survivor
-/// selection.
-///
-/// Engine-owned (option-B boundary, docs/BLE-ARCHITECTURE-V3.md),
-/// alongside the link bindings it qualifies: BLEService debug-traps any
-/// access off the engine queue.
-struct BLELinkAuthState {
-    private var authenticatedOwners: [BLEIngressLinkID: PeerID] = [:]
-    private var reconnectPolicy = BLENoiseReconnectPolicy()
-    // Entries older than the cooldown are pruned on each check.
-    private var lastRebindAt: [String: Date] = [:]
-    private var lastRedundantRetirementAt: [PeerID: Date] = [:]
-
-    // MARK: - Authentication ownership
-
-    /// Whether `peerID`'s Noise session was established on this exact link.
-    func isAuthenticated(_ link: BLEIngressLinkID, for peerID: PeerID) -> Bool {
-        authenticatedOwners[link] == peerID
-    }
-
-    func links(ownedBy peerID: PeerID) -> [BLEIngressLinkID] {
-        authenticatedOwners.compactMap { link, owner in
-            owner == peerID ? link : nil
-        }
-    }
-
-    mutating func markAuthenticated(_ link: BLEIngressLinkID, owner peerID: PeerID) {
-        authenticatedOwners[link] = peerID
-    }
-
-    /// Retires a link's proof and closes its revalidation epoch — the pair
-    /// every teardown path (disconnect, unsubscribe, timeout, rebind,
-    /// redundant retirement) must apply together.
-    mutating func retireLink(_ link: BLEIngressLinkID) {
-        authenticatedOwners.removeValue(forKey: link)
-        reconnectPolicy.endLinkEpoch(link)
-    }
-
-    /// Retires every link the departing peer's proofs still own; returns
-    /// the retired links.
-    mutating func retireLinks(ownedBy peerID: PeerID) -> [BLEIngressLinkID] {
-        let departed = links(ownedBy: peerID)
-        for link in departed {
-            retireLink(link)
-        }
-        return departed
-    }
-
-    /// Drops every link proof and revalidation epoch. The containment
-    /// cooldowns deliberately SURVIVE this: panic and emergency resets can
-    /// restart services well inside `bleLinkRebindCooldownSeconds`, and a
-    /// stable CoreBluetooth UUID must not get a fresh rebind/retirement
-    /// allowance just because the session state around it was wiped. The
-    /// maps stay time-pruned on each permit check.
-    mutating func removeAll() {
-        authenticatedOwners.removeAll()
-        reconnectPolicy.removeAll()
-    }
-
-    // MARK: - Session revalidation
-
-    /// Whether a fresh direct link warrants revalidating a cached
-    /// peer-level session with a new XX exchange.
-    mutating func shouldRevalidate(
-        on link: BLEIngressLinkID,
-        for peerID: PeerID,
-        hasEstablishedSession: Bool,
-        hasAuthenticatedPeerLink: Bool,
-        now: Date
-    ) -> Bool {
-        reconnectPolicy.shouldRevalidate(
-            on: link,
-            hasEstablishedSession: hasEstablishedSession,
-            isNoiseAuthenticatedLink: isAuthenticated(link, for: peerID),
-            hasAuthenticatedPeerLink: hasAuthenticatedPeerLink,
-            now: now
-        )
-    }
-
-    // MARK: - Rebind containment cooldowns
-
-    /// At most one rotation rebind per link per cooldown window, so two
-    /// identities can't fight over a link in a replay flip-flop. Prunes,
-    /// checks, and records in one transition; true = permitted (recorded).
-    mutating func permitRebind(linkUUID: String, now: Date, cooldown: TimeInterval) -> Bool {
-        lastRebindAt = lastRebindAt.filter {
-            now.timeIntervalSince($0.value) < cooldown
-        }
-        guard lastRebindAt[linkUUID] == nil else { return false }
-        lastRebindAt[linkUUID] = now
-        return true
-    }
-
-    /// At most one redundant-link retirement per peer per cooldown window,
-    /// bounding how often a replayed announce could flip which duplicate
-    /// link survives. True = permitted (recorded).
-    mutating func permitRedundantRetirement(peerID: PeerID, now: Date, cooldown: TimeInterval) -> Bool {
-        lastRedundantRetirementAt = lastRedundantRetirementAt.filter {
-            now.timeIntervalSince($0.value) < cooldown
-        }
-        guard lastRedundantRetirementAt[peerID] == nil else { return false }
-        lastRedundantRetirementAt[peerID] = now
-        return true
-    }
-}

bitchat/Services/BLE/BLELinkBindings.swift

@@ -1,152 +0,0 @@
-import BitFoundation
-import Foundation
-
-/// Identity↔link bindings: which peer each physical link currently
-/// belongs to, in both roles, plus each peer's preferred peripheral link
-/// for directed sends and fanout collapse.
-///
-/// Engine-owned (option-B boundary, docs/BLE-ARCHITECTURE-V3.md),
-/// alongside `BLELinkAuthState`: *who owns a link* lives on the engine,
-/// *what links exist* stays on bleQueue in the physical store. BLEService
-/// debug-traps any access off the engine queue.
-///
-/// Lifecycle contract: bindings are only created for live physical links
-/// (callers check liveness through `readLinkState`) and are retired
-/// through `peripheralRemoved`/`centralRemoved`/`clear*` on an engine hop
-/// queued by the physical teardown. A binding can therefore briefly
-/// outlive its departed link; queries that need liveness join against the
-/// physical store, and everything converges once the queued retirement
-/// runs.
-struct BLELinkBindings {
-    private var peripheralPeers: [String: PeerID] = [:]
-    private var centralPeers: [String: PeerID] = [:]
-    /// The peer's most recently bound peripheral link, kept so duplicate-
-    /// link fanout collapse stays deterministic (see BLEFanoutSelector).
-    private var preferredPeripheral: [PeerID: String] = [:]
-
-    // MARK: - Queries
-
-    func peer(forPeripheralID peripheralID: String) -> PeerID? {
-        peripheralPeers[peripheralID]
-    }
-
-    func peer(forCentralUUID centralUUID: String) -> PeerID? {
-        centralPeers[centralUUID]
-    }
-
-    func boundPeer(for link: BLEIngressLinkID) -> PeerID? {
-        switch link {
-        case .peripheral(let peripheralUUID):
-            return peripheralPeers[peripheralUUID]
-        case .central(let centralUUID):
-            return centralPeers[centralUUID]
-        }
-    }
-
-    /// Every link bound to the peer, both roles. After a state restoration
-    /// the same device can hold several live peripheral links bound to one
-    /// peer (it reappears under a fresh UUID while the restored connection
-    /// lives on), so this scans all bindings rather than the 1:1 preferred
-    /// map.
-    func links(to peerID: PeerID?) -> Set<BLEIngressLinkID> {
-        guard let peerID else { return [] }
-        var links: Set<BLEIngressLinkID> = []
-        for (peripheralUUID, boundPeer) in peripheralPeers where boundPeer == peerID {
-            links.insert(.peripheral(peripheralUUID))
-        }
-        for (centralUUID, boundPeer) in centralPeers where boundPeer == peerID {
-            links.insert(.central(centralUUID))
-        }
-        return links
-    }
-
-    func hasCentral(boundTo peerID: PeerID) -> Bool {
-        centralPeers.values.contains(peerID)
-    }
-
-    func preferredPeripheralUUID(for peerID: PeerID) -> String? {
-        preferredPeripheral[peerID]
-    }
-
-    /// The full preferred-peripheral map, for fanout collapse.
-    var preferredPeripheralBindings: [PeerID: String] {
-        preferredPeripheral
-    }
-
-    /// The full central binding map, for the subscribed-central snapshot.
-    var centralPeersByUUID: [String: PeerID] {
-        centralPeers
-    }
-
-    // MARK: - Binding transitions
-
-    mutating func bindCentral(_ centralUUID: String, to peerID: PeerID) {
-        centralPeers[centralUUID] = peerID
-    }
-
-    mutating func bindPeripheral(_ peripheralUUID: String, to peerID: PeerID) {
-        let previousPeerID = peripheralPeers[peripheralUUID]
-        peripheralPeers[peripheralUUID] = peerID
-        // Rebinding (peer-ID rotation): drop the retired ID's reverse
-        // mapping so the old peer no longer claims this link.
-        if let previousPeerID, previousPeerID != peerID,
-           preferredPeripheral[previousPeerID] == peripheralUUID {
-            preferredPeripheral.removeValue(forKey: previousPeerID)
-        }
-        preferredPeripheral[peerID] = peripheralUUID
-    }
-
-    /// Retires a peripheral link's binding. When the removed link was the
-    /// peer's preferred one, the reverse map is repaired onto a surviving
-    /// duplicate chosen by the caller from the peer's remaining bound links
-    /// (the caller knows physical liveness; prefer a writable survivor —
-    /// repairing onto a link mid-service-rediscovery would strand directed
-    /// sends until its characteristic comes back).
-    mutating func peripheralRemoved(
-        _ peripheralUUID: String,
-        chooseSurvivor: (_ remainingBoundUUIDs: [String]) -> String?
-    ) -> PeerID? {
-        guard let peerID = peripheralPeers.removeValue(forKey: peripheralUUID) else {
-            return nil
-        }
-        // Only clear (or repair) the reverse map when it points at the
-        // removed link: with duplicate links to one peer, removing a stale
-        // duplicate must not strand the peer's surviving bound link.
-        if preferredPeripheral[peerID] == peripheralUUID {
-            let remaining = peripheralPeers.compactMap { uuid, boundPeer in
-                boundPeer == peerID ? uuid : nil
-            }
-            if let survivorUUID = chooseSurvivor(remaining) {
-                preferredPeripheral[peerID] = survivorUUID
-            } else {
-                preferredPeripheral.removeValue(forKey: peerID)
-            }
-        }
-        return peerID
-    }
-
-    mutating func centralRemoved(_ centralUUID: String) -> PeerID? {
-        centralPeers.removeValue(forKey: centralUUID)
-    }
-
-    /// Drops every peripheral binding; returns the peers that held one.
-    mutating func clearPeripherals() -> [PeerID] {
-        let peerIDs = Array(peripheralPeers.values)
-        peripheralPeers.removeAll()
-        preferredPeripheral.removeAll()
-        return peerIDs
-    }
-
-    /// Drops every central binding; returns the peers that held one.
-    mutating func clearCentrals() -> [PeerID] {
-        let peerIDs = Array(centralPeers.values)
-        centralPeers.removeAll()
-        return peerIDs
-    }
-
-    mutating func removeAll() {
-        peripheralPeers.removeAll()
-        centralPeers.removeAll()
-        preferredPeripheral.removeAll()
-    }
-}

bitchat/Services/BLE/BLELinkEvent.swift

@@ -1,40 +0,0 @@
-import BitFoundation
-import Foundation
-
-/// The upward half of the link-layer port: everything the bleQueue link
-/// layer tells the engine, as one enumerable surface with one engine
-/// entry point (`BLEService.handleLinkEvent`). CoreBluetooth delegates
-/// shrink to physical bookkeeping plus event emission, and the simulated
-/// mesh drives the engine through exactly the same seam.
-///
-/// Naming follows the physical stores: a *peripheral link* is a
-/// connection we own as central (keyed by the remote peripheral's UUID);
-/// a *central link* is a remote central subscribed to our peripheral role
-/// (keyed by its UUID).
-enum BLELinkEvent {
-    /// A decoded frame arrived on a link. Attribution — binding lookup,
-    /// spoof rejection, raw-announce binding, ingress recording — is
-    /// engine work. Emission captures the panic lifecycle at the handoff.
-    case frameDecoded(BitchatPacket, link: BLEIngressLinkID, linkDescription: String)
-
-    /// One peripheral link ended (disconnect, connect failure, or radio
-    /// policy teardown). The engine retires the link's identity half —
-    /// proof, epoch, binding with survivor repair — and, when
-    /// `runPeerBookkeeping` is set (real disconnects), marks the peer
-    /// disconnected once its last live link is gone and republishes the
-    /// peer list.
-    case peripheralLinkEnded(peripheralID: String, runPeerBookkeeping: Bool)
-
-    /// A remote central unsubscribed. The engine retires the central
-    /// link's identity half and runs last-link peer bookkeeping.
-    case centralLinkEnded(centralUUID: String)
-
-    /// The central role reset and every peripheral link is gone
-    /// (power-off retires proofs and notifies peers; an authorization
-    /// loss only drops the bindings).
-    case allPeripheralLinksEnded(peripheralIDs: [String], retireProofsAndNotify: Bool)
-
-    /// The peripheral role reset and every central link is gone (same
-    /// power-off / authorization-loss split).
-    case allCentralLinksEnded(centralUUIDs: [String], retireProofsAndNotify: Bool)
-}

bitchat/Services/BLE/BLELinkStateStore.swift

@@ -5,15 +5,10 @@ import Foundation
 struct BLEPeripheralLinkState {
     let peripheral: CBPeripheral
     var characteristic: CBCharacteristic?
+    var peerID: PeerID?
     var isConnecting: Bool
     var isConnected: Bool
     var lastConnectionAttempt: Date?
-    /// When didConnect last fired for this link. Nil for links restored
-    /// already-connected (their connect predates this process), which is
-    /// exactly the signal redundant-link consolidation needs: a restored
-    /// link lives on an old BLE address the peer no longer advertises,
-    /// so it must never be kept over a freshly connected duplicate.
-    var lastConnectedAt: Date? = nil
     var assembler: NotificationStreamAssembler
 }
 
@@ -31,20 +26,17 @@ struct BLESubscribedCentralSnapshot {
     }
 }
 
-// BLEDirectLinkState and the identity↔link binding queries live on
-// BLELinkBindings; this store owns only physical link state.
-
-/// Owns the PHYSICAL BLE link state (peripheral connections we hold as
-/// central, and central subscriptions we serve as peripheral) — CB object
-/// handles, connect lifecycles, characteristics, and stream assemblers.
-/// Identity↔link bindings live on `BLELinkBindings`. The store has no
-/// internal locking: every access must happen on the single owning queue
-/// (the BLE queue). Other queues must go through BLEService's
-/// `readLinkState`, which hops to that queue. Call `assumeOwnership(of:)`
-/// to have debug builds trap any access from the wrong queue.
+/// Owns all BLE link state (peripheral connections we hold as central, and
+/// central subscriptions we serve as peripheral). The store has no internal
+/// locking: every access must happen on the single owning queue (the BLE
+/// queue). Other queues must go through BLEService's `readLinkState`, which
+/// hops to that queue. Call `assumeOwnership(of:)` to have debug builds trap
+/// any access from the wrong queue.
 final class BLELinkStateStore {
     private(set) var peripherals: [String: BLEPeripheralLinkState] = [:]
+    private(set) var peerToPeripheralUUID: [PeerID: String] = [:]
     private(set) var subscribedCentrals: [CBCentral] = []
+    private(set) var centralToPeerID: [String: PeerID] = [:]
 
     #if DEBUG
     private var ownerQueue: DispatchQueue?
@@ -72,6 +64,14 @@ final class BLELinkStateStore {
         return Array(peripherals.values)
     }
 
+    var subscribedCentralSnapshot: BLESubscribedCentralSnapshot {
+        assertOwned()
+        return BLESubscribedCentralSnapshot(
+            centrals: subscribedCentrals,
+            peerIDsByCentralUUID: centralToPeerID
+        )
+    }
+
     var subscribedCentralCount: Int {
         assertOwned()
         return subscribedCentrals.count
@@ -109,6 +109,7 @@ final class BLELinkStateStore {
             BLEPeripheralLinkState(
                 peripheral: peripheral,
                 characteristic: nil,
+                peerID: nil,
                 isConnecting: true,
                 isConnected: false,
                 lastConnectionAttempt: date,
@@ -118,21 +119,20 @@ final class BLELinkStateStore {
         )
     }
 
-    func markConnected(_ peripheral: CBPeripheral, at now: Date = Date()) {
+    func markConnected(_ peripheral: CBPeripheral) {
         let peripheralID = peripheral.identifier.uuidString
         if updatePeripheral(peripheralID, {
             $0.isConnecting = false
             $0.isConnected = true
-            $0.lastConnectedAt = now
         }) == nil {
             setPeripheralState(
                 BLEPeripheralLinkState(
                     peripheral: peripheral,
                     characteristic: nil,
+                    peerID: nil,
                     isConnecting: false,
                     isConnected: true,
                     lastConnectionAttempt: nil,
-                    lastConnectedAt: now,
                     assembler: NotificationStreamAssembler()
                 ),
                 for: peripheralID
@@ -146,35 +146,108 @@ final class BLELinkStateStore {
         }
     }
 
+    func directPeripheralState(for peerID: PeerID) -> BLEPeripheralLinkState? {
+        assertOwned()
+        return peerToPeripheralUUID[peerID].flatMap { peripherals[$0] }
+    }
+
+    func directLinkState(for peerID: PeerID) -> BLEDirectLinkState {
+        assertOwned()
+        let peripheralUUID = peerToPeripheralUUID[peerID]
+        let hasPeripheral = peripheralUUID.flatMap { peripherals[$0]?.isConnected } ?? false
+        let hasCentral = centralToPeerID.values.contains(peerID)
+        return BLEDirectLinkState(hasPeripheral: hasPeripheral, hasCentral: hasCentral)
+    }
+
+    func links(to peerID: PeerID?) -> Set<BLEIngressLinkID> {
+        assertOwned()
+        guard let peerID else { return [] }
+
+        var links: Set<BLEIngressLinkID> = []
+        if let peripheralUUID = peerToPeripheralUUID[peerID] {
+            links.insert(.peripheral(peripheralUUID))
+        }
+        for (centralUUID, mappedPeerID) in centralToPeerID where mappedPeerID == peerID {
+            links.insert(.central(centralUUID))
+        }
+        return links
+    }
+
+    func peerID(forPeripheralID peripheralID: String) -> PeerID? {
+        assertOwned()
+        return peripherals[peripheralID]?.peerID
+    }
+
+    func peerID(forCentralUUID centralUUID: String) -> PeerID? {
+        assertOwned()
+        return centralToPeerID[centralUUID]
+    }
+
     func addSubscribedCentral(_ central: CBCentral) {
         assertOwned()
         guard !subscribedCentrals.contains(central) else { return }
         subscribedCentrals.append(central)
     }
 
-    func removeSubscribedCentral(_ central: CBCentral) {
+    func removeSubscribedCentral(_ central: CBCentral) -> PeerID? {
         assertOwned()
+        let centralUUID = central.identifier.uuidString
         subscribedCentrals.removeAll { $0.identifier == central.identifier }
+        return centralToPeerID.removeValue(forKey: centralUUID)
     }
 
-    func removePeripheral(_ peripheralID: String) {
+    func bindCentral(_ centralUUID: String, to peerID: PeerID) {
         assertOwned()
-        peripherals.removeValue(forKey: peripheralID)
+        centralToPeerID[centralUUID] = peerID
     }
 
-    func clearPeripherals() {
+    func bindPeripheral(_ peripheralUUID: String, to peerID: PeerID) {
         assertOwned()
+        var previousPeerID: PeerID?
+        let updated = updatePeripheral(peripheralUUID) {
+            previousPeerID = $0.peerID
+            $0.peerID = peerID
+        }
+        guard updated != nil else { return }
+        // Rebinding (peer-ID rotation): drop the retired ID's reverse mapping
+        // so the old peer no longer claims this link.
+        if let previousPeerID, previousPeerID != peerID,
+           peerToPeripheralUUID[previousPeerID] == peripheralUUID {
+            peerToPeripheralUUID.removeValue(forKey: previousPeerID)
+        }
+        peerToPeripheralUUID[peerID] = peripheralUUID
+    }
+
+    func removePeripheral(_ peripheralID: String) -> PeerID? {
+        assertOwned()
+        let peerID = peripherals.removeValue(forKey: peripheralID)?.peerID
+        if let peerID {
+            peerToPeripheralUUID.removeValue(forKey: peerID)
+        }
+        return peerID
+    }
+
+    func clearPeripherals() -> [PeerID] {
+        assertOwned()
+        let peerIDs = peripherals.compactMap { $0.value.peerID }
         peripherals.removeAll()
+        peerToPeripheralUUID.removeAll()
+        return peerIDs
     }
 
-    func clearCentrals() {
+    func clearCentrals() -> [PeerID] {
         assertOwned()
+        let peerIDs = Array(centralToPeerID.values)
         subscribedCentrals.removeAll()
+        centralToPeerID.removeAll()
+        return peerIDs
     }
 
     func clearAll() {
         assertOwned()
         peripherals.removeAll()
+        peerToPeripheralUUID.removeAll()
         subscribedCentrals.removeAll()
+        centralToPeerID.removeAll()
     }
 }

bitchat/Services/BLE/BLELocalIdentityStateStore.swift

@@ -1,113 +0,0 @@
-import BitFoundation
-import Foundation
-
-struct BLELocalIdentitySnapshot: Equatable, Sendable {
-    let peerID: PeerID
-    let peerIDData: Data
-    let nickname: String
-    /// Runtime-toggled capability bits (e.g. the internet-gateway toggle)
-    /// ORed into `PeerCapabilities.localSupported` for every announce.
-    let runtimeCapabilities: PeerCapabilities
-    /// Rendezvous cell advertised while bridging; rides announces only
-    /// while the `.bridge` capability is enabled.
-    let bridgeGeohash: String?
-
-    var advertisedCapabilities: PeerCapabilities {
-        PeerCapabilities.localSupported.union(runtimeCapabilities)
-    }
-
-    var advertisedBridgeGeohash: String? {
-        runtimeCapabilities.contains(.bridge) ? bridgeGeohash : nil
-    }
-}
-
-/// Lock-backed local identity state shared by the transport's message,
-/// Bluetooth, maintenance, and main-actor entry points.
-///
-/// `peerID` and its binary wire representation must change as one unit during
-/// panic rotation. A snapshot also gives announce construction one consistent
-/// view of the nickname, identity, and advertised capabilities instead of
-/// reading independently mutable properties across queues.
-final class BLELocalIdentityStateStore: @unchecked Sendable {
-    private let lock = NSLock()
-    private var state: BLELocalIdentitySnapshot
-
-    init(
-        peerID: PeerID = PeerID(str: ""),
-        nickname: String = "anon"
-    ) {
-        state = BLELocalIdentitySnapshot(
-            peerID: peerID,
-            peerIDData: Data(hexString: peerID.id) ?? Data(),
-            nickname: nickname,
-            runtimeCapabilities: [],
-            bridgeGeohash: nil
-        )
-    }
-
-    func snapshot() -> BLELocalIdentitySnapshot {
-        lock.withLock { state }
-    }
-
-    func setNickname(_ nickname: String) {
-        lock.withLock {
-            state = BLELocalIdentitySnapshot(
-                peerID: state.peerID,
-                peerIDData: state.peerIDData,
-                nickname: nickname,
-                runtimeCapabilities: state.runtimeCapabilities,
-                bridgeGeohash: state.bridgeGeohash
-            )
-        }
-    }
-
-    func replacePeerIdentity(with peerID: PeerID) {
-        lock.withLock {
-            state = BLELocalIdentitySnapshot(
-                peerID: peerID,
-                peerIDData: Data(hexString: peerID.id) ?? Data(),
-                nickname: state.nickname,
-                runtimeCapabilities: state.runtimeCapabilities,
-                bridgeGeohash: state.bridgeGeohash
-            )
-        }
-    }
-
-    /// Flips a runtime capability bit. Returns whether anything changed.
-    @discardableResult
-    func setCapability(_ capability: PeerCapabilities, enabled: Bool) -> Bool {
-        lock.withLock {
-            var capabilities = state.runtimeCapabilities
-            if enabled {
-                capabilities.insert(capability)
-            } else {
-                capabilities.remove(capability)
-            }
-            guard capabilities != state.runtimeCapabilities else { return false }
-            state = BLELocalIdentitySnapshot(
-                peerID: state.peerID,
-                peerIDData: state.peerIDData,
-                nickname: state.nickname,
-                runtimeCapabilities: capabilities,
-                bridgeGeohash: state.bridgeGeohash
-            )
-            return true
-        }
-    }
-
-    /// Sets the bridged rendezvous cell. Returns whether anything changed.
-    @discardableResult
-    func setBridgeGeohash(_ cell: String?) -> Bool {
-        lock.withLock {
-            guard cell != state.bridgeGeohash else { return false }
-            state = BLELocalIdentitySnapshot(
-                peerID: state.peerID,
-                peerIDData: state.peerIDData,
-                nickname: state.nickname,
-                runtimeCapabilities: state.runtimeCapabilities,
-                bridgeGeohash: cell
-            )
-            return true
-        }
-    }
-}

bitchat/Services/BLE/BLEMeshPingTracker.swift

@@ -1,62 +0,0 @@
-import BitFoundation
-import Foundation
-
-struct BLEMeshPingProbe {
-    let peerID: PeerID
-    let sentAt: Date
-    let lifecycleGeneration: UInt64
-    let completion: @MainActor (MeshPingResult?) -> Void
-    let timeout: DispatchWorkItem
-}
-
-/// Engine-confined /ping diagnostics state: outstanding probes keyed by
-/// their unguessable nonce, plus the inbound response budget.
-///
-/// The budget is keyed by the ingress link (the directly connected peer
-/// that delivered the packet), never the packet-claimed sender: pings are
-/// unsigned, so the claimed sender is attacker-controlled and rotating it
-/// would reset the budget, turning a directed unencrypted probe into an
-/// amplification primitive.
-///
-/// Pure state — the transport owns packet I/O, timers, and main-actor
-/// completion delivery around it.
-struct BLEMeshPingTracker {
-    private var pendingProbes: [Data: BLEMeshPingProbe] = [:]
-    private var responseLimiter = SyncResponseRateLimiter(
-        maxResponses: TransportConfig.meshPingInboundMaxPerLink,
-        window: TransportConfig.meshPingInboundWindowSeconds
-    )
-
-    mutating func register(_ probe: BLEMeshPingProbe, nonce: Data) {
-        pendingProbes[nonce] = probe
-    }
-
-    /// Resolves a pong against its outstanding probe. The echoed nonce plus
-    /// the sender check bind the reply to the probed peer.
-    mutating func resolve(nonce: Data, from peerID: PeerID) -> BLEMeshPingProbe? {
-        guard pendingProbes[nonce]?.peerID == peerID else { return nil }
-        return pendingProbes.removeValue(forKey: nonce)
-    }
-
-    /// Removes a timed-out probe so its completion can fire once with nil.
-    mutating func expire(nonce: Data) -> BLEMeshPingProbe? {
-        pendingProbes.removeValue(forKey: nonce)
-    }
-
-    /// Whether an inbound ping delivered by this link is within budget.
-    mutating func shouldRespond(toLink linkPeerID: PeerID, now: Date) -> Bool {
-        responseLimiter.shouldRespond(to: linkPeerID, now: now)
-    }
-
-    /// Drops all probes and restores a fresh response budget (panic wipe).
-    /// Returns the orphaned timeout work items for the caller to cancel.
-    mutating func reset() -> [DispatchWorkItem] {
-        let timeouts = pendingProbes.values.map(\.timeout)
-        pendingProbes.removeAll()
-        responseLimiter = SyncResponseRateLimiter(
-            maxResponses: TransportConfig.meshPingInboundMaxPerLink,
-            window: TransportConfig.meshPingInboundWindowSeconds
-        )
-        return timeouts
-    }
-}

bitchat/Services/BLE/BLENoisePacketHandler.swift

@@ -1,18 +1,7 @@
 import BitFoundation
 import BitLogger
-import CryptoKit
 import Foundation
 
-struct BLENoiseHandshakeHandlingResult {
-    let processed: Bool
-    let didEstablishAuthenticatedSession: Bool
-}
-
-struct BLENoiseDecryptionResult {
-    let plaintext: Data
-    let sessionGeneration: UUID
-}
-
 /// Narrow environment for `BLENoisePacketHandler`.
 ///
 /// All queue hops (collections barrier writes, main-actor UI notification)
@@ -27,15 +16,10 @@ struct BLENoisePacketHandlerEnvironment {
     let messageTTL: UInt8
     /// Current time source.
     let now: () -> Date
-    /// Processes an inbound handshake message, returning its optional response
-    /// and whether that exact candidate authenticated (crypto).
-    let processHandshakeMessage:
-        (_ peerID: PeerID, _ message: Data) throws
-            -> NoiseHandshakeProcessingResult
+    /// Processes an inbound handshake message, returning an optional response payload (crypto).
+    let processHandshakeMessage: (_ peerID: PeerID, _ message: Data) throws -> Data?
     /// Whether any Noise session (established or pending) exists for the peer (crypto).
     let hasNoiseSession: (PeerID) -> Bool
-    /// Whether an inbound ordinary XX responder is waiting for message 3.
-    let isAwaitingResponderHandshakeCompletion: (PeerID) -> Bool
     /// Initiates a fresh Noise handshake with the peer (crypto + send).
     let initiateHandshake: (PeerID) -> Void
     /// Broadcasts a packet on the mesh (caller is already on the message queue).
@@ -43,16 +27,9 @@ struct BLENoisePacketHandlerEnvironment {
     /// Updates the registry last-seen timestamp for the peer (async barrier write).
     let updatePeerLastSeen: (PeerID) -> Void
     /// Decrypts an encrypted payload from the peer (crypto).
-    let decrypt: (_ payload: Data, _ peerID: PeerID) throws -> BLENoiseDecryptionResult
+    let decrypt: (_ payload: Data, _ peerID: PeerID) throws -> Data
     /// Clears the peer's Noise session after an unrecoverable decrypt failure (crypto).
     let clearSession: (PeerID) -> Void
-    /// Consumes session-authenticated protocol state inside the transport. It
-    /// must never escape to UI or Nostr payload dispatch.
-    let handleAuthenticatedPeerState: (
-        _ peerID: PeerID,
-        _ payload: Data,
-        _ sessionGeneration: UUID
-    ) -> Void
     /// Delivers `.noisePayloadReceived` to the UI as one main-actor hop.
     let deliverNoisePayload: (
         _ peerID: PeerID,
@@ -66,55 +43,19 @@ struct BLENoisePacketHandlerEnvironment {
 /// processing (with response), encrypted payload decryption and dispatch,
 /// and session recovery on decrypt failure.
 final class BLENoisePacketHandler {
-    private struct DeferredCiphertext {
-        let packet: BitchatPacket
-        let receivedAt: Date
-    }
-
-    /// Early post-handshake packets are normally tiny control messages or
-    /// queued DMs. Keep the recovery surface deliberately small so an
-    /// unauthenticated half-handshake cannot create an unbounded memory queue.
-    private static let maxDeferredPacketsPerPeer = 4
-    private static let maxDeferredPacketsGlobal = 32
-    /// One legacy sender can immediately follow message 3 with the largest
-    /// valid private-file ciphertext and has no application-level retry. Keep
-    /// room for that packet plus a small control-message budget.
-    private static let maxDeferredBytes =
-        NoiseSecurityConstants.maxPrivateFileCiphertextSize + 256 * 1024
-    private static let deferredLifetime =
-        NoiseSecurityConstants.ordinaryResponderHandshakeTimeout
-
     private let environment: BLENoisePacketHandlerEnvironment
-    private let deferredLock = NSLock()
-    private var deferredCiphertexts: [PeerID: [DeferredCiphertext]] = [:]
-    private var deferredCiphertextBytes = 0
 
     init(environment: BLENoisePacketHandlerEnvironment) {
         self.environment = environment
     }
 
-    /// Returns true when the handshake message was processed successfully.
-    /// Callers use this to distinguish an authenticated reconnect completion
-    /// from a rejected ordinary responder while rollback state is restored.
-    @discardableResult
-    func handleHandshake(_ packet: BitchatPacket, from peerID: PeerID) -> Bool {
-        handleHandshakeWithResult(packet, from: peerID).processed
-    }
-
-    func handleHandshakeWithResult(
-        _ packet: BitchatPacket,
-        from peerID: PeerID
-    ) -> BLENoiseHandshakeHandlingResult {
+    func handleHandshake(_ packet: BitchatPacket, from peerID: PeerID) {
         let env = environment
         // Use NoiseEncryptionService for handshake processing
         if PeerID(hexData: packet.recipientID) == env.localPeerID() {
             // Handshake is for us
             do {
-                let result = try env.processHandshakeMessage(
-                    peerID,
-                    packet.payload
-                )
-                if let response = result.response {
+                if let response = try env.processHandshakeMessage(peerID, packet.payload) {
                     // Send response
                     let responsePacket = BitchatPacket(
                         type: MessageType.noiseHandshake.rawValue,
@@ -129,76 +70,19 @@ final class BLENoisePacketHandler {
                     env.broadcastPacket(responsePacket)
                 }
 
-                // The serialized authentication callback installs transport
-                // state before it drains any bounded early ciphertext.
-                return BLENoiseHandshakeHandlingResult(
-                    processed: true,
-                    didEstablishAuthenticatedSession:
-                        result.didEstablishAuthenticatedSession
-                )
-            } catch let managedFailure as NoiseManagedHandshakeFailure {
-                SecureLogger.error(
-                    "Failed to process handshake; manager owns recovery: \(managedFailure.underlying)"
-                )
-                return BLENoiseHandshakeHandlingResult(
-                    processed: false,
-                    didEstablishAuthenticatedSession: false
-                )
-            } catch NoiseSessionError.peerIdentityMismatch {
-                // The responder was already discarded by the session manager.
-                // Do not let a spoofed claimed ID trigger a fresh outbound
-                // handshake or recreate state for the attacker-selected ID.
-                SecureLogger.warning(
-                    "Rejected Noise handshake whose static key does not match \(peerID.id.prefix(8))…",
-                    category: .security
-                )
-                return BLENoiseHandshakeHandlingResult(
-                    processed: false,
-                    didEstablishAuthenticatedSession: false
-                )
+                // Session establishment will trigger onPeerAuthenticated callback
+                // which will send any pending messages at the right time
             } catch {
                 SecureLogger.error("Failed to process handshake: \(error)")
                 // Try initiating a new handshake
                 if !env.hasNoiseSession(peerID) {
                     env.initiateHandshake(peerID)
                 }
-                return BLENoiseHandshakeHandlingResult(
-                    processed: false,
-                    didEstablishAuthenticatedSession: false
-                )
             }
         }
-        return BLENoiseHandshakeHandlingResult(
-            processed: false,
-            didEstablishAuthenticatedSession: false
-        )
     }
 
     func handleEncrypted(_ packet: BitchatPacket, from peerID: PeerID) {
-        handleEncrypted(packet, from: peerID, isDeferredRetry: false)
-    }
-
-    /// Called by the transport's serialized authentication callback after it
-    /// has installed state for the promoted or restored session generation.
-    func handleSessionAuthenticated(_ peerID: PeerID) {
-        drainDeferredCiphertextsIfReady(for: peerID)
-    }
-
-    /// Synchronously discards ciphertext retained for a pre-panic Noise
-    /// generation. The handler survives the service's identity replacement,
-    /// so keeping this queue would replay old bytes after post-panic auth.
-    func resetForPanic() {
-        deferredLock.lock()
-        deferredCiphertexts.removeAll(keepingCapacity: false)
-        deferredCiphertextBytes = 0
-        deferredLock.unlock()
-    }
-
-    private func handleEncrypted(
-        _ packet: BitchatPacket,
-        from peerID: PeerID,
-        isDeferredRetry: Bool
-    ) {
         let env = environment
         guard let recipientID = PeerID(hexData: packet.recipientID) else {
             SecureLogger.warning("⚠️ Encrypted message has no recipient ID", category: .session)
@@ -214,231 +98,35 @@ final class BLENoisePacketHandler {
         env.updatePeerLastSeen(peerID)
 
         do {
-            let decryption = try env.decrypt(packet.payload, peerID)
-            let decrypted = decryption.plaintext
+            let decrypted = try env.decrypt(packet.payload, peerID)
             guard decrypted.count > 0 else { return }
 
             // First byte indicates the payload type
             let payloadType = decrypted[0]
             let payloadData = decrypted.dropFirst()
 
-            guard let noisePayloadType = NoisePayloadType.decoded(rawValue: payloadType) else {
+            guard let noisePayloadType = NoisePayloadType(rawValue: payloadType) else {
                 SecureLogger.warning("⚠️ Unknown noise payload type: \(payloadType)")
                 return
             }
 
             SecureLogger.debug("🔐 Decrypted noise payload type \(noisePayloadType.description) from \(peerID.id.prefix(8))…", category: .session)
 
-            if noisePayloadType == .authenticatedPeerState {
-                env.handleAuthenticatedPeerState(
-                    peerID,
-                    Data(payloadData),
-                    decryption.sessionGeneration
-                )
-                return
-            }
-
             let ts = Date(timeIntervalSince1970: Double(packet.timestamp) / 1000)
             env.deliverNoisePayload(peerID, noisePayloadType, Data(payloadData), ts)
-        } catch NoiseEncryptionError.transportGenerationNotReady {
-            if isDeferredRetry {
-                SecureLogger.warning(
-                    "Dropping deferred Noise ciphertext from \(peerID.id.prefix(8))… because its authenticated transport generation changed again",
-                    category: .session
-                )
-                return
-            }
-            // The manager promoted or restored keys before BLE's serialized
-            // callback installed generation-bound transport state. The
-            // manager rejected this before decrypting, so replay is safe.
-            deferCiphertext(packet, from: peerID)
         } catch NoiseEncryptionError.sessionNotEstablished {
-            if isDeferredRetry {
-                SecureLogger.warning(
-                    "Dropping deferred Noise ciphertext from \(peerID.id.prefix(8))… because the authenticated session is unavailable",
-                    category: .session
-                )
-                return
-            }
             // We received an encrypted message before establishing a session with this peer.
-            // An initiator may already have sent message 3 followed by this
-            // ciphertext, with BLE delivering the ciphertext first.
-            if env.isAwaitingResponderHandshakeCompletion(peerID) {
-                deferCiphertext(packet, from: peerID)
-                return
-            }
-            // Otherwise trigger a handshake so future messages can decrypt.
+            // Trigger a handshake so future messages can be decrypted.
             SecureLogger.debug("🔑 Encrypted message from \(peerID.id.prefix(8))… without session; initiating handshake")
             if !env.hasNoiseSession(peerID) {
                 env.initiateHandshake(peerID)
             }
         } catch {
-            if isDeferredRetry {
-                // An early packet cannot tear down the authenticated session
-                // merely because its single bounded retry still fails.
-                SecureLogger.warning(
-                    "Dropping deferred Noise ciphertext from \(peerID.id.prefix(8))… after retry failed: \(error)",
-                    category: .session
-                )
-                return
-            }
-            // A responder may retain an older transport as receive-only
-            // rollback state while ordinary XX waits for message 3. New-key
-            // ciphertext can fail against those retained receive keys first.
-            if env.isAwaitingResponderHandshakeCompletion(peerID) {
-                if isDeferrableEarlyHandshakeFailure(error) {
-                    deferCiphertext(packet, from: peerID)
-                } else {
-                    SecureLogger.warning(
-                        "Dropping invalid Noise ciphertext from \(peerID.id.prefix(8))… while responder handshake is completing: \(error)",
-                        category: .session
-                    )
-                }
-                return
-            }
-            if isDropOnlyCiphertextFailure(error) {
-                // The packet is attacker-controlled and did not prove a
-                // transport-state failure. Never let malformed, replayed,
-                // forged, oversized, or rate-limited bytes evict working keys.
-                SecureLogger.warning(
-                    "Dropping rejected Noise ciphertext from \(peerID.id.prefix(8))… without clearing its session: \(error)",
-                    category: .security
-                )
-                return
-            }
             // Decryption failed - clear the corrupted session and re-initiate handshake
-            // Only local/session lifecycle failures reach this path.
+            // This handles cases where session state got out of sync (nonce mismatch, etc.)
             SecureLogger.error("❌ Failed to decrypt message from \(peerID.id.prefix(8))…: \(error) - clearing session and re-initiating handshake")
             env.clearSession(peerID)
             env.initiateHandshake(peerID)
         }
     }
-
-    private func isDeferrableEarlyHandshakeFailure(_ error: Error) -> Bool {
-        if let noiseError = error as? NoiseError {
-            switch noiseError {
-            case .authenticationFailure, .replayDetected:
-                return true
-            default:
-                return false
-            }
-        }
-        if let cryptoError = error as? CryptoKitError,
-           case .authenticationFailure = cryptoError {
-            return true
-        }
-        return false
-    }
-
-    private func isDropOnlyCiphertextFailure(_ error: Error) -> Bool {
-        if let securityError = error as? NoiseSecurityError {
-            switch securityError {
-            case .messageTooLarge, .rateLimitExceeded, .invalidPeerID:
-                return true
-            case .sessionExpired, .sessionExhausted:
-                return false
-            }
-        }
-        if let noiseError = error as? NoiseError {
-            switch noiseError {
-            case .invalidCiphertext, .authenticationFailure, .replayDetected:
-                return true
-            case .uninitializedCipher, .handshakeComplete,
-                    .handshakeNotComplete, .missingLocalStaticKey,
-                    .missingKeys, .invalidMessage, .invalidPublicKey,
-                    .nonceExceeded:
-                return false
-            }
-        }
-        return error is CryptoKitError
-    }
-
-    private func deferCiphertext(_ packet: BitchatPacket, from peerID: PeerID) {
-        guard NoiseSecurityValidator.validatePrivateFileCiphertextSize(
-            packet.payload
-        ) else {
-            SecureLogger.warning(
-                "Dropping oversized early Noise ciphertext from \(peerID.id.prefix(8))…",
-                category: .security
-            )
-            return
-        }
-
-        let now = environment.now()
-        deferredLock.lock()
-        defer { deferredLock.unlock() }
-        purgeExpiredCiphertextsLocked(now: now)
-
-        let peerCount = deferredCiphertexts[peerID]?.count ?? 0
-        let globalCount = deferredCiphertexts.values.reduce(0) {
-            $0 + $1.count
-        }
-        guard peerCount < Self.maxDeferredPacketsPerPeer,
-              globalCount < Self.maxDeferredPacketsGlobal,
-              deferredCiphertextBytes + packet.payload.count
-                <= Self.maxDeferredBytes else {
-            SecureLogger.warning(
-                "Dropping early Noise ciphertext from \(peerID.id.prefix(8))… because the handshake buffer is full",
-                category: .security
-            )
-            return
-        }
-
-        deferredCiphertexts[peerID, default: []].append(
-            DeferredCiphertext(packet: packet, receivedAt: now)
-        )
-        deferredCiphertextBytes += packet.payload.count
-        SecureLogger.debug(
-            "Deferring early Noise ciphertext from \(peerID.id.prefix(8))… until responder handshake completion",
-            category: .session
-        )
-    }
-
-    private func drainDeferredCiphertextsIfReady(for peerID: PeerID) {
-        let env = environment
-        guard !env.isAwaitingResponderHandshakeCompletion(peerID),
-              env.hasNoiseSession(peerID) else {
-            return
-        }
-
-        let now = env.now()
-        deferredLock.lock()
-        purgeExpiredCiphertextsLocked(now: now)
-        let deferred = deferredCiphertexts.removeValue(forKey: peerID) ?? []
-        deferredCiphertextBytes -= deferred.reduce(0) {
-            $0 + $1.packet.payload.count
-        }
-        deferredLock.unlock()
-
-        guard !deferred.isEmpty else { return }
-        SecureLogger.debug(
-            "Retrying \(deferred.count) early Noise ciphertext packet(s) from \(peerID.id.prefix(8))… after handshake completion",
-            category: .session
-        )
-        for item in deferred {
-            handleEncrypted(item.packet, from: peerID, isDeferredRetry: true)
-        }
-    }
-
-    private func purgeExpiredCiphertextsLocked(now: Date) {
-        for peerID in Array(deferredCiphertexts.keys) {
-            guard let items = deferredCiphertexts[peerID] else { continue }
-            let retained = items.filter {
-                now.timeIntervalSince($0.receivedAt) <= Self.deferredLifetime
-            }
-            guard retained.count != items.count else { continue }
-
-            deferredCiphertextBytes -= items.reduce(0) {
-                $0 + $1.packet.payload.count
-            }
-            deferredCiphertextBytes += retained.reduce(0) {
-                $0 + $1.packet.payload.count
-            }
-            if retained.isEmpty {
-                deferredCiphertexts.removeValue(forKey: peerID)
-            } else {
-                deferredCiphertexts[peerID] = retained
-            }
-        }
-    }
 }

bitchat/Services/BLE/BLENoisePayloadFactory.swift

@@ -17,16 +17,6 @@ enum BLENoisePayloadFactory {
         typedPayload(.delivered, payload: Data(messageID.utf8))
     }
 
-    static func privateFile(_ filePacket: BitchatFilePacket) -> Data? {
-        guard let payload = filePacket.encode() else { return nil }
-        return typedPayload(.privateFile, payload: payload)
-    }
-
-    static func authenticatedPeerState(_ state: AuthenticatedPeerStatePacket) -> Data? {
-        guard let payload = state.encode() else { return nil }
-        return typedPayload(.authenticatedPeerState, payload: payload)
-    }
-
     static func typedPayload(_ type: NoisePayloadType, payload: Data) -> Data {
         var typed = Data([type.rawValue])
         typed.append(payload)

bitchat/Services/BLE/BLENoiseReconnectPolicy.swift

@@ -1,40 +0,0 @@
-import Foundation
-
-/// Bounds ordinary Noise revalidation to one attempt per physical-link epoch.
-/// A live epoch may retry after the cooldown so a lost handshake cannot leave
-/// the link permanently unauthenticated.
-struct BLENoiseReconnectPolicy {
-    static let minimumRetryInterval: TimeInterval = 60
-
-    private var lastAttemptAt: [BLEIngressLinkID: Date] = [:]
-
-    mutating func shouldRevalidate(
-        on link: BLEIngressLinkID,
-        hasEstablishedSession: Bool,
-        isNoiseAuthenticatedLink: Bool,
-        hasAuthenticatedPeerLink: Bool,
-        now: Date
-    ) -> Bool {
-        guard hasEstablishedSession,
-              !isNoiseAuthenticatedLink,
-              !hasAuthenticatedPeerLink else {
-            return false
-        }
-        if let previous = lastAttemptAt[link],
-           now.timeIntervalSince(previous) < Self.minimumRetryInterval {
-            return false
-        }
-        lastAttemptAt[link] = now
-        return true
-    }
-
-    /// Link identifiers can be stable across CoreBluetooth reconnects, so a
-    /// disconnect explicitly starts a new epoch and permits one fresh attempt.
-    mutating func endLinkEpoch(_ link: BLEIngressLinkID) {
-        lastAttemptAt.removeValue(forKey: link)
-    }
-
-    mutating func removeAll() {
-        lastAttemptAt.removeAll()
-    }
-}

bitchat/Services/BLE/BLENoiseSessionQueues.swift

@@ -6,16 +6,9 @@ struct BLEPendingPrivateMessage: Equatable {
     let messageID: String
 }
 
-struct BLEPendingTypedPayload: Equatable {
-    let payload: Data
-    /// Present for app-initiated media so handshake queuing preserves the
-    /// fragment scheduler's progress/cancellation identity.
-    let transferId: String?
-}
-
 struct BLENoiseSessionQueues {
     private var privateMessagesByPeerID: [PeerID: [BLEPendingPrivateMessage]] = [:]
-    private var typedPayloadsByPeerID: [PeerID: [BLEPendingTypedPayload]] = [:]
+    private var typedPayloadsByPeerID: [PeerID: [Data]] = [:]
 
     var isEmpty: Bool {
         privateMessagesByPeerID.isEmpty && typedPayloadsByPeerID.isEmpty
@@ -41,35 +34,13 @@ struct BLENoiseSessionQueues {
         privateMessagesByPeerID[peerID, default: []].insert(contentsOf: messages, at: 0)
     }
 
-    mutating func appendTypedPayload(_ payload: Data, transferId: String? = nil, for peerID: PeerID) {
-        typedPayloadsByPeerID[peerID, default: []].append(
-            BLEPendingTypedPayload(payload: payload, transferId: transferId)
-        )
+    mutating func appendTypedPayload(_ payload: Data, for peerID: PeerID) {
+        typedPayloadsByPeerID[peerID, default: []].append(payload)
     }
 
-    mutating func takeTypedPayloads(for peerID: PeerID) -> [BLEPendingTypedPayload] {
+    mutating func takeTypedPayloads(for peerID: PeerID) -> [Data] {
         let payloads = typedPayloadsByPeerID[peerID] ?? []
         typedPayloadsByPeerID.removeValue(forKey: peerID)
         return payloads
     }
-
-    func containsTypedPayload(transferId: String) -> Bool {
-        typedPayloadsByPeerID.values.contains { payloads in
-            payloads.contains { $0.transferId == transferId }
-        }
-    }
-
-    @discardableResult
-    mutating func removeTypedPayload(transferId: String) -> Bool {
-        for peerID in Array(typedPayloadsByPeerID.keys) {
-            guard var payloads = typedPayloadsByPeerID[peerID],
-                  let index = payloads.firstIndex(where: { $0.transferId == transferId }) else {
-                continue
-            }
-            payloads.remove(at: index)
-            typedPayloadsByPeerID[peerID] = payloads.isEmpty ? nil : payloads
-            return true
-        }
-        return false
-    }
 }

bitchat/Services/BLE/BLEOutboundFragmentPlanner.swift

@@ -17,9 +17,6 @@ struct BLEOutboundFragmentPlan {
 }
 
 enum BLEOutboundFragmentPlanner {
-    /// Current Android receivers reject fragment sets above 256. Private
-    /// media v1 treats that deployed ceiling as a cross-platform contract.
-    static let privateMediaV1MaxFragments = 256
     private static let minimumChunkSize = 64
     private static let fragmentIDLength = 8
 
@@ -74,10 +71,6 @@ enum BLEOutboundFragmentPlanner {
         )
     }
 
-    static func isPrivateMediaV1Compatible(_ plan: BLEOutboundFragmentPlan) -> Bool {
-        plan.totalFragments <= privateMediaV1MaxFragments
-    }
-
     private static func sizingPolicy(
         for packet: BitchatPacket,
         requestedMaxChunk: Int?,

bitchat/Services/BLE/BLEOutboundFragmentTransferScheduler.swift

@@ -7,54 +7,10 @@ struct BLEOutboundFragmentTransferRequest {
     let maxChunk: Int?
     let directedPeer: PeerID?
     let transferId: String?
-    let requireDirectPeerLink: Bool
-    let requireNoiseAuthenticatedPeerLink: Bool
-
-    init(
-        packet: BitchatPacket,
-        pad: Bool,
-        maxChunk: Int?,
-        directedPeer: PeerID?,
-        transferId: String?,
-        requireDirectPeerLink: Bool = false,
-        requireNoiseAuthenticatedPeerLink: Bool = false
-    ) {
-        self.packet = packet
-        self.pad = pad
-        self.maxChunk = maxChunk
-        self.directedPeer = directedPeer
-        self.transferId = transferId
-        self.requireDirectPeerLink = requireDirectPeerLink
-        self.requireNoiseAuthenticatedPeerLink = requireNoiseAuthenticatedPeerLink
-    }
 
     var resolvedTransferId: String? {
-        if let transferId { return transferId }
         guard packet.type == MessageType.fileTransfer.rawValue else { return nil }
-        return packet.payload.sha256Hex()
-    }
-
-    /// Content identity independent of the caller-chosen transfer ID: the
-    /// same file resent through another path (gossip-sync replay, retry)
-    /// arrives with a different explicit transferId but identical payload.
-    var contentKey: String? {
-        guard packet.type == MessageType.fileTransfer.rawValue else { return nil }
-        return packet.payload.sha256Hex()
-    }
-}
-
-/// Transactional admission for strict fragment trains. Durable callers may
-/// commit only when every fragment was accepted; the first rejection stops
-/// the train and reports failure so the original remains retryable.
-enum BLEStrictFragmentAdmission {
-    static func admitAll<Fragment>(
-        _ fragments: [Fragment],
-        accepting: (Fragment) -> Bool
-    ) -> Bool {
-        for fragment in fragments where !accepting(fragment) {
-            return false
-        }
-        return true
+        return transferId ?? packet.payload.sha256Hex()
     }
 }
 
@@ -67,16 +23,6 @@ struct BLEOutboundFragmentTransferScheduler {
     enum SubmitResult {
         case start(request: BLEOutboundFragmentTransferRequest, reservedTransferId: String?)
         case queued(request: BLEOutboundFragmentTransferRequest, transferId: String?, position: QueuePosition)
-        /// Strict direct-link requests are transactional: returning false to
-        /// their durable owner must mean no process-local copy remains that
-        /// can transmit later. They are therefore start-or-reject, never
-        /// admitted to `pendingTransfers`.
-        case rejectedStrict(request: BLEOutboundFragmentTransferRequest, transferId: String?)
-        /// The same file is already being (or waiting to be) fragmented out
-        /// to an audience covering this request; sending it again would just
-        /// double the airtime (field-verified: one 41KB voice file went out
-        /// as two complete fragment streams).
-        case droppedDuplicate(request: BLEOutboundFragmentTransferRequest, activeTransferId: String?)
     }
 
     enum CancelResult {
@@ -92,34 +38,14 @@ struct BLEOutboundFragmentTransferScheduler {
     }
 
     private struct ActiveTransferState {
-        var totalFragments: Int
+        let totalFragments: Int
         var sentFragments: Int
         var workItems: [DispatchWorkItem]
-        var contentKey: String?
-        var directedPeer: PeerID?
     }
 
     private var activeTransfers: [String: ActiveTransferState] = [:]
     private var pendingTransfers: [BLEOutboundFragmentTransferRequest] = []
 
-    /// A transfer of the same content whose audience covers `directedPeer`:
-    /// a broadcast covers every peer; a directed transfer covers only its
-    /// recipient. A directed resend to a peer NOT covered by what's in
-    /// flight (different recipient of a private file) is never a duplicate.
-    private func coveringDuplicate(contentKey: String, directedPeer: PeerID?) -> String? {
-        for (transferId, state) in activeTransfers where state.contentKey == contentKey {
-            if state.directedPeer == nil || state.directedPeer == directedPeer {
-                return transferId
-            }
-        }
-        for request in pendingTransfers where request.contentKey == contentKey {
-            if request.directedPeer == nil || request.directedPeer == directedPeer {
-                return request.resolvedTransferId
-            }
-        }
-        return nil
-    }
-
     var activeCount: Int {
         activeTransfers.count
     }
@@ -143,39 +69,17 @@ struct BLEOutboundFragmentTransferScheduler {
             return .start(request: request, reservedTransferId: nil)
         }
 
-        // Only requests without an explicit transferId are dropped as
-        // duplicates: those are resend paths (gossip-sync replay, directed
-        // spool) with no UI waiting on them. An app-initiated send carries a
-        // transferId whose progress events the UI tracks, so it always runs.
-        if request.transferId == nil,
-           let contentKey = request.contentKey,
-           let coveringId = coveringDuplicate(contentKey: contentKey, directedPeer: request.directedPeer) {
-            return .droppedDuplicate(request: request, activeTransferId: coveringId)
-        }
-
         guard activeTransfers.count < maxConcurrentTransfers else {
-            if request.requireDirectPeerLink {
-                return .rejectedStrict(request: request, transferId: transferId)
-            }
             pendingTransfers.append(request)
             return .queued(request: request, transferId: transferId, position: .back)
         }
 
         guard activeTransfers[transferId] == nil else {
-            if request.requireDirectPeerLink {
-                return .rejectedStrict(request: request, transferId: transferId)
-            }
             pendingTransfers.insert(request, at: 0)
             return .queued(request: request, transferId: transferId, position: .front)
         }
 
-        activeTransfers[transferId] = ActiveTransferState(
-            totalFragments: 0,
-            sentFragments: 0,
-            workItems: [],
-            contentKey: request.contentKey,
-            directedPeer: request.directedPeer
-        )
+        activeTransfers[transferId] = ActiveTransferState(totalFragments: 0, sentFragments: 0, workItems: [])
         return .start(request: request, reservedTransferId: transferId)
     }
 
@@ -184,11 +88,12 @@ struct BLEOutboundFragmentTransferScheduler {
         totalFragments: Int,
         workItems: [DispatchWorkItem]
     ) -> Bool {
-        guard var state = activeTransfers[transferId] else { return false }
-        state.totalFragments = totalFragments
-        state.sentFragments = 0
-        state.workItems = workItems
-        activeTransfers[transferId] = state
+        guard activeTransfers[transferId] != nil else { return false }
+        activeTransfers[transferId] = ActiveTransferState(
+            totalFragments: totalFragments,
+            sentFragments: 0,
+            workItems: workItems
+        )
         return true
     }
 
@@ -244,23 +149,13 @@ struct BLEOutboundFragmentTransferScheduler {
 
         while availableSlots > 0, !pendingTransfers.isEmpty {
             let request = pendingTransfers.removeFirst()
+            availableSlots -= 1
 
             guard let transferId = request.resolvedTransferId else {
-                availableSlots -= 1
                 results.append(.start(request: request, reservedTransferId: nil))
                 continue
             }
 
-            // A queued duplicate of content that started while it waited
-            // must not resend the whole file once the slot frees up (same
-            // explicit-transferId exemption as submit).
-            if request.transferId == nil,
-               let contentKey = request.contentKey,
-               let coveringId = coveringDuplicate(contentKey: contentKey, directedPeer: request.directedPeer) {
-                results.append(.droppedDuplicate(request: request, activeTransferId: coveringId))
-                continue
-            }
-
             guard activeTransfers.count < maxConcurrentTransfers else {
                 pendingTransfers.insert(request, at: 0)
                 results.append(.queued(request: request, transferId: transferId, position: .front))
@@ -268,24 +163,12 @@ struct BLEOutboundFragmentTransferScheduler {
             }
 
             guard activeTransfers[transferId] == nil else {
-                // Blocked on an already-active copy of this content: leave
-                // the slot budget untouched so a later, unrelated pending
-                // transfer can still start in this same pass instead of
-                // being starved until some other transfer happens to
-                // complete.
                 blockedFront.append(request)
                 results.append(.queued(request: request, transferId: transferId, position: .front))
                 continue
             }
 
-            availableSlots -= 1
-            activeTransfers[transferId] = ActiveTransferState(
-                totalFragments: 0,
-                sentFragments: 0,
-                workItems: [],
-                contentKey: request.contentKey,
-                directedPeer: request.directedPeer
-            )
+            activeTransfers[transferId] = ActiveTransferState(totalFragments: 0, sentFragments: 0, workItems: [])
             results.append(.start(request: request, reservedTransferId: transferId))
         }
 

bitchat/Services/BLE/BLEOutboundLinkPlanner.swift

@@ -20,15 +20,22 @@ enum BLEOutboundLinkPlanner {
         excludedLinks: Set<BLEIngressLinkID>,
         peripheralPeerBindings: [String: PeerID] = [:],
         centralPeerBindings: [String: PeerID] = [:],
-        preferredPeripheralPerPeer: [PeerID: String] = [:],
-        directAnnounceTTL: UInt8 = TransportConfig.messageTTLDefault,
-        directedOnlyPeer: PeerID?,
-        requireDirectPeerLink: Bool = false
+        directedOnlyPeer: PeerID?
     ) -> BLEOutboundLinkPlan {
+        if let minLimit = minimumLinkLimit(
+            peripheralWriteLimits: peripheralWriteLimits,
+            centralNotifyLimits: centralNotifyLimits
+        ), packet.type != MessageType.fragment.rawValue,
+           dataCount > minLimit {
+            return BLEOutboundLinkPlan(
+                directedPeerHint: directedPeerHint(for: packet, explicitPeer: directedOnlyPeer),
+                fragmentChunkSize: BLEOutboundPacketPolicy.fragmentChunkSize(forLinkLimit: minLimit),
+                selectedLinks: BLEFanoutSelection(peripheralIDs: [], centralIDs: []),
+                shouldSpoolDirectedPacket: false
+            )
+        }
+
         let directedPeerHint = directedPeerHint(for: packet, explicitPeer: directedOnlyPeer)
-        // Direct announces bypass the per-peer duplicate-link collapse so
-        // every live link gets bound (see BLEFanoutSelector.selectLinks).
-        let isDirectAnnounce = packet.type == MessageType.announce.rawValue && packet.ttl == directAnnounceTTL
         let selectedLinks = BLEFanoutSelector.selectLinks(
             peripheralIDs: peripheralIDs,
             centralIDs: centralIDs,
@@ -36,37 +43,11 @@ enum BLEOutboundLinkPlanner {
             excludedLinks: excludedLinks,
             peripheralPeerBindings: peripheralPeerBindings,
             centralPeerBindings: centralPeerBindings,
-            preferredPeripheralPerPeer: preferredPeripheralPerPeer,
-            collapseDuplicatePeerLinks: !isDirectAnnounce,
             directedPeerHint: directedPeerHint,
-            requireDirectPeerLink: requireDirectPeerLink,
             packetType: packet.type,
             messageID: BLEOutboundPacketPolicy.messageID(for: packet)
         )
 
-        // Fragment only for links that this packet can actually use. Looking
-        // at every connected link before directed-peer selection lets an
-        // unrelated peer's MTU make an oversized directed send look routable,
-        // even though every resulting fragment will select zero target links.
-        let selectedPeripheralLimits = zip(peripheralIDs, peripheralWriteLimits).compactMap { id, limit in
-            selectedLinks.peripheralIDs.contains(id) ? limit : nil
-        }
-        let selectedCentralLimits = zip(centralIDs, centralNotifyLimits).compactMap { id, limit in
-            selectedLinks.centralIDs.contains(id) ? limit : nil
-        }
-        if let minLimit = minimumLinkLimit(
-            peripheralWriteLimits: selectedPeripheralLimits,
-            centralNotifyLimits: selectedCentralLimits
-        ), packet.type != MessageType.fragment.rawValue,
-           dataCount > minLimit {
-            return BLEOutboundLinkPlan(
-                directedPeerHint: directedPeerHint,
-                fragmentChunkSize: BLEOutboundPacketPolicy.fragmentChunkSize(forLinkLimit: minLimit),
-                selectedLinks: selectedLinks,
-                shouldSpoolDirectedPacket: false
-            )
-        }
-
         return BLEOutboundLinkPlan(
             directedPeerHint: directedPeerHint,
             fragmentChunkSize: nil,

bitchat/Services/BLE/BLEOutboundNotificationBuffer.swift

@@ -44,16 +44,4 @@ struct BLEOutboundNotificationBuffer<Target> {
         guard !pending.isEmpty else { return }
         notifications.insert(contentsOf: pending, at: 0)
     }
-
-    /// Removes a disconnected target from target-specific retries. Broadcast
-    /// entries (`targets == nil`) remain valid for the surviving subscriber
-    /// set; an entry with no targets left is discarded entirely.
-    mutating func removeTarget(where matches: (Target) -> Bool) {
-        notifications = notifications.compactMap { notification in
-            guard let targets = notification.targets else { return notification }
-            let remaining = targets.filter { !matches($0) }
-            guard !remaining.isEmpty else { return nil }
-            return BLEPendingNotification(data: notification.data, targets: remaining)
-        }
-    }
 }

bitchat/Services/BLE/BLEOutboundPacketPolicy.swift

@@ -15,15 +15,7 @@ enum BLEOutboundPacketPolicy {
         // voiceFrame is deliberately unpadded: padding to the 512 block would
         // push every ~490-byte signed voice packet over the MTU into the
         // fragment path.
-        //
-        // announceV2 is unpadded too, but for a different reason and it is worth
-        // revisiting: it is ~75 bytes, so the smallest bucket would triple the
-        // airtime of the most frequently sent packet in the protocol. Its length
-        // is already near-constant by construction (the tag block is fixed
-        // width); the residual variation is the capability width and whether a
-        // bridge geohash is present. Making those fixed-width would be cheaper
-        // than padding. See docs/PEER-ID-ROTATION.md.
-        case .none, .announce, .announceV2, .message, .leave, .requestSync, .fragment, .fileTransfer, .courierEnvelope, .boardPost, .ping, .pong, .nostrCarrier, .prekeyBundle, .groupMessage, .voiceFrame:
+        case .none, .announce, .message, .leave, .requestSync, .fragment, .fileTransfer, .courierEnvelope, .boardPost, .ping, .pong, .nostrCarrier, .prekeyBundle, .groupMessage, .voiceFrame:
             return false
         }
     }
@@ -35,13 +27,6 @@ enum BLEOutboundPacketPolicy {
             return .fragment(totalFragments: fragmentTotalCount(from: packet.payload))
         case .fileTransfer:
             return .fileTransfer
-        case .announceV2:
-            // Stated rather than inherited from `default`. Presence is small,
-            // time-bounded to its epoch, and useless once stale, so it belongs
-            // with the other control traffic at high priority — but that should
-            // be a decision on the record, not a fall-through, since this type
-            // is not emitted yet and nobody would notice the choice being made.
-            return .high
         default:
             return .high
         }

bitchat/Services/BLE/BLEOutboundWriteBuffer.swift

@@ -46,25 +46,8 @@ struct BLEOutboundWriteBuffer {
         priority: BLEOutboundWritePriority,
         capBytes: Int
     ) -> EnqueueResult {
-        enqueueReportingAcceptance(
-            data: data,
-            for: peripheralID,
-            priority: priority,
-            capBytes: capBytes
-        ).result
-    }
-
-    /// Enqueues while also reporting whether the newly offered write survived
-    /// priority trimming. `EnqueueResult.enqueued` alone cannot express that:
-    /// a full queue may immediately trim the new lowest-priority item.
-    mutating func enqueueReportingAcceptance(
-        data: Data,
-        for peripheralID: String,
-        priority: BLEOutboundWritePriority,
-        capBytes: Int
-    ) -> (result: EnqueueResult, accepted: Bool) {
         guard data.count <= capBytes else {
-            return (.oversized(bytes: data.count), false)
+            return .oversized(bytes: data.count)
         }
 
         var queue = writesByPeripheralID[peripheralID] ?? []
@@ -82,8 +65,7 @@ struct BLEOutboundWriteBuffer {
         }
 
         writesByPeripheralID[peripheralID] = queue.isEmpty ? nil : queue
-        let accepted = insertIndex < queue.count
-        return (.enqueued(trimmedBytes: trimmedBytes, remainingBytes: total), accepted)
+        return .enqueued(trimmedBytes: trimmedBytes, remainingBytes: total)
     }
 
     mutating func takeAll(for peripheralID: String) -> [BLEPendingWrite] {
@@ -92,13 +74,6 @@ struct BLEOutboundWriteBuffer {
         return items
     }
 
-    /// Drops link-specific ciphertext when that physical link is gone. Keeping
-    /// the dictionary entry would let rotating peripheral UUIDs accumulate a
-    /// fresh per-link byte cap indefinitely.
-    mutating func discardAll(for peripheralID: String) {
-        writesByPeripheralID[peripheralID] = nil
-    }
-
     mutating func prepend(_ items: [BLEPendingWrite], for peripheralID: String) {
         guard !items.isEmpty else { return }
         var existing = writesByPeripheralID[peripheralID] ?? []

bitchat/Services/BLE/BLEPeerRegistry.swift

@@ -10,9 +10,6 @@ struct BLEPeerInfo: Equatable {
     var isVerifiedNickname: Bool
     var lastSeen: Date
     var capabilities: PeerCapabilities = []
-    /// Distinguishes an old client that omitted the capabilities TLV from a
-    /// modern client that explicitly advertised a set without a given bit.
-    var capabilitiesWereExplicitlyAdvertised: Bool = false
     /// Rendezvous cell from the peer's announce when it advertises `.bridge`.
     var bridgeGeohash: String?
 }
@@ -117,10 +114,6 @@ struct BLEPeerRegistry {
         peers[peerID.toShort()]?.capabilities ?? []
     }
 
-    func capabilitiesWereExplicitlyAdvertised(for peerID: PeerID) -> Bool {
-        peers[peerID.toShort()]?.capabilitiesWereExplicitlyAdvertised == true
-    }
-
     /// Peers whose last verified announce advertised the given capability.
     func peers(advertising capability: PeerCapabilities) -> [PeerID] {
         peers.values.filter { $0.capabilities.contains(capability) }.map(\.peerID)
@@ -165,38 +158,12 @@ struct BLEPeerRegistry {
         peers[peerID] = info
     }
 
-    /// Flips an already-known peer to connected. Returns false when the peer
-    /// is unknown or already connected (nothing changed).
-    @discardableResult
-    mutating func markConnected(_ peerID: PeerID) -> Bool {
-        guard var info = peers[peerID], !info.isConnected else { return false }
-        info.isConnected = true
-        peers[peerID] = info
-        return true
-    }
-
     mutating func updateLastSeen(_ peerID: PeerID, at date: Date) {
         guard var peer = peers[peerID] else { return }
         peer.lastSeen = date
         peers[peerID] = peer
     }
 
-    /// Replaces the announcement signing key only after the surrounding Noise
-    /// session proved possession of this peer's static key.
-    mutating func bindAuthenticatedSigningPublicKey(_ key: Data, for peerID: PeerID) {
-        guard var peer = peers[peerID.toShort()] else { return }
-        peer.signingPublicKey = key
-        peers[peer.peerID] = peer
-    }
-
-    /// Applies a verified announce to the registry.
-    ///
-    /// TOFU signing-key pinning: once a signing key has been bound to this
-    /// peer entry, an announce carrying a *different* signing key is refused
-    /// (returns `nil`) and the existing record is left untouched. PeerIDs are
-    /// derived from the (public) noise key, so without pinning an attacker
-    /// could replay a victim's noiseKey/peerID with their own signing key and
-    /// silently take over the victim's mesh identity and nickname.
     mutating func upsertVerifiedAnnounce(
         peerID: PeerID,
         nickname: String,
@@ -204,17 +171,10 @@ struct BLEPeerRegistry {
         signingPublicKey: Data?,
         isConnected: Bool,
         now: Date,
-        capabilities: PeerCapabilities? = nil,
+        capabilities: PeerCapabilities = [],
         bridgeGeohash: String? = nil
-    ) -> BLEPeerAnnounceUpdate? {
+    ) -> BLEPeerAnnounceUpdate {
         let existing = peers[peerID]
-
-        if let pinnedSigningKey = existing?.signingPublicKey,
-           let announcedSigningKey = signingPublicKey,
-           pinnedSigningKey != announcedSigningKey {
-            return nil
-        }
-
         let update = BLEPeerAnnounceUpdate(
             isNewPeer: existing == nil,
             wasDisconnected: existing?.isConnected == false,
@@ -223,15 +183,13 @@ struct BLEPeerRegistry {
 
         peers[peerID] = BLEPeerInfo(
             peerID: existing?.peerID ?? peerID,
-            nickname: nickname.normalizedNickname,
+            nickname: nickname,
             isConnected: isConnected,
             noisePublicKey: noisePublicKey,
-            // Never drop an already-pinned signing key.
-            signingPublicKey: signingPublicKey ?? existing?.signingPublicKey,
+            signingPublicKey: signingPublicKey,
             isVerifiedNickname: true,
             lastSeen: now,
-            capabilities: capabilities ?? [],
-            capabilitiesWereExplicitlyAdvertised: capabilities != nil,
+            capabilities: capabilities,
             bridgeGeohash: bridgeGeohash
         )
 

bitchat/Services/BLE/BLEPeerRegistryStore.swift

@@ -1,84 +0,0 @@
-import BitFoundation
-import Foundation
-
-/// Lock-backed shared ownership of the peer registry, readable from any
-/// queue or the main actor without hopping onto a transport queue.
-///
-/// Mutations come only from the transport's own serial queues — the
-/// engine, plus the bleQueue link-drop paths that mark a peer
-/// disconnected — and the lock serializes them against each other and
-/// against readers, so the main actor answers questions like
-/// `isPeerConnected` without blocking behind in-flight transport work.
-/// Every `BLEPeerRegistry` mutation is a single whole-transition method,
-/// so a reader between two mutations always observes a valid pre- or
-/// post-state, never a torn one.
-///
-/// Closures passed to `read`/`mutate` run under the (non-recursive) lock
-/// and must not call back into the store.
-final class BLEPeerRegistryStore: @unchecked Sendable {
-    private let lock = NSLock()
-    private var registry = BLEPeerRegistry()
-
-    /// One consistent view across multiple registry reads.
-    func read<T>(_ body: (BLEPeerRegistry) -> T) -> T {
-        lock.withLock { body(registry) }
-    }
-
-    func mutate<T>(_ body: (inout BLEPeerRegistry) -> T) -> T {
-        lock.withLock { body(&registry) }
-    }
-
-    // MARK: - Single-question reads
-
-    var isEmpty: Bool { read { $0.isEmpty } }
-    var peerIDs: [PeerID] { read { $0.peerIDs } }
-    var connectedCount: Int { read { $0.connectedCount } }
-    var connectedPeerIDs: [PeerID] { read { $0.connectedPeerIDs } }
-    var connectedRoutingData: [Data] { read { $0.connectedRoutingData } }
-    var snapshotByID: [PeerID: BLEPeerInfo] { read { $0.snapshotByID } }
-
-    func info(for peerID: PeerID) -> BLEPeerInfo? {
-        read { $0.info(for: peerID) }
-    }
-
-    func isConnected(_ peerID: PeerID) -> Bool {
-        read { $0.isConnected(peerID) }
-    }
-
-    func isReachable(_ peerID: PeerID, now: Date) -> Bool {
-        read { $0.isReachable(peerID, now: now) }
-    }
-
-    func nickname(for peerID: PeerID, connectedOnly: Bool) -> String? {
-        read { $0.nickname(for: peerID, connectedOnly: connectedOnly) }
-    }
-
-    func fingerprint(for peerID: PeerID) -> String? {
-        read { $0.fingerprint(for: peerID) }
-    }
-
-    func capabilities(for peerID: PeerID) -> PeerCapabilities {
-        read { $0.capabilities(for: peerID) }
-    }
-
-    func advertisedBridgeGeohash() -> String? {
-        read { $0.advertisedBridgeGeohash() }
-    }
-
-    func displayNicknames(selfNickname: String) -> [PeerID: String] {
-        read { $0.displayNicknames(selfNickname: selfNickname) }
-    }
-
-    func transportSnapshots(selfNickname: String) -> [TransportPeerSnapshot] {
-        read { $0.transportSnapshots(selfNickname: selfNickname) }
-    }
-
-    /// Peers advertising `capability` that are reachable now, in one
-    /// consistent view.
-    func reachablePeers(advertising capability: PeerCapabilities, now: Date) -> [PeerID] {
-        read { registry in
-            registry.peers(advertising: capability)
-                .filter { registry.isReachable($0, now: now) }
-        }
-    }
-}

bitchat/Services/BLE/BLEPrivateMediaSessionStore.swift

@@ -1,363 +0,0 @@
-import BitFoundation
-import Foundation
-
-struct BLEAuthenticatedPeerStateObservation {
-    let fingerprint: String
-    let sessionGeneration: UUID
-    let capabilities: PeerCapabilities
-}
-
-struct BLEPrivateMediaProofTimeoutMarker {
-    let fingerprint: String
-    let sessionGeneration: UUID?
-}
-
-struct BLEPrivateMediaProofWatchdog {
-    let fingerprint: String
-    let sessionGeneration: UUID
-    let timeoutNonce: UUID
-}
-
-struct BLEPendingPrivateMediaPolicyResolution {
-    let fingerprint: String
-    var sessionGeneration: UUID?
-    var timeoutNonce: UUID
-    var completions: [UUID: @MainActor (PrivateMediaSendPolicy) -> Void]
-}
-
-struct BLEAuthenticatedPeerStateSendProgress {
-    let sessionGeneration: UUID
-    var sentInitial = false
-    var sentEcho = false
-}
-
-/// Lock-backed private-media session state: which Noise generation each
-/// peer's capability proof, peer-state exchange, and policy waiters are
-/// bound to. A fresh Noise authentication rotates the generation UUID, so
-/// stale proof timers and proof packets cannot classify a replacement
-/// session.
-///
-/// Lock-backed rather than engine-confined for two reasons: the send
-/// policy is answered synchronously on the main actor, and several
-/// transitions run inside noise-manager critical sections that the engine
-/// is sync-waiting on (where re-entering the engine would self-deadlock,
-/// but taking a leaf lock is safe). Every method is one whole transition
-/// under the lock, so no caller can observe a torn intermediate state.
-final class BLEPrivateMediaSessionStore: @unchecked Sendable {
-    private let lock = NSLock()
-    private var sessionGenerations: [PeerID: UUID] = [:]
-    private var authenticatedStates: [PeerID: BLEAuthenticatedPeerStateObservation] = [:]
-    private var proofTimeoutMarkers: [PeerID: BLEPrivateMediaProofTimeoutMarker] = [:]
-    private var proofWatchdogs: [PeerID: BLEPrivateMediaProofWatchdog] = [:]
-    private var pendingPolicyResolutions: [PeerID: BLEPendingPrivateMediaPolicyResolution] = [:]
-    private var stateSendProgress: [PeerID: BLEAuthenticatedPeerStateSendProgress] = [:]
-    /// Peers whose parked outbound queues must stay parked until the
-    /// convergence retry re-authenticates: a timeout-restore brings back
-    /// keys the counterpart may have already discarded, so nothing — not
-    /// even the capability-proof watchdog — may drain the queues under
-    /// them. Set on the deferred restore transition, cleared by any
-    /// transition that is allowed to drain.
-    private var outboundConvergenceDeferred: Set<PeerID> = []
-
-    // MARK: Reads
-
-    func currentGeneration(for peerID: PeerID) -> UUID? {
-        lock.withLock { sessionGenerations[peerID] }
-    }
-
-    /// The exact current generation iff it authenticated both encrypted
-    /// private media (bit 8) and durable receipts/retry (bit 9).
-    func receiptSessionGeneration(for peerID: PeerID, currentNoiseGeneration: UUID?) -> UUID? {
-        lock.withLock {
-            guard let generation = sessionGenerations[peerID],
-                  generation == currentNoiseGeneration,
-                  let authenticated = authenticatedStates[peerID],
-                  authenticated.sessionGeneration == generation,
-                  authenticated.capabilities.contains(.privateMedia),
-                  authenticated.capabilities.contains(.privateMediaReceipts) else {
-                return nil
-            }
-            return generation
-        }
-    }
-
-    /// One consistent view of the state the send-policy calculus needs.
-    func policyInputs(for peerID: PeerID) -> (
-        sessionGeneration: UUID?,
-        authenticatedState: BLEAuthenticatedPeerStateObservation?,
-        timedOut: BLEPrivateMediaProofTimeoutMarker?
-    ) {
-        lock.withLock {
-            (
-                sessionGenerations[peerID],
-                authenticatedStates[peerID],
-                proofTimeoutMarkers[peerID]
-            )
-        }
-    }
-
-    func hasPendingPolicyResolution(for peerID: PeerID) -> Bool {
-        lock.withLock { pendingPolicyResolutions[peerID] != nil }
-    }
-
-    /// The live proof-timeout identity for a peer (watchdog first, then a
-    /// registered waiter) — what a forced/expired timeout must present.
-    func proofTimeoutTarget(for peerID: PeerID) -> (fingerprint: String, generation: UUID?, nonce: UUID)? {
-        lock.withLock {
-            if let watchdog = proofWatchdogs[peerID] {
-                return (watchdog.fingerprint, watchdog.sessionGeneration, watchdog.timeoutNonce)
-            }
-            if let pending = pendingPolicyResolutions[peerID] {
-                return (pending.fingerprint, pending.sessionGeneration, pending.timeoutNonce)
-            }
-            return nil
-        }
-    }
-
-    // MARK: Generation transitions
-
-    /// Installs a freshly authenticated generation: rotates the proof
-    /// watchdog, resets peer-state send progress, and re-binds any pending
-    /// policy waiters whose fingerprint still matches (mismatched waiters
-    /// are rejected and returned for completion). Returns nil when the
-    /// generation is already current — the same-generation reconciliation
-    /// path, which must not re-arm proof machinery.
-    func beginAuthenticatedGeneration(
-        for peerID: PeerID,
-        fingerprint: String,
-        generation: UUID
-    ) -> (watchdogNonce: UUID, rejected: [@MainActor (PrivateMediaSendPolicy) -> Void])? {
-        lock.withLock {
-            guard sessionGenerations[peerID] != generation else { return nil }
-            let watchdogNonce = UUID()
-            sessionGenerations[peerID] = generation
-            authenticatedStates.removeValue(forKey: peerID)
-            proofTimeoutMarkers.removeValue(forKey: peerID)
-            proofWatchdogs[peerID] = BLEPrivateMediaProofWatchdog(
-                fingerprint: fingerprint,
-                sessionGeneration: generation,
-                timeoutNonce: watchdogNonce
-            )
-            stateSendProgress[peerID] =
-                BLEAuthenticatedPeerStateSendProgress(sessionGeneration: generation)
-
-            guard var pending = pendingPolicyResolutions[peerID] else {
-                return (watchdogNonce, [])
-            }
-            guard pending.fingerprint.caseInsensitiveCompare(fingerprint) == .orderedSame else {
-                pendingPolicyResolutions.removeValue(forKey: peerID)
-                return (watchdogNonce, Array(pending.completions.values))
-            }
-            pending.sessionGeneration = generation
-            pending.timeoutNonce = watchdogNonce
-            pendingPolicyResolutions[peerID] = pending
-            return (watchdogNonce, [])
-        }
-    }
-
-    /// Records a verified authenticated-peer-state packet for the current
-    /// generation: pins the observation, retires proof timers, and releases
-    /// matching policy waiters. Returns nil when the generation is no longer
-    /// current (the caller's lease raced a replacement).
-    func applyAuthenticatedPeerState(
-        for peerID: PeerID,
-        fingerprint: String,
-        generation: UUID,
-        capabilities: PeerCapabilities
-    ) -> [@MainActor (PrivateMediaSendPolicy) -> Void]? {
-        lock.withLock {
-            guard sessionGenerations[peerID] == generation else { return nil }
-            authenticatedStates[peerID] = BLEAuthenticatedPeerStateObservation(
-                fingerprint: fingerprint,
-                sessionGeneration: generation,
-                capabilities: capabilities
-            )
-            proofTimeoutMarkers.removeValue(forKey: peerID)
-            proofWatchdogs.removeValue(forKey: peerID)
-            guard let pending = pendingPolicyResolutions.removeValue(forKey: peerID),
-                  pending.fingerprint.caseInsensitiveCompare(fingerprint) == .orderedSame,
-                  pending.sessionGeneration == generation else {
-                return []
-            }
-            return Array(pending.completions.values)
-        }
-    }
-
-    /// Consumes one peer-state send slot (initial or echo) for the current
-    /// generation. Returns whether the packet should actually go out.
-    func markPeerStateSend(for peerID: PeerID, echo: Bool) -> Bool {
-        lock.withLock {
-            guard let generation = sessionGenerations[peerID],
-                  var progress = stateSendProgress[peerID],
-                  progress.sessionGeneration == generation else { return false }
-            if echo {
-                guard !progress.sentEcho else { return false }
-                progress.sentEcho = true
-            } else {
-                guard !progress.sentInitial else { return false }
-                progress.sentInitial = true
-            }
-            stateSendProgress[peerID] = progress
-            return true
-        }
-    }
-
-    // MARK: Outbound convergence deferral
-
-    func setOutboundDeferredUntilConvergence(_ peerID: PeerID) {
-        lock.withLock { _ = outboundConvergenceDeferred.insert(peerID) }
-    }
-
-    func clearOutboundDeferredUntilConvergence(_ peerID: PeerID) {
-        lock.withLock { _ = outboundConvergenceDeferred.remove(peerID) }
-    }
-
-    // MARK: Proof timeout
-
-    /// Expires a proof deadline if its nonce/generation/fingerprint still
-    /// identify the live watchdog or waiter set. On expiry the timeout
-    /// marker is pinned and any waiters are returned for completion.
-    /// `deferredOutbound` reports whether the peer's parked queues must
-    /// stay parked (timeout-restore pending its convergence retry).
-    func expireProofDeadline(
-        for peerID: PeerID,
-        fingerprint: String,
-        sessionGeneration: UUID?,
-        nonce: UUID
-    ) -> (expired: Bool, deferredOutbound: Bool, completions: [@MainActor (PrivateMediaSendPolicy) -> Void]) {
-        lock.withLock {
-            let pending = pendingPolicyResolutions[peerID]
-            let pendingMatches = pending?.timeoutNonce == nonce
-                && pending?.sessionGeneration == sessionGeneration
-                && pending?.fingerprint.caseInsensitiveCompare(fingerprint) == .orderedSame
-            let watchdog = proofWatchdogs[peerID]
-            let watchdogMatches = sessionGeneration != nil
-                && watchdog?.timeoutNonce == nonce
-                && watchdog?.sessionGeneration == sessionGeneration
-                && watchdog?.fingerprint.caseInsensitiveCompare(fingerprint) == .orderedSame
-            guard pendingMatches || watchdogMatches else {
-                return (false, false, [])
-            }
-            var completions: [@MainActor (PrivateMediaSendPolicy) -> Void] = []
-            if pendingMatches, let pending {
-                completions = Array(pending.completions.values)
-            }
-            if pendingMatches {
-                pendingPolicyResolutions.removeValue(forKey: peerID)
-            }
-            if watchdogMatches {
-                proofWatchdogs.removeValue(forKey: peerID)
-            }
-            proofTimeoutMarkers[peerID] = BLEPrivateMediaProofTimeoutMarker(
-                fingerprint: fingerprint,
-                sessionGeneration: sessionGeneration
-            )
-            return (true, outboundConvergenceDeferred.contains(peerID), completions)
-        }
-    }
-
-    /// Registers a policy-resolution waiter for a peer still awaiting its
-    /// capability proof. Joins the existing waiter set when fingerprints
-    /// match (bounded), otherwise starts one, reusing the live watchdog's
-    /// deadline identity when it covers the same fingerprint/generation so
-    /// only one timeout is ever in flight. `shouldSchedule` tells the
-    /// caller to arm a fresh deadline.
-    func registerPolicyResolution(
-        for peerID: PeerID,
-        fingerprint: String,
-        requestID: UUID,
-        completion: @escaping @MainActor (PrivateMediaSendPolicy) -> Void
-    ) -> (registered: Bool, shouldSchedule: Bool, nonce: UUID, generation: UUID?) {
-        lock.withLock {
-            let generation = sessionGenerations[peerID]
-            if var pending = pendingPolicyResolutions[peerID] {
-                guard pending.fingerprint.caseInsensitiveCompare(fingerprint) == .orderedSame,
-                      pending.completions.count
-                        < TransportConfig.privateMediaCapabilityProofWaitersPerPeerCap else {
-                    return (false, false, UUID(), generation)
-                }
-                pending.completions[requestID] = completion
-                pendingPolicyResolutions[peerID] = pending
-                return (true, false, pending.timeoutNonce, pending.sessionGeneration)
-            }
-
-            guard pendingPolicyResolutions.count
-                    < TransportConfig.privateMediaCapabilityProofPendingPeerCap else {
-                return (false, false, UUID(), generation)
-            }
-            let currentWatchdog = proofWatchdogs[peerID]
-            let reusesWatchdog = currentWatchdog?.fingerprint
-                .caseInsensitiveCompare(fingerprint) == .orderedSame
-                && currentWatchdog?.sessionGeneration == generation
-            let nonce: UUID
-            if reusesWatchdog, let currentWatchdog {
-                nonce = currentWatchdog.timeoutNonce
-            } else {
-                nonce = UUID()
-            }
-            pendingPolicyResolutions[peerID] =
-                BLEPendingPrivateMediaPolicyResolution(
-                    fingerprint: fingerprint,
-                    sessionGeneration: generation,
-                    timeoutNonce: nonce,
-                    completions: [requestID: completion]
-                )
-            return (true, !reusesWatchdog, nonce, generation)
-        }
-    }
-
-    // MARK: Teardown
-
-    /// A session clear retires every generation-bound record. Waiters are
-    /// kept but rebased onto a nil generation with a fresh deadline nonce,
-    /// returned so the caller re-arms their timeout.
-    func clearSession(for peerID: PeerID) -> (fingerprint: String, nonce: UUID)? {
-        lock.withLock {
-            sessionGenerations.removeValue(forKey: peerID)
-            authenticatedStates.removeValue(forKey: peerID)
-            proofTimeoutMarkers.removeValue(forKey: peerID)
-            proofWatchdogs.removeValue(forKey: peerID)
-            stateSendProgress.removeValue(forKey: peerID)
-            outboundConvergenceDeferred.remove(peerID)
-            guard var pending = pendingPolicyResolutions[peerID] else {
-                return nil
-            }
-            let nonce = UUID()
-            pending.sessionGeneration = nil
-            pending.timeoutNonce = nonce
-            pendingPolicyResolutions[peerID] = pending
-            return (pending.fingerprint, nonce)
-        }
-    }
-
-    /// Panic wipe: these records belong to pre-panic transfer state, and
-    /// invoking their callbacks would let queued UI work recreate or resend
-    /// wiped media — drop everything.
-    func panicReset() {
-        lock.withLock {
-            sessionGenerations.removeAll()
-            authenticatedStates.removeAll()
-            proofTimeoutMarkers.removeAll()
-            proofWatchdogs.removeAll()
-            pendingPolicyResolutions.removeAll()
-            stateSendProgress.removeAll()
-            outboundConvergenceDeferred.removeAll()
-        }
-    }
-}
-
-extension BLEPrivateMediaSessionStore {
-    /// The current generation iff its authenticated peer state proved the
-    /// private-media capability (and, when required, durable receipts).
-    func provenGeneration(for peerID: PeerID, requireReceipts: Bool) -> UUID? {
-        let inputs = policyInputs(for: peerID)
-        guard let generation = inputs.sessionGeneration,
-              let authenticated = inputs.authenticatedState,
-              authenticated.sessionGeneration == generation,
-              authenticated.capabilities.contains(.privateMedia) else { return nil }
-        if requireReceipts {
-            guard authenticated.capabilities.contains(.privateMediaReceipts) else { return nil }
-        }
-        return generation
-    }
-}

bitchat/Services/BLE/BLEPublicMessageHandler.swift

@@ -122,18 +122,10 @@ final class BLEPublicMessageHandler {
         SecureLogger.debug("💬 [\(senderNickname)] TTL:\(packet.ttl) (\(pathTag)) chars=\(content.count) bytes=\(packet.payload.count)", category: .session)
 
         let ts = Date(timeIntervalSince1970: Double(packet.timestamp) / 1000)
-        let messageID: String?
+        var resolvedSelfMessageID: String? = nil
         if peerID == env.localPeerID() {
-            messageID = env.takeSelfBroadcastMessageID(packet)
-        } else {
-            // The wire carries no message ID; derive the stable one every
-            // device agrees on so bridged copies dedup against the radio copy.
-            messageID = MeshMessageIdentity.stableID(
-                senderIDHex: peerID.id,
-                timestampMs: packet.timestamp,
-                content: content
-            )
+            resolvedSelfMessageID = env.takeSelfBroadcastMessageID(packet)
         }
-        env.deliverPublicMessage(peerID, senderNickname, content, ts, messageID)
+        env.deliverPublicMessage(peerID, senderNickname, content, ts, resolvedSelfMessageID)
     }
 }

bitchat/Services/BLE/BLERadioController.swift

@@ -1,411 +0,0 @@
-import BitLogger
-import CoreBluetooth
-import Foundation
-
-/// The radio's contact points back into the transport. All calls arrive on
-/// bleQueue.
-protocol BLERadioControllerDelegate: AnyObject {
-    /// Whether a panic wipe has quiesced the radio.
-    func radioIsPanicSuspended() -> Bool
-    /// iOS app-active snapshot (drives allow-duplicates scanning and
-    /// background connect deferral); always true on macOS.
-    func radioIsAppActive() -> Bool
-    /// A connect attempt died (timeout or foreground stale-reclaim): retire
-    /// the link's transport bookkeeping — write buffers, link-auth proof,
-    /// reconnect epoch, and the link-state entry itself.
-    func radioTearDownPeripheralLink(_ peripheralID: String)
-}
-
-/// bleQueue-confined owner of the central-role radio policy: discovery
-/// admission, the connection budget and queue, connect timeouts,
-/// wake-on-proximity background connects, scan duty-cycling, RSSI
-/// adaptation, and the advertising payload.
-///
-/// First slice of the link layer (docs/BLE-ARCHITECTURE-V3.md): this type
-/// makes no peer decisions and owns no bindings or security state — it
-/// shares the bleQueue-confined link-state store for admission reads and
-/// asks its delegate to tear down transport bookkeeping when an attempt
-/// dies.
-final class BLERadioController {
-    weak var delegate: BLERadioControllerDelegate?
-    /// The transport is every peripheral's CBPeripheralDelegate; connects
-    /// initiated here must point new peripherals at it.
-    weak var peripheralDelegate: CBPeripheralDelegate?
-    /// Attached when the transport creates (or restores) its managers.
-    weak var central: CBCentralManager?
-
-    private let queue: DispatchQueue
-    private let linkStateStore: BLELinkStateStore
-    private let recentTraffic: BLERecentTrafficMonitor
-
-    // Connection budget & scheduling (central role)
-    private var scheduler = BLEConnectionScheduler<CBPeripheral>()
-    // Recently seen peripherals retained for background wake-on-proximity
-    // connects
-    private let recentPeripheralCache = BLERecentPeripheralCache<CBPeripheral>()
-
-    // Adaptive scanning duty-cycle
-    private var scanDutyTimer: DispatchSourceTimer?
-    private var dutyEnabled: Bool = true
-    private var dutyOnDuration: TimeInterval = TransportConfig.bleDutyOnDuration
-    private var dutyOffDuration: TimeInterval = TransportConfig.bleDutyOffDuration
-    private var dutyActive: Bool = false
-
-    init(
-        queue: DispatchQueue,
-        linkStateStore: BLELinkStateStore,
-        recentTraffic: BLERecentTrafficMonitor
-    ) {
-        self.queue = queue
-        self.linkStateStore = linkStateStore
-        self.recentTraffic = recentTraffic
-    }
-
-    // MARK: - Advertising
-
-    static func advertisementData() -> [String: Any] {
-        // No Local Name for privacy.
-        [CBAdvertisementDataServiceUUIDsKey: [BLEService.serviceUUID]]
-    }
-
-    // MARK: - Scanning
-
-    func startScanning() {
-        guard delegate?.radioIsPanicSuspended() == false,
-              let central,
-              central.state == .poweredOn,
-              !central.isScanning else { return }
-
-        // Allow duplicates while active for faster discovery: immediate
-        // discovery events instead of coalesced ones.
-        let allowDuplicates = delegate?.radioIsAppActive() ?? true
-        central.scanForPeripherals(
-            withServices: [BLEService.serviceUUID],
-            options: [CBCentralManagerScanOptionAllowDuplicatesKey: allowDuplicates]
-        )
-    }
-
-    func updateScanningDutyCycle(connectedCount: Int) {
-        guard let central, central.state == .poweredOn else { return }
-        // Duty cycle only when the app is active and at least one peer is
-        // connected; force full-time scanning with few neighbors or very
-        // recent traffic.
-        let hasRecentTraffic = recentTraffic.hasTraffic(
-            within: TransportConfig.bleRecentTrafficForceScanSeconds,
-            now: Date()
-        )
-        let scanPlan = BLEScanDutyPolicy.plan(
-            dutyEnabled: dutyEnabled,
-            appIsActive: delegate?.radioIsAppActive() ?? true,
-            connectedCount: connectedCount,
-            hasRecentTraffic: hasRecentTraffic
-        )
-
-        switch scanPlan {
-        case .dutyCycle(let onDuration, let offDuration):
-            let durationsChanged = dutyOnDuration != onDuration || dutyOffDuration != offDuration
-            dutyOnDuration = onDuration
-            dutyOffDuration = offDuration
-
-            if scanDutyTimer == nil {
-                // Start with scanning ON; turn OFF after onDuration.
-                let t = DispatchSource.makeTimerSource(queue: queue)
-                if !central.isScanning { startScanning() }
-                dutyActive = true
-                t.schedule(deadline: .now() + dutyOnDuration, repeating: dutyOnDuration + dutyOffDuration)
-                t.setEventHandler { [weak self] in
-                    guard let self, let c = self.central else { return }
-                    if self.dutyActive {
-                        if c.isScanning { c.stopScan() }
-                        self.dutyActive = false
-                        self.queue.asyncAfter(deadline: .now() + self.dutyOffDuration) {
-                            if self.central?.state == .poweredOn { self.startScanning() }
-                            self.dutyActive = true
-                        }
-                    }
-                }
-                t.resume()
-                scanDutyTimer = t
-            } else if durationsChanged {
-                scanDutyTimer?.schedule(deadline: .now() + dutyOnDuration, repeating: dutyOnDuration + dutyOffDuration)
-                if !central.isScanning { startScanning() }
-                dutyActive = true
-            }
-        case .continuous:
-            // Cancel duty cycle and ensure scanning is ON for discovery.
-            scanDutyTimer?.cancel()
-            scanDutyTimer = nil
-            if !central.isScanning { startScanning() }
-        }
-    }
-
-    func stopDutyCycle() {
-        scanDutyTimer?.cancel()
-        scanDutyTimer = nil
-    }
-
-    func updateRSSIThreshold(connectedCount: Int) {
-        scheduler.updateRSSIThreshold(
-            connectedCount: connectedCount,
-            connectedOrConnectingLinkCount: linkStateStore.connectedOrConnectingPeripheralCount,
-            now: Date()
-        )
-    }
-
-    // MARK: - Discovery & connection budget
-
-    func handleDiscovery(
-        _ peripheral: CBPeripheral,
-        advertisementData: [String: Any],
-        rssi: NSNumber
-    ) {
-        guard delegate?.radioIsPanicSuspended() == false, let central else { return }
-        let peripheralID = peripheral.identifier.uuidString
-        let advertisedName = advertisementData[CBAdvertisementDataLocalNameKey] as? String ?? (peripheralID.prefix(6) + "…")
-        let isConnectable = (advertisementData[CBAdvertisementDataIsConnectable] as? NSNumber)?.boolValue ?? true
-
-        let candidate = BLEConnectionCandidate(
-            peripheral: peripheral,
-            peripheralID: peripheralID,
-            rssi: rssi.intValue,
-            name: String(advertisedName),
-            isConnectable: isConnectable,
-            discoveredAt: Date()
-        )
-        if isConnectable {
-            recentPeripheralCache.record(peripheral, peripheralID: peripheralID, at: candidate.discoveredAt)
-        }
-        let existingState = linkStateStore.state(forPeripheralID: peripheralID).map(BLEExistingConnectionState.init)
-
-        switch scheduler.handleDiscovery(
-            candidate,
-            connectedOrConnectingCount: linkStateStore.connectedOrConnectingPeripheralCount,
-            existingState: existingState,
-            peripheralState: peripheral.state.connectionSchedulerState,
-            now: candidate.discoveredAt
-        ) {
-        case .ignore, .queued:
-            return
-        case .scheduleRetry(let delay):
-            queue.asyncAfter(deadline: .now() + delay) { [weak self] in
-                self?.tryConnectFromQueue()
-            }
-            return
-        case .cancelStaleConnection:
-            central.cancelPeripheralConnection(peripheral)
-            return
-        case .connectNow:
-            beginCentralConnection(candidate, using: central, logPrefix: "📱 Connect")
-        }
-    }
-
-    func tryConnectFromQueue() {
-        guard delegate?.radioIsPanicSuspended() == false,
-              let central,
-              central.state == .poweredOn else { return }
-
-        let decision = scheduler.nextCandidate(
-            connectedOrConnectingCount: linkStateStore.connectedOrConnectingPeripheralCount,
-            isAlreadyConnectingOrConnected: { [linkStateStore] peripheralID in
-                let state = linkStateStore.state(forPeripheralID: peripheralID)
-                return state?.isConnected == true || state?.isConnecting == true
-            },
-            now: Date()
-        )
-
-        switch decision {
-        case .none:
-            return
-        case .retryAfter(let delay):
-            queue.asyncAfter(deadline: .now() + delay) { [weak self] in self?.tryConnectFromQueue() }
-        case .connect(let candidate):
-            beginCentralConnection(candidate, using: central, logPrefix: "⏩ Queue connect")
-        }
-    }
-
-    private func beginCentralConnection(
-        _ candidate: BLEConnectionCandidate<CBPeripheral>,
-        using central: CBCentralManager,
-        logPrefix: String
-    ) {
-        guard delegate?.radioIsPanicSuspended() == false else { return }
-        let peripheral = candidate.peripheral
-        let peripheralID = candidate.peripheralID
-        linkStateStore.beginConnecting(to: peripheral, at: Date())
-        peripheral.delegate = peripheralDelegate
-        let options: [String: Any] = [
-            CBConnectPeripheralOptionNotifyOnConnectionKey: true,
-            CBConnectPeripheralOptionNotifyOnDisconnectionKey: true,
-            CBConnectPeripheralOptionNotifyOnNotificationKey: true
-        ]
-        central.connect(peripheral, options: options)
-        scheduler.recordConnectionAttempt(at: Date())
-        SecureLogger.debug("\(logPrefix): \(candidate.name) [RSSI:\(candidate.rssi)]", category: .session)
-
-        queue.asyncAfter(deadline: .now() + TransportConfig.bleConnectTimeoutSeconds) { [weak self] in
-            guard let self,
-                  let state = self.linkStateStore.state(forPeripheralID: peripheralID),
-                  state.isConnecting && !state.isConnected else { return }
-
-            guard peripheral.state != .connected else {
-                SecureLogger.debug("⏱️ Timeout fired but peripheral already connected: \(candidate.name)", category: .session)
-                return
-            }
-
-            if self.delegate?.radioIsAppActive() == false {
-                // Backgrounded: leave the connect pending. iOS never expires
-                // it — the controller completes it whenever the peer comes
-                // back into range, waking the app (state restoration
-                // relaunches us if we were terminated). Foreground return
-                // cancels stale pendings via cancelStalePendingConnects().
-                SecureLogger.info("🌙 Connect timeout deferred while backgrounded, left pending for wake-on-proximity: \(candidate.name)", category: .session)
-                return
-            }
-
-            SecureLogger.debug("⏱️ Timeout: \(candidate.name)", category: .session)
-            central.cancelPeripheralConnection(peripheral)
-            self.delegate?.radioTearDownPeripheralLink(peripheralID)
-            self.scheduler.recordConnectionTimeout(peripheralID: peripheralID, at: Date())
-            self.tryConnectFromQueue()
-        }
-    }
-
-    // MARK: - Scheduler bookkeeping (called from the transport's delegates)
-
-    var candidateCount: Int { scheduler.candidateCount }
-
-    func recordConnectionSuccess(peripheralID: String) {
-        scheduler.recordConnectionSuccess(peripheralID: peripheralID)
-    }
-
-    func recordConnectionFailure(peripheralID: String) {
-        scheduler.recordConnectionFailure(peripheralID: peripheralID)
-    }
-
-    func recordDisconnectError(peripheralID: String, at date: Date) {
-        scheduler.recordDisconnectError(peripheralID: peripheralID, at: date)
-    }
-
-    func recordRecentPeripheral(_ peripheral: CBPeripheral, peripheralID: String, at date: Date) {
-        recentPeripheralCache.record(peripheral, peripheralID: peripheralID, at: date)
-    }
-
-    func pruneConnectionTimeouts(before cutoff: Date) {
-        scheduler.pruneConnectionTimeouts(before: cutoff)
-    }
-
-    /// Panic wipe: drop the candidate queue, backoff state, and RSSI
-    /// adaptation with the identity they served.
-    func reset() {
-        scheduler.reset()
-    }
-
-    #if os(iOS)
-    // MARK: - Background wake-on-proximity
-
-    /// Backgrounding hands the freed connection budget to iOS as pending
-    /// connects against recently seen peers: the controller completes one
-    /// whenever its peer comes into range, waking (or relaunching) the app.
-    /// A couple of central slots stay reserved for connects driven by live
-    /// background discovery — except on the disconnect re-arm path, which
-    /// may consume the slot the disconnect itself just freed (a dense mesh
-    /// with 4+ remaining links would otherwise compute a zero budget and
-    /// never re-arm the lost peer).
-    func armPendingBackgroundConnects(
-        slotReserve: Int = TransportConfig.bleBackgroundPendingConnectSlotReserve
-    ) {
-        queue.async { [weak self] in
-            guard let self,
-                  self.delegate?.radioIsPanicSuspended() == false,
-                  let central = self.central,
-                  central.state == .poweredOn else { return }
-            let budget = TransportConfig.bleMaxCentralLinks
-                - slotReserve
-                - self.linkStateStore.connectedOrConnectingPeripheralCount
-            let now = Date()
-            let targets = self.recentPeripheralCache.reconnectTargets(now: now, limit: budget) { peripheralID in
-                let state = self.linkStateStore.state(forPeripheralID: peripheralID)
-                return state?.isConnected == true || state?.isConnecting == true
-            }
-            guard !targets.isEmpty else { return }
-            for target in targets {
-                // lastConnectionAttempt stays nil: an indefinite pending
-                // connect has no attempt clock, and nil marks it always-stale
-                // so cancelStalePendingConnects() reclaims it on foreground
-                // even after a quick background→foreground bounce.
-                self.linkStateStore.setPeripheralState(
-                    BLEPeripheralLinkState(
-                        peripheral: target.peripheral,
-                        characteristic: nil,
-                        isConnecting: true,
-                        isConnected: false,
-                        lastConnectionAttempt: nil,
-                        assembler: NotificationStreamAssembler()
-                    ),
-                    for: target.peripheralID
-                )
-                target.peripheral.delegate = self.peripheralDelegate
-                central.connect(target.peripheral, options: [
-                    CBConnectPeripheralOptionNotifyOnConnectionKey: true,
-                    CBConnectPeripheralOptionNotifyOnDisconnectionKey: true,
-                    CBConnectPeripheralOptionNotifyOnNotificationKey: true
-                ])
-            }
-            SecureLogger.info("🌙 Armed \(targets.count) pending background connect(s) for wake-on-proximity", category: .session)
-        }
-    }
-
-    /// Foreground restores normal connection management: pending connects
-    /// older than the connect timeout (including ones rebuilt by state
-    /// restoration after a relaunch) are cancelled so live scanning and the
-    /// scheduler take over. Anything still nearby is rediscovered within
-    /// seconds by the allow-duplicates foreground scan.
-    func cancelStalePendingConnects() {
-        queue.async { [weak self] in
-            guard let self, let central = self.central else { return }
-            let now = Date()
-            var cancelled = 0
-            for state in self.linkStateStore.peripheralStates where state.isConnecting && !state.isConnected {
-                let age = state.lastConnectionAttempt.map { now.timeIntervalSince($0) } ?? .infinity
-                guard age > TransportConfig.bleConnectTimeoutSeconds else { continue }
-                let peripheralID = state.peripheral.identifier.uuidString
-                central.cancelPeripheralConnection(state.peripheral)
-                self.delegate?.radioTearDownPeripheralLink(peripheralID)
-                cancelled += 1
-            }
-            if cancelled > 0 {
-                SecureLogger.info("🌅 Cancelled \(cancelled) stale pending connect(s) on foreground", category: .session)
-                self.tryConnectFromQueue()
-            }
-        }
-    }
-    #endif
-}
-
-
-// MARK: - Connection scheduling helpers
-
-private extension BLEExistingConnectionState {
-    init(_ state: BLEPeripheralLinkState) {
-        self.init(
-            isConnecting: state.isConnecting,
-            isConnected: state.isConnected,
-            lastConnectionAttempt: state.lastConnectionAttempt
-        )
-    }
-}
-
-private extension CBPeripheralState {
-    var connectionSchedulerState: BLEPeripheralConnectionState {
-        switch self {
-        case .connected:
-            return .connected
-        case .connecting:
-            return .connecting
-        case .disconnected, .disconnecting:
-            return .disconnected
-        @unknown default:
-            return .disconnected
-        }
-    }
-}

bitchat/Services/BLE/BLEReceivePipeline.swift

@@ -77,26 +77,6 @@ struct BLEReceivePipeline {
     }
 }
 
-/// Lock-backed traffic-level signal: the receive pipeline records packets,
-/// and the radio layer (maintenance and scan-duty adaptation on bleQueue)
-/// reads the level without crossing onto a transport queue.
-final class BLERecentTrafficMonitor: @unchecked Sendable {
-    private let lock = NSLock()
-    private var tracker = BLERecentTrafficTracker()
-
-    func recordPacket(at now: Date) {
-        lock.withLock { tracker.recordPacket(at: now) }
-    }
-
-    func hasTraffic(within seconds: TimeInterval, now: Date) -> Bool {
-        lock.withLock { tracker.hasTraffic(within: seconds, now: now) }
-    }
-
-    func removeAll() {
-        lock.withLock { tracker.removeAll() }
-    }
-}
-
 struct BLERecentTrafficTracker: Equatable {
     private var packetTimestamps: [Date] = []
 

bitchat/Services/BLE/BLERedundantLinkPolicy.swift

@@ -1,138 +0,0 @@
-import BitFoundation
-import Foundation
-
-/// Decides which central-role connections (peripheral links we own) are
-/// redundant duplicates of a peer's live link.
-///
-/// One connection per role per peer is the normal dual-role topology (each
-/// device is both central and peripheral). After a BLE state-restoration
-/// relaunch, though, the same phone can reappear under a fresh peripheral
-/// UUID while the restored connection lives on — leaving several live
-/// central-role connections to one peer, each carrying every packet
-/// (field-verified: 2-3x airtime on all traffic). Only same-role duplicates
-/// are retired; the peer's central-role subscription on our peripheral
-/// manager is its own connection to manage, and it runs the same policy.
-enum BLERedundantLinkPolicy {
-    struct PeripheralLink: Equatable {
-        let uuid: String
-        let peerID: PeerID?
-        let isConnected: Bool
-        /// Whether the link has a discovered characteristic (is writable).
-        /// A link mid-service-rediscovery (didModifyServices cleared it)
-        /// must never be kept over a writable duplicate.
-        let hasCharacteristic: Bool
-        /// When didConnect last fired for this link in this process. Nil
-        /// for restored links, whose connect predates the relaunch.
-        let lastConnectedAt: Date?
-
-        init(
-            uuid: String,
-            peerID: PeerID?,
-            isConnected: Bool,
-            hasCharacteristic: Bool,
-            lastConnectedAt: Date? = nil
-        ) {
-            self.uuid = uuid
-            self.peerID = peerID
-            self.isConnected = isConnected
-            self.hasCharacteristic = hasCharacteristic
-            self.lastConnectedAt = lastConnectedAt
-        }
-    }
-
-    /// The link to keep when a peer has several connected bound peripheral
-    /// links, or nil when there is nothing to consolidate.
-    ///
-    /// Prefers the most recently CONNECTED candidate. Duplicates arise when
-    /// the peer reappears under a fresh BLE address (privacy address
-    /// rotation) while an older connection — typically state-restored —
-    /// lives on: only the newest connection sits on the address the peer
-    /// still advertises. Cancelling that one instead just gets it
-    /// rediscovered and reconnected, a retire↔reconnect oscillation at the
-    /// retirement cooldown (field-observed July 31); the older-address link
-    /// cannot return once cancelled, so consolidation converges immediately.
-    /// Physical connect recency is also a signal an announce replay cannot
-    /// nominate, unlike the previous ingress-link preference — announce
-    /// anchors (ingress, then most recently bound) now only break ties and
-    /// serve links with no connect timestamp at all. Link "health" signals
-    /// like RSSI are deliberately not inputs: they are transient and the
-    /// stale-address link often reads stronger; connect recency is the only
-    /// signal that tracks address currency.
-    ///
-    /// The survivor must be writable while any writable candidate exists:
-    /// keeping a characteristic-less link and cancelling the writable
-    /// duplicate would strand outbound traffic on the central link until
-    /// rediscovery finishes. But when the physically NEWEST connection is
-    /// the one that is not writable yet (service discovery still running),
-    /// consolidation defers entirely — selecting an older writable link
-    /// would cancel the freshly advertised connection and recreate the
-    /// oscillation. When no candidate is identifiable, consolidation waits
-    /// for a later announce rather than guessing.
-    static func keptPeripheralUUID(
-        ingressPeripheralUUID: String?,
-        mostRecentlyBoundUUID: String?,
-        links: [PeripheralLink],
-        peerID: PeerID
-    ) -> String? {
-        let bound = links.filter { $0.peerID == peerID && $0.isConnected }
-        guard bound.count > 1 else { return nil }
-
-        let writable = bound.filter(\.hasCharacteristic)
-        let candidates = writable.isEmpty ? bound : writable
-
-        // The newest connection is still mid-service-discovery while a
-        // writable (typically restored, stale-address) duplicate exists:
-        // defer to a later announce instead of keeping the older link and
-        // cancelling the one connection on the currently advertised address.
-        if !writable.isEmpty,
-           let newestBoundDate = bound.compactMap(\.lastConnectedAt).max(),
-           !writable.contains(where: { $0.lastConnectedAt == newestBoundDate }) {
-            return nil
-        }
-
-        if let newestDate = candidates.compactMap(\.lastConnectedAt).max() {
-            let newest = candidates.filter { $0.lastConnectedAt == newestDate }
-            if newest.count == 1 {
-                return newest[0].uuid
-            }
-            return anchoredChoice(
-                among: newest,
-                ingressPeripheralUUID: ingressPeripheralUUID,
-                mostRecentlyBoundUUID: mostRecentlyBoundUUID
-            ) ?? newest.map(\.uuid).min()
-        }
-
-        return anchoredChoice(
-            among: candidates,
-            ingressPeripheralUUID: ingressPeripheralUUID,
-            mostRecentlyBoundUUID: mostRecentlyBoundUUID
-        )
-    }
-
-    /// The pre-timestamp anchors: the verified announce's ingress link,
-    /// then the peer's most recently bound link.
-    private static func anchoredChoice(
-        among candidates: [PeripheralLink],
-        ingressPeripheralUUID: String?,
-        mostRecentlyBoundUUID: String?
-    ) -> String? {
-        if let ingressPeripheralUUID, candidates.contains(where: { $0.uuid == ingressPeripheralUUID }) {
-            return ingressPeripheralUUID
-        }
-        if let mostRecentlyBoundUUID, candidates.contains(where: { $0.uuid == mostRecentlyBoundUUID }) {
-            return mostRecentlyBoundUUID
-        }
-        return nil
-    }
-
-    /// Connected peripheral links bound to the peer other than the kept one.
-    static func peripheralUUIDsToRetire(
-        links: [PeripheralLink],
-        peerID: PeerID,
-        keeping keptUUID: String
-    ) -> [String] {
-        links
-            .filter { $0.peerID == peerID && $0.isConnected && $0.uuid != keptUUID }
-            .map(\.uuid)
-    }
-}

bitchat/Services/BLE/BLEService+LinkLayerCentralRole.swift

@@ -1,433 +0,0 @@
-//
-// BLEService+LinkLayerCentralRole.swift
-// bitchat
-//
-// This is free and unencumbered software released into the public domain.
-// For more information, see <https://unlicense.org>
-//
-
-import BitFoundation
-import BitLogger
-import CoreBluetooth
-import Foundation
-
-// The bleQueue half of the link layer: CoreBluetooth delegate callbacks do
-// physical bookkeeping (link-state store, buffers, radio policy) and report
-// everything else to the engine through the link-event port
-// (BLELinkEvent / emitLinkEvent). See docs/BLE-ARCHITECTURE-V3.md.
-
-// MARK: - CBCentralManagerDelegate
-
-extension BLEService: CBCentralManagerDelegate {
-    #if os(iOS)
-    func centralManager(_ central: CBCentralManager, willRestoreState dict: [String: Any]) {
-        let restoredPeripherals = (dict[CBCentralManagerRestoredStatePeripheralsKey] as? [CBPeripheral]) ?? []
-        guard !isPanicSuspended else {
-            central.stopScan()
-            restoredPeripherals.forEach {
-                central.cancelPeripheralConnection($0)
-            }
-            return
-        }
-        let restoredServices = (dict[CBCentralManagerRestoredStateScanServicesKey] as? [CBUUID]) ?? []
-        let restoredOptions = (dict[CBCentralManagerRestoredStateScanOptionsKey] as? [String: Any]) ?? [:]
-        let allowDuplicates = restoredOptions[CBCentralManagerScanOptionAllowDuplicatesKey] as? Bool
-
-        SecureLogger.info(
-            "♻️ Central restore: peripherals=\(restoredPeripherals.count) services=\(restoredServices.count) allowDuplicates=\(String(describing: allowDuplicates))",
-            category: .session
-        )
-
-        for peripheral in restoredPeripherals {
-            let identifier = peripheral.identifier.uuidString
-            peripheral.delegate = self
-            let existing = linkStateStore.state(forPeripheralID: identifier)
-            let assembler = existing?.assembler ?? NotificationStreamAssembler()
-            let characteristic = existing?.characteristic
-            let wasConnecting = existing?.isConnecting ?? false
-            let wasConnected = existing?.isConnected ?? false
-
-            let restoredState = BLEPeripheralLinkState(
-                peripheral: peripheral,
-                characteristic: characteristic,
-                isConnecting: wasConnecting || peripheral.state == .connecting,
-                isConnected: wasConnected || peripheral.state == .connected,
-                lastConnectionAttempt: existing?.lastConnectionAttempt,
-                assembler: assembler
-            )
-            linkStateStore.setPeripheralState(restoredState, for: identifier)
-
-            // Restored peripherals are the freshest wake-on-proximity
-            // candidates we have after a relaunch — without this the cache
-            // starts empty and backgrounding right after a restore arms
-            // nothing. Service rediscovery for restored-connected links waits
-            // for poweredOn: CoreBluetooth drops commands issued during
-            // restoration (API MISUSE warnings).
-            radio.recordRecentPeripheral(peripheral, peripheralID: identifier, at: Date())
-        }
-
-        // Via the sampler (not a direct capture): it refreshes the cached
-        // background budget on main first, so the restore log shows the real
-        // wake window instead of the init sentinel.
-        logBluetoothStatus("central-restore")
-
-        if central.state == .poweredOn {
-            radio.startScanning()
-        }
-    }
-    #endif
-
-    func centralManagerDidUpdateState(_ central: CBCentralManager) {
-        emitTransportEvent(.bluetoothStateUpdated(central.state))
-
-        switch central.state {
-        case .poweredOn:
-            guard !isPanicSuspended else {
-                central.stopScan()
-                return
-            }
-            // Links restored as connected have no characteristic in the new
-            // process; without rediscovery they sit connected-but-unusable
-            // until the peer disconnects. Runs here (not willRestoreState)
-            // because commands issued before poweredOn are dropped.
-            for state in linkStateStore.peripheralStates where state.isConnected
-                && state.characteristic == nil
-                && state.peripheral.state == .connected {
-                SecureLogger.info("♻️ Rediscovering services on restored link: \(state.peripheral.identifier.uuidString.prefix(8))…", category: .session)
-                state.peripheral.discoverServices([BLEService.serviceUUID])
-            }
-
-            // Start scanning - use allow duplicates for faster discovery when active
-            radio.startScanning()
-
-        case .poweredOff:
-            // CoreBluetooth has already transitioned out of poweredOn. Do
-            // not issue stop/cancel commands now; they are rejected as API
-            // misuse. Retire our link state locally instead.
-            SecureLogger.info("📴 Bluetooth powered off - cleaning up central state", category: .session)
-            let peripheralIDs = linkStateStore.peripheralStates.map { $0.peripheral.identifier.uuidString }
-            for peripheralID in peripheralIDs {
-                pendingPeripheralWrites.discardAll(for: peripheralID)
-            }
-            linkStateStore.clearPeripherals()
-            emitLinkEvent(.allPeripheralLinksEnded(peripheralIDs: peripheralIDs, retireProofsAndNotify: true))
-
-        case .unauthorized:
-            // User denied Bluetooth permission
-            SecureLogger.warning("🚫 Bluetooth unauthorized - user denied permission", category: .session)
-            linkStateStore.clearPeripherals()
-            emitLinkEvent(.allPeripheralLinksEnded(peripheralIDs: [], retireProofsAndNotify: false))
-
-        case .unsupported:
-            // Device doesn't support BLE
-            SecureLogger.error("❌ Bluetooth LE not supported on this device", category: .session)
-
-        case .resetting:
-            // Bluetooth stack is resetting - will get another state update when done
-            SecureLogger.info("🔄 Bluetooth stack resetting...", category: .session)
-
-        case .unknown:
-            // Initial state before we know the actual state
-            SecureLogger.debug("❓ Bluetooth state unknown (initializing)", category: .session)
-
-        @unknown default:
-            SecureLogger.warning("⚠️ Unknown Bluetooth state: \(central.state.rawValue)", category: .session)
-        }
-    }
-    
-    
-    func centralManager(_ central: CBCentralManager, didDiscover peripheral: CBPeripheral, advertisementData: [String: Any], rssi RSSI: NSNumber) {
-        radio.handleDiscovery(peripheral, advertisementData: advertisementData, rssi: RSSI)
-    }
-
-    func centralManager(_ central: CBCentralManager, didConnect peripheral: CBPeripheral) {
-        guard !isPanicSuspended else {
-            central.cancelPeripheralConnection(peripheral)
-            return
-        }
-        let peripheralID = peripheral.identifier.uuidString
-
-        #if os(iOS)
-        // A connect completing while backgrounded is the wake-on-proximity
-        // path doing its job — worth an info line for field verification.
-        if !isAppActive {
-            SecureLogger.info("🌙 Background wake: connected to \(peripheral.name ?? peripheralID) while backgrounded", category: .session)
-        }
-        #endif
-
-        // Update state to connected
-        linkStateStore.markConnected(peripheral)
-        
-        // Reset backoff state on success
-        radio.recordConnectionSuccess(peripheralID: peripheralID)
-
-        SecureLogger.debug("✅ Connected: \(peripheral.name ?? "Unknown") [\(peripheralID)]", category: .session)
-        
-        // Discover services
-        peripheral.discoverServices([BLEService.serviceUUID])
-    }
-    
-    func centralManager(_ central: CBCentralManager, didDisconnectPeripheral peripheral: CBPeripheral, error: Error?) {
-        let peripheralID = peripheral.identifier.uuidString
-
-        SecureLogger.debug("📱 Disconnect: \(peripheralID)\(error != nil ? " (\(error!.localizedDescription))" : "")", category: .session)
-
-        // If disconnect carried an error (often timeout), apply short backoff to avoid thrash
-        if error != nil {
-            radio.recordDisconnectError(peripheralID: peripheralID, at: Date())
-        }
-
-        // Retain the handle: a dropped link is the best wake-on-proximity
-        // candidate if the app backgrounds before the peer returns.
-        radio.recordRecentPeripheral(peripheral, peripheralID: peripheralID, at: Date())
-
-        #if os(iOS)
-        // Link lost while backgrounded (peer walked away): re-arm a pending
-        // connect during this wake window so the peer's return wakes us again.
-        // Delayed past the disconnect-settle window to avoid reconnect thrash
-        // at range edge.
-        if !isAppActive {
-            bleQueue.asyncAfter(deadline: .now() + TransportConfig.bleDisconnectDiscoveryIgnoreSeconds) { [weak self] in
-                guard let self, !self.isAppActive else { return }
-                // Reserve 0: use the slot this disconnect freed even in a
-                // dense mesh, so the lost peer can wake us when it returns.
-                self.radio.armPendingBackgroundConnects(slotReserve: 0)
-            }
-        }
-        #endif
-
-        // Physical teardown now; identity retirement and peer-disconnect
-        // bookkeeping ride the link-event port. The scan restart and
-        // connect-slot refill below stay on bleQueue — they respond to
-        // the physical drop regardless of remaining logical links.
-        discardPeripheralLinkPhysical(peripheralID)
-        emitLinkEvent(.peripheralLinkEnded(peripheralID: peripheralID, runPeerBookkeeping: true))
-
-        // Restart scanning with allow duplicates for faster rediscovery
-        if centralManager?.state == .poweredOn {
-            // Stop and restart scanning to ensure we get fresh discovery events
-            centralManager?.stopScan()
-            bleQueue.asyncAfter(deadline: .now() + TransportConfig.bleRestartScanDelaySeconds) { [weak self] in
-                self?.radio.startScanning()
-            }
-        }
-        // Attempt to fill freed slot from queue
-        bleQueue.async { [weak self] in self?.radio.tryConnectFromQueue() }
-    }
-    
-    func centralManager(_ central: CBCentralManager, didFailToConnect peripheral: CBPeripheral, error: Error?) {
-        let peripheralID = peripheral.identifier.uuidString
-
-        // Clean up the references: physical now, identity via the port.
-        discardPeripheralLinkPhysical(peripheralID)
-        emitLinkEvent(.peripheralLinkEnded(peripheralID: peripheralID, runPeerBookkeeping: false))
-
-        SecureLogger.error("❌ Failed to connect to peripheral: \(peripheral.name ?? "Unknown") [\(peripheralID)] - Error: \(error?.localizedDescription ?? "Unknown")", category: .session)
-        radio.recordConnectionFailure(peripheralID: peripheralID)
-        // Try next candidate
-        bleQueue.async { [weak self] in self?.radio.tryConnectFromQueue() }
-    }
-}
-
-// MARK: - CBPeripheralDelegate
-
-extension BLEService: CBPeripheralDelegate {
-    func peripheral(_ peripheral: CBPeripheral, didDiscoverServices error: Error?) {
-        guard !isPanicSuspended else { return }
-        if let error = error {
-            SecureLogger.error("❌ Error discovering services for \(peripheral.name ?? "Unknown"): \(error.localizedDescription)", category: .session)
-            // Retry service discovery after a delay
-            DispatchQueue.main.asyncAfter(deadline: .now() + 0.5) {
-                guard peripheral.state == .connected else { return }
-                peripheral.discoverServices([BLEService.serviceUUID])
-            }
-            return
-        }
-        
-        guard let services = peripheral.services else {
-            SecureLogger.warning("⚠️ No services discovered for \(peripheral.name ?? "Unknown")", category: .session)
-            return
-        }
-        
-        guard let service = services.first(where: { $0.uuid == BLEService.serviceUUID }) else {
-            // Not a BitChat peer - disconnect
-            centralManager?.cancelPeripheralConnection(peripheral)
-            return
-        }
-        
-        // Discovering BLE characteristics
-        peripheral.discoverCharacteristics([BLEService.characteristicUUID], for: service)
-    }
-    
-    func peripheral(_ peripheral: CBPeripheral, didDiscoverCharacteristicsFor service: CBService, error: Error?) {
-        guard !isPanicSuspended else { return }
-        if let error = error {
-            SecureLogger.error("❌ Error discovering characteristics for \(peripheral.name ?? "Unknown"): \(error.localizedDescription)", category: .session)
-            return
-        }
-        
-        guard let characteristic = service.characteristics?.first(where: { $0.uuid == BLEService.characteristicUUID }) else {
-            SecureLogger.warning("⚠️ No matching characteristic found for \(peripheral.name ?? "Unknown")", category: .session)
-            return
-        }
-        
-        // Found characteristic
-        
-        // Log characteristic properties for debugging
-        var properties: [String] = []
-        if characteristic.properties.contains(.read) { properties.append("read") }
-        if characteristic.properties.contains(.write) { properties.append("write") }
-        if characteristic.properties.contains(.writeWithoutResponse) { properties.append("writeWithoutResponse") }
-        if characteristic.properties.contains(.notify) { properties.append("notify") }
-        if characteristic.properties.contains(.indicate) { properties.append("indicate") }
-        // Characteristic properties: \(properties.joined(separator: ", "))
-        
-        // Verify characteristic supports reliable writes
-        if !characteristic.properties.contains(.write) {
-            SecureLogger.warning("⚠️ Characteristic doesn't support reliable writes (withResponse)!", category: .session)
-        }
-        
-        // Store characteristic in our consolidated structure
-        let peripheralID = peripheral.identifier.uuidString
-        linkStateStore.updateCharacteristic(characteristic, forPeripheralID: peripheralID)
-        
-        // Subscribe for notifications
-        if characteristic.properties.contains(.notify) {
-            peripheral.setNotifyValue(true, for: characteristic)
-            SecureLogger.debug("🔔 Subscribed to notifications from \(peripheral.name ?? "Unknown")", category: .session)
-            
-            // Send announce after subscription is confirmed (force send for new connection)
-            engineScheduler.schedule(after: TransportConfig.blePostSubscribeAnnounceDelaySeconds) { [weak self] in
-                self?.sendAnnounce(forceSend: true)
-                // Try flushing any spooled directed packets now that we have a link
-                self?.flushDirectedSpool()
-            }
-        } else {
-            SecureLogger.warning("⚠️ Characteristic does not support notifications", category: .session)
-        }
-    }
-    
-    func peripheral(_ peripheral: CBPeripheral, didUpdateValueFor characteristic: CBCharacteristic, error: Error?) {
-        guard !isPanicSuspended else { return }
-        if let error = error {
-            SecureLogger.error("❌ Error receiving notification: \(error.localizedDescription)", category: .session)
-            return
-        }
-        
-        guard let data = characteristic.value, !data.isEmpty else {
-            SecureLogger.warning("⚠️ No data in notification", category: .session)
-            return
-        }
-
-        bufferNotificationChunk(data, from: peripheral)
-    }
-
-    private func bufferNotificationChunk(_ chunk: Data, from peripheral: CBPeripheral) {
-        let peripheralUUID = peripheral.identifier.uuidString
-
-        var state = linkStateStore.state(forPeripheralID: peripheralUUID) ?? BLEPeripheralLinkState(
-            peripheral: peripheral,
-            characteristic: nil,
-            isConnecting: false,
-            isConnected: peripheral.state == .connected,
-            lastConnectionAttempt: nil,
-            assembler: NotificationStreamAssembler()
-        )
-
-        var assembler = state.assembler
-        let result = assembler.append(chunk)
-        state.assembler = assembler
-        linkStateStore.setPeripheralState(state, for: peripheralUUID)
-
-        for byte in result.droppedPrefixes {
-            SecureLogger.warning("⚠️ Dropping byte from BLE stream (unexpected prefix \(String(format: "%02x", byte)))", category: .session)
-        }
-
-        if result.reset {
-            SecureLogger.error("❌ Invalid BLE frame length; reset notification stream", category: .session)
-        }
-        
-        // Attribution — spoof rejection, announce binding, ingress
-        // recording — is engine work now (the engine owns the bindings).
-        // Frames hop up in decode order; the engine's serial slot ordering
-        // gives the same same-batch spoof protection the old bleQueue-side
-        // batch-local binding enforced: an announce that binds this link is
-        // attributed before every frame that rode behind it.
-        for frame in result.frames {
-            guard let packet = BinaryProtocol.decode(frame) else {
-                let prefix = frame.prefix(16).map { String(format: "%02x", $0) }.joined(separator: " ")
-                SecureLogger.error("❌ Failed to decode assembled notification frame (len=\(frame.count), prefix=\(prefix))", category: .session)
-                continue
-            }
-            emitLinkEvent(.frameDecoded(
-                packet,
-                link: .peripheral(peripheralUUID),
-                linkDescription: "Peripheral \(peripheralUUID.prefix(8))…"
-            ))
-        }
-    }
-    
-    func peripheral(_ peripheral: CBPeripheral, didWriteValueFor characteristic: CBCharacteristic, error: Error?) {
-        if let error = error {
-            SecureLogger.error("❌ Write failed to \(peripheral.name ?? peripheral.identifier.uuidString): \(error.localizedDescription)", category: .session)
-            // Don't retry - just log the error
-        } else {
-            SecureLogger.debug("✅ Write confirmed to \(peripheral.name ?? peripheral.identifier.uuidString)", category: .session)
-        }
-    }
-    
-    func peripheralIsReady(toSendWriteWithoutResponse peripheral: CBPeripheral) {
-        guard !isPanicSuspended else { return }
-        // Resume queued writes for this peripheral - called when canSendWriteWithoutResponse becomes true again
-        if logRateLimiter.shouldLog(key: "peripheral-ready:\(peripheral.identifier.uuidString)") {
-            SecureLogger.debug("📤 Peripheral \(peripheral.name ?? peripheral.identifier.uuidString.prefix(8).description) ready for more writes", category: .session)
-        }
-        drainPendingWrites(for: peripheral)
-    }
-    
-    func peripheral(_ peripheral: CBPeripheral, didModifyServices invalidatedServices: [CBService]) {
-        guard !isPanicSuspended else { return }
-        SecureLogger.warning("⚠️ Services modified for \(peripheral.name ?? peripheral.identifier.uuidString)", category: .session)
-
-        let shouldRediscover = BLEService.shouldRediscoverBitChatService(
-            invalidatedServiceUUIDs: invalidatedServices.map(\.uuid),
-            cachedServiceUUIDs: peripheral.services?.map(\.uuid)
-        )
-
-        guard shouldRediscover else { return }
-
-        let peripheralID = peripheral.identifier.uuidString
-        linkStateStore.updatePeripheral(peripheralID) {
-            $0.characteristic = nil
-            $0.assembler = NotificationStreamAssembler()
-        }
-
-        SecureLogger.debug("🔄 BitChat service changed for \(peripheral.name ?? peripheral.identifier.uuidString), rediscovering", category: .session)
-        peripheral.discoverServices([BLEService.serviceUUID])
-    }
-    
-    func peripheral(_ peripheral: CBPeripheral, didUpdateNotificationStateFor characteristic: CBCharacteristic, error: Error?) {
-        guard !isPanicSuspended else { return }
-        if let error = error {
-            SecureLogger.error("❌ Error updating notification state: \(error.localizedDescription)", category: .session)
-        } else {
-            SecureLogger.debug("🔔 Notification state updated for \(peripheral.name ?? peripheral.identifier.uuidString): \(characteristic.isNotifying ? "ON" : "OFF")", category: .session)
-            
-            // If notifications are now on, send an announce to ensure this peer knows about us
-            if characteristic.isNotifying {
-                // Sending announce after subscription
-                self.sendAnnounce(forceSend: true)
-            }
-        }
-    }
-
-}
-
-extension BLEService {
-    static func shouldRediscoverBitChatService(
-        invalidatedServiceUUIDs: [CBUUID],
-        cachedServiceUUIDs: [CBUUID]?
-    ) -> Bool {
-        invalidatedServiceUUIDs.contains(serviceUUID) || cachedServiceUUIDs?.contains(serviceUUID) != true
-    }
-}

bitchat/Services/BLE/BLEService+LinkLayerPeripheralRole.swift

@@ -1,320 +0,0 @@
-//
-// BLEService+LinkLayerPeripheralRole.swift
-// bitchat
-//
-// This is free and unencumbered software released into the public domain.
-// For more information, see <https://unlicense.org>
-//
-
-import BitFoundation
-import BitLogger
-import CoreBluetooth
-import Foundation
-
-// The bleQueue half of the link layer: CoreBluetooth delegate callbacks do
-// physical bookkeeping (link-state store, buffers, radio policy) and report
-// everything else to the engine through the link-event port
-// (BLELinkEvent / emitLinkEvent). See docs/BLE-ARCHITECTURE-V3.md.
-
-// MARK: - CBPeripheralManagerDelegate
-
-extension BLEService: CBPeripheralManagerDelegate {
-    func peripheralManagerDidUpdateState(_ peripheral: CBPeripheralManager) {
-        SecureLogger.debug("📡 Peripheral manager state: \(peripheral.state.rawValue)", category: .session)
-
-        switch peripheral.state {
-        case .poweredOn:
-            guard !isPanicSuspended else {
-                peripheral.stopAdvertising()
-                peripheral.removeAllServices()
-                characteristic = nil
-                return
-            }
-            // Remove all services first to ensure clean state
-            peripheral.removeAllServices()
-
-            // Create characteristic
-            characteristic = CBMutableCharacteristic(
-                type: BLEService.characteristicUUID,
-                properties: [.notify, .write, .writeWithoutResponse, .read],
-                value: nil,
-                permissions: [.readable, .writeable]
-            )
-
-            // Create service
-            let service = CBMutableService(type: BLEService.serviceUUID, primary: true)
-            service.characteristics = [characteristic!]
-
-            // Add service (advertising will start in didAdd delegate)
-            SecureLogger.debug("🔧 Adding BLE service...", category: .session)
-            peripheral.add(service)
-
-        case .poweredOff:
-            // Bluetooth was turned off - clean up peripheral state
-            SecureLogger.info("📴 Bluetooth powered off - cleaning up peripheral state", category: .session)
-            // Clear subscribed centrals (they are now invalid)
-            let centralIDs = linkStateStore.subscribedCentrals.map { $0.identifier.uuidString }
-            pendingNotifications.removeAll()
-            pendingWriteBuffers.removeAll()
-            linkStateStore.clearCentrals()
-            subscriptionAnnounceLimiter.removeAll()
-            characteristic = nil
-            emitLinkEvent(.allCentralLinksEnded(centralUUIDs: centralIDs, retireProofsAndNotify: true))
-
-        case .unauthorized:
-            // User denied Bluetooth permission
-            SecureLogger.warning("🚫 Bluetooth unauthorized for peripheral role", category: .session)
-            linkStateStore.clearCentrals()
-            subscriptionAnnounceLimiter.removeAll()
-            characteristic = nil
-            emitLinkEvent(.allCentralLinksEnded(centralUUIDs: [], retireProofsAndNotify: false))
-
-        case .unsupported:
-            // Device doesn't support BLE peripheral role
-            SecureLogger.error("❌ Bluetooth LE peripheral role not supported", category: .session)
-
-        case .resetting:
-            // Bluetooth stack is resetting
-            SecureLogger.info("🔄 Bluetooth peripheral stack resetting...", category: .session)
-
-        case .unknown:
-            SecureLogger.debug("❓ Peripheral Bluetooth state unknown (initializing)", category: .session)
-
-        @unknown default:
-            SecureLogger.warning("⚠️ Unknown peripheral Bluetooth state: \(peripheral.state.rawValue)", category: .session)
-        }
-    }
-    
-    #if os(iOS)
-    func peripheralManager(_ peripheral: CBPeripheralManager, willRestoreState dict: [String: Any]) {
-        guard !isPanicSuspended else {
-            peripheral.stopAdvertising()
-            peripheral.removeAllServices()
-            characteristic = nil
-            return
-        }
-        let restoredServices = (dict[CBPeripheralManagerRestoredStateServicesKey] as? [CBMutableService]) ?? []
-        let restoredAdvertisement = (dict[CBPeripheralManagerRestoredStateAdvertisementDataKey] as? [String: Any]) ?? [:]
-
-        SecureLogger.info(
-            "♻️ Peripheral restore: services=\(restoredServices.count) advertisingDataKeys=\(Array(restoredAdvertisement.keys))",
-            category: .session
-        )
-
-        // Attempt to recover characteristic from restored services
-        if characteristic == nil {
-            if let service = restoredServices.first(where: { $0.uuid == BLEService.serviceUUID }),
-               let restoredCharacteristic = service.characteristics?.first(where: { $0.uuid == BLEService.characteristicUUID }) as? CBMutableCharacteristic {
-                characteristic = restoredCharacteristic
-            }
-        }
-
-        // Via the sampler for a fresh background budget (see central-restore).
-        logBluetoothStatus("peripheral-restore")
-
-        if peripheral.state == .poweredOn && !peripheral.isAdvertising {
-            peripheral.startAdvertising(BLERadioController.advertisementData())
-        }
-    }
-    #endif
-    
-    func peripheralManager(_ peripheral: CBPeripheralManager, didAdd service: CBService, error: Error?) {
-        guard !isPanicSuspended else {
-            peripheral.stopAdvertising()
-            return
-        }
-        if let error = error {
-            SecureLogger.error("❌ Failed to add service: \(error.localizedDescription)", category: .session)
-            return
-        }
-        
-        SecureLogger.debug("✅ Service added successfully, starting advertising", category: .session)
-        
-        // Start advertising after service is confirmed added
-        let adData = BLERadioController.advertisementData()
-        peripheral.startAdvertising(adData)
-        
-        SecureLogger.debug("📡 Started advertising (LocalName: \((adData[CBAdvertisementDataLocalNameKey] as? String) != nil ? "on" : "off"), ID: \(myPeerID.id.prefix(8))…)", category: .session)
-    }
-    
-    func peripheralManager(_ peripheral: CBPeripheralManager, central: CBCentral, didSubscribeTo characteristic: CBCharacteristic) {
-        guard !isPanicSuspended else { return }
-        let centralUUID = central.identifier.uuidString
-        SecureLogger.debug("📥 Central subscribed: \(centralUUID.prefix(8))…", category: .session)
-        linkStateStore.addSubscribedCentral(central)
-
-        // BCH-01-004: Rate-limit subscription-triggered announces to prevent enumeration attacks
-        let now = Date()
-        switch subscriptionAnnounceLimiter.decision(for: centralUUID, now: now) {
-        case .allowed:
-            break
-        case let .rateLimited(backoffSeconds, attemptCount, suppressAnnounce):
-            SecureLogger.warning("🛡️ BCH-01-004: Rate-limited announce for central \(centralUUID.prefix(8))... (backoff: \(Int(backoffSeconds))s, attempts: \(attemptCount))", category: .security)
-            if suppressAnnounce {
-                SecureLogger.warning("🚨 BCH-01-004: Possible enumeration attack from central \(centralUUID.prefix(8))... - suppressing announce", category: .security)
-                return
-            }
-
-            // Still flush directed packets for legitimate mesh operation
-            engineScheduler.schedule(after: TransportConfig.blePostAnnounceDelaySeconds) { [weak self] in
-                self?.flushDirectedSpool()
-            }
-            return
-        }
-
-        // Send announce to the newly subscribed central after a small delay
-        engineScheduler.schedule(after: TransportConfig.blePostAnnounceDelaySeconds) { [weak self] in
-            self?.sendAnnounce(forceSend: true)
-            // Flush any spooled directed packets now that we have a central subscribed
-            self?.flushDirectedSpool()
-        }
-    }
-    
-    func peripheralManager(_ peripheral: CBPeripheralManager, central: CBCentral, didUnsubscribeFrom characteristic: CBCharacteristic) {
-        let centralID = central.identifier.uuidString
-        SecureLogger.debug("📤 Central unsubscribed: \(centralID.prefix(8))…", category: .session)
-        // bleQueue: physical retirement now.
-        pendingNotifications.removeTarget { $0.identifier.uuidString == centralID }
-        linkStateStore.removeSubscribedCentral(central)
-
-        // Ensure we're still advertising for other devices to find us
-        if !isPanicSuspended, peripheral.isAdvertising == false {
-            SecureLogger.debug("📡 Restarting advertising after central unsubscribed", category: .session)
-            peripheral.startAdvertising(BLERadioController.advertisementData())
-        }
-
-        // Identity retirement and peer-disconnect bookkeeping ride the
-        // link-event port.
-        emitLinkEvent(.centralLinkEnded(centralUUID: centralID))
-    }
-    
-    func peripheralManagerIsReady(toUpdateSubscribers peripheral: CBPeripheralManager) {
-        guard !isPanicSuspended else { return }
-        drainPendingNotifications(logPrefix: "✅ Sent")
-    }
-
-    func logBackpressureSampled(_ message: @autoclosure () -> String) {
-        notificationBackpressureLogCount += 1
-        if notificationBackpressureLogCount == 1 ||
-            notificationBackpressureLogCount.isMultiple(of: TransportConfig.bleBackpressureLogInterval) {
-            SecureLogger.debug("\(message()) [backpressure event #\(notificationBackpressureLogCount)]", category: .session)
-        }
-    }
-
-    func drainPendingNotifications(logPrefix: String) {
-        bleQueue.async { [weak self] in
-            guard let self = self,
-                  let characteristic = self.characteristic,
-                  !self.pendingNotifications.isEmpty else { return }
-
-            let pending = self.pendingNotifications.takeAll()
-            let sentCount = self.sendPendingNotifications(pending, characteristic: characteristic)
-
-            if sentCount > 0 {
-                self.logBackpressureSampled("\(logPrefix) \(sentCount) pending notifications from retry queue (\(self.pendingNotifications.count) still pending)")
-            }
-        }
-    }
-
-    private func sendPendingNotifications(_ pending: [BLEPendingNotification<CBCentral>], characteristic: CBMutableCharacteristic) -> Int {
-        var sentCount = 0
-
-        for (index, notification) in pending.enumerated() {
-            let success = peripheralManager?.updateValue(
-                notification.data,
-                for: characteristic,
-                onSubscribedCentrals: notification.targets
-            ) ?? false
-
-            guard success else {
-                let remaining = Array(pending.dropFirst(index))
-                pendingNotifications.prepend(remaining)
-                logBackpressureSampled("⚠️ Notification queue still full after \(sentCount) sent, re-queuing \(remaining.count) items")
-                break
-            }
-
-            sentCount += 1
-        }
-
-        return sentCount
-    }
-    
-    func peripheralManager(_ peripheral: CBPeripheralManager, didReceiveWrite requests: [CBATTRequest]) {
-        // Suppress logs for single write requests to reduce noise
-        if requests.count > 1 {
-            SecureLogger.debug("📥 Received \(requests.count) write requests from central", category: .session)
-        }
-        
-        // IMPORTANT: Respond immediately to prevent timeouts!
-        // We must respond within a few milliseconds or the central will timeout
-        for request in requests {
-            peripheral.respond(to: request, withResult: .success)
-        }
-        guard !isPanicSuspended else { return }
-        
-        // Process writes. For long writes, CoreBluetooth may deliver multiple CBATTRequest values with offsets.
-        // Combine per-central request values by offset before decoding.
-        // Process directly on our message queue to match transport context
-        let grouped = Dictionary(grouping: requests, by: { $0.central.identifier.uuidString })
-        for (centralUUID, group) in grouped {
-            // Sort by offset ascending
-            let sorted = group.sorted { $0.offset < $1.offset }
-            let hasMultiple = sorted.count > 1 || (sorted.first?.offset ?? 0) > 0
-            let chunks = sorted.compactMap { request -> BLEInboundWriteChunk? in
-                guard let data = request.value, !data.isEmpty else { return nil }
-                return BLEInboundWriteChunk(offset: request.offset, data: data)
-            }
-
-            let result = pendingWriteBuffers.append(
-                chunks: chunks,
-                for: centralUUID,
-                capBytes: TransportConfig.blePendingWriteBufferCapBytes
-            )
-
-            switch result {
-            case let .decoded(packet, metadata):
-                logAccumulatedCentralWrite(metadata, centralUUID: centralUUID)
-                processDecodedCentralWrite(packet, centralUUID: centralUUID, central: sorted[0].central)
-
-            case let .waiting(metadata):
-                logAccumulatedCentralWrite(metadata, centralUUID: centralUUID)
-                logFailedSingleWriteIfNeeded(hasMultiple: hasMultiple, sortedRequests: sorted)
-
-            case let .oversized(metadata):
-                logAccumulatedCentralWrite(metadata, centralUUID: centralUUID)
-                SecureLogger.warning("⚠️ Dropping oversized pending write buffer (\(metadata.accumulatedBytes) bytes) for central \(centralUUID.prefix(8))…", category: .session)
-                logFailedSingleWriteIfNeeded(hasMultiple: hasMultiple, sortedRequests: sorted)
-            }
-        }
-    }
-
-    private func logAccumulatedCentralWrite(_ metadata: BLEInboundWriteAppendMetadata, centralUUID: String) {
-        guard let packetType = metadata.packetType,
-              packetType != MessageType.announce.rawValue else { return }
-
-        SecureLogger.debug(
-            "📥 Accumulated write from central \(centralUUID.prefix(8))…: size=\(metadata.accumulatedBytes) (+\(metadata.appendedBytes)) bytes (type=\(packetType)), offsets=\(metadata.offsets)",
-            category: .session
-        )
-    }
-
-    private func logFailedSingleWriteIfNeeded(hasMultiple: Bool, sortedRequests: [CBATTRequest]) {
-        guard !hasMultiple, let raw = sortedRequests.first?.value else { return }
-
-        let prefix = raw.prefix(16).map { String(format: "%02x", $0) }.joined(separator: " ")
-        SecureLogger.error("❌ Failed to decode packet from central (len=\(raw.count), prefix=\(prefix))", category: .session)
-    }
-
-    private func processDecodedCentralWrite(_ packet: BitchatPacket, centralUUID: String, central: CBCentral) {
-        // bleQueue: physical bookkeeping only. A writer is a live central
-        // whether or not it subscribed; track it so directed replies and
-        // the fanout planner can reach it.
-        linkStateStore.addSubscribedCentral(central)
-        // Attribution is engine work (the engine owns the bindings).
-        emitLinkEvent(.frameDecoded(
-            packet,
-            link: .central(centralUUID),
-            linkDescription: "Central \(centralUUID.prefix(8))…"
-        ))
-    }
-}