mirror of
https://github.com/permissionlesstech/bitchat.git
synced 2026-11-15 08:12:23 +00:00
The gate fails when a floored benchmark stops reporting (exit 3, no retry) so that a benchmark cannot be dropped without an explicit floors-file change. The other direction was advisory: a benchmark that reports a PERF line with no floor printed "consider adding a floor" into the job log and passed. Nothing else surfaces that line, so a new hot-path benchmark could measure on every run and guard nothing, and the file the gate reads would still look complete. That is the shape of the localization gap closed in #1654, where a key missing from every catalog compiled and shipped English while CI stayed green, and the move is the one made in #1646 and #1648: an advisory check becomes blocking once its backlog is zero. perf-floors.json carries 12 floors and PerformanceBaselineTests has 12 benchmarks, so flipping this costs nothing today and holds the two in step from now on. An unfloored benchmark now fails alongside a missing one, with the same exit code and for the same reason: the floors file and the benchmark suite must change together, and no re-measurement can repair a drift between them. The message names the file to edit. The test pinned in the previous commit flips from "reported but does not fail" to "fails without a retry"; the philosophy note in the floors file says "added, renamed or removed" instead of "renamed or removed".