From 46feee1ec7f5d7b46275acf5402579bed2d69239 Mon Sep 17 00:00:00 2001
From: Andrew Ruthven <andrew@etc.gen.nz>
Date: Sat, 10 Dec 2022 01:10:25 +1300
Subject: [PATCH] Stop copying all fields from the Principal object.

PHP 8.2 deprecates dynmically adding properties. See:
  https://php.watch/versions/8.2/dynamic-properties-deprecated

This arbitary copying of all fields tickles these deprecation
warnings, and just below we copy exactly the fields we need.
I reckon this loop is redundant.
---
 inc/HTTPAuthSession.php | 4 ----
 inc/PublicSession.php   | 5 -----
 2 files changed, 9 deletions(-)

diff --git a/inc/HTTPAuthSession.php b/inc/HTTPAuthSession.php
index 08663286..99352f74 100644
--- a/inc/HTTPAuthSession.php
+++ b/inc/HTTPAuthSession.php
@@ -377,10 +377,6 @@ class HTTPAuthSession {
       $principal = new Principal('username',$principal->username);
     }
 
-    // Assign each field in the selected record to the object
-    foreach( $principal AS $k => $v ) {
-      $this->{$k} = $v;
-    }
     if ( !get_class($principal) == 'Principal' ) {
       throw new Exception('HTTPAuthSession::AssignSessionDetails could not find a Principal object');
     }
diff --git a/inc/PublicSession.php b/inc/PublicSession.php
index e779a9df..626bcf44 100644
--- a/inc/PublicSession.php
+++ b/inc/PublicSession.php
@@ -64,11 +64,6 @@ class PublicSession {
 
     $principal = new Principal('username','unauthenticated');
 
-    // Assign each field in the selected record to the object
-    foreach( $principal AS $k => $v ) {
-      $this->{$k} = $v;
-    }
-
     $this->username = $principal->username();
     $this->user_no  = $principal->user_no();
     $this->principal_id = $principal->principal_id();