From dc7df3c506b4d6164df1a2a60a1f2ba46804af49 Mon Sep 17 00:00:00 2001 From: Andrew McMillan Date: Thu, 4 Nov 2010 19:01:16 +1300 Subject: [PATCH] Add @todo note. --- inc/caldav-REPORT-multiget.php | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/inc/caldav-REPORT-multiget.php b/inc/caldav-REPORT-multiget.php index c839c2e7..cb59dfc4 100644 --- a/inc/caldav-REPORT-multiget.php +++ b/inc/caldav-REPORT-multiget.php @@ -103,6 +103,12 @@ else if ( $mode == 'carddav' ) { LEFT JOIN collection USING(collection_id)'; } +/** + * @todo: Add stanzas for missing rows, so we don't just return a blank multistatus but + * actually return stanzas with a 404 for each absent href. We could do + * this relatively easily with an array_flip($params) and remove each matching dav_name + * as we process it. + */ if ( isset($c->strict_result_ordering) && $c->strict_result_ordering ) $where .= " ORDER BY caldav_data.dav_id"; $qry = new AwlQuery( $sql . $where, $params ); if ( $qry->Exec('REPORT',__LINE__,__FILE__) && $qry->rows() > 0 ) {