nik/davical
1
0
Fork 0
mirror of https://gitlab.com/davical-project/davical.git synced 2026-03-13 08:00:15 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Add a missing space to a SQL statement to fix adding groups.

Browse Source 
It looks to me like this bug has been present since 2011.

Closes: #294
This commit is contained in:
Andrew Ruthven 2023-04-30 12:13:37 +12:00 committed by Andrew Ruthven
parent 0059d0dcdb
commit e8f3a3e6f2
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
inc/ui/principal-edit.php
View File

@ -495,9 +495,9 @@ function group_memberships_browser() {
function group_row_editor() {
global $c, $id, $editor, $can_write_principal;
$grouprow = new Editor("Group Members", "group_member");
$sql = 'SELECT principal_id, coalesce(displayname,fullname,username) FROM dav_principal ';
$sql .= 'WHERE principal_id NOT IN (SELECT member_id FROM group_member WHERE group_id = '.$id.') ';
$sql .= 'AND principal_id != '.$id;
$sql = 'SELECT principal_id, coalesce(displayname, fullname, username) FROM dav_principal ';
$sql .= 'WHERE principal_id NOT IN (SELECT member_id FROM group_member WHERE group_id = ' . $id . ') ';
$sql .= 'AND principal_id != ' . $id . ' ';
$sql .= 'ORDER BY 2';
$grouprow->SetLookup( 'member_id', $sql);
$grouprow->SetSubmitName( 'savegrouprow' );