nik/easyrsa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Removing local-only code at tincantech's request

Browse Source 
Conversation from IRC, times are Central Standard:

09:34:13 <@tincantech> i only added the rm as a "precaution" .. it is not really necessary because all the temp pki's are deleted first anyway
09:34:38 < ecrist> When I look at the code, you have a function, destroy_data() which deletes everything.  It's only called in setup() and in tear_down().
09:35:27 <@tincantech> https://github.com/OpenVPN/easy-rsa/blob/v3.0.6/op_test.sh#L564
09:35:28 < vpnHelper> Title: easy-rsa/op_test.sh at v3.0.6 · OpenVPN/easy-rsa · GitHub (at github.com)
09:37:08 < ecrist> what are you pointing out there?
09:37:44 <@tincantech> i am calling $TEMP_DIR/openssl.sh
09:38:51 < ecrist> and where does that file come from?
09:39:27 <@tincantech> i would prefer that https://github.com/OpenVPN/easy-rsa/blob/v3.0.6/op_test.sh#L215 is just removed completely
09:39:28 < vpnHelper> Title: easy-rsa/op_test.sh at v3.0.6 · OpenVPN/easy-rsa · GitHub (at github.com)
09:42:02 < ecrist> I'm still trying to address the $TEMP_DIR/openssl.sh
09:42:06 < ecrist> where is that file?
09:43:12 <@tincantech> it is only a local file
09:43:36 < ecrist> well, it doesn't make sense to build support in to the test script for things that aren't committed with the test script.
09:44:06 < ecrist> And temp is just that, temp.  If there are other dependencies, those should go in a sane location, like test_libs or something.
09:47:06 <@tincantech> then i guess remove line 564-568

Signed-off-by: Eric F Crist <ecrist@secure-computing.net>
This commit is contained in:
Eric F Crist 2019-01-25 10:39:03 -06:00
parent e41b58b608
commit 4fb23053be
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
op_test.sh
View File

@ -561,12 +561,6 @@ create_pki ()
init
[ -f "$TEMP_DIR/openssl.sh" ] || export OPENSSL_ENABLE=0
[ $((OPENSSL_ENABLE)) -eq 1 ] && "$TEMP_DIR/openssl.sh"
[ -f "$TEMP_DIR/libressl.sh" ] || export LIBRESSL_ENABLE=0
[ $((LIBRESSL_ENABLE)) -eq 1 ] && "$TEMP_DIR/libressl.sh"
setup
STAGE_NAME="Default ssl"