More travis-ci related cleanup

* Remove SC2006 from shellcheck: bashism
* Put variable declarations on separate lines (SC1007)
* Remove "local" from Windows sh script (SC2039)
* Remove "x" variable define from read in Windows sh script (SC2034)

Signed-off-by: Eric F Crist <ecrist@secure-computing.net>

.travis.yml

@@ -10,4 +10,4 @@ addons:
     - shellcheck
 
 script:
- - bash -c 'shopt -s globstar; shellcheck **/*.sh easyrsa3/easyrsa'
+ - bash -c 'export SHELLCHECK_OPTS="-e SC2006"; shopt -s globstar; shellcheck **/*.sh easyrsa3/easyrsa'

build/build-dist.sh

@@ -1,4 +1,5 @@
 #!/bin/sh
+# shellcheck disable=
 
 # Easy-RSA 3 distribution packager:
 # creates ready-to-use tarball files for Unixes and a zip file for windows

distro/windows/bin/easyrsa-shell-init.sh

@@ -24,7 +24,7 @@ for f in $extern_list; do
 		echo "  files."
 		echo ""
 		echo "  Press enter to exit."
-		read x
+		read
 		exit 1
 	fi
 done
@@ -32,9 +32,9 @@ done
 # set_var is defined as any vars file needs it.
 # This is the same as in easyrsa, but we _don't_ export
 set_var() {
-        local var=$1
+        var="$1"
         shift
-        local value="$*"
+        value="$*"
         eval "$var=\"\${$var-$value}\""
 } #=> set_var()
 
@@ -62,4 +62,4 @@ echo ""
 echo "Invoke './easyrsa' to call the program. Without commands, help is displayed."
 
 # Drop to a shell and await input
-bin/sh
+bin/sh

easyrsa3/easyrsa

@@ -59,7 +59,8 @@ DIRECTORY STATUS (commands would take effect on these locations)
 # Detailed command help
 # When called with no args, calls usage(), otherwise shows help for a command
 cmd_help() {
-	text= opts=
+	text="" 
+	opts=""
 	case "$1" in
 		init-pki|clean-all) text="
   init-pki [ cmd-opts ]