From c064d3bc669941ebf009cbb1e882ff9957a65917 Mon Sep 17 00:00:00 2001 From: Markus Tillinger Date: Fri, 22 Jan 2021 12:04:17 +0100 Subject: [PATCH] Fixed wrongly disabled shellcheck SC2231: $EASYRSA_PKI is a path that could contain spaces where word splitting must be prevented. --- easyrsa3/easyrsa | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/easyrsa3/easyrsa b/easyrsa3/easyrsa index 7cdf162..84e176d 100755 --- a/easyrsa3/easyrsa +++ b/easyrsa3/easyrsa @@ -1125,8 +1125,7 @@ input in file: $req_in" [ -e "$key_in" ] && mv "$key_in" "$key_by_serial_revoked" # move the rest of the files (p12, p7, ...) - # shellcheck disable=SC2231 - for file in $EASYRSA_PKI/private/$1\.??? + for file in "$EASYRSA_PKI/private/$1"\.??? do # get file extension file_ext="${file##*.}" @@ -1291,8 +1290,7 @@ input in file: $req_in" [ -e "$key_in" ] && mv "$key_in" "$key_by_serial_renewed" # move the rest of the files (p12, p7, ...) - # shellcheck disable=SC2231 - for file in $EASYRSA_PKI/private/$1\.??? + for file in "$EASYRSA_PKI/private/$1"\.??? do # get file extension file_ext="${file##*.}"