From a47da11b1022439082e2bacc20d88a61bc32ca62 Mon Sep 17 00:00:00 2001
From: Josh Hawkins <32435876+hawkeye217@users.noreply.github.com>
Date: Fri, 16 May 2025 06:53:58 -0500
Subject: [PATCH] Ensure notifications register button is only disabled when
 both all cameras and every individual camera is disabled

---
 .../settings/NotificationsSettingsView.tsx    | 38 ++++++++++---------
 1 file changed, 20 insertions(+), 18 deletions(-)

diff --git a/web/src/views/settings/NotificationsSettingsView.tsx b/web/src/views/settings/NotificationsSettingsView.tsx
index f3476decf..69b8e34f8 100644
--- a/web/src/views/settings/NotificationsSettingsView.tsx
+++ b/web/src/views/settings/NotificationsSettingsView.tsx
@@ -165,23 +165,23 @@ export default function NotificationView({
   const [registration, setRegistration] =
     useState<ServiceWorkerRegistration | null>();
 
-  useEffect(() => {
-    if (!("Notification" in window) || !window.isSecureContext) {
-      return;
-    }
-    navigator.serviceWorker
-      .getRegistration(NOTIFICATION_SERVICE_WORKER)
-      .then((worker) => {
-        if (worker) {
-          setRegistration(worker);
-        } else {
-          setRegistration(null);
-        }
-      })
-      .catch(() => {
-        setRegistration(null);
-      });
-  }, []);
+  // useEffect(() => {
+  //   if (!("Notification" in window) || !window.isSecureContext) {
+  //     return;
+  //   }
+  //   navigator.serviceWorker
+  //     .getRegistration(NOTIFICATION_SERVICE_WORKER)
+  //     .then((worker) => {
+  //       if (worker) {
+  //         setRegistration(worker);
+  //       } else {
+  //         setRegistration(null);
+  //       }
+  //     })
+  //     .catch(() => {
+  //       setRegistration(null);
+  //     });
+  // }, []);
 
   // form
 
@@ -520,7 +520,9 @@ export default function NotificationView({
                   <Button
                     aria-label={t("notification.registerDevice")}
                     disabled={
-                      !config?.notifications.enabled || publicKey == undefined
+                      (!config?.notifications.enabled &&
+                        notificationCameras.length === 0) ||
+                      publicKey == undefined
                     }
                     onClick={() => {
                       if (registration == null) {