frigate

nik/frigate

Fork 0

mirror of https://github.com/blakeblackshear/frigate.git synced 2026-05-03 06:50:58 +00:00

...

Author	SHA1	Message	Date
Daniel	f68ff53bd9	fix MQTT disconnect reason code comparison bug The mypy fixes introduced a bug where disconnect callback was comparing reason_code == 0 instead of reason_value == 0. Since reason_code is a ReasonCode object, it never equals integer 0, causing clean disconnects to never be detected and infinite retry loops to occur. Fixed by using reason_value (extracted from reason_code.value) for numeric comparison, consistent with how we extract the value for logging. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>	2025-09-14 20:07:22 -04:00
Daniel	b0f189056a	fix MQTT retry loop race condition with cleanup disconnect Previously, the reconnection loop was calling client.disconnect() during cleanup, which triggered the disconnect callback with code 0 ("Normal disconnection"). The callback would then exit early, preventing further reconnection attempts. This creates a cleanup flag that prevents the disconnect callback from stopping reconnection when we're intentionally cleaning up the old client during retry attempts. Fixes issue where MQTT would get stuck in retry loop without actually attempting fresh connections. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>	2025-09-14 19:03:34 -04:00

Author

SHA1

Message

Date

Daniel

f68ff53bd9

fix MQTT disconnect reason code comparison bug

The mypy fixes introduced a bug where disconnect callback was comparing
reason_code == 0 instead of reason_value == 0. Since reason_code is a
ReasonCode object, it never equals integer 0, causing clean disconnects
to never be detected and infinite retry loops to occur.

Fixed by using reason_value (extracted from reason_code.value) for
numeric comparison, consistent with how we extract the value for logging.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

2025-09-14 20:07:22 -04:00

Daniel

b0f189056a

fix MQTT retry loop race condition with cleanup disconnect

Previously, the reconnection loop was calling client.disconnect() during cleanup,
which triggered the disconnect callback with code 0 ("Normal disconnection").
The callback would then exit early, preventing further reconnection attempts.

This creates a cleanup flag that prevents the disconnect callback from
stopping reconnection when we're intentionally cleaning up the old client
during retry attempts.

Fixes issue where MQTT would get stuck in retry loop without actually
attempting fresh connections.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

2025-09-14 19:03:34 -04:00

1 changed files with 1 additions and 1 deletions

									
										2

frigate/comms/mqtt.py
									
											View File
											
					@ -244,7 +244,7 @@ class MqttClient(Communicator):

					            logger.error("MQTT not reconnecting - stop flag set")

					            logger.error("MQTT not reconnecting - stop flag set")

					            return

					            return

					        if reason_code == 0:

					        if reason_value == 0:

					            logger.error("MQTT not reconnecting - clean disconnect (code 0)")

					            logger.error("MQTT not reconnecting - clean disconnect (code 0)")

					            return

					            return

Compare commits

2 Commits

91d3a7b245 ... f68ff53bd9

2

frigate/comms/mqtt.py

View File

Compare commits

2 Commits 91d3a7b245 ... f68ff53bd9

2 frigate/comms/mqtt.py Unescape Escape View File

2 Commits

91d3a7b245 ... f68ff53bd9

2

frigate/comms/mqtt.py

View File