Merge #626: tests: don't wait for lianad to log on shutdown
97abc4699c7343e4be6a0596a25481f9e07bb3bb tests: don't wait for lianad to log on shutdown (Antoine Poinsot)
Pull request description:
It seems to be causing some races that i don't want to be investigating at the moment. It's redundant anyways as we are already checking for the return code of the process.
It's fixing the annoying "Process died while waiting for logs" when stopping the daemon. AKA:
> Yes it died i stopped it that's the point.
ACKs for top commit:
darosior:
self-ACK 97abc4699c7343e4be6a0596a25481f9e07bb3bb -- trivial
Tree-SHA512: bed7779da37719c5bcd9ce25a39d00ce720980265b564d8230290c23868a51012a10547a3a8f9c964679f779c302a206985394f947a1e8950f845e88ddaebc5d
This commit is contained in:
commit
032bb26997
@ -127,9 +127,6 @@ class Lianad(TailableProc):
|
||||
def stop(self, timeout=5):
|
||||
try:
|
||||
self.rpc.stop()
|
||||
self.wait_for_log(
|
||||
"Stopping the liana daemon.",
|
||||
)
|
||||
self.proc.wait(timeout)
|
||||
except Exception as e:
|
||||
logging.error(f"{self.prefix} : error when calling stop: '{e}'")
|
||||
|
||||
Loading…
x
Reference in New Issue
Block a user