nik/liana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge #334: CHANGELOG: mention the origin requirement

Browse Source 
ed4d620f7fe412a1a2d8f709d5b5a9773ed49361 CHANGELOG: mention the origin requirement (Antoine Poinsot)

Pull request description:

ACKs for top commit:
  darosior:
    self-ACK ed4d620f7fe412a1a2d8f709d5b5a9773ed49361

Tree-SHA512: 96f77dfc1f862bfbd2a61f59bcdcf92ce67072836ad38898abc5bb67d41e8efcdb4052b524192e91bb150dbc84d622abf921e98d7d0097dcc4fe28d1dda8af59
This commit is contained in:
Antoine Poinsot 2023-02-07 16:01:18 +01:00
commit 08adc76079
No known key found for this signature in database
GPG Key ID: E13FC145CD3F4304
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
CHANGELOG.md
View File

@ -24,6 +24,13 @@ either, or both, of the spending paths.
ELF binary.
- We now check the `bitcoind` version before trying to import a Miniscript descriptor.
- We now discard unconfirmed incoming payments that were dropped from our mempool.
- **Breaking change**: the first version of Liana mistakenly accepted extended keys without origin
in descriptors. This meant that unless this extended key was the master extended key of a chain,
it would not be possible to sign with it (since signing devices need to know the origin). Starting
from version 2 Liana forces extended keys to contain an origin (of the form `[a1b2c3d4]`) to avoid
this footgun. This means that existing descriptors might have to be migrated, but it's very likely
only for test configurations where an xpub wasn't gathered from a signing device (which prepends
an origin) but generated (probably imported from Coleman's website) and pasted without origin.
#### GUI-specific