nik/liana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge #151: Some tiny cleanups

Browse Source 
a4e66566886901f28e383e67f06de2215e3ebc42 daemon: remove / correct some TODOs (Antoine Poinsot)
628ed3d0ed3997a64d8d0d92206842ef5445e2fa descriptors: remove TODO in assertions, explain instead (Antoine Poinsot)
62067f0030795143cbec87dcc1d5db0e5265c5c5 qa: remove needless import in fixtures (Antoine Poinsot)

Pull request description:

  Small things i noticed while working on #148.

ACKs for top commit:
  darosior:
    ACK a4e66566886901f28e383e67f06de2215e3ebc42

Tree-SHA512: 0d6b6b95a99744cd92b9ecd30d9678ff27c7223238a31c3e9093899caa11889d40cfe4c7d855c07c378ca127ca900269980d179aeb02478f04e3eaa1e20e1721
This commit is contained in:
Antoine Poinsot 2022-12-06 13:20:22 +01:00
commit 0c80702f1b
No known key found for this signature in database
GPG Key ID: E13FC145CD3F4304
5 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/bitcoin/d/utils.rs
View File

@ -86,7 +86,6 @@ mod tests {
// Create a dummy BlockStats struct with the given time
fn create_stats(time: u32) -> BlockStats {
// TODO
BlockStats {
height: 0,
confirmations: 0,

4
src/commands/mod.rs
View File

@ -571,7 +571,7 @@ impl DaemonControl {
let transactions = txids
.iter()
.filter_map(|txid| {
// TODO: batch batch those calls to the Bitcoin backend
// TODO: batch those calls to the Bitcoin backend
// so it can in turn optimize its queries.
self.bitcoin
.wallet_transaction(txid)
@ -590,7 +590,7 @@ impl DaemonControl {
let transactions = txids
.iter()
.filter_map(|txid| {
// TODO: batch batch those calls to the Bitcoin backend
// TODO: batch those calls to the Bitcoin backend
// so it can in turn optimize its queries.
self.bitcoin
.wallet_transaction(txid)

1
src/config.rs
View File

@ -48,7 +48,6 @@ fn default_daemon() -> bool {
false
}
// TODO: separate Bitcoin config and bitcoind-specific config.
/// Everything we need to know for talking to bitcoind serenely
#[derive(Debug, Clone, Deserialize, Serialize)]
pub struct BitcoindConfig {

4
src/descriptors.rs
View File

@ -347,12 +347,12 @@ impl MultipathDescriptor {
}
let owner_pk = Miniscript::from_ast(Terminal::Check(sync::Arc::from(
Miniscript::from_ast(Terminal::PkK(owner_key)).expect("TODO"),
Miniscript::from_ast(Terminal::PkK(owner_key)).expect("pk_k is a valid Miniscript"),
)))
.expect("Well typed");
let heir_pkh = Miniscript::from_ast(Terminal::Check(sync::Arc::from(
Miniscript::from_ast(Terminal::PkH(heir_key)).expect("TODO"),
Miniscript::from_ast(Terminal::PkH(heir_key)).expect("pk_h is a valid Miniscript"),
)))
.expect("Well typed");

1
tests/fixtures.py
View File

@ -1,7 +1,6 @@
from bip32 import BIP32
from bip380.descriptors import Descriptor
from concurrent import futures
from ephemeral_port_reserve import reserve
from test_framework.bitcoind import Bitcoind
from test_framework.lianad import Lianad
from test_framework.utils import (