From 97c9affd9cb400fee516dd2d566ce85af96abb6b Mon Sep 17 00:00:00 2001 From: Michael Mallan Date: Fri, 1 Nov 2024 14:15:50 +0000 Subject: [PATCH 1/7] gui(launcher): refer explicitly to liana wallet --- gui/src/launcher.rs | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/gui/src/launcher.rs b/gui/src/launcher.rs index 8d2fe86e..f9ffe94b 100644 --- a/gui/src/launcher.rs +++ b/gui/src/launcher.rs @@ -259,7 +259,7 @@ impl Launcher { .width(Length::Fixed(100.0)), ) .push( - p1_regular("Create a new wallet") + p1_regular("Create a new Liana wallet") .style(color::GREY_3), ) .push( @@ -283,8 +283,10 @@ impl Launcher { .width(Length::Fixed(100.0)), ) .push( - p1_regular("Add an existing wallet") - .style(color::GREY_3), + p1_regular( + "Add an existing Liana wallet", + ) + .style(color::GREY_3), ) .push( button::secondary(None, "Select") From 8183370f561ee4ad4de6ae733c2eb1f8107b521c Mon Sep 17 00:00:00 2001 From: Michael Mallan Date: Fri, 1 Nov 2024 14:26:17 +0000 Subject: [PATCH 2/7] gui(installer): update template names & descriptions --- gui/src/installer/view/editor/template/custom.rs | 2 +- gui/src/installer/view/editor/template/inheritance.rs | 2 +- gui/src/installer/view/editor/template/mod.rs | 6 +++--- .../view/editor/template/multisig_security_wallet.rs | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/gui/src/installer/view/editor/template/custom.rs b/gui/src/installer/view/editor/template/custom.rs index f7a2a439..1ef401d3 100644 --- a/gui/src/installer/view/editor/template/custom.rs +++ b/gui/src/installer/view/editor/template/custom.rs @@ -27,7 +27,7 @@ pub fn custom_template_description(progress: (usize, usize)) -> Element<'static, "Introduction", Column::new() .align_items(Alignment::Start) - .push(h3("Custom wallet")) + .push(h3("Build your own")) .max_width(800.0) .push(Container::new( p1_regular("Through this setup you can choose how many keys you want to use. For security reasons, we suggest you use Hardware Wallets to store them.") diff --git a/gui/src/installer/view/editor/template/inheritance.rs b/gui/src/installer/view/editor/template/inheritance.rs index 4716643f..5416ed3e 100644 --- a/gui/src/installer/view/editor/template/inheritance.rs +++ b/gui/src/installer/view/editor/template/inheritance.rs @@ -27,7 +27,7 @@ pub fn inheritance_template_description(progress: (usize, usize)) -> Element<'st "Introduction", Column::new() .align_items(Alignment::Start) - .push(h3("Inheritance wallet")) + .push(h3("Simple inheritance wallet")) .max_width(800.0) .push(Container::new( p1_regular("For this Inheritance wallet you will need 2 Keys: Your Primary Key (for yourself) and an Inheritance Key (for your heir). For security reasons, we suggest you use 2 Hardware Wallets to store them.") diff --git a/gui/src/installer/view/editor/template/mod.rs b/gui/src/installer/view/editor/template/mod.rs index 66859aac..a76dde9b 100644 --- a/gui/src/installer/view/editor/template/mod.rs +++ b/gui/src/installer/view/editor/template/mod.rs @@ -47,8 +47,8 @@ pub fn choose_descriptor_template(progress: (usize, usize)) -> Element<'static, Button::new( Column::new() .align_items(Alignment::Start) - .push(h3("Multisig security wallet")) - .push(p2_regular("A secure scheme requiring stricter multiparty signature and recovery.").style(color::GREY_2)) + .push(h3("Expanding multisig")) + .push(p2_regular("Two keys required to spend, with an extra key as a backup.").style(color::GREY_2)) .width(Length::Fill) ) .padding(15) @@ -63,7 +63,7 @@ pub fn choose_descriptor_template(progress: (usize, usize)) -> Element<'static, Button::new( Column::new() .align_items(Alignment::Start) - .push(h3("Custom (choose your own)")) + .push(h3("Build your own")) .push(p2_regular("Create a custom setup that fits all your needs.").style(color::GREY_2)) .width(Length::Fill) ) diff --git a/gui/src/installer/view/editor/template/multisig_security_wallet.rs b/gui/src/installer/view/editor/template/multisig_security_wallet.rs index 18576085..432634c9 100644 --- a/gui/src/installer/view/editor/template/multisig_security_wallet.rs +++ b/gui/src/installer/view/editor/template/multisig_security_wallet.rs @@ -32,7 +32,7 @@ pub fn multisig_security_template_description( "Introduction", Column::new() .align_items(Alignment::Start) - .push(h3("Multisig security wallet")) + .push(h3("Expanding multisig wallet")) .max_width(800.0) .push(Container::new( p1_regular("For this setup you will need 3 keys: two Primary Keys and a Recovery Key. For security reasons, we suggest you use 3 Hardware Wallets to store them.") From 4d05e6127e68b5b6000a1f2697ae47bc71bd47c4 Mon Sep 17 00:00:00 2001 From: Michael Mallan Date: Fri, 1 Nov 2024 14:27:03 +0000 Subject: [PATCH 3/7] gui(installer): remove templates introductory text --- gui/src/installer/view/editor/template/mod.rs | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/gui/src/installer/view/editor/template/mod.rs b/gui/src/installer/view/editor/template/mod.rs index a76dde9b..c19947a0 100644 --- a/gui/src/installer/view/editor/template/mod.rs +++ b/gui/src/installer/view/editor/template/mod.rs @@ -2,11 +2,11 @@ pub mod custom; pub mod inheritance; pub mod multisig_security_wallet; -use iced::{alignment, Alignment, Length}; +use iced::{Alignment, Length}; use liana_ui::{ color, - component::text::{h3, p1_regular, p2_regular}, + component::text::{h3, p2_regular}, theme, widget::*, }; @@ -22,11 +22,6 @@ pub fn choose_descriptor_template(progress: (usize, usize)) -> Element<'static, Column::new() .max_width(800.0) .align_items(Alignment::Start) - .push(Container::new( - p1_regular("What do you want your wallet for? This depends on the amount of funds you have, the more funds, the higher the security should be. Not sure about the wallet type? We can help you.") - .style(color::GREY_2) - .horizontal_alignment(alignment::Horizontal::Left) - ).align_x(alignment::Horizontal::Left).width(Length::Fill)) .push( Button::new( Column::new() From 3764c972f2431545a23434bd01003de8678638a2 Mon Sep 17 00:00:00 2001 From: Michael Mallan Date: Fri, 1 Nov 2024 15:47:19 +0000 Subject: [PATCH 4/7] gui(installer): change button text to Next --- gui/src/installer/view/editor/template/custom.rs | 2 +- gui/src/installer/view/editor/template/inheritance.rs | 2 +- .../installer/view/editor/template/multisig_security_wallet.rs | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/gui/src/installer/view/editor/template/custom.rs b/gui/src/installer/view/editor/template/custom.rs index 1ef401d3..82d424f8 100644 --- a/gui/src/installer/view/editor/template/custom.rs +++ b/gui/src/installer/view/editor/template/custom.rs @@ -45,7 +45,7 @@ pub fn custom_template_description(progress: (usize, usize)) -> Element<'static, .style(color::GREY_2) .horizontal_alignment(alignment::Horizontal::Left) ).align_x(alignment::Horizontal::Left).width(Length::Fill)) - .push(Row::new().push(Space::with_width(Length::Fill)).push(button::primary(None, "Select").width(Length::Fixed(200.0)).on_press(Message::Next))) + .push(Row::new().push(Space::with_width(Length::Fill)).push(button::primary(None, "Next").width(Length::Fixed(200.0)).on_press(Message::Next))) .push(Space::with_height(50.0)) .spacing(20), true, diff --git a/gui/src/installer/view/editor/template/inheritance.rs b/gui/src/installer/view/editor/template/inheritance.rs index 5416ed3e..bdabfa01 100644 --- a/gui/src/installer/view/editor/template/inheritance.rs +++ b/gui/src/installer/view/editor/template/inheritance.rs @@ -56,7 +56,7 @@ After a period of inactivity (but not before that) your Inheritance Key will bec .horizontal_alignment(alignment::Horizontal::Left) ).align_x(alignment::Horizontal::Left).width(Length::Fill)) .push(image::inheritance_template_description().width(Length::Fill)) - .push(Row::new().push(Space::with_width(Length::Fill)).push(button::primary(None, "Select").width(Length::Fixed(200.0)).on_press(Message::Next))) + .push(Row::new().push(Space::with_width(Length::Fill)).push(button::primary(None, "Next").width(Length::Fixed(200.0)).on_press(Message::Next))) .push(Space::with_height(50.0)) .spacing(20), true, diff --git a/gui/src/installer/view/editor/template/multisig_security_wallet.rs b/gui/src/installer/view/editor/template/multisig_security_wallet.rs index 432634c9..64904c5b 100644 --- a/gui/src/installer/view/editor/template/multisig_security_wallet.rs +++ b/gui/src/installer/view/editor/template/multisig_security_wallet.rs @@ -66,7 +66,7 @@ pub fn multisig_security_template_description( .horizontal_alignment(alignment::Horizontal::Left) ).align_x(alignment::Horizontal::Left).width(Length::Fill)) .push(image::multisig_security_template_description().width(Length::Fill)) - .push(Row::new().push(Space::with_width(Length::Fill)).push(button::primary(None, "Select").width(Length::Fixed(200.0)).on_press(Message::Next))) + .push(Row::new().push(Space::with_width(Length::Fill)).push(button::primary(None, "Next").width(Length::Fixed(200.0)).on_press(Message::Next))) .push(Space::with_height(50.0)) .spacing(20), true, From ca276bf563990cfd795f52a66e8021c23bde7279 Mon Sep 17 00:00:00 2001 From: Michael Mallan Date: Fri, 1 Nov 2024 15:55:58 +0000 Subject: [PATCH 5/7] gui(installer): remove prompts for spending paths --- gui/src/installer/prompt.rs | 4 ---- gui/src/installer/view/editor/template/custom.rs | 3 --- 2 files changed, 7 deletions(-) diff --git a/gui/src/installer/prompt.rs b/gui/src/installer/prompt.rs index 3eafa48a..de1c44e1 100644 --- a/gui/src/installer/prompt.rs +++ b/gui/src/installer/prompt.rs @@ -1,9 +1,5 @@ pub const BACKUP_DESCRIPTOR_MESSAGE: &str = "The descriptor is necessary to recover your funds. The backup of your key (via mnemonics, sometimes called 'seed words') is not enough. Please make sure you have backed up both your private key and your descriptor."; pub const BACKUP_DESCRIPTOR_HELP: &str = "In Bitcoin, the coins are locked using a Script (related to the 'address'). In order to recover your funds you need to know both the Scripts you have participated in (your 'addresses'), and be able to sign a transaction that spends from those. For the ability to sign, you back up your private key, this is your mnemonic ('seed words'). For finding the coins that belong to you, you back up a template of your Script (your 'addresses'), this is your descriptor. However, note the descriptor need not be stored as securely as the private key. A thief who steals your descriptor but not your private key cannot steal your funds."; -pub const DEFINE_DESCRIPTOR_PRIMARY_PATH_TOOLTIP: &str = - "Set key(s) that can be used to spend coins immediately, with no time restriction."; -pub const DEFINE_DESCRIPTOR_RECOVERY_PATH_TOOLTIP: &str = - "Set key(s) that can be used to spend coins after a defined period of time.\n Different sets of keys can be set to become available at different times."; pub const DEFINE_DESCRIPTOR_FINGERPRINT_TOOLTIP: &str = "The alias is applied on all the keys derived from the same seed"; pub const REGISTER_DESCRIPTOR_HELP: &str = "To be used with the wallet, a signing device needs the descriptor. If the descriptor contains one or more keys imported from an external signing device, the descriptor must be registered on it. Registration confirms that the device is able to handle the policy. Registration on a device is not a substitute for backing up the descriptor."; diff --git a/gui/src/installer/view/editor/template/custom.rs b/gui/src/installer/view/editor/template/custom.rs index 82d424f8..1d8497b7 100644 --- a/gui/src/installer/view/editor/template/custom.rs +++ b/gui/src/installer/view/editor/template/custom.rs @@ -12,7 +12,6 @@ use liana_ui::{ use crate::installer::{ message::{self, Message}, - prompt, step::descriptor::editor::key::Key, view::{ editor::{define_descriptor_advanced_settings, defined_key, path, undefined_key}, @@ -97,7 +96,6 @@ pub fn custom_template<'a>( }, move || define_descriptor_advanced_settings(use_taproot), )) - .push(p1_regular(prompt::DEFINE_DESCRIPTOR_PRIMARY_PATH_TOOLTIP).style(color::GREY_2)) .push( path( color::GREEN, @@ -137,7 +135,6 @@ pub fn custom_template<'a>( ) .map(|msg| Message::DefineDescriptor(message::DefineDescriptor::Path(0, msg))), ) - .push(p1_regular(prompt::DEFINE_DESCRIPTOR_RECOVERY_PATH_TOOLTIP).style(color::GREY_2)) .push(recovery_paths.into_iter().enumerate().fold( Column::new().spacing(20), |col, (i, p)| { From e0434013d36376670fd16db1cc9ef9488f9fea1e Mon Sep 17 00:00:00 2001 From: Michael Mallan Date: Fri, 1 Nov 2024 15:57:16 +0000 Subject: [PATCH 6/7] gui(installer): update general templates wording --- gui/src/installer/view/editor/template/custom.rs | 9 ++------- gui/src/installer/view/editor/template/inheritance.rs | 4 ++-- .../view/editor/template/multisig_security_wallet.rs | 4 ++-- 3 files changed, 6 insertions(+), 11 deletions(-) diff --git a/gui/src/installer/view/editor/template/custom.rs b/gui/src/installer/view/editor/template/custom.rs index 1d8497b7..94224cf7 100644 --- a/gui/src/installer/view/editor/template/custom.rs +++ b/gui/src/installer/view/editor/template/custom.rs @@ -29,21 +29,16 @@ pub fn custom_template_description(progress: (usize, usize)) -> Element<'static, .push(h3("Build your own")) .max_width(800.0) .push(Container::new( - p1_regular("Through this setup you can choose how many keys you want to use. For security reasons, we suggest you use Hardware Wallets to store them.") + p1_regular("For this setup you will need to define your primary and recovery spending policies. For security reasons, we suggest you use a separate Hardware Wallet for each key belonging to them.") .style(color::GREY_2) .horizontal_alignment(alignment::Horizontal::Left) ).align_x(alignment::Horizontal::Left).width(Length::Fill)) .push(Container::new( - p1_regular("For this Custom wallet you will need to define your Primary and Recovery Sets of Keys.") + p1_regular("The keys belonging to your primary policy can always spend. Those belonging to the recovery policies will be able to spend only after a defined time of wallet inactivity, allowing for secure recovery and advanced spending policies.") .style(color::GREY_2) .horizontal_alignment(alignment::Horizontal::Left) ).align_x(alignment::Horizontal::Left).width(Length::Fill)) .push(image::custom_template_description().width(Length::Fill)) - .push(Container::new( - p1_regular("The Primary set of Keys will always be able to spend. Your Recovery set(s) of Keys will activate only after a defined time of wallet inactivity, allowing for secure recovery and advanced spending policies. You can define more than one set of Recovery Keys activating at different times.") - .style(color::GREY_2) - .horizontal_alignment(alignment::Horizontal::Left) - ).align_x(alignment::Horizontal::Left).width(Length::Fill)) .push(Row::new().push(Space::with_width(Length::Fill)).push(button::primary(None, "Next").width(Length::Fixed(200.0)).on_press(Message::Next))) .push(Space::with_height(50.0)) .spacing(20), diff --git a/gui/src/installer/view/editor/template/inheritance.rs b/gui/src/installer/view/editor/template/inheritance.rs index bdabfa01..b709e7aa 100644 --- a/gui/src/installer/view/editor/template/inheritance.rs +++ b/gui/src/installer/view/editor/template/inheritance.rs @@ -30,7 +30,7 @@ pub fn inheritance_template_description(progress: (usize, usize)) -> Element<'st .push(h3("Simple inheritance wallet")) .max_width(800.0) .push(Container::new( - p1_regular("For this Inheritance wallet you will need 2 Keys: Your Primary Key (for yourself) and an Inheritance Key (for your heir). For security reasons, we suggest you use 2 Hardware Wallets to store them.") + p1_regular("For this setup you will need 2 Keys: Your Primary Key (for yourself) and an Inheritance Key (for your heir). For security reasons, we suggest you use a separate Hardware Wallet for each key.") .style(color::GREY_2) .horizontal_alignment(alignment::Horizontal::Left) ).align_x(alignment::Horizontal::Left).width(Length::Fill)) @@ -51,7 +51,7 @@ pub fn inheritance_template_description(progress: (usize, usize)) -> Element<'st )) .push(Container::new( p1_regular("You will always be able to spend using your Primary Key. -After a period of inactivity (but not before that) your Inheritance Key will become able to recover your funds. Give it to your heir(s) in order to be able to collect their inheritance.") +After a period of inactivity (but not before that) your Inheritance Key will become able to recover your funds.") .style(color::GREY_2) .horizontal_alignment(alignment::Horizontal::Left) ).align_x(alignment::Horizontal::Left).width(Length::Fill)) diff --git a/gui/src/installer/view/editor/template/multisig_security_wallet.rs b/gui/src/installer/view/editor/template/multisig_security_wallet.rs index 64904c5b..4f4c1ca4 100644 --- a/gui/src/installer/view/editor/template/multisig_security_wallet.rs +++ b/gui/src/installer/view/editor/template/multisig_security_wallet.rs @@ -35,7 +35,7 @@ pub fn multisig_security_template_description( .push(h3("Expanding multisig wallet")) .max_width(800.0) .push(Container::new( - p1_regular("For this setup you will need 3 keys: two Primary Keys and a Recovery Key. For security reasons, we suggest you use 3 Hardware Wallets to store them.") + p1_regular("For this setup you will need 3 keys: two Primary Keys and a Recovery Key. For security reasons, we suggest you use a separate Hardware Wallet for each key.") .style(color::GREY_2) .horizontal_alignment(alignment::Horizontal::Left) ).align_x(alignment::Horizontal::Left).width(Length::Fill)) @@ -61,7 +61,7 @@ pub fn multisig_security_template_description( .push(p1_regular("Recovery key").bold()) )) .push(Container::new( - p1_regular("The Primary Keys will compose a 2-of-2 multisig which will be your always-active spending policy. In case one of your keys becomes unavailable, after a period of inactivity you will be able to recover your funds using the Recovery Key together with one of your Primary Keys (2-of-3 multisig):") + p1_regular("The Primary Keys will compose a 2-of-2 multisig which will always be able to spend. In case one of your keys becomes unavailable, after a period of inactivity you will be able to recover your funds using the Recovery Key together with one of your Primary Keys (2-of-3 multisig):") .style(color::GREY_2) .horizontal_alignment(alignment::Horizontal::Left) ).align_x(alignment::Horizontal::Left).width(Length::Fill)) From 9a3bc87a755d8290f2b89847431a0fe2eb889370 Mon Sep 17 00:00:00 2001 From: Michael Mallan Date: Mon, 4 Nov 2024 08:55:52 +0000 Subject: [PATCH 7/7] gui(installer): update template SVGs --- .../images/custom_template_description.svg | 50 +++++++++--------- .../inheritance_template_description.svg | 51 ++++++++++--------- .../images/multisig_security_template.svg | 6 +-- 3 files changed, 55 insertions(+), 52 deletions(-) diff --git a/gui/ui/static/images/custom_template_description.svg b/gui/ui/static/images/custom_template_description.svg index 5873d98a..af48dbac 100644 --- a/gui/ui/static/images/custom_template_description.svg +++ b/gui/ui/static/images/custom_template_description.svg @@ -1,28 +1,30 @@ - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/gui/ui/static/images/inheritance_template_description.svg b/gui/ui/static/images/inheritance_template_description.svg index 8b8f25f0..88cddce1 100644 --- a/gui/ui/static/images/inheritance_template_description.svg +++ b/gui/ui/static/images/inheritance_template_description.svg @@ -1,29 +1,30 @@ - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + + + - diff --git a/gui/ui/static/images/multisig_security_template.svg b/gui/ui/static/images/multisig_security_template.svg index 15cd8702..e49967c0 100644 --- a/gui/ui/static/images/multisig_security_template.svg +++ b/gui/ui/static/images/multisig_security_template.svg @@ -19,8 +19,8 @@ - - + + @@ -40,6 +40,6 @@ - +