From 3a4192bfc5b36b85315e6665604e9dc2d19e0624 Mon Sep 17 00:00:00 2001 From: Antoine Poinsot Date: Fri, 1 Sep 2023 12:51:35 +0200 Subject: [PATCH 1/2] [bugfix] gui: installer: don't let them generate more than one xpub We would always generate the same one. --- gui/src/installer/view.rs | 26 +------------------------- 1 file changed, 1 insertion(+), 25 deletions(-) diff --git a/gui/src/installer/view.rs b/gui/src/installer/view.rs index e4947e1b..eada4c36 100644 --- a/gui/src/installer/view.rs +++ b/gui/src/installer/view.rs @@ -480,17 +480,6 @@ pub fn signer_xpubs(xpubs: &Vec) -> Element { ), ) })) - }) - .push_maybe(if !xpubs.is_empty() { - Some( - Container::new( - button::secondary(Some(icon::plus_icon()), "New public key") - .on_press(Message::UseHotSigner), - ) - .padding(10), - ) - } else { - None }), ) .style(theme::Container::Card(theme::Card::Simple)) @@ -563,19 +552,6 @@ pub fn hardware_wallet_xpubs<'a>( ), ) })) - }) - .push_maybe(if !xpubs.is_empty() { - Some( - Container::new(if !processing { - button::secondary(Some(icon::plus_icon()), "New public key") - .on_press(Message::Select(i)) - } else { - button::secondary(Some(icon::plus_icon()), "New public key") - }) - .padding(10), - ) - } else { - None }), ) .style(theme::Container::Card(theme::Card::Simple)) @@ -642,7 +618,7 @@ pub fn participate_xpub<'a>( .width(Length::Fill), ) .push(checkbox( - "I have shared my public keys", + "I have shared my extended public key", shared, Message::UserActionDone, )) From 9d2309ea5e7ee91eb0c06777153df59249d88926 Mon Sep 17 00:00:00 2001 From: Antoine Poinsot Date: Fri, 1 Sep 2023 12:55:15 +0200 Subject: [PATCH 2/2] CHANGELOG: warn about v2 descriptors being possibly incompatible with v1 --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7ba76910..d8b835c5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,10 @@ This release significantly simplifies the installation of Liana. It also fixes a number of small bugs and glitches. +### Breaking changes + +- Descriptors created with Liana v2 may not be backward compatible with Liana v1. + ### Features - We made it possible to re-use an xpub within a descriptor, so long as it uses a different