nik/liana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qa: drop specific value assertions in coin selection test

Browse Source 
They don't add much value and cause flakiness because the size might sometimes be lower than that due to low-R signature grinding.

Fixes #1000.
This commit is contained in:
Antoine Poinsot 2024-03-13 17:02:36 +01:00
parent 7eb024afbc
commit 4bb2372a63
No known key found for this signature in database
GPG Key ID: E13FC145CD3F4304
1 changed files with 0 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
tests/test_spend.py
View File

@ -335,8 +335,6 @@ def test_coin_selection(lianad, bitcoind):
)
anc_vsize = bitcoind.rpc.getmempoolentry(spend_txid_1)["ancestorsize"]
anc_fees = int(bitcoind.rpc.getmempoolentry(spend_txid_1)["fees"]["ancestor"] * COIN)
if not USE_TAPROOT:
assert anc_vsize == 161 and anc_fees == 339
additional_fee = additional_fees(anc_vsize, anc_fees, feerate)
assert len(spend_res_2["warnings"]) == 1
assert (
@ -355,8 +353,6 @@ def test_coin_selection(lianad, bitcoind):
)
anc_vsize = bitcoind.rpc.getmempoolentry(spend_txid_1)["ancestorsize"]
anc_fees = int(bitcoind.rpc.getmempoolentry(spend_txid_1)["fees"]["ancestor"] * COIN)
if not USE_TAPROOT:
assert anc_vsize == 161 and anc_fees == 339
additional_fee = additional_fees(anc_vsize, anc_fees, feerate)
assert len(spend_res_2["warnings"]) == 1
assert (
@ -403,9 +399,6 @@ def test_coin_selection(lianad, bitcoind):
anc_fees = int(bitcoind.rpc.getmempoolentry(deposit_2)["fees"]["ancestor"] * COIN)
prev_anc_vsize = bitcoind.rpc.getmempoolentry(spend_txid_1)["ancestorsize"]
prev_anc_fees = int(bitcoind.rpc.getmempoolentry(spend_txid_1)["fees"]["ancestor"] * COIN)
if not USE_TAPROOT:
assert anc_vsize == anc_fees == 165
assert prev_anc_vsize == 161 and prev_anc_fees == 339
additional_fee = additional_fees(anc_vsize, anc_fees, feerate) + additional_fees(prev_anc_vsize, prev_anc_fees, feerate)
assert len(spend_res_3["warnings"]) == 1
assert (