qa: test spent coins are always marked as such

tests/test_spend.py

@@ -1,6 +1,6 @@
 from fixtures import *
 from test_framework.serializations import PSBT
-from test_framework.utils import wait_for
+from test_framework.utils import wait_for, COIN
 
 
 def test_spend_change(lianad, bitcoind):
@@ -53,3 +53,120 @@ def test_spend_change(lianad, bitcoind):
     spend_txid = signed_psbt.tx.txid().hex()
     lianad.rpc.broadcastspend(spend_txid)
     bitcoind.generate_block(1, wait_for_mempool=spend_txid)
+
+
+def test_coin_marked_spent(lianad, bitcoind):
+    """Test a spent coin is marked as such under various conditions."""
+    # Receive a coin in a single transaction
+    addr = lianad.rpc.getnewaddress()["address"]
+    deposit_a = bitcoind.rpc.sendtoaddress(addr, 0.01)
+    bitcoind.generate_block(1, wait_for_mempool=deposit_a)
+    wait_for(lambda: len(lianad.rpc.listcoins()["coins"]) == 1)
+
+    # Receive another coin on the same address
+    deposit_b = bitcoind.rpc.sendtoaddress(addr, 0.02)
+    bitcoind.generate_block(1, wait_for_mempool=deposit_b)
+    wait_for(lambda: len(lianad.rpc.listcoins()["coins"]) == 2)
+
+    # Receive three coins in a single deposit transaction
+    destinations = {
+        lianad.rpc.getnewaddress()["address"]: 0.03,
+        lianad.rpc.getnewaddress()["address"]: 0.04,
+        lianad.rpc.getnewaddress()["address"]: 0.05,
+    }
+    deposit_c = bitcoind.rpc.sendmany("", destinations)
+    bitcoind.generate_block(1, wait_for_mempool=deposit_c)
+    wait_for(lambda: len(lianad.rpc.listcoins()["coins"]) == 5)
+
+    # Receive a coin in an unconfirmed deposit transaction
+    addr = lianad.rpc.getnewaddress()["address"]
+    deposit_d = bitcoind.rpc.sendtoaddress(addr, 0.06)
+    wait_for(lambda: len(lianad.rpc.listcoins()["coins"]) == 5)
+
+    def sign_and_broadcast(psbt):
+        txid = psbt.tx.txid().hex()
+        psbt = lianad.sign_psbt(psbt)
+        lianad.rpc.updatespend(psbt.to_base64())
+        lianad.rpc.broadcastspend(txid)
+        return txid
+
+    # Spend the first coin with a change output
+    outpoint = next(
+        c["outpoint"]
+        for c in lianad.rpc.listcoins()["coins"]
+        if deposit_a in c["outpoint"]
+    )
+    destinations = {
+        bitcoind.rpc.getnewaddress(): 500_000,
+    }
+    res = lianad.rpc.createspend(destinations, [outpoint], 6)
+    psbt = PSBT.from_base64(res["psbt"])
+    sign_and_broadcast(psbt)
+
+    # Spend the second coin without a change output
+    outpoint = next(
+        c["outpoint"]
+        for c in lianad.rpc.listcoins()["coins"]
+        if deposit_b in c["outpoint"]
+    )
+    destinations = {
+        bitcoind.rpc.getnewaddress(): int(0.02 * COIN) - 1_000,
+    }
+    res = lianad.rpc.createspend(destinations, [outpoint], 1)
+    psbt = PSBT.from_base64(res["psbt"])
+    sign_and_broadcast(psbt)
+
+    # Spend the third coin to an address of ours, no change
+    outpoints = [
+        c["outpoint"]
+        for c in lianad.rpc.listcoins()["coins"]
+        if deposit_c in c["outpoint"]
+    ]
+    destinations = {
+        lianad.rpc.getnewaddress()["address"]: int(0.03 * COIN) - 1_000,
+    }
+    res = lianad.rpc.createspend(destinations, [outpoints[0]], 1)
+    psbt = PSBT.from_base64(res["psbt"])
+    sign_and_broadcast(psbt)
+
+    # Spend the fourth coin to an address of ours, with change
+    destinations = {
+        lianad.rpc.getnewaddress()["address"]: int(0.04 * COIN / 2),
+    }
+    res = lianad.rpc.createspend(destinations, [outpoints[1]], 18)
+    psbt = PSBT.from_base64(res["psbt"])
+    sign_and_broadcast(psbt)
+
+    # Batch spend the fourth and fifth coins
+    outpoint = next(
+        c["outpoint"]
+        for c in lianad.rpc.listcoins()["coins"]
+        if deposit_d in c["outpoint"]
+    )
+    destinations = {
+        lianad.rpc.getnewaddress()["address"]: int(0.01 * COIN),
+        lianad.rpc.getnewaddress()["address"]: int(0.01 * COIN),
+        bitcoind.rpc.getnewaddress(): int(0.01 * COIN),
+    }
+    res = lianad.rpc.createspend(destinations, [outpoints[2], outpoint], 2)
+    psbt = PSBT.from_base64(res["psbt"])
+    sign_and_broadcast(psbt)
+
+    # All the spent coins must have been detected as such
+    all_deposits = (deposit_a, deposit_b, deposit_c, deposit_d)
+
+    def deposited_coins():
+        return (
+            c
+            for c in lianad.rpc.listcoins()["coins"]
+            if c["outpoint"][:-2] in all_deposits
+        )
+
+    def is_spent(coin):
+        if coin["spend_info"] is None:
+            return False
+        if coin["spend_info"]["txid"] is None:
+            return False
+        return True
+
+    wait_for(lambda: all(is_spent(c) for c in deposited_coins()))